Re: [crossfire] [PATCH 0/2] Work on keys.c and the keybinding system

2013-11-03 Thread Kevin Zheng 
On 11/02/2013 18:21, Arvid Brodin wrote:
 I think we should still remove the functionality that allows one 
 to rebind the modifier keys, for two reasons:
 
 * It doesn't seem to work. Try it out on rev 19089 - the bind is
   successful (when you press the bound key the corresponding Run/
   Shift indicator lights up), but as soon as you press a direction
   key, the Run/Fire modifier is lost, and you only get a normal 
   direction press.

This seems like a very compelling reason to me. I vote that we go ahead
and make the change.

 * Patch #2 introduces character-specific keys files. It would be
   nice to take the opportunity to change the format of that file
   in the same go, to correspond with the Ctrl and Shift keys (so
   C for Ctrl, instead of todays R for run, etc).

Yes, this change makes sense if control keys can't be rebound.

Thanks,
Kevin Zheng
___
crossfire mailing list
crossfire@metalforge.org
http://mailman.metalforge.org/mailman/listinfo/crossfire

[crossfire] [PATCH 0/2] Work on keys.c and the keybinding system

2013-11-02 Thread Arvid Brodin 
I have generated a new set of patches without the removal of the 
functionality to re-bind key modifiers, and with some minor 
improvements. Otherwise, they are the same as before.

These apply on top of current svn repository (rev 19089).


I think we should still remove the functionality that allows one 
to rebind the modifier keys, for two reasons:

* It doesn't seem to work. Try it out on rev 19089 - the bind is
  successful (when you press the bound key the corresponding Run/
  Shift indicator lights up), but as soon as you press a direction
  key, the Run/Fire modifier is lost, and you only get a normal 
  direction press.

* Patch #2 introduces character-specific keys files. It would be
  nice to take the opportunity to change the format of that file
  in the same go, to correspond with the Ctrl and Shift keys (so
  C for Ctrl, instead of todays R for run, etc).


-- 
Arvid
___
crossfire mailing list
crossfire@metalforge.org
http://mailman.metalforge.org/mailman/listinfo/crossfire