Re: -current boot failure @ wm(4)
Hi, Brad. On 2017/07/14 3:12, bch wrote: Hello NetBSD. I think this maybe related to msaitoh@ work in ./sys/dev/pci/*wm*. The latest kernel begins boot, then just hangs, last 3 lines are (transcribed): wm0 at pci0 dev 25 function 0: PCH2 LAN (82579LM) controller (rev. 0x04) wm0: interrupting at msii vec 0 wm0: wm_init_lcd_from_nvm: need write_smbus() -bch Thanks. I could reproduce the same problem. It's not easy to fix this problem, so I've committed to disable wm_init_lcd_from_nvm() now. Please cvs update. Thanks. -- --- SAITOH Masanobu (msai...@execsw.org msai...@netbsd.org)
daily CVS update output
Updating src tree: P src/doc/RESPONSIBLE P src/etc/etc.hpcmips/ttys P src/etc/powerd/scripts/sleep_button P src/lib/libc/citrus/citrus_none.c P src/libexec/ld.elf_so/tls.c P src/sbin/route/rtutil.c P src/sys/arch/arm/sunxi/sunxi_platform.c P src/sys/arch/evbarm/conf/SUNXI P src/sys/arch/pmax/conf/RAMDISK P src/sys/dev/mii/inbmphyreg.h P src/sys/dev/pci/if_wm.c P src/sys/dev/pci/if_wmreg.h P src/sys/dev/pci/pci_subr.c P src/sys/dev/pci/pcireg.h P src/sys/lib/libunwind/Registers.hpp P src/sys/netipsec/key.c P src/sys/netipsec/key.h P src/sys/netipsec/xform.h P src/sys/netipsec/xform_ah.c P src/sys/netipsec/xform_esp.c P src/sys/netipsec/xform_ipcomp.c P src/sys/netipsec/xform_ipip.c P src/sys/netipsec/xform_tcp.c P src/usr.bin/pmc/pmc.1 Updating xsrc tree: Killing core files: Updating file list: -rw-rw-r-- 1 srcmastr netbsd 58204486 Jul 14 03:05 ls-lRA.gz
Re: pmc changes break kernels w/makeoptions "COPTS=-Os"
On Thu, 13 Jul 2017, John D. Baker wrote: > On Thu, 13 Jul 2017, John D. Baker wrote: > > > Would the following patch be appropriate for appeasing GCC? > > [snip] > > It allows compilation to succeed. Will test run-time soon. A quick > look suggests CPU capability/feature detection is sufficient to render > the pmc code inactive on the net4501. Kernel boots fine. Please unbreak build of NET4501 and similarly- makeoption'd kernels. -- |/"\ John D. Baker, KN5UKS NetBSD Darwin/MacOS X |\ / jdbaker[snail]mylinuxisp[flyspeck]comOpenBSDFreeBSD | X No HTML/proprietary data in email. BSD just sits there and works! |/ \ GPGkeyID: D703 4A7E 479F 63F8 D3F4 BD99 9572 8F23 E4AD 1645
Re: pmc changes break kernels w/makeoptions "COPTS=-Os"
On Thu, 13 Jul 2017, John D. Baker wrote: > Would the following patch be appropriate for appeasing GCC? [snip] It allows compilation to succeed. Will test run-time soon. A quick look suggests CPU capability/feature detection is sufficient to render the pmc code inactive on the net4501. -- |/"\ John D. Baker, KN5UKS NetBSD Darwin/MacOS X |\ / jdbaker[snail]mylinuxisp[flyspeck]comOpenBSDFreeBSD | X No HTML/proprietary data in email. BSD just sits there and works! |/ \ GPGkeyID: D703 4A7E 479F 63F8 D3F4 BD99 9572 8F23 E4AD 1645
pmc changes break kernels w/makeoptions "COPTS=-Os"
Kernel configs like "NET4501" routinely include:
makeoptions "COPTS=-Os"
This causes GCC to emit warnings (treated as errors) if it thinks a
variable might be used uninitialized. For example, the following:
# compile NET4501_JDB/pmc.o
/r1/build/current/tools/amd64/bin/i486--netbsdelf-gcc -msoft-float -mno-mmx
-mno-sse -mno-avx -ffreestanding -fno-zero-initialized-in-bss -g -Os
-fstack-protector -Wstack-protector --param ssp-buffer-size=1
-fno-strict-aliasing -fno-common -std=gnu99 -Werror -Wall -Wno-main
-Wno-format-zero-length -Wpointer-arith -Wmissing-prototypes
-Wstrict-prototypes -Wold-style-definition -Wswitch -Wshadow -Wcast-qual
-Wwrite-strings -Wno-unreachable-code -Wno-pointer-sign -Wno-attributes -Wextra
-Wno-unused-parameter -Wold-style-definition -Wno-sign-compare
--sysroot=/r1/build/current/DEST/i386 -Di386 -I.
-I/x/current/src/sys/external/bsd/acpica/dist
-I/x/current/src/sys/../common/lib/libx86emu
-I/x/current/src/sys/../common/include -I/x/current/src/sys/arch
-I/x/current/src/sys -nostdinc -DTIMER_FREQ=1189200 -D_KERNEL -D_KERNEL_OPT
-std=gnu99 -I/x/current/src/sys/lib/libkern/../../../common/lib/libc/quad
-I/x/current/src/sys/lib/libkern/../../../common/lib/libc/string
-I/x/current/src/sys/lib/libkern/../../../common/lib/libc/arch/i386/string
-D_FORTIFY_SOURCE=2 -I/x/current/src/sys/dist/pf -c
/x/current/src/sys/arch/x86/x86/pmc.c -o pmc.o
/x/current/src/sys/arch/x86/x86/pmc.c: In function 'pmc_nmi':
/x/current/src/sys/arch/x86/x86/pmc.c:168:2: error: 'pmc' may be used
uninitialized in this function [-Werror=maybe-uninitialized]
wrmsr(pmc->ctrmsr, pmc->ctrinitval);
^
While I can follow the logic in "pmc.c", GCC with "-Os" cannot. Would
the following patch be appropriate for appeasing GCC?
+Index: sys/arch/x86/x86/pmc.c
+===
+RCS file: /cvsroot/src/sys/arch/x86/x86/pmc.c,v
+retrieving revision 1.10
+diff -u -p -r1.10 pmc.c
+--- sys/arch/x86/x86/pmc.c 12 Jul 2017 17:33:29 - 1.10
sys/arch/x86/x86/pmc.c 13 Jul 2017 19:08:13 -
+@@ -138,7 +138,7 @@ static int
+ pmc_nmi(const struct trapframe *tf, void *dummy)
+ {
+ struct cpu_info *ci = curcpu();
+- pmc_state_t *pmc;
++ pmc_state_t *pmc = (pmc_state_t *)NULL;
+ pmc_cpu_t *cpu;
+ uint64_t ctr;
+ size_t i;
--
|/"\ John D. Baker, KN5UKS NetBSD Darwin/MacOS X
|\ / jdbaker[snail]mylinuxisp[flyspeck]comOpenBSDFreeBSD
| X No HTML/proprietary data in email. BSD just sits there and works!
|/ \ GPGkeyID: D703 4A7E 479F 63F8 D3F4 BD99 9572 8F23 E4AD 1645
-current boot failure @ wm(4)
Hello NetBSD. I think this maybe related to msaitoh@ work in ./sys/dev/pci/*wm*. The latest kernel begins boot, then just hangs, last 3 lines are (transcribed): wm0 at pci0 dev 25 function 0: PCH2 LAN (82579LM) controller (rev. 0x04) wm0: interrupting at msii vec 0 wm0: wm_init_lcd_from_nvm: need write_smbus() -bch
Re: netbsd-8 broken: sbin/fsck_lfs/lfs.c:369:4: error: 'struct inode' has no member named 'i_flag'
On Thu, 13 Jul 2017, co...@sdf.org wrote: I renamed i_flag to i_state in -current after the -8 branch. It looks like -current headers being used for building -8. Indeed, this seems to be a local problem. Thanks for the hint! - Hubert
Re: netbsd-8 broken: sbin/fsck_lfs/lfs.c:369:4: error: 'struct inode' has no member named 'i_flag'
On Thu, Jul 13, 2017 at 10:58:53AM +, co...@sdf.org wrote: > I renamed i_flag to i_state in -current after the -8 branch. > It looks like -current headers being used for building -8. An update build works without issue on my native netbsd-8 box.
Re: netbsd-8 broken: sbin/fsck_lfs/lfs.c:369:4: error: 'struct inode' has no member named 'i_flag'
I renamed i_flag to i_state in -current after the -8 branch. It looks like -current headers being used for building -8.
netbsd-8 broken: sbin/fsck_lfs/lfs.c:369:4: error: 'struct inode' has no member named 'i_flag'
How can a release branch be broken? Was this not tested before/after the pullup? Or is this some local problem? Where to look? Details below. - Hubert # compile lfs_cleanerd/lfs.o /Users/feyrer/work/NetBSD/cvs/src-8/tooldir.Darwin/bin/x86_64--netbsd-gcc -O2 -fPIE-std=gnu99-Wall -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wno-sign-compare -Wsystem-headers -Wno-traditional -Wa,--fatal-warnings -Wreturn-type -Wswitch -Wshadow -Wcast-qual -Wwrite-strings -Wextra -Wno-unused-parameter -Wno-sign-compare -Werror --sysroot=/Volumes/netbsd-src-objdestdir/destdir.amd64 -I/Users/feyrer/work/NetBSD/cvs/src-8/sbin/fsck_lfs -I/Users/feyrer/work/NetBSD/cvs/src-8/sbin/mount_lfs -c /Users/feyrer/work/NetBSD/cvs/src-8/sbin/fsck_lfs/lfs.c /Users/feyrer/work/NetBSD/cvs/src-8/sbin/fsck_lfs/lfs.c: In function 'lfs_raw_vget': /Users/feyrer/work/NetBSD/cvs/src-8/sbin/fsck_lfs/lfs.c:369:4: error: 'struct inode' has no member named 'i_flag' ip->i_flag = 0; ^ /Users/feyrer/work/NetBSD/cvs/src-8/sbin/fsck_lfs/lfs.c: In function 'extend_ifile': /Users/feyrer/work/NetBSD/cvs/src-8/sbin/fsck_lfs/lfs.c:955:4: error: 'struct inode' has no member named 'i_flag' ip->i_flag |= IN_MODIFIED; ^ /Users/feyrer/work/NetBSD/cvs/src-8/sbin/fsck_lfs/lfs.c: In function 'lfs_balloc': /Users/feyrer/work/NetBSD/cvs/src-8/sbin/fsck_lfs/lfs.c:1061:6: error: 'struct inode' has no member named 'i_flag' ip->i_flag |= IN_CHANGE | IN_UPDATE; ^ /Users/feyrer/work/NetBSD/cvs/src-8/sbin/fsck_lfs/lfs.c: In function 'lfs_fragextend': /Users/feyrer/work/NetBSD/cvs/src-8/sbin/fsck_lfs/lfs.c:1255:4: error: 'struct inode' has no member named 'i_flag' ip->i_flag |= IN_CHANGE | IN_UPDATE; ^ *** [lfs.o] Error code 1
nouveau reboot
or "new" reboot: just updated a working 3rd July amd64 kernel with this morning's source, and the computer reboots after printing nouveau, but before drm. Haven't had a chance to dig (won't until tonight) - any first guesses? Cheers, Patrick
