Automated report: NetBSD-current/i386 test failure
This is an automatically generated notice of a new failure of the NetBSD test suite. The newly failing test case is: usr.bin/xlint/lint1/t_integration:all_messages The above test failed in each of the last 4 test runs, and passed in at least 26 consecutive runs before that. The following commits were made between the last successful test and the failed test: 2021.01.05.22.17.40 mlelstv src/share/man/man4/dk.4,v 1.8 2021.01.05.22.38.51 rillig src/tests/usr.bin/xlint/lint1/msg_324.c,v 1.2 2021.01.05.22.38.51 rillig src/tests/usr.bin/xlint/lint1/msg_324.exp,v 1.2 Logs can be found at: http://releng.NetBSD.org/b5reports/i386/commits-2021.01.html#2021.01.05.22.38.51
alignment and packed structs
I just tried to compile if_iwn as a module. It failed with
dev/pci/if_iwn.c:2685:6: error: converting a packed 'struct iwn_fw_dump'
pointer (alignment 1) to a 'uint32_t' {aka 'unsigned int'} pointer (alignment
4) may result in an unaligned pointer value [-Werror=address-of-packed-member]
I got around it with
diff -u -r1.17 if_iwnreg.h
--- if_iwnreg.h 19 Jul 2017 16:55:12 - 1.17
+++ if_iwnreg.h 6 Jan 2021 17:24:01 -
@@ -1447,7 +1447,7 @@
uint32_tsrc_line;
uint32_ttsf;
uint32_ttime[2];
-} __packed;
+} __attribute__((aligned(4),packed));
/* TLV firmware header. */
struct iwn_fw_tlv_hdr {
Why isn't this necessary when building if_iwn.c as part of a kernel?
Is the above the right solution?
Cheers,
Patrick
Re: Big-endian mode supported for Raspberry Pi [0-3] with bootable images available
Thank you for all your hard work! The images work just fine out of the box. After a few hours of compiling, there was a panic. This is a 3B+ (the 1400 MHz one): [ 18045.402869] ifree: dev = 0xa801, ino = 35088, fs = / [ 18045.402869] panic: ffs_freefile_common: freeing free inode [ 18045.414509] cpu0: Begin traceback... [ 18045.414509] trace fp c0004376f810 [ 18045.414509] fp c0004376f840 vpanic() at c04e5d5c netbsd:vpanic+0x14c [ 18045.424917] fp c0004376f8a0 panic() at c04e5e54 netbsd:panic+0x44 [ 18045.424917] fp c0004376f930 ffs_freefile_common.isra.0() at c0422f44 netbsd:ffs_freefile_common.isra.0+0x2d4 [ 18045.436775] fp c0004376f9a0 ffs_freefile() at c0427bb4 netbsd:ffs_freefile+0xf4 [ 18045.445200] fp c0004376fa00 ffs_reclaim() at c0434968 netbsd:ffs_reclaim+0x110 [ 18045.445200] fp c0004376fa40 VOP_RECLAIM() at c0556cfc netbsd:VOP_RECLAIM+0x34 [ 18045.455684] fp c0004376fa70 vcache_reclaim() at c0548a6c netbsd:vcache_reclaim+0x14c [ 18045.465203] fp c0004376fb40 vrelel() at c0549520 netbsd:vrelel+0x2a0 [ 18045.465203] fp c0004376fba0 vn_close() at c054dcfc netbsd:vn_close+0x44 [ 18045.477720] fp c0004376fbd0 closef() at c047c448 netbsd:closef+0x60 [ 18045.477720] fp c0004376fc10 fd_free() at c047f3c0 netbsd:fd_free+0xf8 [ 18045.488230] fp c0004376fc90 exit1() at c048a5cc netbsd:exit1+0xfc [ 18045.488230] fp c0004376fd80 sys_exit() at c048af08 netbsd:sys_exit+0x38 [ 18045.498527] fp c0004376fdb0 syscall() at c008ef1c netbsd:syscall+0x18c [ 18045.508234] fp c0004376fe60 trap_el0_sync() at c00903f0 netbsd:trap_el0_sync+0x380 [ 18045.508234] tf c0004376fed0 el0_trap() at c00927f0 netbsd:el0_trap [ 18045.518235] trapframe 0xc0004376fed0 (304 bytes) [ 18045.518235] pc=fd5f181b0c14, spsr=8000 [ 18045.518235]esr=5601,far=f53aaf49a000 [ 18045.529932] x0=, x1= [ 18045.529932] x2=00020013e000, x3=ff837b80 [ 18045.529932] x4=, x5=fd5f1844a3c0 [ 18045.541002] x6=, x7=4545524348363400 [ 18045.541002] x8=fd5f, x9=0003 [ 18045.541002]x10=fd5f18221000,x11=0030 [ 18045.552073]x12=fd5f18239a00,x13=fd5f17c008c0 [ 18045.552073]x14=0014,x15=4008 [ 18045.552073]x16=00020013d1f8,x17=fd5f181b0c10 [ 18045.563146]x18=0041,x19= [ 18045.563146]x20=00020013d000,x21=ff838fe0 [ 18045.563146]x22=00020013df80,x23= [ 18045.574215]x24=ff838fe0,x25=f33f [ 18045.574215]x26=,x27= [ 18045.574215]x28=, fp=x29=ff837b80 [ 18045.585287] lr=x30=00020011c890, sp=ff837b80 [ 18045.585287] [ 18045.585287] cpu0: End traceback... [ 18045.594926] rebooting... This was a clean big endian filesystem on a USB attached SSD on its first boot. Trying to fully fsck didn't work (I don't have a record - it was on the local console), and trying to fsck on a little endian Pi gave this: http://mail-index.netbsd.org/port-arm/2020/12/26/msg007132.html I decided to make a clean little endian filesystem and restart. However, enabling WAPBL in fstab causes the boot to fail with messages saying that the filesystem is read-only, then: mount /dev/sd0a / mount_ffs: /dev/sd0a on /: specified device does not match mounted device Perhaps it should be noted somewhere that WAPBL can't be used on other-endian systems, and a more meaningful error presented when it is attempted? John Klos
Re: alignment and packed structs
On Wed, 6 Jan 2021, Patrick Welche wrote:
I just tried to compile if_iwn as a module. It failed with
dev/pci/if_iwn.c:2685:6: error: converting a packed 'struct iwn_fw_dump'
pointer (alignment 1) to a 'uint32_t' {aka 'unsigned int'} pointer (alignment
4) may result in an unaligned pointer value [-Werror=address-of-packed-member]
I got around it with
...
Why isn't this necessary when building if_iwn.c as part of a kernel?
This isn't an isolated case. I recently built some other (Intel
DRM) code as modules and had to "fix " the code in 3 or 4 places
for the whole kernel/module compilation to complete successfully.
I figured it was a case of slightly different compiler flags being
used for the monolithic vs. modular kernel builds.
-RVP
daily CVS update output
Updating src tree: P src/bin/df/df.1 P src/share/man/man4/dk.4 P src/sys/arch/amiga/dev/amidisplaycc.c P src/sys/arch/powerpc/booke/booke_pmap.c P src/sys/arch/powerpc/booke/trap.c P src/sys/arch/powerpc/ibm4xx/ibm4xx_machdep.c P src/sys/arch/powerpc/include/db_machdep.h P src/sys/arch/powerpc/include/vmparam.h P src/sys/arch/powerpc/pci/pciconf_indirect.c P src/sys/arch/powerpc/pci/pciconf_ofmethod.c P src/sys/arch/sparc64/dev/psycho.c P src/tests/usr.bin/xlint/lint1/msg_093.c U src/tests/usr.bin/xlint/lint1/msg_093.exp P src/tests/usr.bin/xlint/lint1/msg_094.c U src/tests/usr.bin/xlint/lint1/msg_094.exp P src/tests/usr.bin/xlint/lint1/msg_095.c U src/tests/usr.bin/xlint/lint1/msg_095.exp P src/tests/usr.bin/xlint/lint1/msg_096.c U src/tests/usr.bin/xlint/lint1/msg_096.exp U src/tests/usr.bin/xlint/lint1/msg_097.c U src/tests/usr.bin/xlint/lint1/msg_097.exp U src/tests/usr.bin/xlint/lint1/msg_098.c U src/tests/usr.bin/xlint/lint1/msg_098.exp P src/tests/usr.bin/xlint/lint1/msg_099.c U src/tests/usr.bin/xlint/lint1/msg_099.exp P src/tests/usr.bin/xlint/lint1/msg_324.c U src/tests/usr.bin/xlint/lint1/msg_324.exp P src/usr.bin/ftp/cmds.c P src/usr.bin/ftp/ftp.1 P src/usr.bin/ftp/ftp.c P src/usr.bin/ftp/progressbar.c P src/usr.bin/ftp/progressbar.h P src/usr.bin/ftp/ssl.c P src/usr.bin/ftp/version.h Updating xsrc tree: Killing core files: Updating file list: -rw-rw-r-- 1 srcmastr netbsd 36562943 Jan 7 03:03 ls-lRA.gz
netbsd-9 sys/dev/usb/ehci.c panic: exfer->ex_isdone
I've had a couple of recent crashes on amd64, likely due to a dodgy USB hub. Still, no matter how bad the hub is, I think the crashes indicate a bug somewhere. System is: NetBSD slave 9.1_STABLE NetBSD 9.1_STABLE (SLAVE) #5: Wed Dec 9 17:19:04 AEDT 2020 stix@slave:/home/netbsd/netbsd-9/obj.amd64/home/netbsd/netbsd-9/src/sys/arch/amd64/compile/SLAVE amd64 I updated between the two crashes to see if there'd been any relevant updates. USB tree is usually something like: ksh$ sudo usbdevs addr 1: EHCI root hub, NetBSD addr 2: Rate Matching Hub, Intel addr 3: USB 2.0 Hub, Terminus Technology addr 4: Gaming KB, Gaming KB addr 5: Microsoft Basic Optical Mouse v2.0, Microsoft addr 6: product 0042, Arduino (www.arduino.cc) addr 7: Ext HDD 1021, Western Digital addr 1: EHCI root hub, NetBSD addr 2: Rate Matching Hub, Intel addr 4: MT1806, MediaTek Inc addr 5: Bluetooth USB Adapter, Cambridge Silicon Radio Dec 7 11:43:56 slave /netbsd: [ 3150526.7715654] panic: kernel diagnostic assertion "exfer->ex_isdone" failed: file "/home/netbsd/netbsd-9/src/sys/dev/usb/ehci.c", line 4079 Dec 7 11:43:56 slave /netbsd: [ 3150526.7715654] cpu0: Begin traceback... Dec 7 11:43:56 slave /netbsd: [ 3150526.7715654] vpanic() at netbsd:vpanic+0x160 Dec 7 11:43:56 slave /netbsd: [ 3150526.7715654] stge_eeprom_wait.isra.4() at netbsd:stge_eeprom_wait.isra.4 Dec 7 11:43:56 slave /netbsd: [ 3150526.7715654] ehci_device_intr_start() at netbsd:ehci_device_intr_start+0x275 Dec 7 11:43:56 slave /netbsd: [ 3150526.7715654] usbd_start_next() at netbsd:usbd_start_next+0xd6 Dec 7 11:43:56 slave /netbsd: [ 3150526.7715654] ehci_abortx() at netbsd:ehci_abortx+0x9c Dec 7 11:43:56 slave /netbsd: [ 3150526.7715654] usbd_xfer_timeout_task() at netbsd:usbd_xfer_timeout_task+0x5c Dec 7 11:43:56 slave /netbsd: [ 3150526.7815697] usb_task_thread() at netbsd:usb_task_thread+0xba Dec 7 11:43:56 slave /netbsd: [ 3150526.7815697] cpu0: End traceback... Dec 7 11:43:56 slave /netbsd: [ 3150526.7815697] uvm_fault(0xf566d3edb5c8, 0x0, 1) -> e Dec 7 11:43:56 slave /netbsd: [ 3150526.7815697] fatal page fault in supervisor mode Dec 7 11:43:56 slave /netbsd: [ 3150526.7815697] trap type 6 code 0 rip 0x809c93b2 cs 0x8 rflags 0x10202 cr2 0xa5 ilevel 0x8 rsp 0xd1813f40fe30 Dec 7 11:43:56 slave /netbsd: Dec 7 11:43:56 slave /netbsd: [ 3150526.7815697] curlwp 0xf569ccad1b20 pid 24376.1 lowest kstack 0xd1813fd4umpci2ncg 0t Jan 4 21:43:38 slave /netbsd: [ 2241344.6177737] panic: kernel diagnostic assertion "exfer->ex_isdone" failed: file "/home/netbsd/netbsd-9/src/sys/dev/usb/ehci.c", line 4079 Jan 4 21:43:38 slave /netbsd: [ 2241344.6177737] cpu0: Begin traceback... Jan 4 21:43:38 slave /netbsd: [ 2241344.6177737] vpanic() at netbsd:vpanic+0x160 Jan 4 21:43:38 slave /netbsd: [ 2241344.6177737] stge_eeprom_wait.isra.4() at netbsd:stge_eeprom_wait.isra.4 Jan 4 21:43:38 slave /netbsd: [ 2241344.6177737] ehci_device_intr_start() at netbsd:ehci_device_intr_start+0x275 Jan 4 21:43:38 slave /netbsd: [ 2241344.6177737] usbd_start_next() at netbsd:usbd_start_next+0xd6 Jan 4 21:43:38 slave /netbsd: [ 2241344.6177737] ehci_abortx() at netbsd:ehci_abortx+0x9c Jan 4 21:43:38 slave /netbsd: [ 2241344.627] usbd_xfer_timeout_task() at netbsd:usbd_xfer_timeout_task+0x5c Jan 4 21:43:38 slave /netbsd: [ 2241344.627] usb_task_thread() at netbsd:usb_task_thread+0xba Jan 4 21:43:38 slave /netbsd: [ 2241344.627] cpu0: End traceback... Jan 4 21:43:38 slave /netbsd: [ 2241344.627] uvm_fault(0xfa8b73c275f0, 0x0, 2) -> e Jan 4 21:43:38 slave /netbsd: [ 2241344.627] fatal page fault in supervisor mode Jan 4 21:43:38 slave /netbsd: [ 2241344.627] trap type 6 code 0x2 rip 0x809c2626 cs 0x8 rflags 0x10282 cr2 0x84 ilevel 0x8 rsp 0xcf817e00cb60 Jan 4 21:43:38 slave /netbsd: Jan 4 21:43:38 slave /netbsd: [ 2241344.627] curlwp 0xfa8b1d6a7500 pid 10543.31 lowest kstack 0xdffufmfpcifn8g1 7teo0 0d9e2vc 0 -- Paul Ripke "Great minds discuss ideas, average minds discuss events, small minds discuss people." -- Disputed: Often attributed to Eleanor Roosevelt. 1948.
