daily CVS update output
Updating src tree: P src/distrib/acorn32/stand/Makefile P src/distrib/utils/libhack/wrap.c P src/lib/libc/arch/alpha/gen/__longjmp14.c P src/lib/libc/compat/arch/alpha/gen/compat__setjmp.S P src/lib/libc/compat/arch/alpha/gen/compat_setjmp.S P src/lib/libc/gen/setjmp.3 P src/sys/arch/alpha/alpha/machdep.c P src/sys/arch/alpha/alpha/pmap.c P src/sys/arch/alpha/include/mcontext.h P src/sys/arch/alpha/include/pmap.h P src/sys/arch/macppc/stand/ofwboot/ofdev.c P src/sys/arch/mips/mips/fp.S P src/sys/dev/i2c/axppmic.c P src/sys/dev/raidframe/rf_netbsdkintf.c P src/sys/net/lagg/if_lagg.c P src/sys/net/lagg/if_lagg.h P src/sys/net/lagg/if_lagg_lacp.h P src/sys/net/lagg/if_laggproto.c P src/sys/net/lagg/if_laggproto.h P src/sys/net/lagg/if_laggvar.h P src/tests/lib/libc/sys/t_ptrace_wait.h P src/tests/net/if_lagg/t_lagg.sh P src/tools/compat/compat_defs.h Updating xsrc tree: Killing core files: Updating file list: -rw-rw-r-- 1 srcmastr netbsd 40538391 May 25 03:03 ls-lRA.gz
Re: Anyone using a Jabra USB Headset with -current?
Seems like the latest current causing my system to crash on boot with xhci devices. Nevertheless, I tested jabra headset with the patch on USB 2.0 ports, but it still causes panic on removal while audio is playing by running "audiocfg test 0". It can crash with either of two: panic: kernel diagnostic assertion "(target->prt_class == class)" failed: file "/home/andriusv/workspace/netbsd-src/sys/kern/subr_psref.c", line 296 mismatched psref target class: 0x0 (ref) != 0xb45183b1a940 (expected) cpu0: Begin traceback... vpanic() at netbsd:vpanic+0x156 __x86_indirect_thunk_rax() at netbsd:__x86_indirect_thunk_rax psref_acquire() at netbsd:psref_acquire+0x15a audioclose() at netbsd:audioclose+0x96 closef() at netbsd:closef+0x60 fd_free() at netbsd:fd_free+0x1e4 exit1() at netbsd:exit1+0x126 sys_exit() at netbsd:sys_exit+0x39 syscall() at netbsd:syscall+0x196 --- syscall (number 1) --- netbsd:syscall+0x196: cpu0: End traceback... or panic: kernel diagnostic assertion "!target->prt_draining" failed: file "/home/andriusv/workspace/netbsd-src/sys/kern/subr_psref.c", line 299 psref target already destroyed: 0xf0cdc5b42d48 cpu1: Begin traceback... vpanic() at netbsd:vpanic+0x156 __x86_indirect_thunk_rax() at netbsd:__x86_indirect_thunk_rax psref_acquire() at netbsd:psref_acquire+0x191 audioclose() at netbsd:audioclose+0x96 closef() at netbsd:closef+0x60 fd_free() at netbsd:fd_free+0x1e4 exit1() at netbsd:exit1+0x126 sys_exit() at netbsd:sys_exit+0x39 syscall() at netbsd:syscall+0x196 --- syscall (number 1) --- netbsd:syscall+0x196: cpu1: End traceback... I didn't try to play anything actual sound file, so possibly it's related only to the test itself. On Mon, May 24, 2021 at 12:34 PM Andrius V wrote: > > I will retest later today, I was testing current over a week ago. > > > On Mon, May 24, 2021 at 11:07 AM Michael van Elst wrote: > > > > On Mon, May 24, 2021 at 08:49:26AM +0300, Andrius V wrote: > > > Jabra Evolve 20 is not working on NetBSD 9.2 for me (submitted pr > > > 56172 recently). But yes, it does work on current branch, except that > > > removing headset on audio play causes panic. > > > > Possible. I test on -current. > > > > Removing the headset doesn't panic for me which might be caused by: > > > > Index: uaudio.c > > === > > RCS file: /cvsroot/src/sys/dev/usb/uaudio.c,v > > retrieving revision 1.169 > > diff -p -u -r1.169 uaudio.c > > --- uaudio.c15 Feb 2021 13:39:18 - 1.169 > > +++ uaudio.c24 May 2021 08:05:05 - > > @@ -519,7 +519,7 @@ static int > > uaudio_detach(device_t self, int flags) > > { > > struct uaudio_softc *sc = device_private(self); > > - int rv = 0; > > + int rv; > > > > sc->sc_dying = 1; > > > > @@ -529,8 +529,11 @@ uaudio_detach(device_t self, int flags) > > uaudio_halt_out_dma_unlocked(sc); > > uaudio_halt_in_dma_unlocked(sc); > > > > - if (sc->sc_audiodev != NULL) > > + if (sc->sc_audiodev != NULL) { > > rv = config_detach(sc->sc_audiodev, flags); > > + if (rv) > > + return rv; > > + } > > > > usbd_add_drv_event(USB_EVENT_DRIVER_DETACH, sc->sc_udev, > > sc->sc_dev); > > > > @@ -541,7 +544,7 @@ uaudio_detach(device_t self, int flags) > > mutex_destroy(>sc_lock); > > mutex_destroy(>sc_intr_lock); > > > > - return rv; > > + return 0; > > } > > > > Static int > > > > > > > > Greetings, > > -- > > Michael van Elst > > Internet: mlel...@serpens.de > > "A potential Snark may lurk in every tree."
Re: Anyone using a Jabra USB Headset with -current?
I will retest later today, I was testing current over a week ago. On Mon, May 24, 2021 at 11:07 AM Michael van Elst wrote: > > On Mon, May 24, 2021 at 08:49:26AM +0300, Andrius V wrote: > > Jabra Evolve 20 is not working on NetBSD 9.2 for me (submitted pr > > 56172 recently). But yes, it does work on current branch, except that > > removing headset on audio play causes panic. > > Possible. I test on -current. > > Removing the headset doesn't panic for me which might be caused by: > > Index: uaudio.c > === > RCS file: /cvsroot/src/sys/dev/usb/uaudio.c,v > retrieving revision 1.169 > diff -p -u -r1.169 uaudio.c > --- uaudio.c15 Feb 2021 13:39:18 - 1.169 > +++ uaudio.c24 May 2021 08:05:05 - > @@ -519,7 +519,7 @@ static int > uaudio_detach(device_t self, int flags) > { > struct uaudio_softc *sc = device_private(self); > - int rv = 0; > + int rv; > > sc->sc_dying = 1; > > @@ -529,8 +529,11 @@ uaudio_detach(device_t self, int flags) > uaudio_halt_out_dma_unlocked(sc); > uaudio_halt_in_dma_unlocked(sc); > > - if (sc->sc_audiodev != NULL) > + if (sc->sc_audiodev != NULL) { > rv = config_detach(sc->sc_audiodev, flags); > + if (rv) > + return rv; > + } > > usbd_add_drv_event(USB_EVENT_DRIVER_DETACH, sc->sc_udev, sc->sc_dev); > > @@ -541,7 +544,7 @@ uaudio_detach(device_t self, int flags) > mutex_destroy(>sc_lock); > mutex_destroy(>sc_intr_lock); > > - return rv; > + return 0; > } > > Static int > > > > Greetings, > -- > Michael van Elst > Internet: mlel...@serpens.de > "A potential Snark may lurk in every tree."
Re: Anyone using a Jabra USB Headset with -current?
On Mon, May 24, 2021 at 08:49:26AM +0300, Andrius V wrote: > Jabra Evolve 20 is not working on NetBSD 9.2 for me (submitted pr > 56172 recently). But yes, it does work on current branch, except that > removing headset on audio play causes panic. Possible. I test on -current. Removing the headset doesn't panic for me which might be caused by: Index: uaudio.c === RCS file: /cvsroot/src/sys/dev/usb/uaudio.c,v retrieving revision 1.169 diff -p -u -r1.169 uaudio.c --- uaudio.c15 Feb 2021 13:39:18 - 1.169 +++ uaudio.c24 May 2021 08:05:05 - @@ -519,7 +519,7 @@ static int uaudio_detach(device_t self, int flags) { struct uaudio_softc *sc = device_private(self); - int rv = 0; + int rv; sc->sc_dying = 1; @@ -529,8 +529,11 @@ uaudio_detach(device_t self, int flags) uaudio_halt_out_dma_unlocked(sc); uaudio_halt_in_dma_unlocked(sc); - if (sc->sc_audiodev != NULL) + if (sc->sc_audiodev != NULL) { rv = config_detach(sc->sc_audiodev, flags); + if (rv) + return rv; + } usbd_add_drv_event(USB_EVENT_DRIVER_DETACH, sc->sc_udev, sc->sc_dev); @@ -541,7 +544,7 @@ uaudio_detach(device_t self, int flags) mutex_destroy(>sc_lock); mutex_destroy(>sc_intr_lock); - return rv; + return 0; } Static int Greetings, -- Michael van Elst Internet: mlel...@serpens.de "A potential Snark may lurk in every tree."