Re: dependency of magic.h

2018-12-11 Thread Masanobu SAITOH

On 2018/12/11 21:40, Christos Zoulas wrote:

In article <944c79fd-4414-1936-67f4-03ec228bd...@execsw.org>,
Masanobu SAITOH   wrote:

  Hi.

  While doing "./build.sh -j16 distribution", I got "unterminated ifdef"
error in magic.h(src/external/bsd/file/lib). When I got this compile error,
I checked the file and the #ifdef...#endif was consistent. It seems the
compiler saw unfinished magic.h. Have you ever seen this error before?

  src/external/bsd/file/lib/Makefile has "${ALLOBJS}: magic.h".
I'm not familiar with Makefile, but I suspect it should be replaced with
"DPSRCS+=magic.h".

  Right?

  It's hard to reproduce the problem, so I can't verify the change works
or not...


Why don't you change it anyway. I think I've seen this before too.

christo


 Committed now!

--
---
SAITOH Masanobu (msai...@execsw.org
 msai...@netbsd.org)


Re: dependency of magic.h

2018-12-11 Thread Christos Zoulas
In article <944c79fd-4414-1936-67f4-03ec228bd...@execsw.org>,
Masanobu SAITOH   wrote:
>  Hi.
>
>  While doing "./build.sh -j16 distribution", I got "unterminated ifdef"
>error in magic.h(src/external/bsd/file/lib). When I got this compile error,
>I checked the file and the #ifdef...#endif was consistent. It seems the
>compiler saw unfinished magic.h. Have you ever seen this error before?
>
>  src/external/bsd/file/lib/Makefile has "${ALLOBJS}: magic.h".
>I'm not familiar with Makefile, but I suspect it should be replaced with
>"DPSRCS+=magic.h".
>
>  Right?
>
>  It's hard to reproduce the problem, so I can't verify the change works
>or not...

Why don't you change it anyway. I think I've seen this before too.

christo