Re: varshm check in postinstall

2019-01-31 Thread Masanobu SAITOH 

On 2019/01/31 18:49, Martin Husemann wrote:

On Thu, Jan 31, 2019 at 05:23:45PM +0900, Masanobu SAITOH wrote:

-   if ${GREP} -w "/var/shm" "${DEST_DIR}/etc/fstab" >/dev/null 2>&1;
+   if ${GREP} -E "^var_shm_symlink" "${DEST_DIR}/etc/rc.conf" >/dev/null 
2>&1;
+   then
+   failed=0;
+   elif ${GREP} -w "/var/shm" "${DEST_DIR}/etc/fstab" >/dev/null 2>&1;
then
failed=0;
else

OK?


Sounds good!
I always left a commented out /var/shm tmpfs entry in my fstab, but your fix
is better.

Martin


 Done!

--
---
SAITOH Masanobu (msai...@execsw.org
 msai...@netbsd.org)

Re: varshm check in postinstall

2019-01-31 Thread Martin Husemann 
On Thu, Jan 31, 2019 at 05:23:45PM +0900, Masanobu SAITOH wrote:
> - if ${GREP} -w "/var/shm" "${DEST_DIR}/etc/fstab" >/dev/null 2>&1;
> + if ${GREP} -E "^var_shm_symlink" "${DEST_DIR}/etc/rc.conf" >/dev/null 
> 2>&1;
> + then
> + failed=0;
> + elif ${GREP} -w "/var/shm" "${DEST_DIR}/etc/fstab" >/dev/null 2>&1;
>   then
>   failed=0;
>   else
> 
> OK?

Sounds good!
I always left a commented out /var/shm tmpfs entry in my fstab, but your fix
is better.

Martin