[Curtin-dev] [Merge] ~mwhudson/curtin:lp-1876626 into curtin:master
The proposal to merge ~mwhudson/curtin:lp-1876626 into curtin:master has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~mwhudson/curtin/+git/curtin/+merge/383319 -- Your team curtin developers is subscribed to branch curtin:master. -- Mailing list: https://launchpad.net/~curtin-dev Post to : curtin-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~curtin-dev More help : https://help.launchpad.net/ListHelp
Re: [Curtin-dev] [Merge] ~mwhudson/curtin:lp-1876626 into curtin:master
Review: Approve continuous-integration -- https://code.launchpad.net/~mwhudson/curtin/+git/curtin/+merge/383319 Your team curtin developers is subscribed to branch curtin:master. -- Mailing list: https://launchpad.net/~curtin-dev Post to : curtin-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~curtin-dev More help : https://help.launchpad.net/ListHelp
Re: [Curtin-dev] [Merge] ~mwhudson/curtin:lp-1876626 into curtin:master
Spurious failure on ppc64 node; could be lab vpn related; I was having some trouble as well. I think autolander will retry. -- https://code.launchpad.net/~mwhudson/curtin/+git/curtin/+merge/383319 Your team curtin developers is subscribed to branch curtin:master. -- Mailing list: https://launchpad.net/~curtin-dev Post to : curtin-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~curtin-dev More help : https://help.launchpad.net/ListHelp
Re: [Curtin-dev] [Merge] ~mwhudson/curtin:lp-1876626 into curtin:master
Review: Needs Fixing continuous-integration Autolanding: FAILED More details in the following jenkins job: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/166/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/166/ SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/166/ FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/166/ SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/166/ -- https://code.launchpad.net/~mwhudson/curtin/+git/curtin/+merge/383319 Your team curtin developers is subscribed to branch curtin:master. -- Mailing list: https://launchpad.net/~curtin-dev Post to : curtin-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~curtin-dev More help : https://help.launchpad.net/ListHelp
[Curtin-dev] [Merge] ~mwhudson/curtin:lp-1876626 into curtin:master
The proposal to merge ~mwhudson/curtin:lp-1876626 into curtin:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mwhudson/curtin/+git/curtin/+merge/383319 -- Your team curtin developers is subscribed to branch curtin:master. -- Mailing list: https://launchpad.net/~curtin-dev Post to : curtin-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~curtin-dev More help : https://help.launchpad.net/ListHelp
[Curtin-dev] [Merge] ~mwhudson/curtin:lp-1876626 into curtin:master
The proposal to merge ~mwhudson/curtin:lp-1876626 into curtin:master has been updated. Commit message changed to: block.detect_multipath: ignore fake "devices" from /proc/mounts A tmpfs can be mounted with any old junk in the "device" field and unfortunately casper sometimes puts "/dev/shm" there, which is usually a directory. Ignore such cases. LP: #1876626 For more details, see: https://code.launchpad.net/~mwhudson/curtin/+git/curtin/+merge/383319 -- Your team curtin developers is subscribed to branch curtin:master. -- Mailing list: https://launchpad.net/~curtin-dev Post to : curtin-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~curtin-dev More help : https://help.launchpad.net/ListHelp
[Curtin-dev] [Merge] ~mwhudson/curtin:lp-1876626 into curtin:master
The proposal to merge ~mwhudson/curtin:lp-1876626 into curtin:master has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~mwhudson/curtin/+git/curtin/+merge/383319 -- Your team curtin developers is subscribed to branch curtin:master. -- Mailing list: https://launchpad.net/~curtin-dev Post to : curtin-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~curtin-dev More help : https://help.launchpad.net/ListHelp
[Curtin-dev] [Merge] ~mwhudson/curtin:lp-1876626 into curtin:master
The proposal to merge ~mwhudson/curtin:lp-1876626 into curtin:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mwhudson/curtin/+git/curtin/+merge/383319 -- Your team curtin developers is subscribed to branch curtin:master. -- Mailing list: https://launchpad.net/~curtin-dev Post to : curtin-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~curtin-dev More help : https://help.launchpad.net/ListHelp
Re: [Curtin-dev] [Merge] ~mwhudson/curtin:lp-1876626 into curtin:master
Review: Approve Thanks! -- https://code.launchpad.net/~mwhudson/curtin/+git/curtin/+merge/383319 Your team curtin developers is subscribed to branch curtin:master. -- Mailing list: https://launchpad.net/~curtin-dev Post to : curtin-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~curtin-dev More help : https://help.launchpad.net/ListHelp
[Curtin-dev] [Merge] ~mwhudson/curtin:lp-1876626 into curtin:master
The proposal to merge ~mwhudson/curtin:lp-1876626 into curtin:master has been updated. Commit message changed to: block.detect_multipath: ignore fake "devices" from /proc/mounts A tmpfs can be mounted with any old junk in the "device" field and unfortunately casper sometimes puts "/dev/shm" there, which is usually a directory. Ignore such cases. (See https://bugs.launchpad.net/bugs/1876626) LP: #1876626 For more details, see: https://code.launchpad.net/~mwhudson/curtin/+git/curtin/+merge/383319 -- Your team curtin developers is requested to review the proposed merge of ~mwhudson/curtin:lp-1876626 into curtin:master. -- Mailing list: https://launchpad.net/~curtin-dev Post to : curtin-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~curtin-dev More help : https://help.launchpad.net/ListHelp
Re: [Curtin-dev] [Merge] ~mwhudson/curtin:lp-1876626 into curtin:master
Review: Approve continuous-integration PASSED: Continuous integration, rev:61a11664e749d216555e0241335717f538cca22c https://jenkins.ubuntu.com/server/job/curtin-ci/73/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/73/ SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-arm64/73/ SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-ppc64el/73/ SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-s390x/73/ Click here to trigger a rebuild: https://jenkins.ubuntu.com/server/job/curtin-ci/73//rebuild -- https://code.launchpad.net/~mwhudson/curtin/+git/curtin/+merge/383319 Your team curtin developers is requested to review the proposed merge of ~mwhudson/curtin:lp-1876626 into curtin:master. -- Mailing list: https://launchpad.net/~curtin-dev Post to : curtin-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~curtin-dev More help : https://help.launchpad.net/ListHelp
[Curtin-dev] [Merge] ~mwhudson/curtin:lp-1876626 into curtin:master
Michael Hudson-Doyle has proposed merging ~mwhudson/curtin:lp-1876626 into
curtin:master.
Commit message:
block.detect_multipath: ignore fake "devices" from /proc/mounts
A tmpfs can be mounted with any old junk in the "device" field and
unfortunately casper sometimes puts "/dev/shm" there, which is usually a
directory. Ignore such cases. (See https://bugs.launchpad.net/bugs/1876626)
Requested reviews:
curtin developers (curtin-dev)
For more details, see:
https://code.launchpad.net/~mwhudson/curtin/+git/curtin/+merge/383319
--
Your team curtin developers is requested to review the proposed merge of
~mwhudson/curtin:lp-1876626 into curtin:master.
diff --git a/curtin/block/__init__.py b/curtin/block/__init__.py
index a7fe22f..c006aa4 100644
--- a/curtin/block/__init__.py
+++ b/curtin/block/__init__.py
@@ -637,6 +637,12 @@ def detect_multipath(target_mountpoint=None):
for device in (os.path.realpath(dev)
for (dev, _mp, _vfs, _opts, _freq, _passno)
in get_proc_mounts() if dev.startswith('/dev/')):
+if not is_block_device(device):
+# A tmpfs can be mounted with any old junk in the "device"
+# field and unfortunately casper sometimes puts "/dev/shm"
+# there, which is usually a directory. Ignore such cases.
+# (See https://bugs.launchpad.net/bugs/1876626)
+continue
if _device_is_multipathed(device):
return device
--
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~curtin-dev
More help : https://help.launchpad.net/ListHelp
