Re: mintty crashes on Windows 7
On Thu, 5 May 2022 13:41:20 +0900 Takashi Yano wrote: > I downloaded bash source files from: > https://git.savannah.gnu.org/git/bash.git > and built it by: > ./configure && make > and replaced /usr/bin/bash. > > Then the issue disappeared. > Now, I start to suspect the issue is a bug of msys2 bash package. I tried several shells and results are as follows. tcsh: ok ash: ok dash: ok zsh: ok ksh: ok fish: ok bash (build from original source): ok bash (from msys2 package): ng Only bash in msys2 package fails. -- Takashi Yano -- Problem reports: https://cygwin.com/problems.html FAQ: https://cygwin.com/faq/ Documentation:https://cygwin.com/docs.html Unsubscribe info: https://cygwin.com/ml/#unsubscribe-simple
Re: mintty crashes on Windows 7
On Thu, 5 May 2022 12:33:07 +0900
Takashi Yano wrote:
> On Thu, 5 May 2022 10:59:54 +0900
> Takashi Yano wrote:
> > On Thu, 5 May 2022 10:27:24 +0900
> > Takashi Yano wrote:
> > > On Thu, 5 May 2022 10:20:45 +0900
> > > Takashi Yano wrote:
> > >
> > > > On Wed, 4 May 2022 16:27:43 +0300
> > > > Orgad Shaneh wrote:
> > > > > On Wed, May 4, 2022 at 2:16 PM Takashi Yano
> > > > > wrote:
> > > > > >
> > > > > > > Reduced the revert to this:
> > > > > > > @@ -979,16 +979,10 @@ fhandler_pty_slave::open (int flags, mode_t)
> > > > > > > code does not work as expected because it calls Win32
> > > > > > > API directly rather than cygwin read()/write(). Due to
> > > > > > > this behaviour, protection based on attach_mutex does
> > > > > > > not take effect. */
> > > > > > > get_ttyp ()->need_invisible_console = true;
> > > > > > > - else if (_major (myself->ctty) != DEV_CONS_MAJOR
> > > > > > > -&& (!get_ttyp ()->invisible_console_pid
> > > > > > > -|| !pinfo (get_ttyp ()->invisible_console_pid)))
> > > > > > > -/* Create a new invisible console for each pty to isolate
> > > > > > > - CTRL_C_EVENTs between ptys. */
> > > > > > > -get_ttyp ()->need_invisible_console = true;
> > > > > > >else
> > > > > > > {
> > > > > > >acquire_attach_mutex (mutex_timeout);
> > > > > > >fhandler_console::need_invisible ();
> > > > > > >release_attach_mutex ();
> > > > > >
> > > > > > A few things about this.
> > > > > >
> > > > > > 1) bash exits with exit code 127 for 'mintty bash'
> > > > > > 2) 'mintty bash' does not work, but 'mintty ash' and 'mintty tcsh'
> > > > > > work.
> > > > >
> > > > > Right. mintty dash also works.
> > > > >
> > > > > Notice that I did *not* set enable_pcon (not supported on Win7
> > > > > anyway).
> > > >
> > > > Even without that commit (and also with msys2 3.3.4 release),
> > > > something wrong with msys2 in Windows 7.
> > > >
> > > > If you run script command (/usr/bin/script), bash crashes in
> > > > similar way. typescript file generated by script command is
> > > > as follows.
> > > >
> > > > Script started on 2022-05-05 10:12:28+09:00 [TERM="cygwin"
> > > > TTY="/dev/cons0" COLUMNS="80" LINES="25"]
> > > >
> > > > Script done on 2022-05-05 10:12:29+09:00 [COMMAND_EXIT_CODE="127"]
> > > >
> > > > bash also exited with exit code 127.
> > >
> > > Ah, this only occurs if script command is started in console.
> >
> > And also this is caused by:
> > get_ttyp ()->need_invisible_console = true;
> > at another place.
>
> I found that bash crashes at:
> h = GetProcessWindowStation ();
> in fhandler_console::need_invisible().
I downloaded bash source files from:
https://git.savannah.gnu.org/git/bash.git
and built it by:
./configure && make
and replaced /usr/bin/bash.
Then the issue disappeared.
Now, I start to suspect the issue is a bug of msys2 bash package.
--
Takashi Yano
--
Problem reports: https://cygwin.com/problems.html
FAQ: https://cygwin.com/faq/
Documentation:https://cygwin.com/docs.html
Unsubscribe info: https://cygwin.com/ml/#unsubscribe-simple
Re: mintty crashes on Windows 7
On Thu, 5 May 2022 10:59:54 +0900
Takashi Yano wrote:
> On Thu, 5 May 2022 10:27:24 +0900
> Takashi Yano wrote:
> > On Thu, 5 May 2022 10:20:45 +0900
> > Takashi Yano wrote:
> >
> > > On Wed, 4 May 2022 16:27:43 +0300
> > > Orgad Shaneh wrote:
> > > > On Wed, May 4, 2022 at 2:16 PM Takashi Yano
> > > > wrote:
> > > > >
> > > > > > Reduced the revert to this:
> > > > > > @@ -979,16 +979,10 @@ fhandler_pty_slave::open (int flags, mode_t)
> > > > > > code does not work as expected because it calls Win32
> > > > > > API directly rather than cygwin read()/write(). Due to
> > > > > > this behaviour, protection based on attach_mutex does
> > > > > > not take effect. */
> > > > > > get_ttyp ()->need_invisible_console = true;
> > > > > > - else if (_major (myself->ctty) != DEV_CONS_MAJOR
> > > > > > -&& (!get_ttyp ()->invisible_console_pid
> > > > > > -|| !pinfo (get_ttyp ()->invisible_console_pid)))
> > > > > > -/* Create a new invisible console for each pty to isolate
> > > > > > - CTRL_C_EVENTs between ptys. */
> > > > > > -get_ttyp ()->need_invisible_console = true;
> > > > > >else
> > > > > > {
> > > > > >acquire_attach_mutex (mutex_timeout);
> > > > > >fhandler_console::need_invisible ();
> > > > > >release_attach_mutex ();
> > > > >
> > > > > A few things about this.
> > > > >
> > > > > 1) bash exits with exit code 127 for 'mintty bash'
> > > > > 2) 'mintty bash' does not work, but 'mintty ash' and 'mintty tcsh'
> > > > > work.
> > > >
> > > > Right. mintty dash also works.
> > > >
> > > > Notice that I did *not* set enable_pcon (not supported on Win7 anyway).
> > >
> > > Even without that commit (and also with msys2 3.3.4 release),
> > > something wrong with msys2 in Windows 7.
> > >
> > > If you run script command (/usr/bin/script), bash crashes in
> > > similar way. typescript file generated by script command is
> > > as follows.
> > >
> > > Script started on 2022-05-05 10:12:28+09:00 [TERM="cygwin"
> > > TTY="/dev/cons0" COLUMNS="80" LINES="25"]
> > >
> > > Script done on 2022-05-05 10:12:29+09:00 [COMMAND_EXIT_CODE="127"]
> > >
> > > bash also exited with exit code 127.
> >
> > Ah, this only occurs if script command is started in console.
>
> And also this is caused by:
> get_ttyp ()->need_invisible_console = true;
> at another place.
I found that bash crashes at:
h = GetProcessWindowStation ();
in fhandler_console::need_invisible().
--
Takashi Yano
--
Problem reports: https://cygwin.com/problems.html
FAQ: https://cygwin.com/faq/
Documentation:https://cygwin.com/docs.html
Unsubscribe info: https://cygwin.com/ml/#unsubscribe-simple
Re: mintty crashes on Windows 7
On Thu, 5 May 2022 10:27:24 +0900
Takashi Yano wrote:
> On Thu, 5 May 2022 10:20:45 +0900
> Takashi Yano wrote:
>
> > On Wed, 4 May 2022 16:27:43 +0300
> > Orgad Shaneh wrote:
> > > On Wed, May 4, 2022 at 2:16 PM Takashi Yano
> > > wrote:
> > > >
> > > > > Reduced the revert to this:
> > > > > @@ -979,16 +979,10 @@ fhandler_pty_slave::open (int flags, mode_t)
> > > > > code does not work as expected because it calls Win32
> > > > > API directly rather than cygwin read()/write(). Due to
> > > > > this behaviour, protection based on attach_mutex does
> > > > > not take effect. */
> > > > > get_ttyp ()->need_invisible_console = true;
> > > > > - else if (_major (myself->ctty) != DEV_CONS_MAJOR
> > > > > -&& (!get_ttyp ()->invisible_console_pid
> > > > > -|| !pinfo (get_ttyp ()->invisible_console_pid)))
> > > > > -/* Create a new invisible console for each pty to isolate
> > > > > - CTRL_C_EVENTs between ptys. */
> > > > > -get_ttyp ()->need_invisible_console = true;
> > > > >else
> > > > > {
> > > > >acquire_attach_mutex (mutex_timeout);
> > > > >fhandler_console::need_invisible ();
> > > > >release_attach_mutex ();
> > > >
> > > > A few things about this.
> > > >
> > > > 1) bash exits with exit code 127 for 'mintty bash'
> > > > 2) 'mintty bash' does not work, but 'mintty ash' and 'mintty tcsh' work.
> > >
> > > Right. mintty dash also works.
> > >
> > > Notice that I did *not* set enable_pcon (not supported on Win7 anyway).
> >
> > Even without that commit (and also with msys2 3.3.4 release),
> > something wrong with msys2 in Windows 7.
> >
> > If you run script command (/usr/bin/script), bash crashes in
> > similar way. typescript file generated by script command is
> > as follows.
> >
> > Script started on 2022-05-05 10:12:28+09:00 [TERM="cygwin" TTY="/dev/cons0"
> > COLUMNS="80" LINES="25"]
> >
> > Script done on 2022-05-05 10:12:29+09:00 [COMMAND_EXIT_CODE="127"]
> >
> > bash also exited with exit code 127.
>
> Ah, this only occurs if script command is started in console.
And also this is caused by:
get_ttyp ()->need_invisible_console = true;
at another place.
--
Takashi Yano
--
Problem reports: https://cygwin.com/problems.html
FAQ: https://cygwin.com/faq/
Documentation:https://cygwin.com/docs.html
Unsubscribe info: https://cygwin.com/ml/#unsubscribe-simple
Re: mintty crashes on Windows 7
On Thu, 5 May 2022 10:20:45 +0900
Takashi Yano wrote:
> On Wed, 4 May 2022 16:27:43 +0300
> Orgad Shaneh wrote:
> > On Wed, May 4, 2022 at 2:16 PM Takashi Yano
> > wrote:
> > >
> > > > Reduced the revert to this:
> > > > @@ -979,16 +979,10 @@ fhandler_pty_slave::open (int flags, mode_t)
> > > > code does not work as expected because it calls Win32
> > > > API directly rather than cygwin read()/write(). Due to
> > > > this behaviour, protection based on attach_mutex does
> > > > not take effect. */
> > > > get_ttyp ()->need_invisible_console = true;
> > > > - else if (_major (myself->ctty) != DEV_CONS_MAJOR
> > > > -&& (!get_ttyp ()->invisible_console_pid
> > > > -|| !pinfo (get_ttyp ()->invisible_console_pid)))
> > > > -/* Create a new invisible console for each pty to isolate
> > > > - CTRL_C_EVENTs between ptys. */
> > > > -get_ttyp ()->need_invisible_console = true;
> > > >else
> > > > {
> > > >acquire_attach_mutex (mutex_timeout);
> > > >fhandler_console::need_invisible ();
> > > >release_attach_mutex ();
> > >
> > > A few things about this.
> > >
> > > 1) bash exits with exit code 127 for 'mintty bash'
> > > 2) 'mintty bash' does not work, but 'mintty ash' and 'mintty tcsh' work.
> >
> > Right. mintty dash also works.
> >
> > Notice that I did *not* set enable_pcon (not supported on Win7 anyway).
>
> Even without that commit (and also with msys2 3.3.4 release),
> something wrong with msys2 in Windows 7.
>
> If you run script command (/usr/bin/script), bash crashes in
> similar way. typescript file generated by script command is
> as follows.
>
> Script started on 2022-05-05 10:12:28+09:00 [TERM="cygwin" TTY="/dev/cons0"
> COLUMNS="80" LINES="25"]
>
> Script done on 2022-05-05 10:12:29+09:00 [COMMAND_EXIT_CODE="127"]
>
> bash also exited with exit code 127.
Ah, this only occurs if script command is started in console.
--
Takashi Yano
--
Problem reports: https://cygwin.com/problems.html
FAQ: https://cygwin.com/faq/
Documentation:https://cygwin.com/docs.html
Unsubscribe info: https://cygwin.com/ml/#unsubscribe-simple
Re: mintty crashes on Windows 7
On Wed, 4 May 2022 16:27:43 +0300
Orgad Shaneh wrote:
> On Wed, May 4, 2022 at 2:16 PM Takashi Yano wrote:
> >
> > > Reduced the revert to this:
> > > @@ -979,16 +979,10 @@ fhandler_pty_slave::open (int flags, mode_t)
> > > code does not work as expected because it calls Win32
> > > API directly rather than cygwin read()/write(). Due to
> > > this behaviour, protection based on attach_mutex does
> > > not take effect. */
> > > get_ttyp ()->need_invisible_console = true;
> > > - else if (_major (myself->ctty) != DEV_CONS_MAJOR
> > > -&& (!get_ttyp ()->invisible_console_pid
> > > -|| !pinfo (get_ttyp ()->invisible_console_pid)))
> > > -/* Create a new invisible console for each pty to isolate
> > > - CTRL_C_EVENTs between ptys. */
> > > -get_ttyp ()->need_invisible_console = true;
> > >else
> > > {
> > >acquire_attach_mutex (mutex_timeout);
> > >fhandler_console::need_invisible ();
> > >release_attach_mutex ();
> >
> > A few things about this.
> >
> > 1) bash exits with exit code 127 for 'mintty bash'
> > 2) 'mintty bash' does not work, but 'mintty ash' and 'mintty tcsh' work.
>
> Right. mintty dash also works.
>
> Notice that I did *not* set enable_pcon (not supported on Win7 anyway).
Even without that commit (and also with msys2 3.3.4 release),
something wrong with msys2 in Windows 7.
If you run script command (/usr/bin/script), bash crashes in
similar way. typescript file generated by script command is
as follows.
Script started on 2022-05-05 10:12:28+09:00 [TERM="cygwin" TTY="/dev/cons0"
COLUMNS="80" LINES="25"]
Script done on 2022-05-05 10:12:29+09:00 [COMMAND_EXIT_CODE="127"]
bash also exited with exit code 127.
--
Takashi Yano
--
Problem reports: https://cygwin.com/problems.html
FAQ: https://cygwin.com/faq/
Documentation:https://cygwin.com/docs.html
Unsubscribe info: https://cygwin.com/ml/#unsubscribe-simple
[ANNOUNCEMENT] xpdf 4.04-1
The following package has been uploaded to the Cygwin distribution: * xpdf-4.03-1 Xpdf is an open source viewer for Portable Document Format (PDF) files. (These are also sometimes called 'Acrobat' files, from the name of Adobe's PDF software.) The Xpdf viewer uses the Qt cross-platform GUI toolkit. The Xpdf project also includes a PDF text extractor, PDF-to-PostScript converter, and various other utilities. These are not included in the Cygwin xpdf package because poppler provides similar utilities. This is an update to the latest upstream release. It is primarily a bugfix release, but there are also a few new features. See https://forum.xpdfreader.com/viewtopic.php?f=1&t=42260 for more details. Ken Brown Cygwin's Xpdf maintainer -- Problem reports: https://cygwin.com/problems.html FAQ: https://cygwin.com/faq/ Documentation:https://cygwin.com/docs.html Unsubscribe info: https://cygwin.com/ml/#unsubscribe-simple
RE: [cygwin] Re: mintty phantom key presses
> -Original Message- > From: Eric Adams > Sent: Wednesday, May 4, 2022 1:58 PM > > On Tue, May 3, 2022 at 9:27 AM Jason Pyeron wrote: > > > > Does it happen on a fresh install (you can use another directory). I am > > interested because I have > observed similar, but different, control code weirdness. > > > > v/r, > > Jason > > > > Jason, > I think I installed a fresh minimalist copy at C:\cygwin64TEST, went > into the bin directory and invoked mintty. > Within the new mintty, I started vi, and performed the vi insertion > test. I did not find escape characters inserted. Glad to hear there is a configuration that does not cause a problem. > > I would try to note differences from my typical environment - a new > binary directory / mintty invoked from the bin directory I usually copy the cygterm shortcut and update for the new root path and name - I am lazy. > / running > bash instead of tcsh / I think the home directory was the same / not > all startup files were found or used / I felt very strange in this > setup :) . Start looking at input rc related things? Try to make the new match the old... testing along the way. diff -urw is your friend. -Jason -- Jason Pyeron | Architect PD Inc| Certified SBA 8(a) 10 w 24th St | Certified SBA HUBZone Baltimore, MD | CAGE Code: 1WVR6 .mil: jason.j.pyeron@mail.mil .com: jpye...@pdinc.us tel : 202-741-9397 -- Problem reports: https://cygwin.com/problems.html FAQ: https://cygwin.com/faq/ Documentation:https://cygwin.com/docs.html Unsubscribe info: https://cygwin.com/ml/#unsubscribe-simple
[ANNOUNCEMENT] freetype2 2.12.1-1
The following packages have been uploaded to the Cygwin distribution: * freetype2-demos-2.12.1-1 * libfreetype6-2.12.1-1 * libfreetype-devel-2.12.1-1 * libfreetype-doc-2.12.1-1 FreeType 2 is a software font engine that is designed to be small, efficient, and highly customizable while capable of producing high-quality output (glyph images). This is an update to the latest upstream release. Ken Brown Cygwin's FreeType2 maintainer -- Problem reports: https://cygwin.com/problems.html FAQ: https://cygwin.com/faq/ Documentation:https://cygwin.com/docs.html Unsubscribe info: https://cygwin.com/ml/#unsubscribe-simple
Re: [cygwin] Re: mintty phantom key presses
On Tue, May 3, 2022 at 9:27 AM Jason Pyeron wrote: > > Does it happen on a fresh install (you can use another directory). I am > interested because I have observed similar, but different, control code > weirdness. > > v/r, > Jason > Jason, I think I installed a fresh minimalist copy at C:\cygwin64TEST, went into the bin directory and invoked mintty. Within the new mintty, I started vi, and performed the vi insertion test. I did not find escape characters inserted. I would try to note differences from my typical environment - a new binary directory / mintty invoked from the bin directory / running bash instead of tcsh / I think the home directory was the same / not all startup files were found or used / I felt very strange in this setup :) . Eric Adams. -- Problem reports: https://cygwin.com/problems.html FAQ: https://cygwin.com/faq/ Documentation:https://cygwin.com/docs.html Unsubscribe info: https://cygwin.com/ml/#unsubscribe-simple
Re: cygdll 3.3.4 breaks cygpath.exe. mistyped commands result in fork bomb
The fork() bomb is still a problem with 3.3.4 but it's "benign" under <=3.2.0
because a Ctrl-C reaps the call stack. Something changed significantly between
how processes are spawned apparently.
But the CAUSE of the fork() bomb was the combined use of CYGWIN_NOWINPATH=1 and
this fragment in my .bashrc
function command_not_found_handle() { cmd.exe /D /C "$@"; }
It now reads:[ -z "${CYGWIN_NOWINPATH+X}" ] && is_exec cmd.exe && function
command_not_found_handle() { cmd.exe /D /C "$@"; }
On Friday, April 29, 2022, 09:20:14 PM EDT, matthew patton
wrote:
> Can you try the suggestions I made in my reply
>https://cygwin.com/pipermail/cygwin/2022-February/250790.html ?
sorry, no. Even though I have Admin I am unable to override this. Please note
that all previous versions of cygwin1.dll (<3.3.3) are not interfered with.
Though if this is indeed Sentinel, it does seem to *sporadically* kill threads
launched under strace regardless of cygwin DLL version all the way back to
3.1.7.
--
Problem reports: https://cygwin.com/problems.html
FAQ: https://cygwin.com/faq/
Documentation:https://cygwin.com/docs.html
Unsubscribe info: https://cygwin.com/ml/#unsubscribe-simple
Re: [ANNOUNCEMENT] harfbuzz 4.2.0-1 (TEST)
On 4/11/2022 4:13 PM, Ken Brown via Cygwin-announce wrote: The following packages have been uploaded to the Cygwin distribution as test releases: * harfbuzz-4.2.0-1 * libharfbuzz0-4.2.0-1 * libharfbuzz-devel-4.2.0-1 * libharfbuzz-gobject0-4.2.0-1 * libharfbuzz-gobject-devel-4.2.0-1 * libharfbuzz-subset0-4.2.0-1 * libharfbuzz-subset-devel-4.2.0-1 * libharfbuzz-icu0-4.2.0-1 * libharfbuzz-icu-devel-4.2.0-1 * girepository-HarfBuzz0.0-4.2.0-1 This has now been promoted from test to current. Ken -- Problem reports: https://cygwin.com/problems.html FAQ: https://cygwin.com/faq/ Documentation:https://cygwin.com/docs.html Unsubscribe info: https://cygwin.com/ml/#unsubscribe-simple
Re: mintty crashes on Windows 7
On Wed, May 4, 2022 at 2:16 PM Takashi Yano wrote:
>
> > Reduced the revert to this:
> > @@ -979,16 +979,10 @@ fhandler_pty_slave::open (int flags, mode_t)
> > code does not work as expected because it calls Win32
> > API directly rather than cygwin read()/write(). Due to
> > this behaviour, protection based on attach_mutex does
> > not take effect. */
> > get_ttyp ()->need_invisible_console = true;
> > - else if (_major (myself->ctty) != DEV_CONS_MAJOR
> > -&& (!get_ttyp ()->invisible_console_pid
> > -|| !pinfo (get_ttyp ()->invisible_console_pid)))
> > -/* Create a new invisible console for each pty to isolate
> > - CTRL_C_EVENTs between ptys. */
> > -get_ttyp ()->need_invisible_console = true;
> >else
> > {
> >acquire_attach_mutex (mutex_timeout);
> >fhandler_console::need_invisible ();
> >release_attach_mutex ();
>
> A few things about this.
>
> 1) bash exits with exit code 127 for 'mintty bash'
> 2) 'mintty bash' does not work, but 'mintty ash' and 'mintty tcsh' work.
Right. mintty dash also works.
Notice that I did *not* set enable_pcon (not supported on Win7 anyway).
- Orgad
--
Problem reports: https://cygwin.com/problems.html
FAQ: https://cygwin.com/faq/
Documentation:https://cygwin.com/docs.html
Unsubscribe info: https://cygwin.com/ml/#unsubscribe-simple
Re: Typos in FAQ - where to submit a pull request?
On 04/05/2022 11:43, Hamish McIntyre-Bhatty wrote: A little while back, I noticed some typos in the Cygwin FAQ, but I'm not sure where the source is or where to submit a pull request. Can anyone give me some guidance? The docbook source for the FAQ is in the cygwin repo, see: https://cygwin.com/git/?p=newlib-cygwin.git;a=tree;f=winsup/doc So send patches to cygwin-patches list, as directed in https://cygwin.com/contrib.html -- Problem reports: https://cygwin.com/problems.html FAQ: https://cygwin.com/faq/ Documentation:https://cygwin.com/docs.html Unsubscribe info: https://cygwin.com/ml/#unsubscribe-simple
Re: mintty crashes on Windows 7
On Wed, 4 May 2022 12:46:28 +0300
Orgad Shaneh wrote:
> On Wed, May 4, 2022 at 12:33 PM Orgad Shaneh wrote:
> >
> > On Tue, May 3, 2022 at 7:10 PM Takashi Yano
> > wrote:
> > >
> > > On Tue, 3 May 2022 18:52:28 +0300
> > > Orgad Shaneh wrote:
> > > > On Tue, May 3, 2022 at 6:23 PM Takashi Yano
> > > > wrote:
> > > > >
> > > > > On Tue, 3 May 2022 14:47:17 +0300
> > > > > Orgad Shaneh wrote:
> > > > > > Hi,
> > > > > >
> > > > > > Running `mintty ./bash` crashes on Windows 7 on cygwin-3_3-branch.
> > > > > >
> > > > > > Tested in MSYS2 on merge-3.3 branch from
> > > > > > https://github.com/orgads/msys2-runtime-1. It includes the tip of
> > > > > > cygwin-3_3-branch as of today (05827d2df8).
> > > > > >
> > > > > I cannot reproduce this with cygwin git head of cygwin-3_3-branch.
> > > > > Is this MSYS2 specific problem?
> > > >
> > > > You're right. I can't reproduce either. Only in my MSYS branch.
> > > >
> > > > Can you give me some guidance how to debug it?
> > >
> > > If you could identify which commit causes the issue, It would help.
> >
> > 0e1847fb87f5306cda6c022540560c5926627ae1 is the first bad commit
> > commit 0e1847fb87f5306cda6c022540560c5926627ae1
> > Author: Takashi Yano
> > Date: Mon Feb 28 20:25:09 2022 +0900
> >
> > Cygwin: pty: Isolate CTRL_C_EVENTs between ptys.
> >
> > - With this patch, unique invisible consoles are created for each pty
> > to isolate CTRL_C_EVENTs between ptys. This is necessary by Ctrl-C
> > handling in fhandler_termios::process_sigs() for non-cygwin apps
> > started in pty if the pseudo console is disabled.
> >
> > winsup/cygwin/fhandler_termios.cc | 6 ++
> > winsup/cygwin/fhandler_tty.cc | 17 +
> > winsup/cygwin/tty.cc | 2 ++
> > 3 files changed, 21 insertions(+), 4 deletions(-)
> >
> > I tried reverting this commit, and it fixed the crash indeed.
> >
> > - Orgad
>
> Reduced the revert to this:
> @@ -979,16 +979,10 @@ fhandler_pty_slave::open (int flags, mode_t)
> code does not work as expected because it calls Win32
> API directly rather than cygwin read()/write(). Due to
> this behaviour, protection based on attach_mutex does
> not take effect. */
> get_ttyp ()->need_invisible_console = true;
> - else if (_major (myself->ctty) != DEV_CONS_MAJOR
> -&& (!get_ttyp ()->invisible_console_pid
> -|| !pinfo (get_ttyp ()->invisible_console_pid)))
> -/* Create a new invisible console for each pty to isolate
> - CTRL_C_EVENTs between ptys. */
> -get_ttyp ()->need_invisible_console = true;
>else
> {
>acquire_attach_mutex (mutex_timeout);
>fhandler_console::need_invisible ();
>release_attach_mutex ();
A few things about this.
1) bash exits with exit code 127 for 'mintty bash'
2) 'mintty bash' does not work, but 'mintty ash' and 'mintty tcsh' work.
--
Takashi Yano
--
Problem reports: https://cygwin.com/problems.html
FAQ: https://cygwin.com/faq/
Documentation:https://cygwin.com/docs.html
Unsubscribe info: https://cygwin.com/ml/#unsubscribe-simple
Typos in FAQ - where to submit a pull request?
A little while back, I noticed some typos in the Cygwin FAQ, but I'm not sure where the source is or where to submit a pull request. Can anyone give me some guidance? Thanks, Hamish -- Problem reports: https://cygwin.com/problems.html FAQ: https://cygwin.com/faq/ Documentation:https://cygwin.com/docs.html Unsubscribe info: https://cygwin.com/ml/#unsubscribe-simple
Re: mintty crashes on Windows 7
On Wed, May 4, 2022 at 12:33 PM Orgad Shaneh wrote:
>
> On Tue, May 3, 2022 at 7:10 PM Takashi Yano wrote:
> >
> > On Tue, 3 May 2022 18:52:28 +0300
> > Orgad Shaneh wrote:
> > > On Tue, May 3, 2022 at 6:23 PM Takashi Yano
> > > wrote:
> > > >
> > > > On Tue, 3 May 2022 14:47:17 +0300
> > > > Orgad Shaneh wrote:
> > > > > Hi,
> > > > >
> > > > > Running `mintty ./bash` crashes on Windows 7 on cygwin-3_3-branch.
> > > > >
> > > > > Tested in MSYS2 on merge-3.3 branch from
> > > > > https://github.com/orgads/msys2-runtime-1. It includes the tip of
> > > > > cygwin-3_3-branch as of today (05827d2df8).
> > > > >
> > > > I cannot reproduce this with cygwin git head of cygwin-3_3-branch.
> > > > Is this MSYS2 specific problem?
> > >
> > > You're right. I can't reproduce either. Only in my MSYS branch.
> > >
> > > Can you give me some guidance how to debug it?
> >
> > If you could identify which commit causes the issue, It would help.
>
> 0e1847fb87f5306cda6c022540560c5926627ae1 is the first bad commit
> commit 0e1847fb87f5306cda6c022540560c5926627ae1
> Author: Takashi Yano
> Date: Mon Feb 28 20:25:09 2022 +0900
>
> Cygwin: pty: Isolate CTRL_C_EVENTs between ptys.
>
> - With this patch, unique invisible consoles are created for each pty
> to isolate CTRL_C_EVENTs between ptys. This is necessary by Ctrl-C
> handling in fhandler_termios::process_sigs() for non-cygwin apps
> started in pty if the pseudo console is disabled.
>
> winsup/cygwin/fhandler_termios.cc | 6 ++
> winsup/cygwin/fhandler_tty.cc | 17 +
> winsup/cygwin/tty.cc | 2 ++
> 3 files changed, 21 insertions(+), 4 deletions(-)
>
> I tried reverting this commit, and it fixed the crash indeed.
>
> - Orgad
Reduced the revert to this:
@@ -979,16 +979,10 @@ fhandler_pty_slave::open (int flags, mode_t)
code does not work as expected because it calls Win32
API directly rather than cygwin read()/write(). Due to
this behaviour, protection based on attach_mutex does
not take effect. */
get_ttyp ()->need_invisible_console = true;
- else if (_major (myself->ctty) != DEV_CONS_MAJOR
-&& (!get_ttyp ()->invisible_console_pid
-|| !pinfo (get_ttyp ()->invisible_console_pid)))
-/* Create a new invisible console for each pty to isolate
- CTRL_C_EVENTs between ptys. */
-get_ttyp ()->need_invisible_console = true;
else
{
acquire_attach_mutex (mutex_timeout);
fhandler_console::need_invisible ();
release_attach_mutex ();
- Orgad
--
Problem reports: https://cygwin.com/problems.html
FAQ: https://cygwin.com/faq/
Documentation:https://cygwin.com/docs.html
Unsubscribe info: https://cygwin.com/ml/#unsubscribe-simple
Re: mintty crashes on Windows 7
On Tue, May 3, 2022 at 7:10 PM Takashi Yano wrote: > > On Tue, 3 May 2022 18:52:28 +0300 > Orgad Shaneh wrote: > > On Tue, May 3, 2022 at 6:23 PM Takashi Yano > > wrote: > > > > > > On Tue, 3 May 2022 14:47:17 +0300 > > > Orgad Shaneh wrote: > > > > Hi, > > > > > > > > Running `mintty ./bash` crashes on Windows 7 on cygwin-3_3-branch. > > > > > > > > Tested in MSYS2 on merge-3.3 branch from > > > > https://github.com/orgads/msys2-runtime-1. It includes the tip of > > > > cygwin-3_3-branch as of today (05827d2df8). > > > > > > > I cannot reproduce this with cygwin git head of cygwin-3_3-branch. > > > Is this MSYS2 specific problem? > > > > You're right. I can't reproduce either. Only in my MSYS branch. > > > > Can you give me some guidance how to debug it? > > If you could identify which commit causes the issue, It would help. 0e1847fb87f5306cda6c022540560c5926627ae1 is the first bad commit commit 0e1847fb87f5306cda6c022540560c5926627ae1 Author: Takashi Yano Date: Mon Feb 28 20:25:09 2022 +0900 Cygwin: pty: Isolate CTRL_C_EVENTs between ptys. - With this patch, unique invisible consoles are created for each pty to isolate CTRL_C_EVENTs between ptys. This is necessary by Ctrl-C handling in fhandler_termios::process_sigs() for non-cygwin apps started in pty if the pseudo console is disabled. winsup/cygwin/fhandler_termios.cc | 6 ++ winsup/cygwin/fhandler_tty.cc | 17 + winsup/cygwin/tty.cc | 2 ++ 3 files changed, 21 insertions(+), 4 deletions(-) I tried reverting this commit, and it fixed the crash indeed. - Orgad -- Problem reports: https://cygwin.com/problems.html FAQ: https://cygwin.com/faq/ Documentation:https://cygwin.com/docs.html Unsubscribe info: https://cygwin.com/ml/#unsubscribe-simple
