RE: PERL 5.8.0-2 and Haase_Gerrit/1.3/perl/Tk800.023-1.patch - taking this to Tk800.024

2003-04-05 Thread Alan Miles 
Igor,

I am using MS Outlook 2000 - Gerrit's email was:
[EMAIL PROTECTED]

when I checked the "properties" of this email I got:

[EMAIL PROTECTED]

Thus I am guessing I inadvertently sent "duplicate" messages to the group -
my apologies for that.

Alan

-Original Message-
From: Igor Pechtchanski [mailto:[EMAIL PROTECTED]
Sent: April 5, 2003 10:41
To: [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]
Subject: RE: PERL 5.8.0-2 and Haase_Gerrit/1.3/perl/Tk800.023-1.patch -
taking this to Tk800.024


On Sat, 5 Apr 2003, Alan Miles wrote:

> Sorry - my original reply went to Gerrit only - having read on the list
that
> it should be going to the group, I am sending this to the group ...
> [snip]

Alan,

Did you by any chance notice which return address Gerrit used? ;-)
FYI, your original reply is here:
<http://cygwin.com/ml/cygwin/2003-04/msg00502.html>
Igor
--
http://cs.nyu.edu/~pechtcha/
  |\  _,,,---,,_[EMAIL PROTECTED]
ZZZzz /,`.-'`'-.  ;-;;,_[EMAIL PROTECTED]
 |,4-  ) )-,_. ,\ (  `'-'   Igor Pechtchanski
'---''(_/--'  `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

Knowledge is an unending adventure at the edge of uncertainty.
  -- Leto II




--
Unsubscribe info:  http://cygwin.com/ml/#unsubscribe-simple
Bug reporting: http://cygwin.com/bugs.html
Documentation: http://cygwin.com/docs.html
FAQ:   http://cygwin.com/faq/

RE: PERL 5.8.0-2 and Haase_Gerrit/1.3/perl/Tk800.023-1.patch - taking this to Tk800.024

2003-04-05 Thread Igor Pechtchanski 
On Sat, 5 Apr 2003, Alan Miles wrote:

> Sorry - my original reply went to Gerrit only - having read on the list that
> it should be going to the group, I am sending this to the group ...
> [snip]

Alan,

Did you by any chance notice which return address Gerrit used? ;-)
FYI, your original reply is here:

Igor
-- 
http://cs.nyu.edu/~pechtcha/
  |\  _,,,---,,_[EMAIL PROTECTED]
ZZZzz /,`.-'`'-.  ;-;;,_[EMAIL PROTECTED]
 |,4-  ) )-,_. ,\ (  `'-'   Igor Pechtchanski
'---''(_/--'  `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

Knowledge is an unending adventure at the edge of uncertainty.
  -- Leto II


--
Unsubscribe info:  http://cygwin.com/ml/#unsubscribe-simple
Bug reporting: http://cygwin.com/bugs.html
Documentation: http://cygwin.com/docs.html
FAQ:   http://cygwin.com/faq/

RE: PERL 5.8.0-2 and Haase_Gerrit/1.3/perl/Tk800.023-1.patch - taking this to Tk800.024

2003-04-05 Thread Alan Miles 
Sorry - my original reply went to Gerrit only - having read on the list that
it should be going to the group, I am sending this to the group ...

Gerrit,

Thanks for the email.

I have been using CYGWIN for about 3/4 years now, both at home and at work,
and I needed to get this item to work using cygwin perl. Now it does.

>> It was reported that Tk800.024 builds without patching it or with
>> minimal tweaks like the one you need to apply to get it compiled
>> after updating 023 w/ patch to 024.

The libraries compile (except for the warning below), but one of the test
programs failed to link due to the undefined reference to
`_win32_get_osfhandle' issue in Tk800.024-1/Event/Event.xs. I found the
answer on how to fix that in
http://sources.redhat.com/ml/cygwin/2002-09/msg00752.html.

To build I execute the command "perl Makefile.PL && make && make test &&
make install". Hence my reason for "patching" the source.

My purpose in sending the email was to ensure that nobody else had to
"re-invent the wheel". Maybe you could try this patch out, and then release
it for the cygwin community.

Since emailing the group, I have fixed the below problem:

/usr/include/limits.h:143:1: warning: this is the location of the previous
definition
gcc -c  -I.. -I../pTk/mTk/xlib -I. -Ibitmaps -I../pTk/mTk/xlib -DPERL_USE_SA
FE_PUTENV -fno-strict-aliasing -DUSEIMPORTLIB -O2   -DVERSION=\"800.024\" -D
XS_VERSION=\"800.024\"
"-I/usr/lib/perl5/5.8.0/cygwin-multi-64int/CORE"  -D__WIN32__ -D_WIN32 -DWIN
32 -Wall -Wno-implicit-int -Wno-comment -Wno-unused -D__USE_FIXED_PROTOTYPES
__ imgGIF.c
In file included from tkPort.h:28,
 from tk.h:71,
 from imgGIF.c:35:
tkWinPort.h:54:1: warning: "OPEN_MAX" redefined
In file included from
/usr/lib/gcc-lib/i686-pc-cygwin/3.2/include/limits.h:132,
 from
/usr/lib/gcc-lib/i686-pc-cygwin/3.2/include/syslimits.h:7,
 from
/usr/lib/gcc-lib/i686-pc-cygwin/3.2/include/limits.h:11,
 from tkWinPort.h:31,
 from tkPort.h:28,
 from tk.h:71,
 from imgGIF.c:35:

Hence my current (complete) patch is (which is largely based on your
original patch):


diff -r -u Tk800.024/Event/Event.xs Tk800.024-1/Event/Event.xs
--- Tk800.024/Event/Event.xs2002-01-07 03:35:44.0 -0600
+++ Tk800.024-1/Event/Event.xs  2003-04-04 13:49:42.0 -0600
@@ -4,6 +4,17 @@
   modify it under the same terms as Perl itself.
 */

+/*
+ * Fix required to fix: undefined reference to `_win32_get_osfhandle' issue
as directed in:
+ *
+ * http://sources.redhat.com/ml/cygwin/2002-09/msg00752.html
+ *
+ */
+#ifdef __CYGWIN__
+# define win32_get_osfhandle _get_osfhandle
+# define win32_open_osfhandle _open_osfhandle
+#endif
+
 #include 
 #include 
 #include 
diff -r -u Tk800.024/Makefile.PL Tk800.024-1/Makefile.PL
--- Tk800.024/Makefile.PL   2002-03-05 08:00:43.0 -0600
+++ Tk800.024-1/Makefile.PL 2003-04-04 13:49:42.0 -0600
@@ -154,7 +154,7 @@
 }

 sub MY::postamble {
-'
+ my $str = '

 html : subdirs manifypods
@cd pod && $(MAKE) html $(PASTHRU)
@@ -184,6 +184,8 @@
$(MAKE) manifest

 ';
+ $str =~ s/DEFINE=.*// if($^O eq 'cygwin');
+ $str;
 }


diff -r -u Tk800.024/README.cygwin Tk800.024-1/README.cygwin
--- Tk800.024/README.cygwin 2000-09-08 04:27:27.0 -0500
+++ Tk800.024-1/README.cygwin   2003-04-04 13:49:42.0 -0600
@@ -90,7 +90,7 @@
   (sometimes $^O eq 'MSWin32' is used instead of $Tk::platform
eq 'MSWin32' assuming they are equivalent and vice versa)
 + #define distinctions
-_WIN32defined by gcc, if X11 need to undef
+_WIN32win_arch MSWin32
 __WIN32__ win_arch MSWin32, also defined in pTk/Lang.h
 WIN32 from #include 
   when precedes #include "perl.h" then need
@@ -107,7 +107,7 @@
 README.cygwin MANIFEST
 * documentation

-Makefile.PL Tk/MMutil.pm pTk/Makefile.PL
+Makefile.PL Tk/MMutil.pm pTk/Makefile.PL myConfig
 * make stuff

 pTk/mTk/win/tkWinX.c
@@ -149,6 +149,6 @@
 + Fix gcc warnings, mostly in pTk win32 flavor?
 + Test with cygwin-xfree X Server?

-Thu Aug 31 12:54:09 BST 2000
+Sun Jun 10 21:34:30 PST 2001
 Eric Fifer
[EMAIL PROTECTED]
[EMAIL PROTECTED]
diff -r -u Tk800.024/Tk/MMutil.pm Tk800.024-1/Tk/MMutil.pm
--- Tk800.024/Tk/MMutil.pm  2002-03-05 08:27:40.0 -0600
+++ Tk800.024-1/Tk/MMutil.pm2003-04-04 13:49:42.0 -0600
@@ -238,13 +238,10 @@
  push(@def,qw(-D__CYGWIN__));
  if ($win_arch eq 'MSWin32')
   {
-   push(@def,qw(-D__WIN32__)) unless $self->{'DEFINE'} =~
/-D__WIN32__/;
+   push(@def,qw(-D__WIN32__ -D_WIN32))
+  unless $self->{'DEFINE'} =~ /-D__WIN32__/;
push(@def,qw(-DWIN32)) if $self->{'NAME'} eq 'Tk::pTk';
   }
- elsif ($win_arch eq 'x')
-  {
-   push(@def,qw(-U_WI

RE: PERL 5.8.0-2 and Haase_Gerrit/1.3/perl/Tk800.023-1.patch - taking this to Tk800.024

2003-04-05 Thread Alan Miles 
Gerrit,

Thanks for the email.

I have been using CYGWIN for about 3/4 years now, both at home and at work,
and I needed to get this item to work using cygwin perl. Now it does.

>> It was reported that Tk800.024 builds without patching it or with
>> minimal tweaks like the one you need to apply to get it compiled
>> after updating 023 w/ patch to 024.

The libraries compile (except for the warning below), but one of the test
programs failed to link due to the undefined reference to
`_win32_get_osfhandle' issue in Tk800.024-1/Event/Event.xs. I found the
answer on how to fix that in
http://sources.redhat.com/ml/cygwin/2002-09/msg00752.html.

To build I execute the command "perl Makefile.PL && make && make test &&
make install". Hence my reason for "patching" the source.

My purpose in sending the email was to ensure that nobody else had to
"re-invent the wheel". Maybe you could try this patch out, and then release
it for the cygwin community.

Since emailing the group, I have fixed the below problem:

/usr/include/limits.h:143:1: warning: this is the location of the previous
definition
gcc -c  -I.. -I../pTk/mTk/xlib -I. -Ibitmaps -I../pTk/mTk/xlib -DPERL_USE_SA
FE_PUTENV -fno-strict-aliasing -DUSEIMPORTLIB -O2   -DVERSION=\"800.024\" -D
XS_VERSION=\"800.024\"
"-I/usr/lib/perl5/5.8.0/cygwin-multi-64int/CORE"  -D__WIN32__ -D_WIN32 -DWIN
32 -Wall -Wno-implicit-int -Wno-comment -Wno-unused -D__USE_FIXED_PROTOTYPES
__ imgGIF.c
In file included from tkPort.h:28,
 from tk.h:71,
 from imgGIF.c:35:
tkWinPort.h:54:1: warning: "OPEN_MAX" redefined
In file included from
/usr/lib/gcc-lib/i686-pc-cygwin/3.2/include/limits.h:132,
 from
/usr/lib/gcc-lib/i686-pc-cygwin/3.2/include/syslimits.h:7,
 from
/usr/lib/gcc-lib/i686-pc-cygwin/3.2/include/limits.h:11,
 from tkWinPort.h:31,
 from tkPort.h:28,
 from tk.h:71,
 from imgGIF.c:35:

Hence my current (complete) patch is (which is largely based on your
original patch):


diff -r -u Tk800.024/Event/Event.xs Tk800.024-1/Event/Event.xs
--- Tk800.024/Event/Event.xs2002-01-07 03:35:44.0 -0600
+++ Tk800.024-1/Event/Event.xs  2003-04-04 13:49:42.0 -0600
@@ -4,6 +4,17 @@
   modify it under the same terms as Perl itself.
 */

+/*
+ * Fix required to fix: undefined reference to `_win32_get_osfhandle' issue
as directed in:
+ *
+ * http://sources.redhat.com/ml/cygwin/2002-09/msg00752.html
+ *
+ */
+#ifdef __CYGWIN__
+# define win32_get_osfhandle _get_osfhandle
+# define win32_open_osfhandle _open_osfhandle
+#endif
+
 #include 
 #include 
 #include 
diff -r -u Tk800.024/Makefile.PL Tk800.024-1/Makefile.PL
--- Tk800.024/Makefile.PL   2002-03-05 08:00:43.0 -0600
+++ Tk800.024-1/Makefile.PL 2003-04-04 13:49:42.0 -0600
@@ -154,7 +154,7 @@
 }

 sub MY::postamble {
-'
+ my $str = '

 html : subdirs manifypods
@cd pod && $(MAKE) html $(PASTHRU)
@@ -184,6 +184,8 @@
$(MAKE) manifest

 ';
+ $str =~ s/DEFINE=.*// if($^O eq 'cygwin');
+ $str;
 }


diff -r -u Tk800.024/README.cygwin Tk800.024-1/README.cygwin
--- Tk800.024/README.cygwin 2000-09-08 04:27:27.0 -0500
+++ Tk800.024-1/README.cygwin   2003-04-04 13:49:42.0 -0600
@@ -90,7 +90,7 @@
   (sometimes $^O eq 'MSWin32' is used instead of $Tk::platform
eq 'MSWin32' assuming they are equivalent and vice versa)
 + #define distinctions
-_WIN32defined by gcc, if X11 need to undef
+_WIN32win_arch MSWin32
 __WIN32__ win_arch MSWin32, also defined in pTk/Lang.h
 WIN32 from #include 
   when precedes #include "perl.h" then need
@@ -107,7 +107,7 @@
 README.cygwin MANIFEST
 * documentation

-Makefile.PL Tk/MMutil.pm pTk/Makefile.PL
+Makefile.PL Tk/MMutil.pm pTk/Makefile.PL myConfig
 * make stuff

 pTk/mTk/win/tkWinX.c
@@ -149,6 +149,6 @@
 + Fix gcc warnings, mostly in pTk win32 flavor?
 + Test with cygwin-xfree X Server?

-Thu Aug 31 12:54:09 BST 2000
+Sun Jun 10 21:34:30 PST 2001
 Eric Fifer
[EMAIL PROTECTED]
[EMAIL PROTECTED]
diff -r -u Tk800.024/Tk/MMutil.pm Tk800.024-1/Tk/MMutil.pm
--- Tk800.024/Tk/MMutil.pm  2002-03-05 08:27:40.0 -0600
+++ Tk800.024-1/Tk/MMutil.pm2003-04-04 13:49:42.0 -0600
@@ -238,13 +238,10 @@
  push(@def,qw(-D__CYGWIN__));
  if ($win_arch eq 'MSWin32')
   {
-   push(@def,qw(-D__WIN32__)) unless $self->{'DEFINE'} =~
/-D__WIN32__/;
+   push(@def,qw(-D__WIN32__ -D_WIN32))
+  unless $self->{'DEFINE'} =~ /-D__WIN32__/;
push(@def,qw(-DWIN32)) if $self->{'NAME'} eq 'Tk::pTk';
   }
- elsif ($win_arch eq 'x')
-  {
-   push(@def,qw(-U_WIN32));
-  }
 }
foreach (@inc)
 {
@@ -519,16 +516,12 @@
  push(@opt,'LD' => 'gcc -shared');
  if ($win_arch eq 'MSWin32')

Re: PERL 5.8.0-2 and Haase_Gerrit/1.3/perl/Tk800.023-1.patch - taking this to Tk800.024

2003-04-05 Thread Gerrit P. Haase 
Hallo Alan,

> The PERL package Tk800.023 is now Tk800.024 but Haase Gerrit's patch to get
> this package to work under Cygwin only works to Tk800.023.

> Since I wanted to use Tk800.024, I had to figure out how to do this.

It was reported that Tk800.024 builds without patching it or with
minimal tweaks like the one you need to apply to get it compiled
after updating 023 w/ patch to 024.


Gerrit
-- 
=^..^=


--
Unsubscribe info:  http://cygwin.com/ml/#unsubscribe-simple
Bug reporting: http://cygwin.com/bugs.html
Documentation: http://cygwin.com/docs.html
FAQ:   http://cygwin.com/faq/

PERL 5.8.0-2 and Haase_Gerrit/1.3/perl/Tk800.023-1.patch - taking this to Tk800.024

2003-04-03 Thread Alan Miles 
All,

I am running the latest cygwin dll, setup etc, with Perl 5.8.0-2 (the
latest). BTW, I am running cygwin on a Windows 2000 Professional SP2
machine.

The PERL package Tk800.023 is now Tk800.024 but Haase Gerrit's patch to get
this package to work under Cygwin only works to Tk800.023.

Since I wanted to use Tk800.024, I had to figure out how to do this.

ftp://ftp.uni-erlangen.de/pub/pc/gnuwin32/cygwin/porters/Haase_Gerrit/1.3/pe
rl/Tk800.023-1.patch
http://www.cpan.org/authors/id/NI-S/Tk800.023.tar.gz
http://www.cpan.org/authors/id/NI-S/Tk800.patch.023.024.gz

To recreate for Tk800.024 I did the following:

1/ Got the above files
2/ Un-tarred the Tk800.023.tar.gz
3/ Applied Haase Gerrit's patch
4/ Applied Tk800.patch.023.024.gz
5/ Renamed the Tk800.023 "root" directory to: Tk800.024

During the make test I got:


D_RUN_PATH="/lib/w32api:/usr/lib" gcc -shared  -s -L/usr/local/lib Event.o
pTkCallback.o tclEvent.o tclNotify.o tclPlatEvent.o tclPlatNotfy.o tclPlat
Time.o tclTimer.o tkWin32Dll.o  -o ../blib/arch/auto/Tk/Event/Event.dll
../pTk/libpTk.a /usr/lib/perl5/5.8.0/cygwin-multi-64int/CORE/libperl.dll.a
-L/
lib/w32api -lcomdlg32 -lgdi32 -lm
Event.o(.text+0x245):Event.c: undefined reference to `_win32_get_osfhandle'
collect2: ld returned 1 exit status
make[1]: *** [../blib/arch/auto/Tk/Event/Event.dll] Error 1
make[1]: Leaving directory
`/home/ammiles/Shared_Binaries/Source/Cygwin_Perl_Modules/TK/tmp/Tk800.024/E
vent'
make: *** [subdirs] Error 2

6/ To fix this:
(a) I had to chmod a+w Event/Event.xs (couldn't edit the file)
(b) Add the following in:


/*
 * Fix required to fix: undefined reference to `_win32_get_osfhandle' issue
as directed in:
 *
 * http://sources.redhat.com/ml/cygwin/2002-09/msg00752.html
 *
 */
#ifdef __CYGWIN__
# define win32_get_osfhandle _get_osfhandle
# define win32_open_osfhandle _open_osfhandle
#endif

6/ Re-ran make test. It compiles, however t/fileevent seems to be "stuck",
i.e., it is blocked - that is I think the pipe read is waiting for pipe
write and visa-versa. I go to
the window this creates and select "quit" and all other tests seem to work
fine.

I am attaching my complete perl Makefile.PL, make, make test logs.

Any ideas?

Alan Miles

some output from my log file:

In file included from tkPort.h:28,
 from Xlib_f.c:1:
tkWinPort.h:54:1: warning: "OPEN_MAX" redefined
In file included from
/usr/lib/gcc-lib/i686-pc-cygwin/3.2/include/limits.h:132,
 from
/usr/lib/gcc-lib/i686-pc-cygwin/3.2/include/syslimits.h:7,
 from
/usr/lib/gcc-lib/i686-pc-cygwin/3.2/include/limits.h:11,
 from tkWinPort.h:31,
 from tkPort.h:28,
 from Xlib_f.c:1:
/usr/include/limits.h:143:1: warning: this is the location of the previous
definition
In file included from Xlib_f.c:10:
Xlib.t:28: warning: initialization from incompatible pointer type
Xlib.t:32: warning: initialization from incompatible pointer type
Xlib.t:36: warning: initialization from incompatible pointer type
Xlib.t:40: warning: initialization from incompatible pointer type
Xlib.t:56: warning: initialization from incompatible pointer type
Xlib.t:66: warning: initialization from incompatible pointer type
Xlib.t:76: warning: initialization from incompatible pointer type
Xlib.t:80: warning: initialization from incompatible pointer type
Xlib.t:96: warning: initialization from incompatible pointer type
Xlib.t:144: warning: initialization from incompatible pointer type
Xlib.t:148: warning: initialization from incompatible pointer type
Xlib.t:158: warning: initialization from incompatible pointer type
Xlib.t:162: warning: initialization from incompatible pointer type
Xlib.t:172: warning: initialization from incompatible pointer type
Xlib.t:176: warning: initialization from incompatible pointer type
Xlib.t:180: warning: initialization from incompatible pointer type
Xlib.t:184: warning: initialization from incompatible pointer type
Xlib.t:200: warning: initialization from incompatible pointer type
Xlib.t:204: warning: initialization from incompatible pointer type
Xlib.t:208: warning: initialization from incompatible pointer type
Xlib.t:212: warning: initialization from incompatible pointer type
Xlib.t:224: warning: initialization from incompatible pointer type
Xlib.t:228: warning: initialization from incompatible pointer type
Xlib.t:232: warning: initialization from incompatible pointer type
Xlib.t:248: warning: initialization from incompatible pointer type
Xlib.t:252: warning: initialization from incompatible pointer type
Xlib.t:278: warning: initialization from incompatible pointer type
Xlib.t:378: warning: initialization from incompatible pointer type
Xlib.t:382: warning: initialization from incompatible pointer type
Xlib.t:386: warning: initialization from incompatible pointer type
Xlib.t:390: warning: initialization from incompatible pointer type
Xlib.t:394: warning: initialization from incompatible pointer type
Xlib.t:412: warning: ini