Re: Patch for shutdown
On Jun 6 14:21, Frank Fesevur wrote: > 2013/5/22 Corinna Vinschen: > > After that, checking out the project is done using > > > > $ cvs -d :ext:@sourceware.org:/cvs/cygwin-apps co shutdown > > The code is in CVS. > > Since this is my first package and it uses the CVS I have a question > about the next steps. > > If I understand things correctly, these are the steps needed: > - add tag "rel1-10" to CVS > - use cygport to generate the bin packages > - "cygport --32 shutdown.cygport download prep compile package" > - "cygport --64 shutdown.cygport download prep compile package" > - I assume these commands will also generate a src package > > >From there I follow the normal steps (ITA, RFU and announcement) as > described on http://cygwin.com/setup.html > > Did I miss anything? Looks good to me. Btw., maintainer issues are usually discussed on the cygwin-apps list. Feel free to discuss any further issue there. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Re: Patch for shutdown
2013/5/22 Corinna Vinschen: > After that, checking out the project is done using > > $ cvs -d :ext:@sourceware.org:/cvs/cygwin-apps co shutdown The code is in CVS. Since this is my first package and it uses the CVS I have a question about the next steps. If I understand things correctly, these are the steps needed: - add tag "rel1-10" to CVS - use cygport to generate the bin packages - "cygport --32 shutdown.cygport download prep compile package" - "cygport --64 shutdown.cygport download prep compile package" - I assume these commands will also generate a src package >From there I follow the normal steps (ITA, RFU and announcement) as described on http://cygwin.com/setup.html Did I miss anything? Regards, Frank -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Re: Patch for shutdown
On May 21 22:00, Frank Fesevur wrote: > 2013/5/21 Corinna Vinschen: > > Uhm... I would prefer if we had the cygwin-specific tools in a single > > repository, if it's not asked too much. I'm sure we could add git > > access as well, if it's not already available. > > I can continue to use CVS, no problem. No need to use git, just for > the sake of git ;-) > > But I guess then I'll need write access or you must still review and > commit the patches I write. Write access is easy: http://sourceware.org/cgi-bin/pdw/ps_form.cgi Use "cygwin-apps" as project, corinna at vinschen dot de as "email address of person who approved request". After that, checking out the project is done using $ cvs -d :ext:@sourceware.org:/cvs/cygwin-apps co shutdown Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Re: Patch for shutdown
2013/5/21 Corinna Vinschen: > Uhm... I would prefer if we had the cygwin-specific tools in a single > repository, if it's not asked too much. I'm sure we could add git > access as well, if it's not already available. I can continue to use CVS, no problem. No need to use git, just for the sake of git ;-) But I guess then I'll need write access or you must still review and commit the patches I write. Regards, Frank -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Re: Patch for shutdown
On May 21 17:20, Frank Fesevur wrote: > 2013/5/21 Corinna Vinschen: > > I'm a bit reluctant as of the backward compatibility breakage. What > > if somebody uses shutdown in a script? You know, starting a backup > > in the evening and the last action of the script is to hibernate the > > machine or something like that... > > That's why I sent my email in March in the first place. But I really > think having -h for halt is better for a POSIX/Linux-like shutdown. > And "shutdown -h now" will now halt the machine instead of hibernate. > Although I understand they definitely are not the same, it won't leave > the machine turned on. It will be in a "form of off". > > A proper announcement is required. The backward compatibility breakage > was the reason I thought about 2.x vs 1.x. > > > Say, do you want to take over shutdown > > maintainership? It's an easy enough package to start with, it > > builds fine on 32 and 64 bit, and you get the cygport configuration > > "for free". What do you say? > > Anything "for free" must be good ;-) > > I see the cygport file is in src archive. It has been very long since > I have played with cygport. > > And I have not looked at cygwin64, although I use Win7-64. I had no > real need for cygwin64 so far, so I wanted to wait for it to be > officially released. I just ran the setup64.exe found at a nearby > mirror, installed cygport and gcc/g++ and shutdown compiles under 32 > and 64 bit. > > So back to the question... why not take over? I will read > http://cygwin.com/setup.html thoroughly, create the new packages and > send the ITA any time soon. Cool, thanks! > You keep the sources in CVS right now. But when I take over, I assume > it is ok I put them at my github. Uhm... I would prefer if we had the cygwin-specific tools in a single repository, if it's not asked too much. I'm sure we could add git access as well, if it's not already available. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Re: Patch for shutdown
2013/5/21 Corinna Vinschen: > I'm a bit reluctant as of the backward compatibility breakage. What > if somebody uses shutdown in a script? You know, starting a backup > in the evening and the last action of the script is to hibernate the > machine or something like that... That's why I sent my email in March in the first place. But I really think having -h for halt is better for a POSIX/Linux-like shutdown. And "shutdown -h now" will now halt the machine instead of hibernate. Although I understand they definitely are not the same, it won't leave the machine turned on. It will be in a "form of off". A proper announcement is required. The backward compatibility breakage was the reason I thought about 2.x vs 1.x. > Say, do you want to take over shutdown > maintainership? It's an easy enough package to start with, it > builds fine on 32 and 64 bit, and you get the cygport configuration > "for free". What do you say? Anything "for free" must be good ;-) I see the cygport file is in src archive. It has been very long since I have played with cygport. And I have not looked at cygwin64, although I use Win7-64. I had no real need for cygwin64 so far, so I wanted to wait for it to be officially released. I just ran the setup64.exe found at a nearby mirror, installed cygport and gcc/g++ and shutdown compiles under 32 and 64 bit. So back to the question... why not take over? I will read http://cygwin.com/setup.html thoroughly, create the new packages and send the ITA any time soon. You keep the sources in CVS right now. But when I take over, I assume it is ok I put them at my github. Regards, Frank -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
RE: Patch for shutdown
Fedin Pavel sent the following at Monday, May 20, 2013 10:00 AM > And following the same logic we would need to teach our find.exe (already > mentioned on this list) to understand Windows options instead of UNIX > options... FYI, Windows find = grep c:\> find /? Searches for a text string in a file or files. FIND [/V] [/C] [/N] [/I] [/OFF[LINE]] "string" [[drive:][path]filename[ ...]] /V Displays all lines NOT containing the specified string. /C Displays only the count of lines containing the string. /N Displays line numbers with the displayed lines. /I Ignores the case of characters when searching for the string. /OFF[LINE] Do not skip files with offline attribute set. "string" Specifies the text string to find. [drive:][path]filename Specifies a file or files to search. If a path is not specified, FIND searches the text typed at the prompt or piped from another command.
Re: Patch for shutdown
On May 20 13:40, Frank Fesevur wrote: > Hi Corinna, > > Since nobody made real objections about changing the short flag for > hibernate from -h to -b to make room for -h for halt [1], I created a > patch to change the shutdown program. The patch was created back in > March, but with all your work being done on cygwin64, your holiday and > myself being very busy with life it was held back. I'm a bit reluctant as of the backward compatibility breakage. What if somebody uses shutdown in a script? You know, starting a backup in the evening and the last action of the script is to hibernate the machine or something like that... > There were no change to the shutdown CVS since then so here is that > patch, including a changelog. > > Note that I didn't change the programs version number in this patch. I > don't know if changing an existing option would require/justify to > change the version from 1.9 to 2.0 instead of simply to 1.10? 1.10 is fine I think. Say, do you want to take over shutdown maintainership? It's an easy enough package to start with, it builds fine on 32 and 64 bit, and you get the cygport configuration "for free". What do you say? Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Re: Patch for shutdown
2013/5/20 Jeffrey Altman: > I believe it is very important that the Cygwin shutdown not alter the > meaning of command line parameters such that they are different from the > Windows native version. The various options are already too confusing > to remember. Typing the right option value into wrong shell should not > result in the wrong behavior if we can help it. But why do you install the cygwin shutdown package when you want to use the native windows shutdown command line options? The windows shutdown.exe work just fine when it is run from cygwin (mintty, rxvt, ssh). When you de-install the cygwin package, you can use the windows shutdown command. The cygwin shutdown tries to give a POSIX/Linux-like shutdown experience and therefore should mimic the common Linux command line options as good as possible. That's the reason I install the shutdown package. In cygwin I type "ls", "less", etc. It feels like Linux, so I want the shutdown to feel like Linux as well and use -h for halt just like on any real Linux system. And remember that the cygwin shutdown has long options and the "halt", "reboot" and "hibernate" commands. Regards, Frank -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Re: Patch for shutdown
Greetings, Fedin Pavel! > At the other hand, IMHO, Windows .bat scripts are never run from wihin > bash, and vice versa, UNIX .sh scripts are never run from within cmd.exe... That's a bold claim. If I run it down to underlying interpreter, I always run all scripts from "cmd", be it .bat, .cmd, .btm, .sh or, say, .php. > And following the same logic we would need to teach our find.exe (already > mentioned on this list) to understand Windows options instead of UNIX > options... Yeah, that would be ridiculous one. > Even further, in terminal case, why have Cygwin at all ? It is different > from Windows command line and this is confusing... Heh. Anyway, real argument is that Cygwin is providing tools that mimic *NIX environment. What you want to use in the end of the day is up to you. Supposedly, you're fully aware of the consequences. -- WBR, Andrey Repin (anrdae...@freemail.ru) 20.05.2013, <21:37> Sorry for my terrible english... -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Re: Patch for shutdown
On 5/20/2013 9:59 AM, Fedin Pavel wrote: > At the other hand, IMHO, Windows .bat scripts are never run from wihin > bash, and vice versa, UNIX .sh scripts are never run from within > cmd.exe... And following the same logic we would need to teach our > find.exe (already mentioned on this list) to understand Windows > options instead of UNIX options... Even further, in terminal case, why > have Cygwin at all ? It is different from Windows command line and > this is confusing... Kind regards. Unlike the 'find' command, the shutdown command can leave the machine in a state which cannot be recovered without physical access. That is the difference as I see it and it is a significant difference. Sincerely Jeffrey Altman -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Re: Patch for shutdown
On Mon, May 20, 2013 at 9:59 AM, Fedin Pavel wrote: > > At the other hand, IMHO, Windows .bat scripts are never run from wihin bash, > and vice versa, UNIX .sh scripts are never run from within cmd.exe... I do this. Create a null (native, i.e. non-cygwin) program named #! and put it in PATH. Then my scripts can do ~ #!/cmd /c :: Dos batch commands ~ > And following the same logic we would need to teach our find.exe (already > mentioned on this list) to understand Windows options instead of UNIX > options... I think that would be a no go from the get go. > Even further, in terminal case, why have Cygwin at all ? It is different > from Windows command line and this is confusing... > Oh, now I read the sarcasm. :/ -- Earnie -- https://sites.google.com/site/earnieboyd -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
RE: Patch for shutdown
> I would be unhappy with this proposed change. The Windows > "shutdown.exe" uses: > > 'h' for hibernate > 'l' for logoff > 's' for shutdown and halt > 'r' for shutdown and restart > 'g' for shutdown and restart including registered applications > > 'a' for abort shutdown > > with the following modifiers: > > 'f' for force > 'p' for 'no warning > 'e' document the reason > 'i' display GUI > 'm' specify target computer > 't' specify timeout > 'c' specify comment > 'd' shutdown reason code > > I believe it is very important that the Cygwin shutdown not alter the > meaning of command line parameters such that they are different from > the > Windows native version. The various options are already too confusing > to remember. Typing the right option value into wrong shell should not > result in the wrong behavior if we can help it. At the other hand, IMHO, Windows .bat scripts are never run from wihin bash, and vice versa, UNIX .sh scripts are never run from within cmd.exe... And following the same logic we would need to teach our find.exe (already mentioned on this list) to understand Windows options instead of UNIX options... Even further, in terminal case, why have Cygwin at all ? It is different from Windows command line and this is confusing... Kind regards. -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Re: Patch for shutdown
Frank, I would be unhappy with this proposed change. The Windows "shutdown.exe" uses: 'h' for hibernate 'l' for logoff 's' for shutdown and halt 'r' for shutdown and restart 'g' for shutdown and restart including registered applications 'a' for abort shutdown with the following modifiers: 'f' for force 'p' for 'no warning 'e' document the reason 'i' display GUI 'm' specify target computer 't' specify timeout 'c' specify comment 'd' shutdown reason code I believe it is very important that the Cygwin shutdown not alter the meaning of command line parameters such that they are different from the Windows native version. The various options are already too confusing to remember. Typing the right option value into wrong shell should not result in the wrong behavior if we can help it. Thank you. Jeffrey Altman On 5/20/2013 7:40 AM, Frank Fesevur wrote: > Hi Corinna, > > Since nobody made real objections about changing the short flag for > hibernate from -h to -b to make room for -h for halt [1], I created a > patch to change the shutdown program. The patch was created back in > March, but with all your work being done on cygwin64, your holiday and > myself being very busy with life it was held back. > > There were no change to the shutdown CVS since then so here is that > patch, including a changelog. > > Note that I didn't change the programs version number in this patch. I > don't know if changing an existing option would require/justify to > change the version from 1.9 to 2.0 instead of simply to 1.10? > > Regards, > Frank > > [1] http://cygwin.com/ml/cygwin/2013-03/msg00354.html > > > > -- > Problem reports: http://cygwin.com/problems.html > FAQ: http://cygwin.com/faq/ > Documentation: http://cygwin.com/docs.html > Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple > -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
