Re: cygcheck bug: symlinks with unix paths are wrongly resolved
Andrey Repin wrote: Greetings, Csaba Raduly! ... The API can handle "/" as the path separator, but cmd.exe can't. You're seriously wrong... How? (Which part is wrong?) The Start menu's Run... command accepts forward slashes, and cmd.exe parses unquoted forward slashes as parameter delimiters. Are you just alluding to _quoted_ forwards slashes in cmd.exe? Daniel -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Re: cygcheck bug: symlinks with unix paths are wrongly resolved
Greetings, Csaba Raduly! > On Thu, Oct 21, 2010 at 4:46 AM, Andrey Repin wrote: >> >> Not to mention, the Windows itself don't see much of a difference between "/" >> and "\" in path. (where it see, it is a bug). > The API can handle "/" as the path separator, but cmd.exe can't. You're seriously wrong... -- WBR, Andrey Repin (anrdae...@freemail.ru) 21.10.2010, <13:00> Sorry for my terrible english... -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Re: cygcheck bug: symlinks with unix paths are wrongly resolved
On Thu, Oct 21, 2010 at 4:46 AM, Andrey Repin wrote: > > Not to mention, the Windows itself don't see much of a difference between "/" > and "\" in path. (where it see, it is a bug). The API can handle "/" as the path separator, but cmd.exe can't. -- GCS a+ e++ d- C++ ULS$ L+$ !E- W++ P+++$ w++$ tv+ b++ DI D++ 5++ Life is complex, with real and imaginary parts. "Ok, it boots. Which means it must be bug-free and perfect. " -- Linus Torvalds "People disagree with me. I just ignore them." -- Linus Torvalds -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Re: cygcheck bug: symlinks with unix paths are wrongly resolved
On Thu, Oct 21, 2010 at 06:46:16AM +0400, Andrey Repin wrote: >Greetings, Christopher Faylor! > >>>[snip...] a...@dstar ~ $ ln -s `which cmd.exe` cmd.exe a...@dstar ~ $ cygcheck ./cmd.exe -> D:\OTHERBIN\cygwin\cygdrive\d\WINDOWS\system32\cmd.exe cygcheck: could not find './cmd.exe' >>> >>>cygcheck is not a cygwin application, it's a native windows application, >>>so it does not know how to resolve unix paths. > >> Sure it does: > >Not to mention, the Windows itself don't see much of a difference between "/" >and "\" in path. (where it see, it is a bug). I should clarify. cygcheck does understand UNIX paths. It does not understand symlinks just like the OP said. Sorry for not making that clear. cgf -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Re: cygcheck bug: symlinks with unix paths are wrongly resolved
Greetings, Christopher Faylor! >>[snip...] >>> a...@dstar ~ >>> $ ln -s `which cmd.exe` cmd.exe >>> >>> a...@dstar ~ >>> $ cygcheck ./cmd.exe >>> -> D:\OTHERBIN\cygwin\cygdrive\d\WINDOWS\system32\cmd.exe >>> cygcheck: could not find './cmd.exe' >> >>cygcheck is not a cygwin application, it's a native windows application, >>so it does not know how to resolve unix paths. > Sure it does: Not to mention, the Windows itself don't see much of a difference between "/" and "\" in path. (where it see, it is a bug). -- WBR, Andrey Repin (anrdae...@freemail.ru) 21.10.2010, <6:45> Sorry for my terrible english... -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Re: cygcheck bug: symlinks with unix paths are wrongly resolved
On Wed, Oct 20, 2010 at 07:46:05PM -0400, Rolf Campbell wrote: >On 2010-10-19 19:17, Arseny Slobodyuk wrote: >[snip...] >> a...@dstar ~ >> $ ln -s `which cmd.exe` cmd.exe >> >> a...@dstar ~ >> $ cygcheck ./cmd.exe >> -> D:\OTHERBIN\cygwin\cygdrive\d\WINDOWS\system32\cmd.exe >> cygcheck: could not find './cmd.exe' > >cygcheck is not a cygwin application, it's a native windows application, >so it does not know how to resolve unix paths. Sure it does: VVV c:\>cygcheck /usr/bin/ls.exe C:\cygwin\bin\ls.exe c:\cygwin\bin\cygwin1.dll C:\WINXP\system32\ADVAPI32.DLL C:\WINXP\system32\KERNEL32.dll C:\WINXP\system32\ntdll.dll C:\WINXP\system32\RPCRT4.dll C:\WINXP\system32\Secur32.dll c:\cygwin\bin\cygintl-8.dll c:\cygwin\bin\cygiconv-2.dll c:\cygwin\bin\cyggcc_s-1.dll And also: bash-3.2$ cd /cygdrive/c/winxp/system32 bash-3.2$ cygcheck ./cmd.exe C:\winxp\system32\cmd.exe C:\winxp\system32\KERNEL32.dll C:\winxp\system32\ntdll.dll C:\winxp\system32\msvcrt.dll C:\winxp\system32\USER32.dll C:\winxp\system32\GDI32.dll cgf -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Re: cygcheck bug: symlinks with unix paths are wrongly resolved
On 2010-10-19 19:17, Arseny Slobodyuk wrote: [snip...] a...@dstar ~ $ ln -s `which cmd.exe` cmd.exe a...@dstar ~ $ cygcheck ./cmd.exe -> D:\OTHERBIN\cygwin\cygdrive\d\WINDOWS\system32\cmd.exe cygcheck: could not find './cmd.exe' cygcheck is not a cygwin application, it's a native windows application, so it does not know how to resolve unix paths. -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Re: cygcheck bug
On Feb 7 23:21, Eric Blake wrote: > $ uname -a > CYGWIN_98-4.10 bedroom 1.5.19(0.150/4/2) 2006-01-20 13:28 i686 Cygwin > $ cd /bin > $ cygcheck ./bash > .\.\.\.\.\ - Cannot open > $ cygcheck ./bash.exe > .\bash.exe > .\cygwin1.dll > ... I've checked in a fix. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Project Co-Leader cygwin AT cygwin DOT com Red Hat -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Problem reports: http://cygwin.com/problems.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/
Re: cygcheck bug
> > $ uname -a > > CYGWIN_98-4.10 bedroom 1.5.19(0.150/4/2) 2006-01-20 13:28 i686 Cygwin > > $ cd /bin > > $ cygcheck ./bash > > .\.\.\.\.\ - Cannot open > > $ cygcheck ./bash.exe > > .\bash.exe > > .\cygwin1.dll > > ... > > FWIW, WFM: > > $ cygcheck --version > cygcheck version 1.74 > System Checker for Cygwin > Copyright 1998, 1999, 2000, 2001, 2002, 2003, 2004, 2005 Red Hat, Inc. > Compiled on Jul 2 2005 Hmm, older version. $ cygcheck --version cygcheck version 1.88 System Checker for Cygwin Copyright 1998, 1999, 2000, 2001, 2002, 2003, 2004, 2005 Red Hat, Inc. Compiled on Jan 20 2006 Hmm, another bug - GNU coding standards state that only the most recent year is needed in the --version output (although Red Hat may require the additional years). But at any rate, cygcheck --version should report copyright 2006, since it was compiled this year. -- Eric Blake -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Problem reports: http://cygwin.com/problems.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/
Re: cygcheck bug
On Tue, 7 Feb 2006, Eric Blake wrote: > $ uname -a > CYGWIN_98-4.10 bedroom 1.5.19(0.150/4/2) 2006-01-20 13:28 i686 Cygwin > $ cd /bin > $ cygcheck ./bash > .\.\.\.\.\ - Cannot open > $ cygcheck ./bash.exe > .\bash.exe > .\cygwin1.dll > ... FWIW, WFM: $ uname -svr CYGWIN_NT-5.1 1.5.20(0.153/4/2) 2006-02-06 22:48 $ cd /bin $ cygcheck ./bash .\bash.exe .\cygwin1.dll ... $ cygcheck ./bash.exe .\bash.exe .\cygwin1.dll ... $ cygcheck --version cygcheck version 1.74 System Checker for Cygwin Copyright 1998, 1999, 2000, 2001, 2002, 2003, 2004, 2005 Red Hat, Inc. Compiled on Jul 2 2005 $ Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! "Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte." "But no -- you are no fool; you call yourself a fool, there's proof enough in that!" -- Rostand, "Cyrano de Bergerac" -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Problem reports: http://cygwin.com/problems.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/
cygcheck bug
$ uname -a CYGWIN_98-4.10 bedroom 1.5.19(0.150/4/2) 2006-01-20 13:28 i686 Cygwin $ cd /bin $ cygcheck ./bash .\.\.\.\.\ - Cannot open $ cygcheck ./bash.exe .\bash.exe .\cygwin1.dll ... -- Eric Blake -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Problem reports: http://cygwin.com/problems.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/
Re: [PATCH] cygcheck bug when listing services
On Tue, 6 Dec 2005, Christopher Faylor wrote: > On Tue, Dec 06, 2005 at 08:41:24PM -0500, Igor Pechtchanski wrote: > >On Tue, 6 Dec 2005, Yitzchak Scott-Thoennes wrote: > >[snip] > >> That needs a comment in the code. > > > >Fair enough: > >[snip] > >+ /* Add two nulls to avoid confusing strtok() when the trailing > >separator > >+ is missing */ > > How about a testcase which shows that the MSVCRT strtok needs two > trailing NUL bytes to work around problems when there is no trailing > separator? I would find that much more interesting than a comment which > simply asserts that behavior. Fair enough. The double-null issue was a red herring, apparently -- a simple recompile fixed the problem. In fact, the cygcheck from the latest snapshot doesn't exhibit this behavior. Patch withdrawn. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_[EMAIL PROTECTED] |,4- ) )-,_. ,\ ( `'-' Igor Pechtchanski, Ph.D. '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! If there's any real truth it's that the entire multidimensional infinity of the Universe is almost certainly being run by a bunch of maniacs. /DA -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Problem reports: http://cygwin.com/problems.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/
Re: [PATCH] cygcheck bug when listing services (Was Re: Parallel writes to a single FIFO do not queue, and deadlock cygwin)
On Tue, Dec 06, 2005 at 08:41:24PM -0500, Igor Pechtchanski wrote:
>On Tue, 6 Dec 2005, Yitzchak Scott-Thoennes wrote:
>
>> On Mon, Dec 05, 2005 at 09:40:01AM -0500, Igor Pechtchanski wrote:
>> > Running cygcheck under strace shows that after listing all the available
>> > services, it invokes "cygrunsrv --query grunsrv.exe --list", which results
>> > in the above message. I think this may be because the output of
>> > "cygrunsrv --list" doesn't contain a trailing '\n', and so strtok gets
>> > confused. The following patch (against a slightly older cygcheck) fixes
>> > it for me, but I haven't had the time to test it extensively:
>> > [snip]
>> > - buf[nchars] = 0;
>> > + buf[nchars] = buf[nchars+1] = 0;
>>
>> That needs a comment in the code.
>
>Fair enough:
>
>Index: cygcheck.cc
>===
>RCS file: /cvs/src/src/winsup/utils/cygcheck.cc,v
>retrieving revision 1.77
>diff -u -p -r1.77 cygcheck.cc
>--- cygcheck.cc 17 Aug 2005 00:52:43 - 1.77
>+++ cygcheck.cc 7 Dec 2005 01:38:07 -
>@@ -950,8 +950,10 @@ dump_sysinfo_services ()
> else
> {
> /* read the output of --list, and then run --query for each service */
>- size_t nchars = fread ((void *) buf, 1, sizeof (buf) - 1, f);
>- buf[nchars] = 0;
>+ size_t nchars = fread ((void *) buf, 1, sizeof (buf) - 2, f);
>+ /* Add two nulls to avoid confusing strtok() when the trailing separator
>+ is missing */
>+ buf[nchars] = buf[nchars+1] = 0;
> pclose (f);
>
> if (nchars > 0)
>
>I'll even add a ChangeLog of sorts :-)
>
>2005-12-06 Igor Pechtchanski <[EMAIL PROTECTED]>
>
> * cygcheck.cc (dump_sysinfo_services): Add an extra NUL to mollify
> strtok() when the trailing newline is missing.
How about a testcase which shows that the MSVCRT strtok needs two
trailing NUL bytes to work around problems when there is no trailing
separator? I would find that much more interesting than a comment which
simply asserts that behavior.
cgf
--
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Problem reports: http://cygwin.com/problems.html
Documentation: http://cygwin.com/docs.html
FAQ: http://cygwin.com/faq/
Re: [PATCH] cygcheck bug when listing services (Was Re: Parallel writes to a single FIFO do not queue, and deadlock cygwin)
On Tue, 6 Dec 2005, Yitzchak Scott-Thoennes wrote:
> On Mon, Dec 05, 2005 at 09:40:01AM -0500, Igor Pechtchanski wrote:
> > Running cygcheck under strace shows that after listing all the available
> > services, it invokes "cygrunsrv --query grunsrv.exe --list", which results
> > in the above message. I think this may be because the output of
> > "cygrunsrv --list" doesn't contain a trailing '\n', and so strtok gets
> > confused. The following patch (against a slightly older cygcheck) fixes
> > it for me, but I haven't had the time to test it extensively:
> > [snip]
> > - buf[nchars] = 0;
> > + buf[nchars] = buf[nchars+1] = 0;
>
> That needs a comment in the code.
Fair enough:
Index: cygcheck.cc
===
RCS file: /cvs/src/src/winsup/utils/cygcheck.cc,v
retrieving revision 1.77
diff -u -p -r1.77 cygcheck.cc
--- cygcheck.cc 17 Aug 2005 00:52:43 - 1.77
+++ cygcheck.cc 7 Dec 2005 01:38:07 -
@@ -950,8 +950,10 @@ dump_sysinfo_services ()
else
{
/* read the output of --list, and then run --query for each service */
- size_t nchars = fread ((void *) buf, 1, sizeof (buf) - 1, f);
- buf[nchars] = 0;
+ size_t nchars = fread ((void *) buf, 1, sizeof (buf) - 2, f);
+ /* Add two nulls to avoid confusing strtok() when the trailing separator
+ is missing */
+ buf[nchars] = buf[nchars+1] = 0;
pclose (f);
if (nchars > 0)
I'll even add a ChangeLog of sorts :-)
2005-12-06 Igor Pechtchanski <[EMAIL PROTECTED]>
* cygcheck.cc (dump_sysinfo_services): Add an extra NUL to mollify
strtok() when the trailing newline is missing.
HTH,
Igor
--
http://cs.nyu.edu/~pechtcha/
|\ _,,,---,,_[EMAIL PROTECTED]
ZZZzz /,`.-'`'-. ;-;;,_[EMAIL PROTECTED]
|,4- ) )-,_. ,\ ( `'-' Igor Pechtchanski, Ph.D.
'---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow!
If there's any real truth it's that the entire multidimensional infinity
of the Universe is almost certainly being run by a bunch of maniacs. /DA
--
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Problem reports: http://cygwin.com/problems.html
Documentation: http://cygwin.com/docs.html
FAQ: http://cygwin.com/faq/
Re: cygcheck bug when listing services (Was Re: Parallel writes to a single FIFO do not queue, and deadlock cygwin)
On Mon, Dec 05, 2005 at 09:40:01AM -0500, Igor Pechtchanski wrote:
> Running cygcheck under strace shows that after listing all the available
> services, it invokes "cygrunsrv --query grunsrv.exe --list", which results
> in the above message. I think this may be because the output of
> "cygrunsrv --list" doesn't contain a trailing '\n', and so strtok gets
> confused. The following patch (against a slightly older cygcheck) fixes
> it for me, but I haven't had the time to test it extensively:
>
> Index: cygcheck.cc
> ===
> RCS file: /cvs/src/src/winsup/utils/cygcheck.cc,v
> retrieving revision 1.77
> diff -u -p -r1.77 cygcheck.cc
> --- cygcheck.cc 17 Aug 2005 00:52:43 - 1.77
> +++ cygcheck.cc 5 Dec 2005 14:37:58 -
> @@ -950,8 +950,8 @@ dump_sysinfo_services ()
>else
> {
>/* read the output of --list, and then run --query for each service */
> - size_t nchars = fread ((void *) buf, 1, sizeof (buf) - 1, f);
> - buf[nchars] = 0;
> + size_t nchars = fread ((void *) buf, 1, sizeof (buf) - 2, f);
> + buf[nchars] = buf[nchars+1] = 0;
That needs a comment in the code.
--
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Problem reports: http://cygwin.com/problems.html
Documentation: http://cygwin.com/docs.html
FAQ: http://cygwin.com/faq/
cygcheck bug when listing services (Was Re: Parallel writes to a single FIFO do not queue, and deadlock cygwin)
On Sun, 4 Dec 2005, Mark Piper wrote:
> P.S. Here is the full output from cygcheck
>
> $ /bin/cygcheck.exe -s
>
> Cygwin Configuration Diagnostics
> [snip]
> 1265k 2005/07/03 C:\cygwin\bin\cygwin1.dll
> Cygwin DLL version info:
> DLL version: 1.5.18
> DLL epoch: 19
> DLL bad signal mask: 19005
> DLL old termios: 5
> DLL malloc env: 28
> API major: 0
> API minor: 132
> Shared data: 4
> DLL identifier: cygwin1
> Mount /usr/bin/cygrunsrv: Exactly one of --install, --remove,
> --start, --stop, --query, or --list is required
> Try `/usr/bin/cygrunsrv --help' for more information.
> registry: 2
> Cygnus registry name: Cygnus Solutions
> Cygwin registry name: Cygwin
> Program options name: Program Options
> Cygwin mount registry name: mounts v2
> Cygdrive flags: cygdrive flags
> Cygdrive prefix: cygdrive prefix
> Cygdrive default prefix:
> Build date: Sat Jul 2 20:30:04 EDT 2005
> Shared id: cygwin1S4
>
>
> Service : sshd
> Display name: CYGWIN sshd
> Current State : Running
> Controls Accepted : Stop
> Command : /usr/sbin/sshd -D
Note the cygrunsrv error message above. I was able to reproduce it in
non-verbose mode.
Running cygcheck under strace shows that after listing all the available
services, it invokes "cygrunsrv --query grunsrv.exe --list", which results
in the above message. I think this may be because the output of
"cygrunsrv --list" doesn't contain a trailing '\n', and so strtok gets
confused. The following patch (against a slightly older cygcheck) fixes
it for me, but I haven't had the time to test it extensively:
Index: cygcheck.cc
===
RCS file: /cvs/src/src/winsup/utils/cygcheck.cc,v
retrieving revision 1.77
diff -u -p -r1.77 cygcheck.cc
--- cygcheck.cc 17 Aug 2005 00:52:43 - 1.77
+++ cygcheck.cc 5 Dec 2005 14:37:58 -
@@ -950,8 +950,8 @@ dump_sysinfo_services ()
else
{
/* read the output of --list, and then run --query for each service */
- size_t nchars = fread ((void *) buf, 1, sizeof (buf) - 1, f);
- buf[nchars] = 0;
+ size_t nchars = fread ((void *) buf, 1, sizeof (buf) - 2, f);
+ buf[nchars] = buf[nchars+1] = 0;
pclose (f);
if (nchars > 0)
HTH,
Igor
--
http://cs.nyu.edu/~pechtcha/
|\ _,,,---,,_[EMAIL PROTECTED]
ZZZzz /,`.-'`'-. ;-;;,_[EMAIL PROTECTED]
|,4- ) )-,_. ,\ ( `'-' Igor Pechtchanski, Ph.D.
'---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow!
If there's any real truth it's that the entire multidimensional infinity
of the Universe is almost certainly being run by a bunch of maniacs. /DA
--
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Problem reports: http://cygwin.com/problems.html
Documentation: http://cygwin.com/docs.html
FAQ: http://cygwin.com/faq/
