Re: Integrating Ralf's rebase into setup.exe
On Wed, 2003-01-01 at 02:17, Charles Wilson wrote: > I needed to make the following changes before this would compile. > Mostly namespace errors, but also a typo and main() void vs. int. > > I figured the library files should explicitly call std::cout & friends, > but the executables could go ahead and say 'using namespace std;'. > > Oh, a few other niggles: why does Makefile have DOS line-endings, but > all the other files have UNIX line-endings? README needs a brief note > about this 0.6 version. And shouldn't there be a ChangeLog? And heres a show stopper. The library should not use cout at all. It should throw an exception, and let the user interface handle it. Rob -- --- GPG key available at: http://users.bigpond.net.au/robertc/keys.txt. --- signature.asc Description: This is a digitally signed message part
Re: Integrating Ralf's rebase into setup.exe
Still missing a lot of the errors that were fixed in my patch. Here's
the remainder:
1) 'hex' and 'endl' are also in the std:: namespace
2) unbind_main.cc needs 'using namespace std;'
3) (new) rebind_main will rebind the first commandline argument over and
over; it needs to use argv[i] not argv[1]
4) fiximage.cc and rebaseimage.cc seem not have gotten any of the std::
fixes.
errmmm...why not inspect the patch below for correctness, and then apply
& commit, rather than implementing all of the fixes by hand, which
invariably will skip/miss some?
--Chuck
Index: checkimage.cc
===
RCS file: /cvsroot/kde-cygwin/tools/rebase/checkimage.cc,v
retrieving revision 1.5
diff -u -r1.5 checkimage.cc
--- checkimage.cc 31 Dec 2002 18:33:14 - 1.5
+++ checkimage.cc 31 Dec 2002 18:54:05 -
@@ -32,7 +32,7 @@
if (!dll.isLoaded())
{
if (Base::debug)
-std::cout << "error: could not open file" << endl;
+std::cout << "error: could not open file" << std::endl;
SetLastError(ERROR_FILE_NOT_FOUND);
return false;
}
@@ -40,7 +40,7 @@
if (!dll.checkRelocations())
{
if (Base::debug)
-std::cout << "dll relocation errors - please fix the errors at first" << endl;
+std::cout << "dll relocation errors - please fix the errors at first" <<
+std::endl;
SetLastError(ERROR_INVALID_DATA);
return false;
}
Index: fiximage.cc
===
RCS file: /cvsroot/kde-cygwin/tools/rebase/fiximage.cc,v
retrieving revision 1.3
diff -u -r1.3 fiximage.cc
--- fiximage.cc 31 Dec 2002 12:56:48 - 1.3
+++ fiximage.cc 31 Dec 2002 18:54:05 -
@@ -29,12 +29,12 @@
LinkedObjectFile dll(filename,true);
if (Base::debug)
-cout << filename << ": " << endl;
+std::cout << filename << ": " << std::endl;
if (!dll.isLoaded())
{
if (Base::debug)
-cout << "error: could not open file" << endl;
+std::cout << "error: could not open file" << std::endl;
SetLastError(ERROR_FILE_NOT_FOUND);
return false;
}
@@ -42,7 +42,7 @@
if (!dll.fixRelocations())
{
if (Base::debug)
-cout << "error: could not fix relocation problems" << endl;
+std::cout << "error: could not fix relocation problems" << std::endl;
SetLastError(ERROR_INVALID_DATA);
return false;
}
Index: getimageinfos.cc
===
RCS file: /cvsroot/kde-cygwin/tools/rebase/getimageinfos.cc,v
retrieving revision 1.4
diff -u -r1.4 getimageinfos.cc
--- getimageinfos.cc31 Dec 2002 18:33:14 - 1.4
+++ getimageinfos.cc31 Dec 2002 18:54:06 -
@@ -34,7 +34,7 @@
if (!dll.isLoaded())
{
if (Base::debug)
-std::cout << "error: could not open file" << endl;
+std::cout << "error: could not open file" << std::endl;
SetLastError(ERROR_FILE_NOT_FOUND);
return false;
}
@@ -43,7 +43,7 @@
*ImageSize = dll.getNTHeader()->OptionalHeader.SizeOfImage;
if (Base::debug)
-std::cout << "ImageBase: 0x" << hex << *ImageBase << " ImageSize: 0x" <<
*ImageSize << endl;
+std::cout << "ImageBase: 0x" << std::hex << *ImageBase << " ImageSize: 0x" <<
+*ImageSize << std::endl;
SetLastError(NO_ERROR);
return true;
Index: rebaseimage.cc
===
RCS file: /cvsroot/kde-cygwin/tools/rebase/rebaseimage.cc,v
retrieving revision 1.2
diff -u -r1.2 rebaseimage.cc
--- rebaseimage.cc 31 Dec 2002 12:56:48 - 1.2
+++ rebaseimage.cc 31 Dec 2002 18:54:07 -
@@ -54,7 +54,7 @@
if (!dll.checkRelocations())
{
if (Base::debug)
-cout << "error: dll relocation errors - please fix the errors at first" <<
endl;
+std::cout << "error: dll relocation errors - please fix the errors at first"
+<< std::endl;
SetLastError(ERROR_INVALID_DATA);
return false;
}
@@ -84,7 +84,7 @@
if (ntheader->OptionalHeader.ImageBase == *NewImageBase)
{
if (Base::debug)
-cout << "dll is already rebased" << endl;
+std::cout << "dll is already rebased" << std::endl;
SetLastError(NO_ERROR);
return true;
}
@@ -97,7 +97,7 @@
if (!dll.performRelocation(difference))
{
if (Base::debug)
-cout << "error: could not rebase image" << endl;
+std::cout << "error: could not rebase image" << std::endl;
SetLastError(ERROR_BAD_FORMAT);
return false;
}
Index: rebind_main.cc
===
RCS file: /cvsroot/kde-cygwin/tools/rebase/rebind_main.cc,v
retrieving revision 1.3
diff -u -r1.3 rebind_main.cc
--- rebind_main.cc 31 Dec 2002 18:33:14 - 1.3
+++ rebind_main.cc 31 Dec 2002 18:54:08 -
@@ -61,7 +61,7 @@
char *a =
Re: Integrating Ralf's rebase into setup.exe
Ralf Habacker wrote: I needed to make the following changes before this would compile. Mostly namespace errors, the std:: below or something else ? Nope, that was it. but also a typo where ? In checkimage.cc: - ctFile dll(filename); + LinkedObjectFile dll(filename); README needs a brief note about this 0.6 version. More than I have written in my last email ? No, it's just that the README file itself contains some brief descriptions of version 0.1 -- 0.5, but not 0.6. I thought it odd that 0.6 was missing. Created with cvs2cl and added to the cvs. Interesting tool -- I'd never heard of it before. --Chuck
RE: Integrating Ralf's rebase into setup.exe
> I needed to make the following changes before this would compile. > Mostly namespace errors, the std:: below or something else ? > but also a typo where ? > and main() void vs. int. fixed > I figured the library files should explicitly call std::cout & friends, fixed > but the executables could go ahead and say 'using namespace std;'. > > Oh, a few other niggles: why does Makefile have DOS line-endings fixed > README needs a brief note about this 0.6 version. More than I have written in my last email ? >And shouldn't there be a ChangeLog? Created with cvs2cl and added to the cvs. Ralf
Re: Integrating Ralf's rebase into setup.exe
On Tue, Dec 31, 2002 at 06:41:45PM +0100, Ralf Habacker wrote: > > However, should we use the names libimagehlp.a and imagehlp.h? They > > clash with the mingw versions. > > > Do you have a better name ? Rob suggested libcygimagehlp.a for the library. Should we leave the names as is, but use -L and -I to find the right files instead? Jason -- PGP/GPG Key: http://www.tishler.net/jason/pubkey.asc or key servers Fingerprint: 7A73 1405 7F2B E669 C19D 8784 1AFD E4CC ECF4 8EF6
RE: Integrating Ralf's rebase into setup.exe
> However, should we use the names libimagehlp.a and imagehlp.h? They > clash with the mingw versions. > Do you have a better name ? Ralf
Re: symbols in Microsoft DLL's and Linking w/ them
On Tue, Dec 31, 2002 at 07:50:59AM -0800, Robert Bercik wrote: >I'm trying to create a cygwin dll that links to a microsoft DLL. >However, when I try and link to the DLL, the linkerl complains that the >symbols contained in the microsoft DLL are still unresolved. I used >the nm command on the DLL and it reported that it did not find any >symbols, but when I did a grep command the symbols as an argument, it >found them in the DLL. Have any of you had any success with this in >the past? I'm really stuck here. > >Thanks in advance, Go back and read http://cygwin.com/lists.html. This isn't the mailing list for this kind of request. I've redirected this to cygwin at cygwin dot com. cgf
Re: guile-1.5.6-5 mentioned in setup.ini
<[EMAIL PROTECTED]> writes: > In the current setup.ini (timestamp 1041225613) guile-1.5.6-5 is marked as > [prev] for all three of @guile, @guile-devel and @guile-doc. But it is > presumed [curr] as the source for @libguile14. *guile*-1.6.0-1 (is curr and) should be used for all purposes. > It seems odd to me but I can think of reasons why what might be [prev] for > one package might be [curr] for others. Please can the correct-ness of this > be confirmed by the maintainer? Sorry, and thanks. There's no reason, however, for the latest version of a versioned library package (libguile14-1.5.6-5 in this case) not to be curr. Old or custom packages (that possibly marked curr), may depend on it. Note that libguile12 is *newer* than libguile14 (see the guile-devel list). Greetings, Jan. -- Jan Nieuwenhuizen <[EMAIL PROTECTED]> | GNU LilyPond - The music typesetter http://www.xs4all.nl/~jantien | http://www.lilypond.org -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Bug reporting: http://cygwin.com/bugs.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/ -- Jan Nieuwenhuizen <[EMAIL PROTECTED]> | GNU LilyPond - The music typesetter http://www.xs4all.nl/~jantien | http://www.lilypond.org
symbols in Microsoft DLL's and Linking w/ them
Hi, I'm trying to create a cygwin dll that links to a microsoft DLL. However, when I try and link to the DLL, the linkerl complains that the symbols contained in the microsoft DLL are still unresolved. I used the nm command on the DLL and it reported that it did not find any symbols, but when I did a grep command the symbols as an argument, it found them in the DLL. Have any of you had any success with this in the past? I'm really stuck here. Thanks in advance, -Rob Do you Yahoo!? Yahoo! Mail Plus - Powerful. Affordable. Sign up now
Re: Integrating Ralf's rebase into setup.exe
I needed to make the following changes before this would compile.
Mostly namespace errors, but also a typo and main() void vs. int.
I figured the library files should explicitly call std::cout & friends,
but the executables could go ahead and say 'using namespace std;'.
Oh, a few other niggles: why does Makefile have DOS line-endings, but
all the other files have UNIX line-endings? README needs a brief note
about this 0.6 version. And shouldn't there be a ChangeLog?
--Chuck
Index: checkimage.cc
===
RCS file: /cvsroot/kde-cygwin/tools/rebase/checkimage.cc,v
retrieving revision 1.3
diff -u -r1.3 checkimage.cc
--- checkimage.cc 31 Dec 2002 12:56:48 - 1.3
+++ checkimage.cc 31 Dec 2002 15:14:42 -
@@ -27,12 +27,12 @@
BOOL CheckImage(LPSTR filename)
{
- ctFile dll(filename);
+ LinkedObjectFile dll(filename);
if (!dll.isLoaded())
{
if (Base::debug)
-cout << "error: could not open file" << endl;
+std::cout << "error: could not open file" << std::endl;
SetLastError(ERROR_FILE_NOT_FOUND);
return false;
}
@@ -40,7 +40,7 @@
if (!dll.checkRelocations())
{
if (Base::debug)
-cout << "dll relocation errors - please fix the errors at first" << endl;
+std::cout << "dll relocation errors - please fix the errors at first" <<
+std::endl;
SetLastError(ERROR_INVALID_DATA);
return false;
}
Index: fiximage.cc
===
RCS file: /cvsroot/kde-cygwin/tools/rebase/fiximage.cc,v
retrieving revision 1.3
diff -u -r1.3 fiximage.cc
--- fiximage.cc 31 Dec 2002 12:56:48 - 1.3
+++ fiximage.cc 31 Dec 2002 15:14:42 -
@@ -29,12 +29,12 @@
LinkedObjectFile dll(filename,true);
if (Base::debug)
-cout << filename << ": " << endl;
+std::cout << filename << ": " << std::endl;
if (!dll.isLoaded())
{
if (Base::debug)
-cout << "error: could not open file" << endl;
+std::cout << "error: could not open file" << std::endl;
SetLastError(ERROR_FILE_NOT_FOUND);
return false;
}
@@ -42,7 +42,7 @@
if (!dll.fixRelocations())
{
if (Base::debug)
-cout << "error: could not fix relocation problems" << endl;
+std::cout << "error: could not fix relocation problems" << std::endl;
SetLastError(ERROR_INVALID_DATA);
return false;
}
Index: getimageinfos.cc
===
RCS file: /cvsroot/kde-cygwin/tools/rebase/getimageinfos.cc,v
retrieving revision 1.3
diff -u -r1.3 getimageinfos.cc
--- getimageinfos.cc31 Dec 2002 12:56:48 - 1.3
+++ getimageinfos.cc31 Dec 2002 15:14:42 -
@@ -34,7 +34,7 @@
if (!dll.isLoaded())
{
if (Base::debug)
-cout << "error: could not open file" << endl;
+std::cout << "error: could not open file" << std::endl;
SetLastError(ERROR_FILE_NOT_FOUND);
return false;
}
@@ -43,7 +43,7 @@
*ImageSize = dll.getNTHeader()->OptionalHeader.SizeOfImage;
if (Base::debug)
-cout << "ImageBase: 0x" << hex << *ImageBase << " ImageSize: 0x" << *ImageSize <<
endl;
+std::cout << "ImageBase: 0x" << std::hex << *ImageBase << " ImageSize: 0x" <<
+*ImageSize << std::endl;
SetLastError(NO_ERROR);
return true;
Index: rebase_main.cc
===
RCS file: /cvsroot/kde-cygwin/tools/rebase/rebase_main.cc,v
retrieving revision 1.1
diff -u -r1.1 rebase_main.cc
--- rebase_main.cc 31 Dec 2002 11:08:08 - 1.1
+++ rebase_main.cc 31 Dec 2002 15:14:44 -
@@ -48,7 +48,7 @@
int theListFlag = 0;
-void
+int
main(int argc, char* argv[])
{
ParseArgs(argc, argv);
Index: rebaseimage.cc
===
RCS file: /cvsroot/kde-cygwin/tools/rebase/rebaseimage.cc,v
retrieving revision 1.2
diff -u -r1.2 rebaseimage.cc
--- rebaseimage.cc 31 Dec 2002 12:56:48 - 1.2
+++ rebaseimage.cc 31 Dec 2002 15:14:44 -
@@ -54,7 +54,7 @@
if (!dll.checkRelocations())
{
if (Base::debug)
-cout << "error: dll relocation errors - please fix the errors at first" <<
endl;
+std::cout << "error: dll relocation errors - please fix the errors at first"
+<< std::endl;
SetLastError(ERROR_INVALID_DATA);
return false;
}
@@ -84,7 +84,7 @@
if (ntheader->OptionalHeader.ImageBase == *NewImageBase)
{
if (Base::debug)
-cout << "dll is already rebased" << endl;
+std::cout << "dll is already rebased" << std::endl;
SetLastError(NO_ERROR);
return true;
}
@@ -97,7 +97,7 @@
if (!dll.performRelocation(difference))
{
if (Base::debug)
-cout << "error: could not rebase image" << endl;
+std::cout << "error: could not rebase image"
Re: Integrating Ralf's rebase into setup.exe
Ralf, On Tue, Dec 31, 2002 at 02:20:36PM +0100, Ralf Habacker wrote: > - creates a static lib containing all needed objectfiles for > RebaseImage() and friends. The library is named libimagehlp.a and the > relating include file imagehlp.h. After checking out just call > > $ make imagehlp > > and the lib is created. > > - the debug message printing is conditionalized with an internal debug > flag, so by default the code does not print any debug messages. Thanks for the above! Sometimes it pays to procrastinate. :,) However, should we use the names libimagehlp.a and imagehlp.h? They clash with the mingw versions. Jason -- PGP/GPG Key: http://www.tishler.net/jason/pubkey.asc or key servers Fingerprint: 7A73 1405 7F2B E669 C19D 8784 1AFD E4CC ECF4 8EF6
Pending packages status - last issue for year 2002 :)
1. grace version: 5.1.10-1 status : not reviewed notes : http://cygwin.com/ml/cygwin-apps/2002-11/msg00322.html votes : 1 (Robert) url: http://www.scytek.de/cygwin/grace-5.1.10-1.tar.bz2 http://www.scytek.de/cygwin/grace-5.1.10-1-src.tar.bz2 http://www.scytek.de/cygwin/setup.hint 2. nasm version: 0.98.35-1 status : reviewed; updated package is available notes : http://sources.redhat.com/ml/cygwin-apps/2002-12/msg00023.html http://www.cygwin.com/ml/cygwin-apps/2002-12/msg00029.html reviews: http://www.cygwin.com/ml/cygwin-apps/2002-12/msg00139.html http://www.cygwin.com/ml/cygwin-apps/2002-12/msg00169.html votes : 4 (Abraham, Gerrit, Joshua and Lapo) url: http://www.proud-x.com/~p00ya/cygwin-apps/nasm/nasm-0.98.35-1.tar.bz2 http://www.proud-x.com/~p00ya/cygwin-apps/nasm/nasm-0.98.35-1-src.tar.bz2 http://www.proud-x.com/~p00ya/cygwin-apps/nasm/setup.hint 3. sunrpc version: 4.0-1 status : reviewed; updated package is available notes : http://www.cygwin.com/ml/cygwin-apps/2002-12/msg00113.html reviews: http://www.cygwin.com/ml/cygwin-apps/2002-12/msg00117.html http://www.cygwin.com/ml/cygwin-apps/2002-12/msg00120.html votes : 4 (Christopher, Corinna, Hack and Sergey) url: http://www.oneparticularharbor.net/cygwin/sunrpc/sunrpc-4.0-1.tar.bz2 http://www.oneparticularharbor.net/cygwin/sunrpc/sunrpc-4.0-1-src.tar.bz2 http://www.oneparticularharbor.net/cygwin/sunrpc/setup.hint 4. nfs-server version: 2.2.47-1 status : reviewed notes : http://www.cygwin.com/ml/cygwin-apps/2002-12/msg00113.html reviews: http://www.cygwin.com/ml/cygwin-apps/2002-12/msg00117.html http://www.cygwin.com/ml/cygwin-apps/2002-12/msg00120.html http://www.cygwin.com/ml/cygwin-apps/2002-12/msg00161.html votes : 4 (Christopher, Corinna, Hack and Sergey) url: http://www.oneparticularharbor.net/cygwin/nfs-server/nfs-server-2.2.47-1.tar.bz2 http://www.oneparticularharbor.net/cygwin/nfs-server/nfs-server-2.2.47-1-src.tar.bz2 http://www.oneparticularharbor.net/cygwin/nfs-server/setup.hint
guile-1.5.6-5 mentioned in setup.ini (fwd)
-- Forwarded message -- Date: Tue, 31 Dec 2002 11:58:02 - From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Subject: guile-1.5.6-5 mentioned in setup.ini In the current setup.ini (timestamp 1041225613) guile-1.5.6-5 is marked as [prev] for all three of @guile, @guile-devel and @guile-doc. But it is presumed [curr] as the source for @libguile14. (I found this while fiddling around trying to reduce [curr] + [prev] + [test] to fit on one CD.) It seems odd to me but I can think of reasons why what might be [prev] for one package might be [curr] for others. Please can the correct-ness of this be confirmed by the maintainer? Sorry, and thanks. Fergus -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Bug reporting: http://cygwin.com/bugs.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/
Re: Integrating Ralf's rebase into setup.exe
Hi all, relating to the this thread, which starts at http://www.cygwin.com/ml/cygwin-apps/2002-12/msg00021.html I have updated the rebase source with : - creates a static lib containing all needed objectfiles for RebaseImage() and friends. The library is named libimagehlp.a and the relating include file imagehlp.h. After checking out just call $ make imagehlp and the lib is created. - the debug message printing is conditionalized with an internal debug flag, so by default the code does not print any debug messages. Regards Ralf
Re: xinetd and chkconfig - ok to upload ?
On Mon, 30 Dec 2002, Charles Wilson wrote: > Short version: > as far as MY concerns go, these two packages are ok for upload. Ok, then :) I've just uploaded both packages. Sergey, please send the announcement in a couple of hours.
Re: exim 4.12-1
On Mon, 30 Dec 2002, Pierre A. Humblet wrote: > A new exim release is ready for upload > > http://home.attbi.com/~phumblet/setup.hint > http://home.attbi.com/~phumblet/exim-4.12-1.tar.bz2 > http://home.attbi.com/~phumblet/exim-4.12-1-src.tar.bz2 Uploaded. I've removed the files for version 4.10-1 of the package. Please, send an announcement in a couple of hours.
Re: [nasm packaging review] was Re: Pending packages status
> On Mon, 30 Dec 2002, Max Bowsher wrote: > >> I do think that a version number should uniquely identify a version, >> though. A possibility that was not considered last time this was >> discussed is to start the reviewing at -0.1, going -0.2, -0.3, etc., >> and then bump to -1 on release. >> >> Feel free to ignore me if you don't want to reopen this discussion. Pavel Tsekov wrote: > Hello, Max > > Just to let you know that I do not want to ignore your opinion, nor > do I want to ignore any other peoples' opinion. I just do not have > strong opinion on this topic. So, as far as I'm concerned I'm trying > to follow the instructions at http://cygwin.com/setup.html. If as a > result of a discussion on this list this instructions do change, I'll > follow the new instructions whatever they are. I'm sorry, I didn't mean to imply that I thought you or anyone else might treat my opinions unfairly. Quite the opposite in fact - that it would be fair to say that it's my fault for not paying sufficient attention to the discussion last month. I do feel that assigning individual version numbers to each change in the pre-release package would allow better cross-referencing of feedback during review, and that there is no need to reset the release number to 1 when released to the mirrors. I must agree, though, that this is not an issue of high importance. Max.
