Re: [ITP] znc 1.6.0
On Jul 30 23:34, Alexey Sokolov wrote: > >>> > - Forgive me for being pedantic, but who gave this a GTG? I couldn't > find one on this thread, and yet the package is up on the mirrors. > >>> > >>> I thought if the package exists in popular distros, no GTG needed? > >> > >> Uhm, no. The *votes* are not required, the GTG is. > >> > > > > Oops. Sorry then! > > > > Hi, > > Is there anything missing for GTG? > https://github.com/znc/znc-cygwin/tree/e80164ce0f463177fe8bd0c2adfce9e707495da8 > is the latest version with .dll.a (I didn't push to mirrors it yet) Oh sorry, I thought you already did push the packages. Can you please point us to wget'able package files? Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat pgpvaO9diZ61A.pgp Description: PGP signature
Re: [Attn Maintainer] stow
On Jul 31 17:30, Andrew Schulman wrote: > > None of this discussion should detract from the amazing job you've done in > > pulling this Perl update together. I hope you get several gold stars > > and/or > > plush hippos for all your work. > > Awarded! http://cygwin.com/goldstars/#AG I guess I should more often just disappear for a few days... :) Thanks to all of you. Thanks to Achim for pulling this through, thanks to Ken for pointing this out, thanks to Andrew for having the awards ready when they are most needed, and thanks to you other maintainers providing the required new packages. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat pgpT4GLtvvOQh.pgp Description: PGP signature
Re: [Attn Maintainer] amanda
On Jul 31 16:24, Yaakov Selkowitz wrote: > On Tue, 2015-07-28 at 09:05 +0200, Marco Atzeri wrote: > > for what I see Mark never updated the package after first release > > in Sept 2012 and never provided a 64 bit version. > > No, he did not. > > > The package is currently amanda-3.3.2-8 while upstream is at > > 3.3.7p1. > > > > I built during weekend the 3.3.7p1 (64bit and 32bit) version > > with perl 5.14 and it passes all the tests; > > if Mark does not show up I will upload a Perl 5.22 version. > > Mark has yet to respond to any messages regarding his packages (e.g. > libffi4 -> libffi6 rebuild). If you're interested in maintaining > amanda, it's yours, otherwise I'll remove it from the distro. I had contact via PM with Mark early 2015, but unfortunately nothing much happened. For the time being I set the package to orphaned. But, yes, I agree that we should remove it if nobody wants it. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat pgpCagaMdVu5q.pgp Description: PGP signature
Re: SSH key for upload access
Hi Marcos, On Aug 1 15:43, Marcos Vives Del Sol wrote: > Name: Marcos Vives Del Sol > Package: libnfc > BEGIN SSH2 PUBLIC KEY Your key is up. Are you going to upload the 64 bit version of libnfc? Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat pgpFXay0rBdgW.pgp Description: PGP signature
Re: [ITP] znc 1.6.0
03.08.2015 08:59, Corinna Vinschen пишет: > On Jul 30 23:34, Alexey Sokolov wrote: > >> - Forgive me for being pedantic, but who gave this a GTG? I couldn't >> find one on this thread, and yet the package is up on the mirrors. > > I thought if the package exists in popular distros, no GTG needed? Uhm, no. The *votes* are not required, the GTG is. >>> >>> Oops. Sorry then! >>> >> >> Hi, >> >> Is there anything missing for GTG? >> https://github.com/znc/znc-cygwin/tree/e80164ce0f463177fe8bd0c2adfce9e707495da8 >> is the latest version with .dll.a (I didn't push to mirrors it yet) > > Oh sorry, I thought you already did push the packages. Can you please > point us to wget'able package files? > I pushed some packages, but the version with .dll.a not yet. I thought that probably I should get GTG before pushing again. http://people.znc.in/~darthgandalf/znc/znc-cygwin/
Re: [ITP] znc 1.6.0
On Aug 3 10:02, Alexey Sokolov wrote: > 03.08.2015 08:59, Corinna Vinschen пишет: > > On Jul 30 23:34, Alexey Sokolov wrote: > > > >> - Forgive me for being pedantic, but who gave this a GTG? I couldn't > >> find one on this thread, and yet the package is up on the mirrors. > > > > I thought if the package exists in popular distros, no GTG needed? > > Uhm, no. The *votes* are not required, the GTG is. > > >>> > >>> Oops. Sorry then! > >>> > >> > >> Hi, > >> > >> Is there anything missing for GTG? > >> https://github.com/znc/znc-cygwin/tree/e80164ce0f463177fe8bd0c2adfce9e707495da8 > >> is the latest version with .dll.a (I didn't push to mirrors it yet) > > > > Oh sorry, I thought you already did push the packages. Can you please > > point us to wget'able package files? > > > > I pushed some packages, but the version with .dll.a not yet. > I thought that probably I should get GTG before pushing again. If that's the most noticable change, please go ahead and upload. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat pgpsXmCTc6XU_.pgp Description: PGP signature
Re: setup
I've just found out that MD5 checksums get parsed OK, but wind up as solid zeros in the package database in setup. I have no idea how this is even possible, since the exact same code works just fine for SHA512 checksums. I didn't check yet if this actually works in the release version of setup. An extra pair of eyeballs would be appreciated. I don't see how my changes could be responsible and I was sure I'd checked it before… :-( Also, I want to clean up the parser code a bit and fix a very old formatting bug found while debugging the problem with the MD5 checksums. Another thing: it seems that the SHA512 digest is checked for existence by checking that the first byte is non-zero. Is that actually a guarantee that the SHA2 standard makes or is it just very unlikely to encounter 0x00 as the first byte? Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ Factory and User Sound Singles for Waldorf Blofeld: http://Synth.Stromeko.net/Downloads.html#WaldorfSounds
Re: setup
Achim Gratz writes: > I've just found out that MD5 checksums get parsed OK, but wind up as > solid zeros in the package database in setup. I have no idea how this > is even possible, since the exact same code works just fine for SHA512 > checksums. I didn't check yet if this actually works in the release > version of setup. An extra pair of eyeballs would be appreciated. I > don't see how my changes could be responsible and I was sure I'd checked > it before… :-( Found it, I feel stupid now… > Also, I want to clean up the parser code a bit and fix a very old > formatting bug found while debugging the problem with the MD5 checksums. In preparation. > Another thing: it seems that the SHA512 digest is checked for existence > by checking that the first byte is non-zero. Is that actually a > guarantee that the SHA2 standard makes or is it just very unlikely to > encounter 0x00 as the first byte? If the SHA512 checksum is all zeros in the package DB it doesn't get checked, which is actually the reason I didn't catch the error earlier. Have to fix that also. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ SD adaptations for Waldorf Q V3.00R3 and Q+ V3.54R2: http://Synth.Stromeko.net/Downloads.html#WaldorfSDada
Re: setup
Here are the four patches to make setup work again.
>From c7ad9a642a51753344a841c1718efd963af82505 Mon Sep 17 00:00:00 2001
From: Achim Gratz
Date: Mon, 3 Aug 2015 20:15:51 +0200
Subject: [PATCH 1/4] Fix MD5sum.str () formatting bug
* csu_util/MD5Sum.cc (str): The stream modifiers are not sticky
and must be applied for each conversion.
---
ChangeLog | 5 +
csu_util/MD5Sum.cc | 4 ++--
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 7d14458..f8cd2b4 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2015-08-03 Achim Gratz
+
+ * csu_util/MD5Sum.cc (str): The stream modifiers are not sticky
+ and must be applied for each conversion.
+
2015-08-01 David Hoke
* download.cc (IncludeSource): New command line switch
diff --git a/csu_util/MD5Sum.cc b/csu_util/MD5Sum.cc
index 1d9c362..596089d 100644
--- a/csu_util/MD5Sum.cc
+++ b/csu_util/MD5Sum.cc
@@ -85,9 +85,9 @@ MD5Sum::str() const
{
std::ostringstream hexdigest;
- hexdigest << std::hex << std::setfill('0') << std::setw(2);
for (int i=0; i<16; ++i )
-hexdigest << static_cast(digest[i]);
+hexdigest << std::hex << std::setfill('0') << std::setw(2)
+ << static_cast(digest[i]);
return hexdigest.str();
}
--
2.4.6
>From 7faf6f57472ee0247c757f12aff56faf2c2c4919 Mon Sep 17 00:00:00 2001
From: Achim Gratz
Date: Mon, 3 Aug 2015 21:04:10 +0200
Subject: [PATCH 2/4] Fix bug in nibbled1 and use character types throughout
* ini.h (nibbled1): Fix a thinko in this macro that made the result always zero.
(hexnibble, nibbled1, b64url, b64d1, b64d2, b64d3): Make all
calculation constants dealing with characters character literals.
Remove trailing semicolons.
---
ChangeLog | 7 +++
ini.h | 20 ++--
2 files changed, 17 insertions(+), 10 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index f8cd2b4..ef3a733 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
2015-08-03 Achim Gratz
+ * ini.h (nibbled1): Fix a thinko in this macro that made the result always zero.
+ (hexnibble, nibbled1, b64url, b64d1, b64d2, b64d3): Make all
+ calculation constants dealing with characters character literals.
+ Remove trailing semicolons.
+
+2015-08-03 Achim Gratz
+
* csu_util/MD5Sum.cc (str): The stream modifiers are not sticky
and must be applied for each conversion.
diff --git a/ini.h b/ini.h
index 164e3d2..7f6db22 100644
--- a/ini.h
+++ b/ini.h
@@ -59,16 +59,16 @@ extern int yyerror_count; /* number of parse errors */
/* The following definitions are used in the parser implementation */
-#define hexnibble(val) (255 & (val > '9') ? val - 'a' + 10 : val - '0');
-#define nibbled1(v1,v2) (255 & ((v1 << 4) & v2));
+#define hexnibble(val) ('\xff' & (val > '9') ? val - 'a' + 10 : val - '0')
+#define nibbled1(v1,v2) ('\xff' & ((v1 << 4) | v2))
#define b64url(val) \
- (63 & (( val == '_') ? 63 \
- : (val == '-') ? 62 \
- : (val >= 'a') ? val - 'a' + 26 \
- : (val >= 'A') ? val - 'A' + 0 \
- :val - '0' + 52))
-#define b64d1(v1,v2,v3,v4) (255 & ((v1 << 2) | (v2 >> 4)));
-#define b64d2(v1,v2,v3,v4) (255 & ((v2 << 4) | (v3 >> 2)));
-#define b64d3(v1,v2,v3,v4) (255 & ((v3 << 6) | v4));
+ ('\x3f' & (( val == '_') ? '\x3f'\
+ : (val == '-') ? '\x3e'\
+ : (val >= 'a') ? val - 'a' + '\x1a' \
+ : (val >= 'A') ? val - 'A' + '\x00' \
+ :val - '0' + '\x34'))
+#define b64d1(v1,v2,v3,v4) ('\xff' & ((v1 << 2) | (v2 >> 4)))
+#define b64d2(v1,v2,v3,v4) ('\xff' & ((v2 << 4) | (v3 >> 2)))
+#define b64d3(v1,v2,v3,v4) ('\xff' & ((v3 << 6) | v4))
#endif /* SETUP_INI_H */
--
2.4.6
>From ffbee617a0943ef08d250b3d65a1a46a9b7fd9e1 Mon Sep 17 00:00:00 2001
From: Achim Gratz
Date: Mon, 3 Aug 2015 21:19:53 +0200
Subject: [PATCH 3/4] If MD5 checksum is missing then SHA512 must always be
checked
* install.cc (chksum_one): If MD5 checksum is not available, then
SHA512 must always be checked even if just against the zeroed
digest as initialized. Otherwise a package with no checksum would
be treated as valid.
---
ChangeLog | 7 +++
install.cc | 6 +++---
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index ef3a733..4d19736 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
2015-08-03 Achim Gratz
+ * install.cc (chksum_one): If MD5 checksum is not available, then
+ SHA512 must always be checked even if just against the zeroed
+ digest as initialized. Otherwise a package with no checksum would
+ be treated as valid.
+
+2015-08-03 Achim Gratz
+
* ini.h (nibbled1): Fix a thinko in this macro that made the result always zero.
(hexnibble, nibbled1, b64url, b64d1, b64d2, b64d3): Make all
calculation constants dealing with characters character literals.
diff --git a/install.cc b/install.cc
index 4274715..1e69564 100644
--- a/install.cc
+++ b/install.cc
@@ -1044,8 +1044,8 @@ chksum_one (const packagesource& pk
Re: setup
On Aug 3 22:02, Achim Gratz wrote: > > Here are the four patches to make setup work again. Trusting that you tested them, I only have a minor nit in terms of the ChangeLog: > * ini.h (nibbled1): Fix a thinko in this macro that made the result > always zero. line too long. > (hexnibble, nibbled1, b64url, b64d1, b64d2, b64d3): Make all > calculation constants dealing with characters character literals. characters character? :) Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat pgpFvvSziPonC.pgp Description: PGP signature
Re: setup
Corinna Vinschen writes: >> (hexnibble, nibbled1, b64url, b64d1, b64d2, b64d3): Make all >> calculation constants dealing with characters character literals. > > characters character? :) How'd you say that? Sorry, it's been a long day. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ Factory and User Sound Singles for Waldorf Q+, Q and microQ: http://Synth.Stromeko.net/Downloads.html#WaldorfSounds
Re: setup
On Aug 3 22:31, Achim Gratz wrote: > Corinna Vinschen writes: > >>(hexnibble, nibbled1, b64url, b64d1, b64d2, b64d3): Make all > >>calculation constants dealing with characters character literals. > > > > characters character? :) > > How'd you say that? Sorry, it's been a long day. Replace numerical constants with character literals. Alternatively, what about using UCHAR_MAX? Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat pgpgIQnrLjn0w.pgp Description: PGP signature
Re: setup
Corinna Vinschen writes: > Replace numerical constants with character literals. Sure, but only those that should represent characters. The shift lengths for instance need to be kept as integers. > Alternatively, what about using UCHAR_MAX? There's an implicit assumption that the character is 8bits wide, so using that constant seems to conceal that. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ Waldorf MIDI Implementation & additional documentation: http://Synth.Stromeko.net/Downloads.html#WaldorfDocs
Re: setup
Corinna Vinschen writes: > On Aug 3 22:02, Achim Gratz wrote: >> >> Here are the four patches to make setup work again. > > Trusting that you tested them, I only have a minor nit in terms of > the ChangeLog: Pushed. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ Factory and User Sound Singles for Waldorf Blofeld: http://Synth.Stromeko.net/Downloads.html#WaldorfSounds
