Re: cygport: Request a new feature in order to set owner/group names in packaged tarballs.
On Wed, 5 Aug 2020 20:34:24 +0100, Jon Turney > On 04/08/2020 21:49, Lemures Lemniscati via Cygwin-apps wrote: > > On Tue, 04 Aug 2020 19:02:35 +0200, ASSI > >> Lemures Lemniscati via Cygwin-apps writes: > >>> And a next one is for making BUILD_REQUIRES a single-line list in > >>> *src.hint files. > >> > >> … or just don't embed newlines. Since cygport is bash under the hood > >> you can do > >> > >> BUILD_REQUIRES+=" whatever" > >> > >> instead of wrapping lines. > > > > By squeezing white spaces, we can save some characters in *.cygport > > files :). And new maintainers can avoid an issue relating newlines in > > BUILD_REQUIRES without knowing it (I was trapped in it once). > Yes, this would be nice. > > However, I think there is a consistency problem here, as other variables > which should only produce a single line in the .hint file (e.g. REQUIRES, > etc.) don't get whitespace canonicalized (as least, that's how it seemed to > me when I briefly looked at this). > > Thanks for the patch. Thank you for reviewing. It would be easy to canonicalize through a functiion like __single_line_list () in the commit https://github.com/cygwin-lem/cygport/commit/7607782d3d1972aef6b88ee32f5211f21abbbcfb I'll check later for 'category:', 'requires:', 'obsoletes:', 'provides:', and 'conflicts:'. Any other field to be checked for canonicalization? -- Lem
Re: cygport: Request a new feature in order to set owner/group names in packaged tarballs.
On Wed, 05 Aug 2020 20:31:33 +0200, ASSI > Lemures Lemniscati via Cygwin-apps writes: > > I've simplified options to Simplify options to CYGPORT_TAR_OPTS and > > CYGPORT_TAR_EXT. > > You've also removed the possibility to invoke tar with a different > environment, which you must do if you want to control the compression > parameters. You would now need to introduce another configuration > variable for if you wanted to keep that ability… > Do you mean controlling with '-I' or '--use-compress-program='? (And I didn't know these options of tar... oh.) from 'man tar' -I, --use-compress-program=COMMAND Filter data through COMMAND. It must accept the -d option, for decompression. The argument can contain command line options. from 'man tar' Because these options can take a space-containing parameter, I guess I understand that we would need another variable, as you write. Regards, Lem
Re: cygport: Request a new feature in order to set owner/group names in packaged tarballs.
On 04/08/2020 21:49, Lemures Lemniscati via Cygwin-apps wrote: On Tue, 04 Aug 2020 19:02:35 +0200, ASSI Lemures Lemniscati via Cygwin-apps writes: And a next one is for making BUILD_REQUIRES a single-line list in *src.hint files. … or just don't embed newlines. Since cygport is bash under the hood you can do BUILD_REQUIRES+=" whatever" instead of wrapping lines. By squeezing white spaces, we can save some characters in *.cygport files :). And new maintainers can avoid an issue relating newlines in BUILD_REQUIRES without knowing it (I was trapped in it once). Yes, this would be nice. However, I think there is a consistency problem here, as other variables which should only produce a single line in the .hint file (e.g. REQUIRES, etc.) don't get whitespace canonicalized (as least, that's how it seemed to me when I briefly looked at this). Thanks for the patch.
Re: cygport: Request a new feature in order to set owner/group names in packaged tarballs.
Lemures Lemniscati via Cygwin-apps writes: > I've simplified options to Simplify options to CYGPORT_TAR_OPTS and > CYGPORT_TAR_EXT. You've also removed the possibility to invoke tar with a different environment, which you must do if you want to control the compression parameters. You would now need to introduce another configuration variable for if you wanted to keep that ability… Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ SD adaptations for KORG EX-800 and Poly-800MkII V0.9: http://Synth.Stromeko.net/Downloads.html#KorgSDada
