Re: gnulib m4/threadlib.m4 bug crashing package tests
Brian Inglis writes: > The problem with Cygwin weak symbols is apparently that ld expects > there to be a runtime dynamic loader to resolve NULL weak dynamic > library references, but unlike ELF neither Cygwin nor Windows does so, > and PE may not retain the information to do so, or this project would > likely have done so. No, that part is well understood since more than a decade when that problem first hit, the actual problem is that such symbols no longer resolve to 0x0 on 64bit. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ SD adaptations for Waldorf Q V3.00R3 and Q+ V3.54R2: http://Synth.Stromeko.net/Downloads.html#WaldorfSDada
Re: [ATTN MAINTAINER] openssh
Corinna Vinschen via Cygwin-apps writes: > On Nov 28 10:53, Achim Gratz wrote: >> Achim Gratz writes: >> > These patches work for 32bit also and I believe they are correct, but >> > that build should not be made available due to a bug in libfido2 that >> > crashes when trying to free the memory associated with the WebAuthn >> > payload returned. Without these patches applied you can still use the >> > fallback to USB-HID when you are an administrator. >> >> The call into WebAuthn completely messes up the stack apparently. The >> returned object looks OK once you realize it is a version 1 and thus the >> extension fields are bogus, but the whole thing crashes if you do just >> one more call. Gdb session: >> >> https://paste.c-net.org/SerumLoser >> >> Any ideas what that might be? > > For the bystanders, on a hunch I created a libfido2 patch to change > the calling convention for the dynamically loaded windows functions. > Let's see if Achim's testing now succeeds on 32 bit... It does, your hunches are _that_ good. :-) So, once the new libfido2 hits the release area you can pull in the OpenSSH patches and re-release that to take advantage of the now correctly working Webauthn suppport. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ Factory and User Sound Singles for Waldorf Q+, Q and microQ: http://Synth.Stromeko.net/Downloads.html#WaldorfSounds
Re: gnulib m4/threadlib.m4 bug crashing package tests
Ken Brown via Cygwin-apps writes: > You're right, I was wrong. Here's the gnulib test program for anyone > else who wants to look at this: > > #include > #pragma weak fputs > int main () > { > return (fputs == NULL); > } > > As you said, this used to return 1, but now it returns 0 on 64-bit. The root cause of this mystery is almost surely in binutils, this area was touched when they moved the default base address past the 4GiB boundary (obviously that's a 64bit only change and it only affects PE targets). I still have to figure out if I need to pull in a patch from after the release or revert commits that went into 2.37. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ Wavetables for the Terratec KOMPLEXER: http://Synth.Stromeko.net/Downloads.html#KomplexerWaves
Re: [ATTN MAINTAINER] openssh
On Nov 28 10:53, Achim Gratz wrote: > Achim Gratz writes: > > These patches work for 32bit also and I believe they are correct, but > > that build should not be made available due to a bug in libfido2 that > > crashes when trying to free the memory associated with the WebAuthn > > payload returned. Without these patches applied you can still use the > > fallback to USB-HID when you are an administrator. > > The call into WebAuthn completely messes up the stack apparently. The > returned object looks OK once you realize it is a version 1 and thus the > extension fields are bogus, but the whole thing crashes if you do just > one more call. Gdb session: > > https://paste.c-net.org/SerumLoser > > Any ideas what that might be? For the bystanders, on a hunch I created a libfido2 patch to change the calling convention for the dynamically loaded windows functions. Let's see if Achim's testing now succeeds on 32 bit... Corinna