Re: fuse

2022-04-13 Thread Jon Turney

On 01/02/2022 06:20, ASSI wrote:

Mark Geisert writes:

I see that 'mtr' is another Cygwin package that makes use of a Windows
driver via libpcap.  Maybe I can use mtr.cygport etc as a guide; I'm
unsure whether a Cygwin package should be including Windows drivers.


No they should not, although there is at least one other package (libusb
IIRC) that requires non-standard Windows drivers for functioning fully
or correctly.  How to present that requirement in setup is another
question.


The 'message:' line in the .hint file (see [1]) can be used for a 
related purpose of telling people that Windows drivers are needed, 
although in fact this is only used by libusb0 at the moment.


Actually checking for those being installed generically in setup seems 
fraught.  But I guess you could write a postinstall script which checks 
somehow for it's presence and fails if it's not present?


[1] https://cygwin.com/packaging-hint-files.html


Re: [PATCH cygport v3] autotools.cygclass: correctly detect Autoconf 2.70+

2022-04-13 Thread Jon Turney

On 14/03/2022 22:15, Adam Dinwoodie wrote:

The latest version of Autoconf is 2.71, but the version detection
incorrectly considers 2.70 and higher as being the same as 2.59 and
lower for the purposes of specifying documentation directories.  Correct
that, and make the version detection a bit more future-proof by parsing
out the actual version parts and performing numeric comparison.

While we're at it, add a bit more commentary explaining the intent of
the different behaviour over the different Autoconf versions.


I applied this.

But it seems no good deed goes unpunished...


configure="${confdir}/configure"
-   confver=$(grep -m 1 'GNU Autoconf' ${configure} | cut -d ' ' -f 6)
+   confver="$("$configure" --version | sed -rn 's/.*GNU Autoconf 
([0-9\.]+)/\1/p')"
+   confver_maj=${confver%%.*}
+   confver_min=${confver##*.}
+   if [ $confver_maj -ne 2 ]
+   then
+   error "unexpected autoconf version";
+   fi


When rebuilding 'dialog' to update the SRC_URI, I get:


/usr/share/cygport/cygclass/autotools.cygclass: line 658: [: -ne: unary 
operator expected
/usr/share/cygport/cygclass/autotools.cygclass: line 689: [: -ge: unary 
operator expected
/usr/share/cygport/cygclass/autotools.cygclass: line 703: [: -ge: unary 
operator expected


It seems that the configure script for that it customized somehow and 
doesn't output anything matching that regex:



$ ./configure --version

Copyright 2003-2020,2021Thomas E. Dickey
Copyright 1992, 1993, 1994, 1995, 1996, 1998, 1999, 2000, 2001
Free Software Foundation, Inc.
This configure script is free software; the Free Software Foundation
gives unlimited permission to copy, distribute and modify it.


I think that if $confver is empty, that should be an error, and then 
perhaps there needs to be a variable which can be set to override 
autodection of the ./configure script version (e.g. something like 
'CONF_VERSION=2.60')




Re: [PATCH cygport] xorg.cygclass: Allow configuration of default SRC_URI compression

2022-04-13 Thread Jon Turney

On 12/04/2022 01:41, Yaakov Selkowitz wrote:

On Mon, 2022-04-11 at 13:58 +0100, Jon Turney wrote:

Historically, xorg packages were usually provided as .gz and .bz2
compressed tarballs.  The current trend is to no longer provide .bz2,
but .gz and .xz instead.  Allow the compression to be configured, with a
backwards compatible default.


If all or even most current packages use .xz, then maybe just default to that
and define XORG_SRC_COMPRESSION for the (current) exceptions?


Yeah, I went back and forth on what the default should be here.

It's only most packages, since it relies on someone remembering to 
change the compressions in AM_INIT_AUTOMAKE, which sometimes hasn't 
happened.


Changing the default changes the meaning of old .cygport files in a way 
that probably breaks them.