Re: [ITP] gflags 2.2.2
On 04/12/2023 11:01, Daisuke Fujimura via Cygwin-apps wrote: Thank you for your review. I will merge the documentation and scripts into the runtime package. gflags.cygport diff : https://cygwin.com/cgit/cygwin-packages/playground/commit/?id=3d92ec96da0cfb58ffee465eb65eec2f0b923f19 CI : https://github.com/cygwin/scallywag/actions/runs/7085452227 That looks fine. Thanks!
Re: [ITP] gflags 2.2.2
Thank you for your review. I will merge the documentation and scripts into the runtime package. gflags.cygport diff : https://cygwin.com/cgit/cygwin-packages/playground/commit/?id=3d92ec96da0cfb58ffee465eb65eec2f0b923f19 CI : https://github.com/cygwin/scallywag/actions/runs/7085452227 On Mon, Dec 4, 2023 at 12:06 AM Jon Turney wrote: > > On 25/11/2023 08:55, Daisuke Fujimura via Cygwin-apps wrote: > >> The one question I have is about what 'gflags_completions.sh' is for? Is > >> this a helper for scripts other packages using gflags might install in > >> /etc/bash_completion.d/, or an example? or generally useful? > > > > gflags_completions.sh is a script that generates completions for > > options supported by gflags. > > > > - > > https://stackoverflow.com/questions/32555861/how-to-get-bash-tab-completions-for-your-own-project-with-gflags > > > > Also, since major distributions such as arch and fedora include this > > script in their packages, we decided it would be better to include it > > in the cygwin package as well. > > > > - https://archlinux.org/packages/extra/x86_64/gflags/files/ > > - https://src.fedoraproject.org/rpms/gflags/blob/rawhide/f/gflags.spec > > > > However, perhaps this should be included in runtime or development. > > Thanks. That makes perfect sense. > > Yeah, it seems like perhaps it should be with the runtime, I think. >
Re: [ITP] gflags 2.2.2
On 25/11/2023 08:55, Daisuke Fujimura via Cygwin-apps wrote: The one question I have is about what 'gflags_completions.sh' is for? Is this a helper for scripts other packages using gflags might install in /etc/bash_completion.d/, or an example? or generally useful? gflags_completions.sh is a script that generates completions for options supported by gflags. - https://stackoverflow.com/questions/32555861/how-to-get-bash-tab-completions-for-your-own-project-with-gflags Also, since major distributions such as arch and fedora include this script in their packages, we decided it would be better to include it in the cygwin package as well. - https://archlinux.org/packages/extra/x86_64/gflags/files/ - https://src.fedoraproject.org/rpms/gflags/blob/rawhide/f/gflags.spec However, perhaps this should be included in runtime or development. Thanks. That makes perfect sense. Yeah, it seems like perhaps it should be with the runtime, I think.
Re: [ITP] gflags 2.2.2
> The one question I have is about what 'gflags_completions.sh' is for? Is > this a helper for scripts other packages using gflags might install in > /etc/bash_completion.d/, or an example? or generally useful? gflags_completions.sh is a script that generates completions for options supported by gflags. - https://stackoverflow.com/questions/32555861/how-to-get-bash-tab-completions-for-your-own-project-with-gflags Also, since major distributions such as arch and fedora include this script in their packages, we decided it would be better to include it in the cygwin package as well. - https://archlinux.org/packages/extra/x86_64/gflags/files/ - https://src.fedoraproject.org/rpms/gflags/blob/rawhide/f/gflags.spec However, perhaps this should be included in runtime or development. On Tue, Nov 21, 2023 at 2:13 AM Jon Turney wrote: > > On 16/11/2023 23:20, Daisuke Fujimura via Cygwin-apps wrote: > > Hello, > > > > [ITP] A new package proposal: gflags > > > > - gflags > > - libgflags2.2 > > - libgflags-devel > > > > > > > > SUMMARY: Commandline flags module for C++ > > HOMEPAGE: https://github.com/gflags/gflags > > SRC_URI: https://github.com/gflags/gflags/archive/refs/tags/v2.2.2.tar.gz > > LICENSE: BSD-3-Clause > > > > > > > > Corresponding Linux/Unix packages are searched: > > - https://repology.org/project/gflags/versions > > > > Cygportfile: > > - > > https://cygwin.com/git-cygwin-packages/?p=git/cygwin-packages/playground.git;a=shortlog;h=refs/heads/gflags > > > > Packages, logs: > > - https://github.com/cygwin/scallywag/actions/runs/6893072156 > > > > Looks good. > > I've added this to your packages. > > The one question I have is about what 'gflags_completions.sh' is for? Is > this a helper for scripts other packages using gflags might install in > /etc/bash_completion.d/, or an example? or generally useful? >
Re: [ITP] gflags 2.2.2
On 16/11/2023 23:20, Daisuke Fujimura via Cygwin-apps wrote: Hello, [ITP] A new package proposal: gflags - gflags - libgflags2.2 - libgflags-devel SUMMARY: Commandline flags module for C++ HOMEPAGE: https://github.com/gflags/gflags SRC_URI: https://github.com/gflags/gflags/archive/refs/tags/v2.2.2.tar.gz LICENSE: BSD-3-Clause Corresponding Linux/Unix packages are searched: - https://repology.org/project/gflags/versions Cygportfile: - https://cygwin.com/git-cygwin-packages/?p=git/cygwin-packages/playground.git;a=shortlog;h=refs/heads/gflags Packages, logs: - https://github.com/cygwin/scallywag/actions/runs/6893072156 Looks good. I've added this to your packages. The one question I have is about what 'gflags_completions.sh' is for? Is this a helper for scripts other packages using gflags might install in /etc/bash_completion.d/, or an example? or generally useful?
[ITP] gflags 2.2.2
Hello, [ITP] A new package proposal: gflags - gflags - libgflags2.2 - libgflags-devel SUMMARY: Commandline flags module for C++ HOMEPAGE: https://github.com/gflags/gflags SRC_URI: https://github.com/gflags/gflags/archive/refs/tags/v2.2.2.tar.gz LICENSE: BSD-3-Clause Corresponding Linux/Unix packages are searched: - https://repology.org/project/gflags/versions Cygportfile: - https://cygwin.com/git-cygwin-packages/?p=git/cygwin-packages/playground.git;a=shortlog;h=refs/heads/gflags Packages, logs: - https://github.com/cygwin/scallywag/actions/runs/6893072156