Re: [PATCH setup] Add --allow-test-versions

2021-04-26 Thread Jon Turney

On 23/04/2021 14:11, David Allsopp via Cygwin-apps wrote:

Jon Turney wrote:

On 20/04/2021 15:37, David Allsopp via Cygwin-apps wrote:

Attached adds -t/--allow-test-packages to Setup which controls the
initial state of the "Test" checkbox.

Motivation is to allow one CI cron job to be installing test versions
of packages, then we can help identify things like [1] before they're

released.

Nice.  Thanks.


+static BoolOption AllowTestOption (false, 't', "allow-test-packages",
+"Permit installation of package versions marked test");


The only quibble I have is the help text here.  The user has always been
permitted to choose test packages, this checkbox allows setup to decide to
use them itself.

So maybe something like "Consider package versions marked test".


No problem - see attached.



Thanks for producing an updated patch!


RE: [PATCH setup] Add --allow-test-versions

2021-04-23 Thread David Allsopp via Cygwin-apps
Jon Turney wrote:
> On 20/04/2021 15:37, David Allsopp via Cygwin-apps wrote:
> > Attached adds -t/--allow-test-packages to Setup which controls the
> > initial state of the "Test" checkbox.
> >
> > Motivation is to allow one CI cron job to be installing test versions
> > of packages, then we can help identify things like [1] before they're
> released.
> 
> Nice.  Thanks.
> 
> > +static BoolOption AllowTestOption (false, 't', "allow-test-packages",
> > +"Permit installation of package versions marked test");
> 
> The only quibble I have is the help text here.  The user has always been
> permitted to choose test packages, this checkbox allows setup to decide to
> use them itself.
> 
> So maybe something like "Consider package versions marked test".

No problem - see attached.

All best,


David


0001-Add-allow-test-packages.patch
Description: 0001-Add-allow-test-packages.patch


Re: [PATCH setup] Add --allow-test-versions

2021-04-23 Thread Jon Turney

On 20/04/2021 15:37, David Allsopp via Cygwin-apps wrote:

Attached adds -t/--allow-test-packages to Setup which controls the initial
state of the "Test" checkbox.

Motivation is to allow one CI cron job to be installing test versions of
packages, then we can help identify things like [1] before they're released.


Nice.  Thanks.


+static BoolOption AllowTestOption (false, 't', "allow-test-packages", "Permit 
installation of package versions marked test");


The only quibble I have is the help text here.  The user has always been 
permitted to choose test packages, this checkbox allows setup to decide 
to use them itself.


So maybe something like "Consider package versions marked test".


[PATCH setup] Add --allow-test-versions

2021-04-20 Thread David Allsopp via Cygwin-apps
Attached adds -t/--allow-test-packages to Setup which controls the initial
state of the "Test" checkbox.

Motivation is to allow one CI cron job to be installing test versions of
packages, then we can help identify things like [1] before they're released.


David


[1] https://cygwin.com/pipermail/cygwin/2021-April/248300.html


0001-Add-allow-test-packages.patch
Description: Binary data