RE: [Patch] setup source page should use command-line option over last selected
Dave Korn wrote on Thursday, January 19, 2006 6:25 PM: Thrall, Bryan wrote: Dave Korn wrote on Thursday, January 19, 2006 12:45 PM: Christopher Faylor wrote: So, since there is now this unbelievable consensus and good will could someone check in the patch? cgf Well, I haven't tested it yet, so if nobody else does so first, I'll build it and test it after I get home from work this evening and check it in. But I'd never check in something I hadn't personally verified that, at the very least, everything still compiles. (Generally I'd like to do even a bit more testing than that) cheers, DaveK Cool, and thanks! 'k, I've built setup and verified the bug exists as described; I've read the patch and the code it applies to and it looks sane and logically valid to me; I've applied the patch and rebuilt the code and it applied and built without warnings and I've tested the result and the bug is indeed fixed as it should be! So all we need now is a ChangeLog entry please Byran! cheers, DaveK Oh yeah. Here you go: == 2006-01-20 Bryan Thrall [EMAIL PROTECTED] * source.cc (SourcePage::OnActivate): Command line takes precedence over last user selection. -- Bryan Thrall FlightSafety International [EMAIL PROTECTED]
RE: [Patch] setup source page should use command-line option over last selected
Thrall, Bryan wrote: So all we need now is a ChangeLog entry please Byran! Oh yeah. Here you go: Applied: http://cygwin.com/ml/cygwin-apps-cvs/2006-q1/msg1.html Thanks for your contribution! cheers, DaveK -- Can't think of a witty .sigline today
RE: [Patch] setup source page should use command-line option over last selected
Dave Korn wrote on Friday, January 20, 2006 9:18 AM: Thrall, Bryan wrote: So all we need now is a ChangeLog entry please Byran! Oh yeah. Here you go: Applied: http://cygwin.com/ml/cygwin-apps-cvs/2006-q1/msg1.html Thanks for your contribution! cheers, DaveK Thanks! -- Bryan Thrall FlightSafety International [EMAIL PROTECTED]
RE: [Patch] setup source page should use command-line option over last selected
Thrall, Bryan wrote: Thrall, Bryan wrote on Thursday, January 12, 2006 1:17 PM: Setup.exe currently (based on CVS HEAD) uses the last selected option from the Source page instead of the command line option (if it is present). For example, if the user selected Download without installing the last time they ran setup, then that will be selected the next time setup runs regardless of the command line. To reproduce: 1) Run 'setup.exe' and on the Choose Download Source page, select (for example) Download without installing. Click next, then cancel. 2) Run 'setup.exe -L' and go to the Choose Download Source page. Install from local directory should be selected, but Download without installing still is. The attached patch should fix this. *ping* Am I wrong in thinking that the command line options should override the last user-choice? Thanks, *pong* Of course you aren't wrong in thinking that the command line options should override the last user-choice! You're welcome! cheers, DaveK -- Can't think of a witty .sigline today
Re: [Patch] setup source page should use command-line option over last selected
On Thu, Jan 19, 2006 at 10:44:56AM -, Dave Korn wrote: Thrall, Bryan wrote: Thrall, Bryan wrote on Thursday, January 12, 2006 1:17 PM: Setup.exe currently (based on CVS HEAD) uses the last selected option from the Source page instead of the command line option (if it is present). For example, if the user selected Download without installing the last time they ran setup, then that will be selected the next time setup runs regardless of the command line. To reproduce: 1) Run 'setup.exe' and on the Choose Download Source page, select (for example) Download without installing. Click next, then cancel. 2) Run 'setup.exe -L' and go to the Choose Download Source page. Install from local directory should be selected, but Download without installing still is. The attached patch should fix this. *ping* Am I wrong in thinking that the command line options should override the last user-choice? Thanks, *pong* Of course you aren't wrong in thinking that the command line options should override the last user-choice! You're welcome! So, since there is now this unbelievable consensus and good will could someone check in the patch? cgf
RE: [Patch] setup source page should use command-line option over last selected
Dave Korn wrote on Thursday, January 19, 2006 12:45 PM: Christopher Faylor wrote: So, since there is now this unbelievable consensus and good will could someone check in the patch? cgf Well, I haven't tested it yet, so if nobody else does so first, I'll build it and test it after I get home from work this evening and check it in. But I'd never check in something I hadn't personally verified that, at the very least, everything still compiles. (Generally I'd like to do even a bit more testing than that) cheers, DaveK Cool, and thanks! -- Bryan Thrall FlightSafety International [EMAIL PROTECTED]
RE: [Patch] setup source page should use command-line option over last selected
Thrall, Bryan wrote: Dave Korn wrote on Thursday, January 19, 2006 12:45 PM: Christopher Faylor wrote: So, since there is now this unbelievable consensus and good will could someone check in the patch? cgf Well, I haven't tested it yet, so if nobody else does so first, I'll build it and test it after I get home from work this evening and check it in. But I'd never check in something I hadn't personally verified that, at the very least, everything still compiles. (Generally I'd like to do even a bit more testing than that) cheers, DaveK Cool, and thanks! 'k, I've built setup and verified the bug exists as described; I've read the patch and the code it applies to and it looks sane and logically valid to me; I've applied the patch and rebuilt the code and it applied and built without warnings and I've tested the result and the bug is indeed fixed as it should be! So all we need now is a ChangeLog entry please Byran! cheers, DaveK -- Can't think of a witty .sigline today
RE: [Patch] setup source page should use command-line option over last selected
Thrall, Bryan wrote on Thursday, January 12, 2006 1:17 PM: Setup.exe currently (based on CVS HEAD) uses the last selected option from the Source page instead of the command line option (if it is present). For example, if the user selected Download without installing the last time they ran setup, then that will be selected the next time setup runs regardless of the command line. To reproduce: 1) Run 'setup.exe' and on the Choose Download Source page, select (for example) Download without installing. Click next, then cancel. 2) Run 'setup.exe -L' and go to the Choose Download Source page. Install from local directory should be selected, but Download without installing still is. The attached patch should fix this. *ping* Am I wrong in thinking that the command line options should override the last user-choice? Thanks, -- Bryan Thrall FlightSafety International [EMAIL PROTECTED]
[Patch] setup source page should use command-line option over last selected
Setup.exe currently (based on CVS HEAD) uses the last selected option from the Source page instead of the command line option (if it is present). For example, if the user selected Download without installing the last time they ran setup, then that will be selected the next time setup runs regardless of the command line. To reproduce: 1) Run 'setup.exe' and on the Choose Download Source page, select (for example) Download without installing. Click next, then cancel. 2) Run 'setup.exe -L' and go to the Choose Download Source page. Install from local directory should be selected, but Download without installing still is. The attached patch should fix this. -- Bryan Thrall FlightSafety International [EMAIL PROTECTED] setup.patch Description: setup.patch
