Re: [ITP] alure 1.2

2016-10-24 Thread Jon Turney 

On 18/10/2016 01:06, Bastian Germann wrote:

This is actually a bug (different variable names in FindFLAC.cmake and
CMakeLists.txt) that was fixed implicitly upstream with
http://repo.or.cz/alure.git/commit/6934c17f9ace7fc19ea94623dab0a4b37d11a879

I added a patch for v1.2 and also included support for fluidsynth. Now
all dependencies that are available in the Cygwin repos are built.


Package looks good to me.

Can you provide a ssh key as per 
https://sourceware.org/cygwin-apps/package-upload.html?

Re: [ITP] alure 1.2

2016-10-17 Thread Bastian Germann 
This is actually a bug (different variable names in FindFLAC.cmake and
CMakeLists.txt) that was fixed implicitly upstream with
http://repo.or.cz/alure.git/commit/6934c17f9ace7fc19ea94623dab0a4b37d11a879

I added a patch for v1.2 and also included support for fluidsynth. Now
all dependencies that are available in the Cygwin repos are built.

Re: [ITP] alure 1.2

2016-10-17 Thread Bastian Germann 
2016-10-17 21:38 GMT+02:00 Ken Brown :
> That happens because DYNLOAD is not defined.  If you build with DYNLOAD
> defined, it links fine.  There is one glitch that has to be fixed when you
> do that.  The build detects windows.h and then doesn't include dlfcn.h.
> [See main.h, lines 17--31.]  So I edited CMakeLists.txt so as to trick the
> build into not defining HAVE_WINDOWS_H.  I don't know enough about cmake to
> know the right way to handle this.
>
> Ken

The problem with using DYNLOAD is that the loaded file names would
have to be patched.
And if there is an alure 1.x release, DYNLOAD will be removed as of
changeset 
http://repo.or.cz/alure.git/commit/6b74198a7fea2989a6da16c3e310f76f4b2aac97

I updated the packages according to Marco's suggestions and will
further investigate the FLAC issue.

Re: [ITP] alure 1.2

2016-10-17 Thread Ken Brown 

On 10/17/2016 9:41 AM, Bastian Germann wrote:

Am 16.10.2016 um 23:30 schrieb Marco Atzeri:

Any reason to not add FLAC (Free Lossless Audio Codec)
dependency ?


Yes, there is a reason: The symbols used from FLAC/stream_decoder.h
cannot be linked:

[ 70%] Linking CXX shared library cygalure-1.dll
CMakeFiles/alure.dir/src/codec_flac.o: In function
`flacStream::GetLength()':
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:160: undefined reference
to `FLAC__stream_decoder_get_total_samples'
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:160:(.text$_ZN10flacStream9GetLengthEv[_ZN10flacStream9GetLengthEv]+0x5):
relocation truncated to fit: R_X86_64_PC32 against undefined symbol
`FLAC__stream_decoder_get_total_samples'
CMakeFiles/alure.dir/src/codec_flac.o: In function `flacStream::Rewind()':
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:148: undefined reference
to `FLAC__stream_decoder_seek_absolute'
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:148:(.text$_ZN10flacStream6RewindEv[_ZN10flacStream6RewindEv]+0xf):
relocation truncated to fit: R_X86_64_PC32 against undefined symbol
`FLAC__stream_decoder_seek_absolute'
CMakeFiles/alure.dir/src/codec_flac.o: In function
`flacStream::GetData(unsigned char*, unsigned int)':
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:138: undefined reference
to `FLAC__stream_decoder_process_single'
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:138:(.text$_ZN10flacStream7GetDataEPhj[_ZN10flacStream7GetDataEPhj]+0x73):
relocation truncated to fit: R_X86_64_PC32 against undefined symbol
`FLAC__stream_decoder_process_single'
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:139: undefined reference
to `FLAC__stream_decoder_get_state'
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:139:(.text$_ZN10flacStream7GetDataEPhj[_ZN10flacStream7GetDataEPhj]+0x8a):
relocation truncated to fit: R_X86_64_PC32 against undefined symbol
`FLAC__stream_decoder_get_state'
CMakeFiles/alure.dir/src/codec_flac.o: In function
`flacStream::~flacStream()':
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:191: undefined reference
to `FLAC__stream_decoder_finish'
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:191:(.text$_ZN10flacStreamD1Ev[_ZN10flacStreamD1Ev]+0x1d):
relocation truncated to fit: R_X86_64_PC32 against undefined symbol
`FLAC__stream_decoder_finish'
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:192: undefined reference
to `FLAC__stream_decoder_delete'
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:192:(.text$_ZN10flacStreamD1Ev[_ZN10flacStreamD1Ev]+0x26):
relocation truncated to fit: R_X86_64_PC32 against undefined symbol
`FLAC__stream_decoder_delete'
CMakeFiles/alure.dir/src/codec_flac.o: In function
`flacStream::~flacStream()':
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:191: undefined reference
to `FLAC__stream_decoder_finish'
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:191:(.text$_ZN10flacStreamD0Ev[_ZN10flacStreamD0Ev]+0x1d):
relocation truncated to fit: R_X86_64_PC32 against undefined symbol
`FLAC__stream_decoder_finish'
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:192: undefined reference
to `FLAC__stream_decoder_delete'
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:192:(.text$_ZN10flacStreamD0Ev[_ZN10flacStreamD0Ev]+0x26):
relocation truncated to fit: R_X86_64_PC32 against undefined symbol
`FLAC__stream_decoder_delete'
CMakeFiles/alure.dir/src/codec_flac.o: In function
`flacStream::flacStream(std::istream*)':
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:169: undefined reference
to `FLAC__stream_decoder_new'
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:169:(.text$_ZN11DecoderDeclI10flacStreamLi1EE7FactoryEPSi[_ZN11DecoderDeclI10flacStreamLi1EE7FactoryEPSi]+0xb0):
relocation truncated to fit: R_X86_64_PC32 against undefined symbol
`FLAC__stream_decoder_new'
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:172: undefined reference
to `FLAC__stream_decoder_init_stream'
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:172:(.text$_ZN11DecoderDeclI10flacStreamLi1EE7FactoryEPSi[_ZN11DecoderDeclI10flacStreamLi1EE7FactoryEPSi]+0x117):
relocation truncated to fit: R_X86_64_PC32 against undefined symbol
`FLAC__stream_decoder_init_stream'
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:182: undefined reference
to `FLAC__stream_decoder_delete'
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:182:(.text$_ZN11DecoderDeclI10flacStreamLi1EE7FactoryEPSi[_ZN11DecoderDeclI10flacStreamLi1EE7FactoryEPSi]+0x128):
additional relocation overflows omitted from the output
CMakeFiles/alure.dir/src/codec_flac.o: In function `flacStream::InitFlac()':
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:209: undefined reference
to `FLAC__stream_decoder_process_single'
CMakeFiles/alure.dir/src/codec_flac.o: In function
`flacStream::flacStream(std::istream*)':
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:180: undefined reference
to `FLAC__stream_decoder_finish'
CMakeFiles/alure.dir/src/codec_flac.o: In function `flacStream::InitFlac()':
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:210: undefined reference
to `FLAC__stream_decoder_get_state'

Re: [ITP] alure 1.2

2016-10-17 Thread Bastian Germann 
Am 16.10.2016 um 23:30 schrieb Marco Atzeri:
> However I suggest to not build the static library
> and to install only the shared one, as this is the default
> on cygwin.

Ok.

> Any reason to not add FLAC (Free Lossless Audio Codec)
> dependency ?

Yes, there is a reason: The symbols used from FLAC/stream_decoder.h
cannot be linked:

[ 70%] Linking CXX shared library cygalure-1.dll
CMakeFiles/alure.dir/src/codec_flac.o: In function
`flacStream::GetLength()':
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:160: undefined reference
to `FLAC__stream_decoder_get_total_samples'
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:160:(.text$_ZN10flacStream9GetLengthEv[_ZN10flacStream9GetLengthEv]+0x5):
relocation truncated to fit: R_X86_64_PC32 against undefined symbol
`FLAC__stream_decoder_get_total_samples'
CMakeFiles/alure.dir/src/codec_flac.o: In function `flacStream::Rewind()':
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:148: undefined reference
to `FLAC__stream_decoder_seek_absolute'
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:148:(.text$_ZN10flacStream6RewindEv[_ZN10flacStream6RewindEv]+0xf):
relocation truncated to fit: R_X86_64_PC32 against undefined symbol
`FLAC__stream_decoder_seek_absolute'
CMakeFiles/alure.dir/src/codec_flac.o: In function
`flacStream::GetData(unsigned char*, unsigned int)':
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:138: undefined reference
to `FLAC__stream_decoder_process_single'
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:138:(.text$_ZN10flacStream7GetDataEPhj[_ZN10flacStream7GetDataEPhj]+0x73):
relocation truncated to fit: R_X86_64_PC32 against undefined symbol
`FLAC__stream_decoder_process_single'
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:139: undefined reference
to `FLAC__stream_decoder_get_state'
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:139:(.text$_ZN10flacStream7GetDataEPhj[_ZN10flacStream7GetDataEPhj]+0x8a):
relocation truncated to fit: R_X86_64_PC32 against undefined symbol
`FLAC__stream_decoder_get_state'
CMakeFiles/alure.dir/src/codec_flac.o: In function
`flacStream::~flacStream()':
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:191: undefined reference
to `FLAC__stream_decoder_finish'
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:191:(.text$_ZN10flacStreamD1Ev[_ZN10flacStreamD1Ev]+0x1d):
relocation truncated to fit: R_X86_64_PC32 against undefined symbol
`FLAC__stream_decoder_finish'
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:192: undefined reference
to `FLAC__stream_decoder_delete'
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:192:(.text$_ZN10flacStreamD1Ev[_ZN10flacStreamD1Ev]+0x26):
relocation truncated to fit: R_X86_64_PC32 against undefined symbol
`FLAC__stream_decoder_delete'
CMakeFiles/alure.dir/src/codec_flac.o: In function
`flacStream::~flacStream()':
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:191: undefined reference
to `FLAC__stream_decoder_finish'
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:191:(.text$_ZN10flacStreamD0Ev[_ZN10flacStreamD0Ev]+0x1d):
relocation truncated to fit: R_X86_64_PC32 against undefined symbol
`FLAC__stream_decoder_finish'
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:192: undefined reference
to `FLAC__stream_decoder_delete'
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:192:(.text$_ZN10flacStreamD0Ev[_ZN10flacStreamD0Ev]+0x26):
relocation truncated to fit: R_X86_64_PC32 against undefined symbol
`FLAC__stream_decoder_delete'
CMakeFiles/alure.dir/src/codec_flac.o: In function
`flacStream::flacStream(std::istream*)':
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:169: undefined reference
to `FLAC__stream_decoder_new'
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:169:(.text$_ZN11DecoderDeclI10flacStreamLi1EE7FactoryEPSi[_ZN11DecoderDeclI10flacStreamLi1EE7FactoryEPSi]+0xb0):
relocation truncated to fit: R_X86_64_PC32 against undefined symbol
`FLAC__stream_decoder_new'
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:172: undefined reference
to `FLAC__stream_decoder_init_stream'
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:172:(.text$_ZN11DecoderDeclI10flacStreamLi1EE7FactoryEPSi[_ZN11DecoderDeclI10flacStreamLi1EE7FactoryEPSi]+0x117):
relocation truncated to fit: R_X86_64_PC32 against undefined symbol
`FLAC__stream_decoder_init_stream'
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:182: undefined reference
to `FLAC__stream_decoder_delete'
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:182:(.text$_ZN11DecoderDeclI10flacStreamLi1EE7FactoryEPSi[_ZN11DecoderDeclI10flacStreamLi1EE7FactoryEPSi]+0x128):
additional relocation overflows omitted from the output
CMakeFiles/alure.dir/src/codec_flac.o: In function `flacStream::InitFlac()':
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:209: undefined reference
to `FLAC__stream_decoder_process_single'
CMakeFiles/alure.dir/src/codec_flac.o: In function
`flacStream::flacStream(std::istream*)':
/usr/src/debug/alure-1.2-1/src/codec_flac.cpp:180: undefined reference
to `FLAC__stream_decoder_finish'
CMakeFiles/alure.dir/src/codec_flac.o: In function `flacStream::InitFlac()':

Re: [ITP] alure 1.2

2016-10-16 Thread Marco Atzeri 

On 13/10/2016 19:05, Bastian Germann wrote:

Hi,

it's almost 4 weeks since I submitted the package. Is there something
wrong with my email to not be answered? I think, I followed the
Contributor's Guide pretty close.


just busy with other life, as most of the other maintainers
for what I see on mailing list traffic.


Is someone willing to review the package?

Regards,
Bastian



build fine.

However I suggest to not build the static library
and to install only the shared one, as this is the default
on cygwin.

Any reason to not add FLAC (Free Lossless Audio Codec)
dependency ?

Additional, the upstream package has no manuals
for the utils, but that is bad practice.
Can you add the one from debian ?

https://anonscm.debian.org/cgit/pkg-games/alure.git/tree/debian

Regards
MArco

Re: [ITP] alure 1.2

2016-10-15 Thread David Stacey 

On 13/10/16 18:05, Bastian Germann wrote:

it's almost 4 weeks since I submitted the package. Is there something
wrong with my email to not be answered? I think, I followed the
Contributor's Guide pretty close.

Is someone willing to review the package?


It's probably only polite for /someone/ on the list to reply, although 
in fairness I'm probably not the most qualified person to do so. You may 
be aware that Cygwin package maintainers are mostly volunteers who have 
to juggle real life (jobs, families, etc.) with Open Source work. The 
bulk of Cygwin packages are maintained by a surprisingly small number of 
individuals, and sometimes real life demands mean that there is little 
time to review new contributions. That's not to say that new packages 
aren't wanted (they are), it's just that occasionally there is no-one 
with sufficient time to undertake a review. 'alure' isn't too big, but 
any package the size of 'gambas3' is going to take quite some time to 
pick through.


The other problem with 'alure' is one of scope: I'm not sure how many 
maintainers are interested or familiar with sound on Cygwin. Yaakov or 
Marco would probably have the best knowledge to perform a review, but it 
depends on their availability. It's certainly a couple of years since I 
last dabbled with sound on Cygwin.


Dave.

Re: [ITP] alure 1.2

2016-10-13 Thread Bastian Germann 
Hi,

it's almost 4 weeks since I submitted the package. Is there something
wrong with my email to not be answered? I think, I followed the
Contributor's Guide pretty close.

Is someone willing to review the package?

Regards,
Bastian

2016-09-17 12:28 GMT+02:00 Bastian Germann:
> I have packaged alure and would like to become a maintainer for it.
> alure is available at http://kcat.strangesoft.net/alure.html and MIT/X11
> licensed.
>
> The major GNU/Linux distributions include it in their repositories, e.g.
> Debian: https://packages.debian.org/source/jessie/alure