Re: ITP: mksh-R39c-1
On Apr 27 19:48, Chris Sutcliffe wrote: On 26 April 2010 12:24, Chris Sutcliffe wrote: Is this package GTG now? I believe all the loose ends have been tied up in terms of this package. Is there anything else that needs to be addressed? Doesn't seem so. Uploaded. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Project Co-Leader cygwin AT cygwin DOT com Red Hat
Re: ITP: mksh-R39c-1
On 26 April 2010 12:24, Chris Sutcliffe wrote: Is this package GTG now? I believe all the loose ends have been tied up in terms of this package. Is there anything else that needs to be addressed? Chris -- Chris Sutcliffe http://emergedesktop.org http://www.google.com/profiles/ir0nh34d
Re: ITP: mksh-R39c-1
Thank you for the review Yaakov!
I've made all the changes you recommended and I've uploaded the new files:
---
wget -x -nH --cut-dirs=3 \
http://emergedesktop.org/cygwin/mksh/mksh-39c-1.tar.bz2 \
http://emergedesktop.org/cygwin/mksh/mksh-39c-1-src.tar.bz2 \
http://emergedesktop.org/cygwin/mksh/setup.hint
---
I'm curious though, when does:
src_test() {
cd ${B}
./test.sh
}
get called? I never saw it run as part of the cygport process.
Cheers!
Chris
--
Chris Sutcliffe
http://emergedesktop.org
http://www.google.com/profiles/ir0nh34d
Re: ITP: mksh-R39c-1
On 2010-04-26 07:02, Chris Sutcliffe wrote:
I'm curious though, when does:
src_test() {
cd ${B}
./test.sh
}
get called? I never saw it run as part of the cygport process.
cygport mksh-39c-1.cygport test
Yaakov
Re: ITP: mksh-R39c-1
On 26 April 2010 12:13, Yaakov (Cygwin/X) wrote:
On 2010-04-26 07:02, Chris Sutcliffe wrote:
I'm curious though, when does:
src_test() {
cd ${B}
./test.sh
}
get called? I never saw it run as part of the cygport process.
cygport mksh-39c-1.cygport test
Ah, 'test' isn't listed as a valid command for cygport... good to
know, thank you!
Is this package GTG now?
Chris
--
Chris Sutcliffe
http://emergedesktop.org
http://www.google.com/profiles/ir0nh34d
Re: ITP: mksh-R39c-1
On 2010-04-26 11:24, Chris Sutcliffe wrote: Ah, 'test' isn't listed as a valid command for cygport... good to know, thank you! The following changes since commit 893c667694cca21efd32bb841fb5815763a85c7d: Yaakov Selkowitz (1): cygport 0.9.82 are available in the git repository at: git://cygwin-ports.git.sourceforge.net/gitroot/cygwin-ports/cygport master Yaakov Selkowitz (3): Update TODO Make manpage rule dependent on help.cygpart Document the 'test' command in cygport --help README |1 + TODO |2 ++ doc/Makefile.am |2 +- lib/help.cygpart |1 + 4 files changed, 5 insertions(+), 1 deletions(-)
Re: ITP: mksh-R39c-1
Ok, but you do have two shared libraries there which should be referenced right? Fair enough, I've updated the setup.hint accordingly: With the latest cygport release (0.9.82) now supporting .cpio.gz archives, I've repackaged mksh using the latest cygport. The updated files are available here: --- wget -x -nH --cut-dirs=3 \ http://emergedesktop.org/cygwin/mksh/mksh-R39c-1.tar.bz2 \ http://emergedesktop.org/cygwin/mksh/mksh-R39c-1-src.tar.bz2 \ http://emergedesktop.org/cygwin/mksh/setup.hint --- Thank you, Chris -- Chris Sutcliffe http://emergedesktop.org http://www.google.com/profiles/ir0nh34d
Re: ITP: mksh-R39c-1
On 2010-04-25 16:25, Chris Sutcliffe wrote:
With the latest cygport release (0.9.82) now supporting .cpio.gz
archives, I've repackaged mksh using the latest cygport.
SRC_URI=https://www.mirbsd.org/MirOS/dist/mir/mksh/${P}.cpio.gz;
Your package version (PV in cygport terms) ends up being R39c, but
according to the website[1] that is an illegal value: The version
number must start with a digit...
So I recommend you drop the leading R and call this
mksh-39c-1.cygport, changing SRC_URI to:
SRC_URI=https://www.mirbsd.org/MirOS/dist/mir/mksh/mksh-R${PV}.cpio.gz;
PKG_HINTS=setup
This is the default and need not be specified where only one binary
package is created.
src_compile() {
lndirs
cd ${B}
sh ./Build.sh
}
src_test() {
cd ${B}
./test.sh
}
insinto /usr/share/man/man1
doins mksh.1
doman mksh.1
insinto /usr/share/doc/mksh/examples
doins dot.mkshrc
docinto examples
dodoc dot.mkshrc
Yaakov
[1] http://cygwin.com/setup.html#sourceware.org
Re: ITP: mksh-R39c-1
On Fri, Apr 23, 2010 at 09:09:46AM -0400, Chris Sutcliffe wrote: Hi All, Given that pdksh has abandoned, I'm proposing to add mksh as a replacement. I realize that Jari Aalto has proposed mksh in the past (http://www.cygwin.com/ml/cygwin-apps/2007-09/msg00021.html), and that it was subsequently shot down in favour of pdksh. But given that Igor Peshansky has seemed to have moved on, and pdksh is now abandoned, I would like to maintain mksh in it's place. I think that's a fine idea. Too bad setup.exe (and upset for that matter) doesn't support a Obsoletes: tag. Since mksh is distributed as a .cpio.gz archive, and at this point cygport does not handle cpio archives, I've had to create my own build script, so I would appreciate it if someone could give it the once over. --- wget -x -nH --cut-dirs=3 \ http://emergedesktop.org/cygwin/mksh/mksh-R39c-1.tar.bz2 \ http://emergedesktop.org/cygwin/mksh/mksh-R39c-1-src.tar.bz2 \ http://emergedesktop.org/cygwin/mksh/setup.hint Doesn't mksh uses ncurses for command line editing and recall? It isn't listed as a dependency. cgf
Re: ITP: mksh-R39c-1
On 23 April 2010 10:11, Christopher Faylor wrote: On Fri, Apr 23, 2010 at 09:09:46AM -0400, Chris Sutcliffe wrote: Doesn't mksh uses ncurses for command line editing and recall? It isn't listed as a dependency. Using the Build.sh script supplied by mksh it does not link against the shared ncurses lib: $ cygcheck mksh.exe Found: C:\cygwin\bin\mksh.exe Found: C:\cygwin\bin\mksh.exe C:\cygwin\bin\mksh.exe C:\cygwin\bin\cygwin1.dll C:\WINDOWS\system32\ADVAPI32.DLL C:\WINDOWS\system32\KERNEL32.dll C:\WINDOWS\system32\ntdll.dll C:\WINDOWS\system32\RPCRT4.dll C:\WINDOWS\system32\Secur32.dll C:\cygwin\bin\cyggcc_s-1.dll C:\cygwin\bin\cygssp-0.dll Cheers! Chris -- Chris Sutcliffe http://emergedesktop.org http://www.google.com/profiles/ir0nh34d
Re: ITP: mksh-R39c-1
On Fri, Apr 23, 2010 at 10:37:13AM -0400, Chris Sutcliffe wrote: On 23 April 2010 10:11, Christopher Faylor wrote: On Fri, Apr 23, 2010 at 09:09:46AM -0400, Chris Sutcliffe wrote: Doesn't mksh uses ncurses for command line editing and recall? ?It isn't listed as a dependency. Using the Build.sh script supplied by mksh it does not link against the shared ncurses lib: $ cygcheck mksh.exe Found: C:\cygwin\bin\mksh.exe Found: C:\cygwin\bin\mksh.exe C:\cygwin\bin\mksh.exe C:\cygwin\bin\cygwin1.dll C:\WINDOWS\system32\ADVAPI32.DLL C:\WINDOWS\system32\KERNEL32.dll C:\WINDOWS\system32\ntdll.dll C:\WINDOWS\system32\RPCRT4.dll C:\WINDOWS\system32\Secur32.dll C:\cygwin\bin\cyggcc_s-1.dll C:\cygwin\bin\cygssp-0.dll Ok, but you do have two shared libraries there which should be referenced right? cgf
Re: ITP: mksh-R39c-1
On 23 April 2010 10:47, Christopher Faylor wrote: Ok, but you do have two shared libraries there which should be referenced right? Fair enough, I've updated the setup.hint accordingly: --- wget -x -nH --cut-dirs=3 \ http://emergedesktop.org/cygwin/mksh/mksh-R39c-1.tar.bz2 \ http://emergedesktop.org/cygwin/mksh/mksh-R39c-1-src.tar.bz2 \ http://emergedesktop.org/cygwin/mksh/setup.hint --- Please let me know if it's appropriate now. Thank you, Chris -- Chris Sutcliffe http://emergedesktop.org http://www.google.com/profiles/ir0nh34d
