grace Review (Re: Pending packages status)
Volker Quetschke wrote: >> date : 25 Nov 2002 >> version: 5.1.10-1 >> status : not reviewed >> notes : http://www.cygwin.com/ml/cygwin-apps/2002-11/msg00322.html >> votes : 2 (Lapo and Robert) > > I updated to grace 5.1.12, the new urls are: > ~ http://www.scytek.de/cygwin/grace-5.1.12-1.tar.bz2 > ~ http://www.scytek.de/cygwin/grace-5.1.12-1-src.tar.bz2 > ~ http://www.scytek.de/cygwin/setup.hint I've never used grace, but it's a pity for a package to have votes but no review, so I thought I'd take a look at the packaging. Here are some issues I found: You say "* No patches necessary." in usr/doc/Cygwin/grace.README, but you do patch examples/Makefile and examples/dotest /usr/grace/gracerc.user will be overwritten on uninstall/upgrade. Based on the comments in it, that might be ok, but it might be nice to add an extra comment indicating this. I don't think changing the default editor to nano is right. I think you should leave it alone, and everyone can set GRACE_EDITOR to their own preference. I certainly don't think grace should depend on nano. [Yes, I am a vim addict] There is some html documentation in the source package. How about installing it? Max.
Re: grace Review (Re: Pending packages status)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Max, |>I updated to grace 5.1.12, the new urls are: |>~ http://www.scytek.de/cygwin/grace-5.1.12-1.tar.bz2 |>~ http://www.scytek.de/cygwin/grace-5.1.12-1-src.tar.bz2 |>~ http://www.scytek.de/cygwin/setup.hint | | I've never used grace, but it's a pity for a package to have votes but no | review, so I thought I'd take a look at the packaging. Thanks! | Here are some issues I found: | | You say "* No patches necessary." in usr/doc/Cygwin/grace.README, but you do | patch examples/Makefile and examples/dotest Ah, well, these patches only fix the make check command, this is not needed if you don't want to do a make check. I'll change that line in the README. | /usr/grace/gracerc.user will be overwritten on uninstall/upgrade. Based on | the comments in it, that might be ok, but it might be nice to add an extra | comment indicating this. Yes, I will add a hint that /usr/grace/gracerc and /usr/grace/gracerc.user will be overwritten. If the user wants to keep his/her settings between updates he should put the gracerc and gracerc.user in a ./grace/ directory. | I don't think changing the default editor to nano is right. I think you | should leave it alone, and everyone can set GRACE_EDITOR to their own | preference. I certainly don't think grace should depend on nano. | [Yes, I am a vim addict] Ok, ok, I will change that back to the default and use the GRACE_EDITOR variable from now on ;-) | There is some html documentation in the source package. How about installing | it? It's installed, it is in /usr/grace/doc, available also from grace with the help menu. Unfortunately I had to change the helpbrowser to lynx because there is no XmHTML or libhelp package in cygwin at the moment and one of those libraries is needed for the internal helpviewer. I will upload a new version shortly. Thanks ~Volker - -- PGP/GPG key (ID: 0x9F8A785D) available from wwwkeys.de.pgp.net key-fingerprint 550D F17E B082 A3E9 F913 9E53 3D35 C9BA 9F8A 785D -BEGIN PGP SIGNATURE- Version: GnuPG v1.2.1 (MingW32) Comment: Using GnuPG with Netscape - http://enigmail.mozdev.org iD8DBQE+a3EQPTXJup+KeF0RAr5QAKDBm2FmFIqOcviA1b0F4pqjUgYnCwCgiuFN DtRvDYlOqhYaGURZDFxUNNE= =DILf -END PGP SIGNATURE-
Re: grace Review (Re: Pending packages status)
Volker Quetschke wrote: > Hi Max, > >>> I updated to grace 5.1.12, the new urls are: >>> ~ http://www.scytek.de/cygwin/grace-5.1.12-1.tar.bz2 >>> ~ http://www.scytek.de/cygwin/grace-5.1.12-1-src.tar.bz2 >>> ~ http://www.scytek.de/cygwin/setup.hint >> >> I've never used grace, but it's a pity for a package to have votes >> but no review, so I thought I'd take a look at the packaging. > Thanks! No problem. >> Here are some issues I found: >> >> You say "* No patches necessary." in usr/doc/Cygwin/grace.README, but > you do >> patch examples/Makefile and examples/dotest > Ah, well, these patches only fix the make check command, this is not > needed if you don't want to do a make check. I'll change that line in > the README. > >> /usr/grace/gracerc.user will be overwritten on uninstall/upgrade. >> Based on the comments in it, that might be ok, but it might be nice >> to add an extra comment indicating this. > Yes, I will add a hint that /usr/grace/gracerc and > /usr/grace/gracerc.user will be overwritten. If the user wants to keep > his/her settings between updates he should put the gracerc and > gracerc.user in a ./grace/ directory. > >> I don't think changing the default editor to nano is right. I think >> you should leave it alone, and everyone can set GRACE_EDITOR to >> their own preference. I certainly don't think grace should depend on >> nano. [Yes, I am a vim addict] > Ok, ok, I will change that back to the default and use the > GRACE_EDITOR variable from now on ;-) Good, good, and good! Don't forget to remove the nano dependency from setup.hint >> There is some html documentation in the source package. How about >> installing it? > It's installed, it is in /usr/grace/doc, available also from grace > with > the help menu. Unfortunately I had to change the helpbrowser to lynx > because there is no XmHTML or libhelp package in cygwin at the moment > and one of those libraries is needed for the internal helpviewer. Oh, ok. Perhaps you could s!doc!/usr/grace/doc!g in the README, so that grace newbies (like me) are more likely to find it? Max.
Re: grace Review (Re: Pending packages status)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi! |>>>I updated to grace 5.1.12, the new urls are: |>>>~ http://www.scytek.de/cygwin/grace-5.1.12-1.tar.bz2 |>>>~ http://www.scytek.de/cygwin/grace-5.1.12-1-src.tar.bz2 |>>>~ http://www.scytek.de/cygwin/setup.hint The urls above now points to the new packages. Volker - -- PGP/GPG key (ID: 0x9F8A785D) available from wwwkeys.de.pgp.net key-fingerprint 550D F17E B082 A3E9 F913 9E53 3D35 C9BA 9F8A 785D -BEGIN PGP SIGNATURE- Version: GnuPG v1.2.1 (MingW32) Comment: Using GnuPG with Netscape - http://enigmail.mozdev.org iD8DBQE+a3z3PTXJup+KeF0RAp17AKCLAcPqjTFraw9GfwuR77AeIYRNzwCg0SZB ibq0035glLcSt3aUiaX6c/Q= =it2S -END PGP SIGNATURE-
