Re: NT 4.0 fixup_mmaps_after_fork() patch
On Wed, Jan 15, 2003 at 02:19:19PM -0500, Jason Tishler wrote: It appears that ReadProcessMemory() can fail with ERROR_NOACCESS under NT 4.0. See attached patch. Applied. Thanks! BTW, my mmap-test test case works under NT 4.0 without this patch. However, vsFTPd does not. Go figure! Details? Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL PROTECTED] Red Hat, Inc.
Re: NT 4.0 fixup_mmaps_after_fork() patch
Corinna, On Thu, Jan 16, 2003 at 03:11:35PM +0100, Corinna Vinschen wrote: On Wed, Jan 15, 2003 at 02:19:19PM -0500, Jason Tishler wrote: It appears that ReadProcessMemory() can fail with ERROR_NOACCESS under NT 4.0. See attached patch. Applied. Thanks! You are welcome. BTW, my mmap-test test case works under NT 4.0 without this patch. However, vsFTPd does not. Go figure! Details? Um... Er... Cockpit error. I still had the mprotect() calls commented out. Thanks, Jason -- PGP/GPG Key: http://www.tishler.net/jason/pubkey.asc or key servers Fingerprint: 7A73 1405 7F2B E669 C19D 8784 1AFD E4CC ECF4 8EF6
Re: etc_changed, passwd group.
On Thu, Jan 16, 2003 at 01:57:21AM -0500, Pierre A. Humblet wrote: Chris, Here is the code as it stands. It compiles runs, and passes fork tests correctly. Feel free to takeover or at least have a look. I will continue testing tomorrow evening. I include only the 5 files that are related to etc_changed, the 5 others (setuid on Win9X) can wait. Hmm. I have a slightly less intrusive idea for how to handle this. I'll check it in shortly. cgf
Re: etc_changed, passwd group.
On Thu, Jan 16, 2003 at 02:07:18PM -0500, Christopher Faylor wrote: On Thu, Jan 16, 2003 at 01:57:21AM -0500, Pierre A. Humblet wrote: Here is the code as it stands. It compiles runs, and passes fork tests correctly. Feel free to takeover or at least have a look. I will continue testing tomorrow evening. I include only the 5 files that are related to etc_changed, the 5 others (setuid on Win9X) can wait. Hmm. I have a slightly less intrusive idea for how to handle this. I'll check it in shortly. Maybe not so less intrusive after all. I broke out the etc handling stuff into a separate class and moved even more functionality into pwdgrp than you did. I hope Corinna approves. I also hope that I got all of your changes that didn't conflict with my work in. I'm generating a new snapshot now. I guess we should ask people to test it for a couple of days before I release 1.3.19. Sigh. Oh, and I just removed the warning when FindFirstChangeNotification fails. This should make the Novell users happy even though the performance will be less than wonderful. Thanks for your patch and your insight, Pierre. cgf
230.4Kbps serial support - patch #2
Chris, This patch rounds out the 230.4Kbps support in fhandler_serial::tcsetattr() - this check probably should have been there all along, but now catches any invalid DCB parameters (ie. trying to set an invalid bitrate for a given port) and returns w/ errno = EINVAL as POSIX dictates. Can you review and check this in before 1.3.19 is released? Thanks, -Troy 2003-01-16 Troy Curtiss [EMAIL PROTECTED] * fhandler_serial.cc (fhandler_serial::tcsetattr): return w/ errno = EINVAL if SetCommState() fails w/ invalid DCB parameter (eg. will catch attempts to set bitrates not supported by a given port.) ser_230k4_patch2 Description: Binary data
