Re: [PATCH] cygwin: doc: Add keywords for ACE order issues

2020-05-12 Thread Yaakov Selkowitz via Cygwin-patches
On Tue, 2020-05-12 at 22:49 +0200, David Macek via Cygwin-patches
wrote:
> Windows Explorer shows a warning with Cygwin-created DACLs, but putting
> the text of the warning into Google doesn't lead to the relevant Cygwin
> docs.  Let's copy the warning text into the docs in the hopes of helping
> confused users.
> 
> Latest inquiry: 
> 
> Signed-off-by: David Macek 
> ---
>  winsup/doc/ntsec.xml | 5 -
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/winsup/doc/ntsec.xml b/winsup/doc/ntsec.xml
> index 08a33bdc6c..b94cdd9a97 100644
> --- a/winsup/doc/ntsec.xml
> +++ b/winsup/doc/ntsec.xml
> @@ -2163,7 +2163,10 @@ preferred order.
>  the Windows Explorer insists to rearrange the order of the ACEs to
>  canonical order before you can read them. Thank God, the sort order
>  remains unchanged if one presses the Cancel button.  But don't even
> -think of pressing OK...
> +think of pressing OK...  For the sake
> +of people searching for this explanation, let's note that the Explorer
> +warning says "The permissions on ... are incorrectly orderer, which may
> +cause some entries to be ineffective."
>  
>  Canonical ACLs are unable to reflect each possible combination
>  of POSIX permissions. Example:

The wording seems awkward.  Why not quote the text of the warning
directly earlier in the paragraph, e.g.:

Unfortunately, the security tab in the file properties dialog of
the Windows Explorer will pop up a warning stating: "The permissions on
... are incorrectly ordered, which may cause some entries to be
ineffective."  Pressing the Cancel button will leave the order
unchanged, but pressing OK will cause Windows to canonicalize the order
of the ACEs, thereby invalidating POSIX compatibility.

-- 
Yaakov Selkowitz
Senior Software Engineer - Platform Enablement
Red Hat, Inc.




Re: [PATCH] cygwin: doc: Add keywords for ACE order issues

2020-05-12 Thread David Macek via Cygwin-patches
> +warning says "The permissions on ... are incorrectly orderer, which may

Oof. Please fix "orderer" to "ordered" if accepted.

-- 
David Macek


[PATCH] cygwin: doc: Add keywords for ACE order issues

2020-05-12 Thread David Macek via Cygwin-patches
Windows Explorer shows a warning with Cygwin-created DACLs, but putting
the text of the warning into Google doesn't lead to the relevant Cygwin
docs.  Let's copy the warning text into the docs in the hopes of helping
confused users.

Latest inquiry: 

Signed-off-by: David Macek 
---
 winsup/doc/ntsec.xml | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/winsup/doc/ntsec.xml b/winsup/doc/ntsec.xml
index 08a33bdc6c..b94cdd9a97 100644
--- a/winsup/doc/ntsec.xml
+++ b/winsup/doc/ntsec.xml
@@ -2163,7 +2163,10 @@ preferred order.
 the Windows Explorer insists to rearrange the order of the ACEs to
 canonical order before you can read them. Thank God, the sort order
 remains unchanged if one presses the Cancel button.  But don't even
-think of pressing OK...
+think of pressing OK...  For the sake
+of people searching for this explanation, let's note that the Explorer
+warning says "The permissions on ... are incorrectly orderer, which may
+cause some entries to be ineffective."
 
 Canonical ACLs are unable to reflect each possible combination
 of POSIX permissions. Example:
-- 
2.26.2.windows.1