Re: [PATCH 1/3 v3] Cygwin: tzcode resync: basics

[Mark Geisert]

Hi Brian,

On Tue, 9 Jun 2020, Brian Inglis wrote:

On 2020-05-26 02:27, Corinna Vinschen wrote:

On May 26 00:09, Mark Geisert wrote:

Corinna Vinschen wrote:

On May 22 02:32, Mark Geisert wrote:

On May 25 14:06, Corinna Vinschen wrote:


Hi folks,

The tzcode package needs updated to get fixes into zic and zdump.
Also tzdata was maintained by Yaakov.

Corinna, would you like to keep tzcode co-maintained with Yaakov?

Or Mark, would you like to ITA tzcode and/or tzdata to keep it in sync with the
base code?

Or would you like me to ITA tzcode and/or tzdata?
I currently check tzdb weekly in cron to download updates for my own interests.
I could add cygport builds to that job.


This "tzcode" patch I did was a one-shot task just getting some time zone 
handling code within the Cygwin DLL up to date.  I don't know if there's 
any overlap between what I worked on and the tzcode+tzdata packages.  Eh, 
just the internal binary copy of a particular tzdata file which should be 
kept up to date: /usr/share/zoneinfo/posixrules.  Dunno how often that 
changes though.


It's fine with me for you to take over both tzcode+tzdata if nobody else 
objects.  Sounds like you have a regular schedule for looking over updates 
which is more than I have :-).

Cheers,

..mark

Re: [PATCH 1/3 v3] Cygwin: tzcode resync: basics

[Brian Inglis]

On 2020-05-26 02:27, Corinna Vinschen wrote:
> On May 26 00:09, Mark Geisert wrote:
>> Corinna Vinschen wrote:
 On May 22 02:32, Mark Geisert wrote:
>>> On May 25 14:06, Corinna Vinschen wrote:

Hi folks,

The tzcode package needs updated to get fixes into zic and zdump.
Also tzdata was maintained by Yaakov.

Corinna, would you like to keep tzcode co-maintained with Yaakov?

Or Mark, would you like to ITA tzcode and/or tzdata to keep it in sync with the
base code?

Or would you like me to ITA tzcode and/or tzdata?
I currently check tzdb weekly in cron to download updates for my own interests.
I could add cygport builds to that job.

-- 
Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada

This email may be disturbing to some readers as it contains
too much technical detail. Reader discretion is advised.
[Data in IEC units and prefixes, physical quantities in SI.]

Re: [PATCH v3] Cygwin: pty: Fix screen distortion after less for native apps again.

[Ken Brown via Cygwin-patches]

On 6/3/2020 9:43 PM, Takashi Yano via Cygwin-patches wrote:

- Commit c4b060e3fe3bed05b3a69ccbcc20993ad85e163d seems to be not
   enough. Moreover, it does not work as expected at all in Win10
   1809. This patch essentially reverts that commit and add another
   fix. After all, the cause of the problem was a race issue in
   switch_to_pcon_out flag. That is, this flag is set when native
   app starts, however, it is delayed by wait_pcon_fwd(). Since the
   flag is not set yet when less starts, the data which should go
   into the output_handle accidentally goes into output_handle_cyg.
   This patch fixes the problem more essentially for the cause of
   the problem than previous one.
---
  winsup/cygwin/fhandler.h  |  1 -
  winsup/cygwin/fhandler_tty.cc | 49 +++
  winsup/cygwin/tty.cc  |  7 -
  winsup/cygwin/tty.h   |  1 -
  4 files changed, 21 insertions(+), 37 deletions(-)

diff --git a/winsup/cygwin/fhandler.h b/winsup/cygwin/fhandler.h
index 4035c7e56..c6ce6d8e1 100644
--- a/winsup/cygwin/fhandler.h
+++ b/winsup/cygwin/fhandler.h
@@ -2354,7 +2354,6 @@ class fhandler_pty_slave: public fhandler_pty_common
void setup_locale (void);
void set_freeconsole_on_close (bool val);
void trigger_redraw_screen (void);
-  void wait_pcon_fwd (void);
void pull_pcon_input (void);
void update_pcon_input_state (bool need_lock);
  };
diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
index bcc7648f3..126249d9f 100644
--- a/winsup/cygwin/fhandler_tty.cc
+++ b/winsup/cygwin/fhandler_tty.cc
@@ -1277,6 +1277,7 @@ fhandler_pty_slave::set_switch_to_pcon (int fd_set)
  {
if (fd < 0)
  fd = fd_set;
+  acquire_output_mutex (INFINITE);
if (fd == 0 && !get_ttyp ()->switch_to_pcon_in)
  {
pull_pcon_input ();
@@ -1286,13 +1287,13 @@ fhandler_pty_slave::set_switch_to_pcon (int fd_set)
get_ttyp ()->switch_to_pcon_in = true;
if (isHybrid && !get_ttyp ()->switch_to_pcon_out)
{
- wait_pcon_fwd ();
+ get_ttyp ()->wait_pcon_fwd ();
  get_ttyp ()->switch_to_pcon_out = true;
}
  }
else if ((fd == 1 || fd == 2) && !get_ttyp ()->switch_to_pcon_out)
  {
-  wait_pcon_fwd ();
+  get_ttyp ()->wait_pcon_fwd ();
if (get_ttyp ()->pcon_pid == 0 ||
  !pinfo (get_ttyp ()->pcon_pid))
get_ttyp ()->pcon_pid = myself->pid;
@@ -1300,6 +1301,7 @@ fhandler_pty_slave::set_switch_to_pcon (int fd_set)
if (isHybrid)
get_ttyp ()->switch_to_pcon_in = true;
  }
+  release_output_mutex ();
  }
  
  void

@@ -1314,12 +1316,14 @@ fhandler_pty_slave::reset_switch_to_pcon (void)
  return;
if (do_not_reset_switch_to_pcon)
  return;
+  acquire_output_mutex (INFINITE);
if (get_ttyp ()->switch_to_pcon_out)
  /* Wait for pty_master_fwd_thread() */
-wait_pcon_fwd ();
+get_ttyp ()->wait_pcon_fwd ();
get_ttyp ()->pcon_pid = 0;
get_ttyp ()->switch_to_pcon_in = false;
get_ttyp ()->switch_to_pcon_out = false;
+  release_output_mutex ();
init_console_handler (true);
  }
  
@@ -1372,7 +1376,7 @@ fhandler_pty_slave::push_to_pcon_screenbuffer (const char *ptr, size_t len,

  p0 = (char *) memmem (p1, nlen - (p1-buf), "\033[?1049h", 8);
  if (p0)
{
- p0 += 8;
+ //p0 += 8;
  get_ttyp ()->screen_alternated = true;
  if (get_ttyp ()->switch_to_pcon_out)
do_not_reset_switch_to_pcon = true;
@@ -1384,7 +1388,7 @@ fhandler_pty_slave::push_to_pcon_screenbuffer (const char 
*ptr, size_t len,
  p1 = (char *) memmem (p0, nlen - (p0-buf), "\033[?1049l", 8);
  if (p1)
{
- //p1 += 8;
+ p1 += 8;
  get_ttyp ()->screen_alternated = false;
  do_not_reset_switch_to_pcon = false;
  memmove (p0, p1, buf+nlen - p1);
@@ -1504,8 +1508,9 @@ fhandler_pty_slave::write (const void *ptr, size_t len)
  
reset_switch_to_pcon ();
  
-  bool output_to_pcon =

-get_ttyp ()->switch_to_pcon_out && !get_ttyp ()->screen_alternated;
+  acquire_output_mutex (INFINITE);
+  bool output_to_pcon = get_ttyp ()->switch_to_pcon_out;
+  release_output_mutex ();
  
UINT target_code_page = output_to_pcon ?

  GetConsoleOutputCP () : get_ttyp ()->term_code_page;
@@ -2420,8 +2425,6 @@ fhandler_pty_master::close ()
}
  release_output_mutex ();
  master_fwd_thread->terminate_thread ();
- CloseHandle (get_ttyp ()->fwd_done);
- get_ttyp ()->fwd_done = NULL;
}
  }
  
@@ -2903,17 +2906,6 @@ fhandler_pty_slave::set_freeconsole_on_close (bool val)

freeconsole_on_close = val;
  }
  
-void

-fhandler_pty_slave::wait_pcon_fwd (void)
-{
-  acquire_output_mutex (INFINITE);
-  get_ttyp ()->pcon_last_time = GetTickCount ();
-  ResetEvent (get_ttyp ()->fwd_done);
-  release_output_mutex ();
-  while (get_ttyp