Re: [PATCH] Cygwin: remove most occurrences of __stdcall, WINAPI, and, __cdecl
On Sun, 5 Jun 2022 21:24:15 +0100 Jon Turney wrote: > On 03/06/2022 15:00, Ken Brown wrote: > > remove most occurrences of __stdcall, WINAPI, and __cdecl > > > > These have no effect on x86_64. Retain only a few occurrences of > > __cdecl in files imported from other sources. > > While you are correct that it has no effect on x86_64, I'd incline > towards retaining WINAPI on Windows API functions, because it's part of > the function signature. But other people might have other opinions on > that... I rather incline to Jon's opinion. -- Takashi Yano
Re: [PATCH] Cygwin: remove most occurrences of __stdcall, WINAPI, and, __cdecl
On 6/5/2022 4:24 PM, Jon Turney wrote: On 03/06/2022 15:00, Ken Brown wrote: remove most occurrences of __stdcall, WINAPI, and __cdecl These have no effect on x86_64. Retain only a few occurrences of __cdecl in files imported from other sources. While you are correct that it has no effect on x86_64, I'd incline towards retaining WINAPI on Windows API functions, because it's part of the function signature. But other people might have other opinions on that... I agree. I just mindlessly deleted all of them. I'll submit a revised patch. Ken
Re: [PATCH] Cygwin: remove most occurrences of __stdcall, WINAPI, and, __cdecl
On 03/06/2022 15:00, Ken Brown wrote: remove most occurrences of __stdcall, WINAPI, and __cdecl These have no effect on x86_64. Retain only a few occurrences of __cdecl in files imported from other sources. While you are correct that it has no effect on x86_64, I'd incline towards retaining WINAPI on Windows API functions, because it's part of the function signature. But other people might have other opinions on that...
