Re: [PATCH] Setup Chooser integration
On Tue, Apr 02, 2002 at 03:14:28PM -0600, Gary R Van Sickle wrote: Image: you click on 'install' for 'gcc', and up pops a window that lists everything that gcc depends on (both requires as we have today, and 'suggested' items that aren't always needed but are useful - ie autoconf), that was not selected before that click. I'm drawing a blank at the utility of such a feature, at least in the guise of a popup of any kind. You're saying that as you go through the dozens of packages you want and select them, that a box pops up bugging you about the dependencies of each selection, which you can't do anything about anyways? That sounds like it would be extremely irritating. Ditto. I also have to admit that I don't see how this corresponds with any complaints or requests that I've seen in the cygwin mailing list. Likewise, if you click ash off, up pops a window listing everything that depends on ash, with an addiotnal message of Warning: removing ash will cause these packages to be removed as well. This does make quite a bit of sense to me. But wouldn't MessageBox() or something akin to it be a better fit to the task? The only possible user input here would be Yes, remove ash and everything dependent on it and Cancel, and the only output a list of package names. Actually, I think that automatically removing dependencies is not a good idea. If I select binutils specifically, then select gcc, then uninstall gcc, I would probably be annoyed to see binutils disappear. cgf
RE: [PATCH] Setup Chooser integration
Likewise, if you click ash off, up pops a window listing everything that depends on ash, with an addiotnal message of Warning: removing ash will cause these packages to be removed as well. This does make quite a bit of sense to me. But wouldn't MessageBox() or something akin to it be a better fit to the task? The only possible user input here would be Yes, remove ash and everything dependent on it and Cancel, and the only output a list of package names. Actually, I think that automatically removing dependencies is not a good idea. If I select binutils specifically, then select gcc, then uninstall gcc, I would probably be annoyed to see binutils disappear. cgf I took it to mean the opposite - if you uninstalled *binutils*, it would uninstall gcc because gcc depends on them. But on further reflection I'm no longer sure even that is desirable. If I uninstall ash, should say make get deleted even though I have bash as sh? -- Gary R. Van Sickle Brewer. Patriot.
[PATCH] Setup Chooser integration
ALT-TAB no longer! This patch integrates the chooser into the wizard interface, eliminating a field-expedient thread in the process. Changelog also attached: 2002-04-02 Gary R. Van Sickle [EMAIL PROTECTED] * choose.cc: Run indent. (nextbutton): Remove static variable. (default_trust): Remove use of nextbutton. (set_view_mode): Ditto. (create_listview): Add IDC_CHOOSE_PREV and IDC_CHOOSE_NEXT to ta[] so rbset() sets the prev/next/curr radio buttons properly. (dialog_cmd): Delete function. (dialog_proc): Delete function. Move WM_INITDIALOG functionality to ChooserPage::OnInit. (do_choose): Delete function. Move pre-DialogBox() code to ChooserPage::OnInit(), post-DialogBox() code to ChooserPage::OnNext. (WM_APP_START_CHOOSE): Remove define. (WM_APP_CHOOSE_IS_FINISHED): Remove define. (do_choose_thread): Delete function. (ChooserPage::OnActivate): Delete method. (ChooserPage::OnMessageApp): Delete method. (ChooserPage::OnInit): New method. (ChooserPage::OnNext): New method. (ChooserPage::OnBack): New method. (ChooserPage::OnMessageCmd): New method. * choose.h: Run indent. (ChooserPage::OnMessageApp): Delete declaration. (ChooserPage::OnActivate): Ditto. (ChooserPage::OnMessageCmd): New declaration. (ChooserPage::OnInit): Ditto. (ChooserPage::OnNext): Ditto. (ChooserPage::OnBack): Ditto. * desktop.cc (DesktopSetupPage::OnBack): Replace use of IDD_CHOOSER with IDD_CHOOSE. * fromcwd.cc (do_fromcwd): Replace use of IDD_CHOOSER with IDD_CHOOSE. * ini.cc (do_ini_thread): Replace use of IDD_CHOOSER with IDD_CHOOSE. * res.rc (IDD_CHOOSE): Remove dialog template. (IDD_CHOOSER): Alter dialog template to fit wizard size and format. -- Gary R. Van Sickle Brewer. Patriot. setup-chooser-integration.diff Description: Binary data ChangeLog-chooser-integration Description: Binary data