Re: [PATCH 0/8] FIFO: bug fixes and small improvements

2020-08-04 Thread Corinna Vinschen
On Aug  4 08:54, Ken Brown via Cygwin-patches wrote:
> The second patch in this series fixes a serious bug that has resulted
> in observable hangs.  The other patches are minor bug fixes or minor
> performance improvements.
> 
> Ken Brown (8):
>   Cygwin: FIFO: lock fixes
>   Cygwin: FIFO: fix timing issue with owner change
>   Cygwin: FIFO: add a timeout to take_ownership
>   Cygwin: FIFO: reorganize some fifo_client_handler methods
>   Cygwin: FIFO: don't read from pipes that are closing
>   Cygwin: FIFO: synchronize the fifo_reader and fifosel threads
>   Cygwin: FIFO: fix indentation
>   Cygwin: FIFO: add a third pass to raw_read
> 
>  winsup/cygwin/fhandler.h   |  24 +--
>  winsup/cygwin/fhandler_fifo.cc | 358 ++---
>  winsup/cygwin/select.cc|  38 ++--
>  3 files changed, 268 insertions(+), 152 deletions(-)
> 
> -- 
> 2.28.0

LGTM


Corinna


[PATCH 0/8] FIFO: bug fixes and small improvements

2020-08-04 Thread Ken Brown via Cygwin-patches
The second patch in this series fixes a serious bug that has resulted
in observable hangs.  The other patches are minor bug fixes or minor
performance improvements.

Ken Brown (8):
  Cygwin: FIFO: lock fixes
  Cygwin: FIFO: fix timing issue with owner change
  Cygwin: FIFO: add a timeout to take_ownership
  Cygwin: FIFO: reorganize some fifo_client_handler methods
  Cygwin: FIFO: don't read from pipes that are closing
  Cygwin: FIFO: synchronize the fifo_reader and fifosel threads
  Cygwin: FIFO: fix indentation
  Cygwin: FIFO: add a third pass to raw_read

 winsup/cygwin/fhandler.h   |  24 +--
 winsup/cygwin/fhandler_fifo.cc | 358 ++---
 winsup/cygwin/select.cc|  38 ++--
 3 files changed, 268 insertions(+), 152 deletions(-)

-- 
2.28.0