Re: [PATCH v1] Cygwin: disable high-entropy VA for ldh

2024-06-02 Thread Takashi Yano 
On Sun, 2 Jun 2024 15:22:41 -0400
Ken Brown  wrote:

> Hi Takashi,
> 
> On 6/1/2024 6:03 PM, Takashi Yano wrote:
> > Hi Ken,
> > 
> > On Tue, 28 May 2024 10:19:22 -0700 (PDT)
> > Jeremy Drake wrote:
> >> If ldd is run against a DLL which links to the Cygwin DLL, ldh will end
> >> up loading the Cygwin DLL dynamically, much like cygcheck or strace.
> >>
> >> Addresses: https://cygwin.com/pipermail/cygwin/2024-May/255991.html
> >> Fixes: 60675f1a7eb2 ("Cygwin: decouple shared mem regions from Cygwin DLL")
> >> Signed-off-by: Jeremy Drake 
> >> ---
> >>   winsup/utils/mingw/Makefile.am | 1 +
> >>   1 file changed, 1 insertion(+)
> >>
> >> diff --git a/winsup/utils/mingw/Makefile.am 
> >> b/winsup/utils/mingw/Makefile.am
> >> index b89d89490a..07b9f928d4 100644
> >> --- a/winsup/utils/mingw/Makefile.am
> >> +++ b/winsup/utils/mingw/Makefile.am
> >> @@ -53,6 +53,7 @@ cygcheck_LDADD = -lz -lwininet -lshlwapi -lpsapi -lntdll
> >>   cygwin_console_helper_SOURCES = cygwin-console-helper.cc
> >>
> >>   ldh_SOURCES = ldh.cc
> >> +ldh_LDFLAGS = ${AM_LDFLAGS} -Wl,--disable-high-entropy-va
> >>
> >>   strace_SOURCES = \
> >>path.cc \
> >> -- 
> >> 2.45.1.windows.1
> > 
> > If this looks good to you too, shall I commit this patch?
> 
> You and Jeremy know much more about this than I do, but I've read 
> through the thread leading to this patch, and it does look good to me. 
> So I think you should go ahead (after adding a release note).

Thanks! Pushed.

-- 
Takashi Yano

Re: [PATCH v1] Cygwin: disable high-entropy VA for ldh

2024-06-02 Thread Ken Brown 

Hi Takashi,

On 6/1/2024 6:03 PM, Takashi Yano wrote:

Hi Ken,

On Tue, 28 May 2024 10:19:22 -0700 (PDT)
Jeremy Drake wrote:

If ldd is run against a DLL which links to the Cygwin DLL, ldh will end
up loading the Cygwin DLL dynamically, much like cygcheck or strace.

Addresses: https://cygwin.com/pipermail/cygwin/2024-May/255991.html
Fixes: 60675f1a7eb2 ("Cygwin: decouple shared mem regions from Cygwin DLL")
Signed-off-by: Jeremy Drake 
---
  winsup/utils/mingw/Makefile.am | 1 +
  1 file changed, 1 insertion(+)

diff --git a/winsup/utils/mingw/Makefile.am b/winsup/utils/mingw/Makefile.am
index b89d89490a..07b9f928d4 100644
--- a/winsup/utils/mingw/Makefile.am
+++ b/winsup/utils/mingw/Makefile.am
@@ -53,6 +53,7 @@ cygcheck_LDADD = -lz -lwininet -lshlwapi -lpsapi -lntdll
  cygwin_console_helper_SOURCES = cygwin-console-helper.cc

  ldh_SOURCES = ldh.cc
+ldh_LDFLAGS = ${AM_LDFLAGS} -Wl,--disable-high-entropy-va

  strace_SOURCES = \
path.cc \
--
2.45.1.windows.1


If this looks good to you too, shall I commit this patch?


You and Jeremy know much more about this than I do, but I've read 
through the thread leading to this patch, and it does look good to me. 
So I think you should go ahead (after adding a release note).


Ken

Re: [PATCH v1] Cygwin: disable high-entropy VA for ldh

2024-06-01 Thread Takashi Yano 
Hi Ken,

On Tue, 28 May 2024 10:19:22 -0700 (PDT)
Jeremy Drake wrote:
> If ldd is run against a DLL which links to the Cygwin DLL, ldh will end
> up loading the Cygwin DLL dynamically, much like cygcheck or strace.
> 
> Addresses: https://cygwin.com/pipermail/cygwin/2024-May/255991.html
> Fixes: 60675f1a7eb2 ("Cygwin: decouple shared mem regions from Cygwin DLL")
> Signed-off-by: Jeremy Drake 
> ---
>  winsup/utils/mingw/Makefile.am | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/winsup/utils/mingw/Makefile.am b/winsup/utils/mingw/Makefile.am
> index b89d89490a..07b9f928d4 100644
> --- a/winsup/utils/mingw/Makefile.am
> +++ b/winsup/utils/mingw/Makefile.am
> @@ -53,6 +53,7 @@ cygcheck_LDADD = -lz -lwininet -lshlwapi -lpsapi -lntdll
>  cygwin_console_helper_SOURCES = cygwin-console-helper.cc
> 
>  ldh_SOURCES = ldh.cc
> +ldh_LDFLAGS = ${AM_LDFLAGS} -Wl,--disable-high-entropy-va
> 
>  strace_SOURCES = \
>   path.cc \
> -- 
> 2.45.1.windows.1

If this looks good to you too, shall I commit this patch?

-- 
Takashi Yano

Re: [PATCH v1] Cygwin: disable high-entropy VA for ldh

2024-05-28 Thread Jeremy Drake via Cygwin-patches 
On Tue, 28 May 2024, Jeremy Drake via Cygwin-patches wrote:

> @@ -53,6 +53,7 @@ cygcheck_LDADD = -lz -lwininet -lshlwapi -lpsapi -lntdll

Oops, I accidentally generated this patch against msys2-3.5.3 branch,
rather than cygwin master like the last one.  The only difference is the
line numbers above, and it does apply cleanly to cygwin master, so I won't
send another version unless I'm requested to.

[PATCH v1] Cygwin: disable high-entropy VA for ldh

2024-05-28 Thread Jeremy Drake via Cygwin-patches 
If ldd is run against a DLL which links to the Cygwin DLL, ldh will end
up loading the Cygwin DLL dynamically, much like cygcheck or strace.

Addresses: https://cygwin.com/pipermail/cygwin/2024-May/255991.html
Fixes: 60675f1a7eb2 ("Cygwin: decouple shared mem regions from Cygwin DLL")
Signed-off-by: Jeremy Drake 
---
 winsup/utils/mingw/Makefile.am | 1 +
 1 file changed, 1 insertion(+)

diff --git a/winsup/utils/mingw/Makefile.am b/winsup/utils/mingw/Makefile.am
index b89d89490a..07b9f928d4 100644
--- a/winsup/utils/mingw/Makefile.am
+++ b/winsup/utils/mingw/Makefile.am
@@ -53,6 +53,7 @@ cygcheck_LDADD = -lz -lwininet -lshlwapi -lpsapi -lntdll
 cygwin_console_helper_SOURCES = cygwin-console-helper.cc

 ldh_SOURCES = ldh.cc
+ldh_LDFLAGS = ${AM_LDFLAGS} -Wl,--disable-high-entropy-va

 strace_SOURCES = \
path.cc \
-- 
2.45.1.windows.1