Re: [PATCH v2 0/3] Reworks for console code

2019-03-31 Thread Corinna Vinschen 
Hi Takashi,

On Mar 31 22:47, Takashi Yano wrote:
> Hi Corinna,
> 
> I have revised the patches according to your advice.
> Could you please have a look?

Thanks for sending this in git `send-email' style :)))

I have a few comments on patch 1 only.  Please see there.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer


signature.asc
Description: PGP signature

[PATCH v2 0/3] Reworks for console code

2019-03-31 Thread Takashi Yano 
Hi Corinna,

I have revised the patches according to your advice.
Could you please have a look?

Takashi Yano (3):
  Cygwin: console: support 24 bit color
  Cygwin: console: fix select() behaviour
  Cygwin: console: Make I/O functions thread-safe

 winsup/cygwin/environ.cc  |7 +-
 winsup/cygwin/fhandler.h  |   34 +-
 winsup/cygwin/fhandler_console.cc | 1153 +++--
 winsup/cygwin/select.cc   |   90 +--
 winsup/cygwin/wincap.cc   |   10 +
 winsup/cygwin/wincap.h|2 +
 6 files changed, 840 insertions(+), 456 deletions(-)

-- 
2.17.0