RE: Problem with winsup/cinstall compilation

2002-01-12 Thread Ralf Habacker

EMail: [EMAIL PROTECTED]

 -Original Message-
 From: [EMAIL PROTECTED]
 [mailto:[EMAIL PROTECTED]]On Behalf Of Christopher Faylor
 Sent: Friday, January 11, 2002 5:51 PM
 To: [EMAIL PROTECTED]
 Subject: Re: Problem with winsup/cinstall compilation


 On Fri, Jan 11, 2002 at 03:45:06PM +0100, Ralf Habacker wrote:
 
  Ralf, I've checked this in.
 
  However: Your changelog was atrocious.
 
  The changes are meant to be 'proper' sentences. That means
  capitalisation is important, as is spelling.
 
  Next time I'll reject the patch and get you to fix it up. That wastes
  time (yours) though, so I'd really prefer it if the changelog is
  acceptable first time round.
 
 I have looked in the cygwin ChangeLog for making a proper ChangeLog, but don't 
recognized
 this details. Sorry

 http://cygwin.com/contrib.html

I have read this and I see many what not to do statements relating changelog. I 
think it
would be easier and faster to read if some true examples are included at this page. :-)

Ralf





Re: Problem with winsup/cinstall compilation

2002-01-12 Thread Corinna Vinschen

On Sat, Jan 12, 2002 at 07:14:25PM +0100, Ralf Habacker wrote:
 EMail: [EMAIL PROTECTED]
 
  -Original Message-
  From: [EMAIL PROTECTED]
  [mailto:[EMAIL PROTECTED]]On Behalf Of Christopher Faylor
  Sent: Friday, January 11, 2002 5:51 PM
  To: [EMAIL PROTECTED]
  Subject: Re: Problem with winsup/cinstall compilation
 
 
  On Fri, Jan 11, 2002 at 03:45:06PM +0100, Ralf Habacker wrote:
  
   Ralf, I've checked this in.
  
   However: Your changelog was atrocious.
  
   The changes are meant to be 'proper' sentences. That means
   capitalisation is important, as is spelling.
  
   Next time I'll reject the patch and get you to fix it up. That wastes
   time (yours) though, so I'd really prefer it if the changelog is
   acceptable first time round.
  
  I have looked in the cygwin ChangeLog for making a proper ChangeLog, but don't 
recognized
  this details. Sorry
 
  http://cygwin.com/contrib.html
 
 I have read this and I see many what not to do statements relating changelog. I 
think it
 would be easier and faster to read if some true examples are included at this page. 
:-)

Isn't the ChangeLog file itself *the* example?

Corinna

-- 
Corinna Vinschen  Please, send mails regarding Cygwin to
Cygwin Developermailto:[EMAIL PROTECTED]
Red Hat, Inc.



RE: Problem with winsup/cinstall compilation

2002-01-11 Thread Ralf Habacker


 Ralf, I've checked this in.

 However: Your changelog was atrocious.

 The changes are meant to be 'proper' sentences. That means
 capitalisation is important, as is spelling.

 Next time I'll reject the patch and get you to fix it up. That wastes
 time (yours) though, so I'd really prefer it if the changelog is
 acceptable first time round.

I have looked in the cygwin ChangeLog for making a proper ChangeLog, but don't 
recognized
this details. Sorry

Ralf




Re: Problem with winsup/cinstall compilation

2002-01-11 Thread Christopher Faylor

On Fri, Jan 11, 2002 at 03:45:06PM +0100, Ralf Habacker wrote:

 Ralf, I've checked this in.

 However: Your changelog was atrocious.

 The changes are meant to be 'proper' sentences. That means
 capitalisation is important, as is spelling.

 Next time I'll reject the patch and get you to fix it up. That wastes
 time (yours) though, so I'd really prefer it if the changelog is
 acceptable first time round.

I have looked in the cygwin ChangeLog for making a proper ChangeLog, but don't 
recognized
this details. Sorry

http://cygwin.com/contrib.html

cgf



Problem with winsup/cinstall compilation

2002-01-10 Thread Ralf Habacker

Hi,

I've tried to compile a recent setup.exe from the cvs and got an error while compiling
mklink2.c about function declaration isn't a prototype
I've found that in cinstall/Makefile.in the -Werror option is set, so warnings causes
compiling failures.

What about this ? As I see there are two solutions for this.

1. remove the -Werror in Makefile.in
CFLAGS  := @CFLAGS@ -Werror -Winline -Wall -Wpointer-arith -Wcast-align\
  
-Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes \
-Wmissing-declarations -Wcomments

2. fix the bad header.
   This seems to me the better solution, so a patch for the w32api header is appended.

Charles Wilson told me, to send this patch to cygwin-patches, so I'm doing this :-)

Regards
Ralf





w32api_20010110.dif
Description: Binary data


ChangeLog.w32api_20010110
Description: Binary data