[NON-WHINE] RE: mkstemp vs. text mode
From: Gary R. Van Sickle From: Gary R. Van Sickle From: Christopher Faylor [snip] Yes, I think it makes sense to open temp files in binary but I'll bet that someone is relying on textmode behavior. I'll see that bet and raise you; I'll bet this results in massive problems. Welp, looks like I (probably) lose that hand (happily). Using: CYGWIN_NT-5.1 DFW5RB41 1.5.20s(0.155/4/2) 20060418 12:31:05 i686 Cygwin with a /tmp mounted as text mode works fine for a configure, build, and install of wxWindows. The configure does most of the temp file machinations, with about 2000 add, modify, and remove events in the /tmp directory, as reported by a program I have for monitoring such things. -- Gary R. Van Sickle
Re: mkstemp vs. text mode
On Mon, Apr 17, 2006 at 06:18:38AM -0600, Eric Blake wrote: Should we change mkstemp to always open in binary mode, regardless of the mount mode of the directory of the template name? Arguments for this is that mkstemp is often used by programs for binary data, where a text-mode /tmp mount point would corrupt that data if we defer to the mount point. Also, a temp file is an intermediate data storage location, similar to pipes, and we currently treat pipes as binary by default; a program copying data to a temp file, then from there to a final destination, only needs text mode on the final destination. Programs that really want a text-mode temp file can do setmode after the fact, but this is probably less common. This should still be a trivial patch. Meanwhile, I will start the process of getting an employee disclaimer for Red Hat (it took me almost a year to get one signed for FSF). 2006-04-17 Eric Blake [EMAIL PROTECTED] * mktemp.cc (_gettemp): Open temp files in binary mode. Yes, I think it makes sense to open temp files in binary but I'll bet that someone is relying on textmode behavior. Nevertheless, I've applied the patch. Let the cygwin ML whines begin... cgf
RE: mkstemp vs. text mode
From: Gary R. Van Sickle From: Christopher Faylor [snip] Yes, I think it makes sense to open temp files in binary but I'll bet that someone is relying on textmode behavior. I'll see that bet and raise you; I'll bet this results in massive problems. Nevertheless, I've applied the patch. Let the cygwin ML whines begin... cgf Ok, I'm about to give it a try (assuming this is in the latest snapshot). When I have some positive results, I shall post them to [EMAIL PROTECTED] If I have negative results, should I post them there as well, or would that be considered a whine? -- Gary R. Van Sickle Last snapshot 4/13, never mind: any potential whine reports will have to wait for another day. -- Gary R. Van Sickle
