taskbar and system tray menus

2003-06-03 Thread Jack Tanner
I know this is really, really nitpicky, and inconsequential in 
comparison with the great work recently done on Xfree (thank you folks 
enormously!), but still: can the context menu for all X clients be 
re-ordered such that the Exit option is bottom-most? (For example, see 
the context menus for any application not in the system tray.)

On a related note, can the context menu for the system tray icon be 
re-ordered the same way?

My motivation for this request is that I'm simply very used to closing 
applications by right-clicking and picking the last option on the list, 
which is where my mouse pointer already happens to be.

-JT



Re: taskbar and system tray menus

2003-06-03 Thread Harold L Hunt II
Jack,

Let me rephrase this:

1) Move 'Always On Top' to the top of the system menu, instead of 
putting it at the bottom.

2) Move 'Exit' from the top of the notification tray icon menu to the 
bottom.

Those sound doable and they both sound like standards that other Windows 
apps follows.  I think they should be done.

Harold

Jack Tanner wrote:

I know this is really, really nitpicky, and inconsequential in 
comparison with the great work recently done on Xfree (thank you folks 
enormously!), but still: can the context menu for all X clients be 
re-ordered such that the Exit option is bottom-most? (For example, see 
the context menus for any application not in the system tray.)

On a related note, can the context menu for the system tray icon be 
re-ordered the same way?

My motivation for this request is that I'm simply very used to closing 
applications by right-clicking and picking the last option on the list, 
which is where my mouse pointer already happens to be.

-JT



Re: taskbar and system tray menus

2003-06-03 Thread Harold L Hunt II
Colin,

I would much rather have you fix this :)

Test91 includes the reorg that I was talking about.  Feel free to patch 
away.

Harold

Colin Harrison wrote:

Hi-Jack,

It's fairly easy to do this (multiwindow)

I assume you want the 'Close' at the bottom instead of the 'Always On Top'
in the sys menus (right click on app. title or task bar) (i.e. the two menu
items transposed)?
and 'Exit' at the bottom below 'Show Root Window' in the tray (right click
on tray X icon )(again transposed)?
If others agree... I'll try this after Harold's reorg.

Coding Note: requires a minor change to XWin.rc and a function call change
in winmultiwindowwindow.c.(AppendMenu to InsertMenu or InsertMenuItem with a
bit of jiggery pokery)
I agree it would be more 'normal' to have close/exits at the bottom of menu
items (why be weird, it's almost a standard in Windows, until MS re-style
and blow us all away!)
Colin   



Re: taskbar and system tray menus

2003-06-03 Thread Jack Tanner
Colin Harrison wrote:
I assume you want the 'Close' at the bottom instead of the 'Always On Top'
in the sys menus (right click on app. title or task bar) (i.e. the two menu
items transposed)?
and 'Exit' at the bottom below 'Show Root Window' in the tray (right click
on tray X icon )(again transposed)?
Yup, this is exactly what I want.

If others agree... I'll try this after Harold's reorg.
Thank you!

Another, even nitpickier request re: the tray menu. The current behavior 
is: click on Show Root Window, get the root window, and the menu 
changes to Hide Root Window; click on Hide Root Window, the root 
window hides, and the menu changes to Show Root Window.

It feels like bad UI to change the menu entry from underneath the user. 
My suggestion: make the default menu Hide Root Window with a (checked) 
checkbox next to it. When the user clicks on (checked) Hide Root 
Window, show the root window and clear the cbeckbox. When the user 
clicks on (unchecked) Hide Root Window, hide the root window and set 
the check again.

-JT




Re: taskbar and system tray menus

2003-06-03 Thread Ilya Goldin
Colin Harrison wrote:
I assume you want the 'Close' at the bottom instead of the 'Always On Top'
in the sys menus (right click on app. title or task bar) (i.e. the two menu
items transposed)?
and 'Exit' at the bottom below 'Show Root Window' in the tray (right click
on tray X icon )(again transposed)?
Yup, this is exactly what I want.

If others agree... I'll try this after Harold's reorg.
Thank you!

Another, even nitpickier request re: the tray menu. The current behavior
is: click on Show Root Window, get the root window, and the menu
changes to Hide Root Window; click on Hide Root Window, the root
window hides, and the menu changes to Show Root Window.
It feels like bad UI to change the menu entry from underneath the user.
My suggestion: make the default menu Hide Root Window with a (checked)
checkbox next to it. When the user clicks on (checked) Hide Root
Window, show the root window and clear the cbeckbox. When the user
clicks on (unchecked) Hide Root Window, hide the root window and set
the check again.
-JT





Re: taskbar and system tray menus

2003-06-03 Thread Harold L Hunt II
Jack Tanner wrote:
  It feels like bad UI to change the menu entry from underneath the user.
My suggestion: make the default menu Hide Root Window with a (checked) 
checkbox next to it. When the user clicks on (checked) Hide Root 
Window, show the root window and clear the cbeckbox. When the user 
clicks on (unchecked) Hide Root Window, hide the root window and set 
the check again.
Right.  I didn't know that checkboxes were so easy when I implemented 
it.  I will probably change this, since I did the same sort of thing in 
my Morse Code Beeper that I just posted.

Harold



Re: taskbar and system tray menus

2003-06-03 Thread Colin Harrison
Hi Harold,

Code changes for this, I missed the mail earlier on doing the checkbox bit
on Hide Root Window, one for you? 

'Exit' to bottom on tray and 'Always On Top' to top on sys menu (better I
think than the transpose with 'Close')
So 'Exit' and 'Close' are now at bottom of respective menus.

I put a hot-key on the T in 'Top' (made sense to me).


Patches:- 
---8--
--- save_XWin.rc2003-06-01 04:04:12.0 +0100
+++ XWin.rc 2003-06-02 21:04:46.0 +0100
@@ -72,10 +72,10 @@
 BEGIN
POPUP TRAYICON_MENU
BEGIN
-   MENUITEM Exit, ID_APP_EXIT
-   MENUITEM SEPARATOR
MENUITEM Hide Root Window, ID_APP_HIDE_ROOT
MENUITEM Show Root Window, ID_APP_SHOW_ROOT
+   MENUITEM SEPARATOR
+   MENUITEM Exit, ID_APP_EXIT
END
 END
8
8
--- save_winmultiwindowwndproc.c2003-06-02 15:11:46.0 +0100
+++ winmultiwindowwndproc.c 2003-06-02 21:59:28.0 +0100
@@ -175,8 +175,8 @@

sys = GetSystemMenu (hwnd, FALSE);

-   AppendMenu (sys, MF_SEPARATOR, 0, NULL);
-   AppendMenu (sys, MF_STRING, ID_APP_ALWAYS_ON_TOP, Always On Top);
+   InsertMenu (sys, 0, MF_BYPOSITION | MF_SEPARATOR, 0, NULL);
+   InsertMenu (sys, 0, MF_BYPOSITION | MF_STRING, ID_APP_ALWAYS_ON_TOP,
Always On Top);
   }
   return 0;
8-

Cheers,

Colin



Re: taskbar and system tray menus

2003-06-03 Thread Earle F. Philhower, III
Hi Colin and Harold.

It seems like there is a storm of nit-picking this week, must be something
in the air.  Anyhoo...

-- Original Message -
Subject: Re: taskbar and system tray menus
..
'Exit' to bottom on tray and 'Always On Top' to top on sys menu (better I
think than the transpose with 'Close')
So 'Exit' and 'Close' are now at bottom of respective menus.
--

My nit is this placing the custom items before the system items
in the title menu is against all other Windoze UIs I've ever seen:
nobody adds things to the top of the popup menu.  Check for yourself,
right-click on a CMD shell or cygwin shell, you see the
Edit/Defaults/Props menu items after the Windoze standard ones.
Right-click on an IE mini-icon in the title bar, you get Close
followed by Make available offline.  Or a regular explorer window,
you get Close followed by all the other items...
-- 
-Earle F. Philhower, III
 [EMAIL PROTECTED]
 http://www.ziplabel.com



Re: taskbar and system tray menus

2003-06-03 Thread Christopher Faylor
On Mon, Jun 02, 2003 at 09:38:55PM -, Earle F. Philhower, III wrote:
It seems like there is a storm of nit-picking this week, must be something
in the air.  Anyhoo...

That's usually a sign that a project is approaching stability and maturity
and users are turning to other things.  It seems like the flood of spelling
corrections that historically hits the linux kernel list when the kernel
is close to being released.

cgf


Re: taskbar and system tray menus

2003-06-03 Thread Colin Harrison
Hi Earle,

I must admit I like 'Close' at the bottom.
Harold must rule on this one, or else we'll keep moving the furniture around
:)
I'm easy either way, I won't use the menu much anyway.
As always 95% of the effort goes into only 5% of the product!
'Always on Top' has a natural place somewhere I'm sure!

Aren't the nits biting today.
Asking an obvious question: Why do we need an 'Always on Top'anyway?
It's silly on most of the remote stuff I run to ever want this to happen.

Only taskbars (Office bars etc) get this privilege to dominate the desktop
and
only then around the edges!

Colin 



Re: taskbar and system tray menus

2003-06-03 Thread Earle F. Philhower III
At 05:49 PM 6/2/2003 -0400, Christopher Faylor wrote:
On Mon, Jun 02, 2003 at 09:38:55PM -, Earle F. Philhower, III wrote:
It seems like there is a storm of nit-picking this week, must be something
in the air.  Anyhoo...
That's usually a sign that a project is approaching stability and maturity
and users are turning to other things.  It seems like the flood of spelling
corrections that historically hits the linux kernel list when the kernel
is close to being released.
If only that was the case! :)  I think there is still mucho trabajo a hacer,
especially in the Window Manager part of the multiwin setup.  Everyone seems
to want it to do something different, and IMHO you can either
a) hack the code to make nobody happy (person X says 'oh, I want it to do 
A' and
person Y says 'oh, if it does A then it's junk!'), or
b) put in real configuration files just like FVWM where you have a ~/.xwinrc
with lines like AlwaysOnTop = FALSE and ContextMenu=[xterm on XXX,
xterm on YYY, ...] and xterm.*.icon=bigicon.png,littleicon.png

Plus, there's the work Harold's doing on the windows message hooks which might
be a really big change.
-Earle F. Philhower, III
 [EMAIL PROTECTED]
 cdrlabel - ZipLabel - FlpLabel
 http://www.cdrlabel.com