Re: POLL: what should reconstruct -f do?
On 2011-04-23 at 10:34, Jeroen van Meeuwen (Kolab Systems) wrote: Bron Gondwana wrote: 3) add the mailbox if there's a directory, don't require cyrus.header. This one has my preference. Mine as well. -- Øyvind Kolbu Postmaster Universitetet i Oslo pgpKldR2FjrNv.pgp Description: PGP signature
Re: POLL: what should reconstruct -f do?
On 23.4.2011 2:07, Bron Gondwana wrote: The question came up from the following bug report: http://bugzilla.cyrusimap.org/bugzilla3/show_bug.cgi?id=3449 Where there were spool files on disk, but no meta data left. Reconstruct gave no information about the files on disk at all. I see 4 options, can I'd like some opinions on what people think reconstruct should do. Speak now(ish) or hold your peace! 1) what we do now - require a cyrus.header in the directory or ignore it. 2) like (1) but warn about the directory with no cyrus.header 3) add the mailbox if there's a directory, don't require cyrus.header. 4) like (3) - but check that there's at least one cyrus.* file OR at least one message file in the directory before creating the mailbox. (so an empty directory doesn't generate a bogus mailbox, and neither does one containing nothing that looks like it belongs in a mailbox) I vote option 3. The option 4 is a secondary choice. -- Leena Heino University of Tampere / Computer Centre ( liinu at uta.fi ) ( http://www.uta.fi/laitokset/tkk )
Re: POLL: what should reconstruct -f do?
On 23 Apr 2011, at 00:07, Bron Gondwana wrote: I see 4 options, can I'd like some opinions on what people think reconstruct should do. Speak now(ish) or hold your peace! 3) add the mailbox if there's a directory, don't require cyrus.header. Number 3. As people have said, it's easier to delete something created in error than try to find something that should have been created but wasn't. Simon -- Simon Amor si...@leaky.org http://www.leaky.org/
Re: POLL: what should reconstruct -f do?
Number 2) with additional command line option to trigger 3). Ondřej Surý On 23.4.2011, at 1:07, Bron Gondwana br...@fastmail.fm wrote: The question came up from the following bug report: http://bugzilla.cyrusimap.org/bugzilla3/show_bug.cgi?id=3449 Where there were spool files on disk, but no meta data left. Reconstruct gave no information about the files on disk at all. I see 4 options, can I'd like some opinions on what people think reconstruct should do. Speak now(ish) or hold your peace! 1) what we do now - require a cyrus.header in the directory or ignore it. 2) like (1) but warn about the directory with no cyrus.header 3) add the mailbox if there's a directory, don't require cyrus.header. 4) like (3) - but check that there's at least one cyrus.* file OR at least one message file in the directory before creating the mailbox. (so an empty directory doesn't generate a bogus mailbox, and neither does one containing nothing that looks like it belongs in a mailbox) Alright, cast your votes! I'll come back to this thread in a week or so and implement the winner. (4) is the hardest to implement, but even that's not very tricky. Bron.
POLL: what should reconstruct -f do?
The question came up from the following bug report: http://bugzilla.cyrusimap.org/bugzilla3/show_bug.cgi?id=3449 Where there were spool files on disk, but no meta data left. Reconstruct gave no information about the files on disk at all. I see 4 options, can I'd like some opinions on what people think reconstruct should do. Speak now(ish) or hold your peace! 1) what we do now - require a cyrus.header in the directory or ignore it. 2) like (1) but warn about the directory with no cyrus.header 3) add the mailbox if there's a directory, don't require cyrus.header. 4) like (3) - but check that there's at least one cyrus.* file OR at least one message file in the directory before creating the mailbox. (so an empty directory doesn't generate a bogus mailbox, and neither does one containing nothing that looks like it belongs in a mailbox) Alright, cast your votes! I'll come back to this thread in a week or so and implement the winner. (4) is the hardest to implement, but even that's not very tricky. Bron.
Re: POLL: what should reconstruct -f do?
* 23/04/2011, Bron Gondwana wrote : The question came up from the following bug report: http://bugzilla.cyrusimap.org/bugzilla3/show_bug.cgi?id=3449 Where there were spool files on disk, but no meta data left. Reconstruct gave no information about the files on disk at all. I see 4 options, can I'd like some opinions on what people think reconstruct should do. Speak now(ish) or hold your peace! 3) add the mailbox if there's a directory, don't require cyrus.header. number 3 ... IMHO is improbable to found a totally bogus dir under Maildir tree ! -- Never try to teach a pig to sing. It wastes your time and annoys the pig.
