[cytoscape/cytoscape.js] 1a6c40: Add support for `edge-distances:endpoints`

2023-09-28 Thread 'Max Franz' via cytoscape-cvs
  Branch: refs/heads/unstable
  Home:   https://github.com/cytoscape/cytoscape.js
  Commit: 1a6c4079f3c74d00d11b158f2f77101cfe7e0891
  
https://github.com/cytoscape/cytoscape.js/commit/1a6c4079f3c74d00d11b158f2f77101cfe7e0891
  Author: Max Franz 
  Date:   2023-09-12 (Tue, 12 Sep 2023)

  Changed paths:
M documentation/md/style.md
M src/extensions/renderer/base/coord-ele-math/edge-control-points.js
M src/style/properties.js

  Log Message:
  ---
  Add support for `edge-distances:endpoints`

Ref: edge-distances: endpoints #3157

Notes:

- This change allows bundled bezier edges, unbundled bezier edges, and segment 
edges to use `edge-distances: endpoints`.
- The documentation has been updated accordingly.
- The change is minimally invasive by making a new function for the adjustment.
  - The adjustment alters the midpoint and the inverted normal vector used for 
middle-point calculations (e.g. bezier control points).
  - Limitation: The adjustment must happen at the middle-point phase, rather 
than the endpoint phase.  The endpoint phase happens after the middle point 
phase, because many edges have automatic endpoints based on the middle points.  
This means that the endpoint calculations would be duplicated for 
`edge-distances: endpoints` edges.  In future, this could be optimised if 
needed.
- Limitation: For a bundled bezier, this implementation assumes that all 
beziers in the bundle have the same endpoint.  That doesn't seem like a valid 
use case, anyway.


  Commit: ae20223c4b3f6503be0a5be80ef2445352390eea
  
https://github.com/cytoscape/cytoscape.js/commit/ae20223c4b3f6503be0a5be80ef2445352390eea
  Author: Max Franz 
  Date:   2023-09-28 (Thu, 28 Sep 2023)

  Changed paths:
M documentation/md/style.md
M src/extensions/renderer/base/coord-ele-math/edge-control-points.js
M src/style/properties.js

  Log Message:
  ---
  Merge pull request #3163 from cytoscape/feature/edge-dist-endpt

Add support for `edge-distances:endpoints`


Compare: 
https://github.com/cytoscape/cytoscape.js/compare/576121a242f7...ae20223c4b3f

-- 
You received this message because you are subscribed to the Google Groups 
"cytoscape-cvs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to cytoscape-cvs+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/cytoscape-cvs/cytoscape/cytoscape.js/push/refs/heads/unstable/576121-ae2022%40github.com.


[cytoscape/cytoscape.js] 1a6c40: Add support for `edge-distances:endpoints`

2023-09-12 Thread 'Max Franz' via cytoscape-cvs
  Branch: refs/heads/feature/edge-dist-endpt
  Home:   https://github.com/cytoscape/cytoscape.js
  Commit: 1a6c4079f3c74d00d11b158f2f77101cfe7e0891
  
https://github.com/cytoscape/cytoscape.js/commit/1a6c4079f3c74d00d11b158f2f77101cfe7e0891
  Author: Max Franz 
  Date:   2023-09-12 (Tue, 12 Sep 2023)

  Changed paths:
M documentation/md/style.md
M src/extensions/renderer/base/coord-ele-math/edge-control-points.js
M src/style/properties.js

  Log Message:
  ---
  Add support for `edge-distances:endpoints`

Ref: edge-distances: endpoints #3157

Notes:

- This change allows bundled bezier edges, unbundled bezier edges, and segment 
edges to use `edge-distances: endpoints`.
- The documentation has been updated accordingly.
- The change is minimally invasive by making a new function for the adjustment.
  - The adjustment alters the midpoint and the inverted normal vector used for 
middle-point calculations (e.g. bezier control points).
  - Limitation: The adjustment must happen at the middle-point phase, rather 
than the endpoint phase.  The endpoint phase happens after the middle point 
phase, because many edges have automatic endpoints based on the middle points.  
This means that the endpoint calculations would be duplicated for 
`edge-distances: endpoints` edges.  In future, this could be optimised if 
needed.
- Limitation: For a bundled bezier, this implementation assumes that all 
beziers in the bundle have the same endpoint.  That doesn't seem like a valid 
use case, anyway.


-- 
You received this message because you are subscribed to the Google Groups 
"cytoscape-cvs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to cytoscape-cvs+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/cytoscape-cvs/cytoscape/cytoscape.js/push/refs/heads/feature/edge-dist-endpt/00-1a6c40%40github.com.