Re: [darcs-devel] [issue589] buggy error message: Impossible case in darcs PatchRead.lhs or Patch/Read.lhs
> darcs get http://darcs.net/repos/unstable Works fine (takes forever, but I guess that's the 5,077 separate http requests) and build fine. I reproduces the original message by writing rubbish into one of the Yi patch files; now I get the message: $ ../darcs/unstable/darcs repair darcs: failed to read patch: Mon Aug 15 02:25:46 BST 2005 Don Stewart <[EMAIL PROTECTED]> * kill off silly ^M in test data Couldn't parse file /home/mga83/working/Haskell/yi.hack/_darcs/patches/20050815012546-9c5c1-2181b0dfc6b06ff299fa072570ab0c9417ae5715.gz $ Seems fair enough, and if I delete the offending file I get the extra text on the end of the filename: : openBinaryFile: does not exist (No such file or directory) Seems ok to me. One oddity I noticed, don't know if it signifies anything: while reading the patches it starts counting up reporting: Reading patches from /home/mga83/working/Haskell/yi.hack 14/331 ... except there are a good deal more that 331 to read! When the number (14 above) grows above 331 the /331 goes away. I don't know if this signifies anything, but it's new behaviour since the stable version. ___ darcs-devel mailing list darcs-devel@darcs.net http://lists.osuosl.org/mailman/listinfo/darcs-devel
Re: [darcs-devel] [issue589] buggy error message: Impossible case in darcs PatchRead.lhs or Patch/Read.lhs
On Fri, 25 Jan 2008, David Roundy wrote: > Micheal, have you still got your repository/proxy combination that > corrupts patches? > > If so, could you try this test again with the latest darcs 2? I've made > a change that will (I think) improve the error message (by changing to a > strict parsing), but I'd rather close this after hearing from you that > it's good enough. Alas, after I complained, the administrators fixed the problem (by adding the web site to an exceptions list, the idiots, but you can't have everything), so alas I can't reproduce the problem anymore! However, come to think of it, I can reproduce it simply by trashing one of the patches in place and running `darcs repair`. Let's see... Sorry, I'm going to need some advice: I can't figure out how to get your latest version. Running `darcs pull` tells me that I'm up to date, which I suspect is because I'm on http://darcs.net/repos/stable ... unfortunately a fairly quick search gives me no clue as to where the current bleeding edge version of darcs is! Sorry for being obtuse here. I'll have a go some time tomorrow if you can point me in the right direction. > Thanks for your bug report! P.S. The page http://www.darcs.net/manual/node3.html still refers me to http://abridgegame.org/repos/darcs which is dormant; I think ertai (message 2538) said they'd made a patch to fix this? ___ darcs-devel mailing list darcs-devel@darcs.net http://lists.osuosl.org/mailman/listinfo/darcs-devel
Re: [darcs-devel] [issue589] buggy error message: Impossible case in darcs PatchRead.lhs or Patch/Read.lhs
On Fri, 25 Jan 2008, Mark Stosberg wrote: > If this is just a string change to create a better error message, perhaps this > issue could be resolved sooner? > > I still don't understand the issue well enough to even suggest what a better > error message might be. If we're just talking about improving the error message, then can I suggest something along the lines of: Patch blah blah corrupted: unable to apply where the blah blah bit gives the proper filename of the patch. Then at least I can hunt it out and look inside it to see -- aha! my damned proxy again. The current error message says (1) panic panic darcs is broken and (2) just identifies the patch by number. The problem with this is that finding the patch file requires a little guesswork and the lucky fact that `ls` lists the patches in the same order as darcs was reading them. ___ darcs-devel mailing list darcs-devel@darcs.net http://lists.osuosl.org/mailman/listinfo/darcs-devel
Re: [darcs-devel] [issue589] Impossible case in darcs PatchRead.lhs or Patch/Read.lhs
> Michael, could this download be passing through a proxy that might > modify the files? > > Could you diff the contents of your _darcs/patches directory agains that of > the > attached yi.tar.bz2? Absolute, and this was definitely the trigger. It took me a while to figure it out (there are some 1,500 patches in Yi) but, yes, for whatever reason our web poxy decided to transform one patch into something completely different. So perhaps this transforms the issue from an outright bug into an unfriendly behaviour. I see two points: 1. The error message implies that the problem is entirely the fault of darcs (and so of course gives little hint about identifying the true culprit). 2. Evidently darcs fails to do any checking on the patches before processing them. A CRC checksum might be a good thing. Actually, the fact that darcs fetchs each of 1500 patches as separate http requests is itself rather painful: takes much longer than it would if this could be done as a single http or https request -- and using https would bypass any brain damaged proxy to further benefit! ___ darcs-devel mailing list darcs-devel@darcs.net http://lists.osuosl.org/mailman/listinfo/darcs-devel
[darcs-devel] Impossible case in darcs PatchRead.lhs or Patch/Read.lhs
I sent the mail below to [EMAIL PROTECTED], but I can't see any trace of it anywhere, so maybe it got lost. I can follow up, though, with something useful: it appears that the patch in question got silently eaten by our goddamned web filter (and converted into a message about "inappropriate" material)! darcs could handle this a bit more smoothly, in particular some form of patch file validation would be sensible, together with reporting the name of the failing patch! The patch in question happens to contain a copy of "Utopia" by Thomas More (test data for Yi?): this is obviously regarded as inappropriate and subversive content by the UK government! Actually, it would be even better if darcs could download all of the patches as a single http request, but I guess that would require more cooperation from the server than the current model allows; even better as an https request to bypass the crap that proxies produce. -- Forwarded message -- Date: Tue, 15 Jan 2008 18:59:33 + (GMT) From: Michael Abbott <[EMAIL PROTECTED]> To: [EMAIL PROTECTED] Subject: Impossible case in darcs PatchRead.lhs or Patch/Read.lhs Running darcs get http://code.haskell.org/yi produces one of the following responses (depending on version). Running the darcs-1.0.9-i386-linux binary, as downloaded from darcs.net, produces the message: $ darcs get http://code.haskell.org/yi ... FINISHED --18:23:31-- Downloaded: 5,562,103 bytes in 1370 files Applying patch 551 of 1370... darcs: bug in darcs! Impossible case at PatchRead.lhs:58 compiled 18:47:46 Aug 28 2007 Please report this to [EMAIL PROTECTED], If possible include the output of 'darcs --exact-version'. $ darcs --exact-version darcs compiled on Aug 28 2007, at 18:50:44 # configured Sat Jun 16 09:59:48 PDT 2007 ./configure /usr/local/share/config.site /usr/local/etc/config.site Context: [TAG 1.0.9 Tommy Pettersson <[EMAIL PROTECTED]>**20070603213706] $ Alternatively, after downloading and building darcs from the repository using darcs get --verbose --partial http://darcs.net/repos/stable the error message has moved slightly: $ darcs get http://code.haskell.org/yi/ Directory '/home/mga83/working/Haskell/yi' already exists, creating repository as '/home/mga83/working/Haskell/yi_0' Copying patch 1370 of 1370... done. Applying patch 551 of 1370... darcs: bug in darcs! Impossible case at src/Darcs/Patch/Read.lhs:58 compiled 18:37:35 Jan 15 2008 Please report this to [EMAIL PROTECTED], If possible include the output of 'darcs --exact-version'. $ darcs --version 1.1.0pre1 (unknown) $ darcs --exact-version | wc -l 1433 $ By the way, the page http://www.darcs.net/manual/node3.html suggests downloading the darcs repository from http://abridgegame.org/repos/darcs -- this appears to be a case of bit rot! I hope this report is helpful. Unfortunately searching bugs.darcs.net doesn't seem to work and just hangs. ___ darcs-devel mailing list darcs-devel@darcs.net http://lists.osuosl.org/mailman/listinfo/darcs-devel
[darcs-devel] [issue590] Impossible case in darcs PatchRead.lhs or Patch/Read.lhs
New submission from Michael Abbott <[EMAIL PROTECTED]>: Running darcs get http://code.haskell.org/yi produces one of the following responses (depending on version). Running the darcs-1.0.9-i386-linux binary, as downloaded from darcs.net, produces the message: $ darcs get http://code.haskell.org/yi ... FINISHED --18:23:31-- Downloaded: 5,562,103 bytes in 1370 files Applying patch 551 of 1370... darcs: bug in darcs! Impossible case at PatchRead.lhs:58 compiled 18:47:46 Aug 28 2007 Please report this to [EMAIL PROTECTED], If possible include the output of 'darcs --exact-version'. $ darcs --exact-version darcs compiled on Aug 28 2007, at 18:50:44 # configured Sat Jun 16 09:59:48 PDT 2007 ./configure /usr/local/share/config.site /usr/local/etc/config.site Context: [TAG 1.0.9 Tommy Pettersson <[EMAIL PROTECTED]>**20070603213706] $ Alternatively, after downloading and building darcs from the repository using darcs get --verbose --partial http://darcs.net/repos/stable the error message has moved slightly: $ darcs get http://code.haskell.org/yi/ Directory '/home/mga83/working/Haskell/yi' already exists, creating repository as '/home/mga83/working/Haskell/yi_0' Copying patch 1370 of 1370... done. Applying patch 551 of 1370... darcs: bug in darcs! Impossible case at src/Darcs/Patch/Read.lhs:58 compiled 18:37:35 Jan 15 2008 Please report this to [EMAIL PROTECTED], If possible include the output of 'darcs --exact-version'. $ darcs --version 1.1.0pre1 (unknown) $ darcs --exact-version | wc -l 1433 $ By the way, the page http://www.darcs.net/manual/node3.html suggests downloading the darcs repository from http://abridgegame.org/repos/darcs -- this appears to be a case of bit rot! I hope this report is helpful. Unfortunately searching bugs.darcs.net doesn't seem to work and just hangs. -- messages: 2534 nosy: beschmi, droundy, kowey, michael, tommy status: unread title: Impossible case in darcs PatchRead.lhs or Patch/Read.lhs __ Darcs bug tracker <[EMAIL PROTECTED]> <http://bugs.darcs.net/issue590> __ ___ darcs-devel mailing list darcs-devel@darcs.net http://lists.osuosl.org/mailman/listinfo/darcs-devel
