Re: [darktable-dev] Improvement tips

2020-02-01 Thread William Ferguson
On Sat, Feb 1, 2020 at 4:40 PM Lorenzo Fontanella <
fontanellalore...@gmail.com> wrote:

> Good evening community, I have been using darktable for some years and I
> appreciate it for the cleanliness of the results and the power of the tools.
> However I happen to associate it with other development software.
> I write in sequence some suggestions that could greatly improve the
> usability of the software.
> - Manual version 3.0
>
- Fujifilm files are displayed without any correspondence with the jpeg
> sooc, even when this has been saved without special settings on the camera.
> Raw Therapee for example does not have this type of problem, since for each
> file it applies a different tonal curve ad-hoc, which uniforms the open
> file to the jpeg (sooc) obviously this equalization can be deactivated so
> as to obtain a "clean" raw file "
> Other software (such as lightroom C01 or ON1 for example, read the
> metadata present in the .raf file and reproduce the file almost exactly
> compared to the jpeg sooc already in the opening phase using the "AUTO"
> mode.
>
> - The path panel for saving files takes the last path specified by the
> user; it would be useful to insert the possibility of being able to save in
> the path of the opening folder of the file you are working on.
>
use $(FILE_FOLDER)/$(FILE_NAME)  then save it as a preset

> - The development modules are categorized according to a logical order of
> programming, not photographic editing, it would be interesting to be able
> to reorganize them according to their own work logic, at least when it
> comes to a user-defined workflow.
>
is this the group they  are in, or their order in the pipeline.  Pipeline
is governed by logical order of programming, but the user can reorder the
pipeline is they desire.

> - in the styles module it would be useful to be able to sort the saved
> styles by subcategories, so as not to create a huge list of styles that you
> have to scroll through every time
>
you can do this by naming your styles
Category|sub-category|sub-sub-category|style-name

> - For the styles module, it would be useful to generate a popup with
> "mouse over" preview, which shows the preview of the photo being worked
> with with the set of settings applied
>
> You can submit feature requests to https://github.com/darktable-org/issues

> Thanks for your attention.
> Lorenzo Fontanella
>
> ___
> darktable developer mailing list to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org


Bill

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

[darktable-dev] Improvement tips

2020-02-01 Thread Lorenzo Fontanella
Good evening community, I have been using darktable for some years and I
appreciate it for the cleanliness of the results and the power of the tools.
However I happen to associate it with other development software.
I write in sequence some suggestions that could greatly improve the
usability of the software.
- Manual version 3.0
- Fujifilm files are displayed without any correspondence with the jpeg
sooc, even when this has been saved without special settings on the camera.
Raw Therapee for example does not have this type of problem, since for each
file it applies a different tonal curve ad-hoc, which uniforms the open
file to the jpeg (sooc) obviously this equalization can be deactivated so
as to obtain a "clean" raw file "
Other software (such as lightroom C01 or ON1 for example, read the metadata
present in the .raf file and reproduce the file almost exactly compared to
the jpeg sooc already in the opening phase using the "AUTO" mode.

- The path panel for saving files takes the last path specified by the
user; it would be useful to insert the possibility of being able to save in
the path of the opening folder of the file you are working on.
- The development modules are categorized according to a logical order of
programming, not photographic editing, it would be interesting to be able
to reorganize them according to their own work logic, at least when it
comes to a user-defined workflow.
- in the styles module it would be useful to be able to sort the saved
styles by subcategories, so as not to create a huge list of styles that you
have to scroll through every time
- For the styles module, it would be useful to generate a popup with "mouse
over" preview, which shows the preview of the photo being worked with with
the set of settings applied

Thanks for your attention.
Lorenzo Fontanella

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Fwd: French translation typos and improvement submission

2020-02-01 Thread Pascal Obry


Laurent,

Thanks, I had almost missed this. It is better to open a PR on our
GitHub.

Anyway, this is now integrated. Thanks!

-- 
  Pascal Obry /  Magny Les Hameaux (78)

  The best way to travel is by means of imagination

  http://www.obry.net

  gpg --keyserver keys.gnupg.net --recv-key F949BD3B

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] unused feature "blend only lightness"

2020-02-01 Thread Heiko Bauke

Hi,

Am 01.02.20 um 16:28 schrieb rawfiner:

Hi
Only a guess, but maybe it is used when we display some channels of the 
parametric masks, or when we display the masks?


this was also my first guess.  But then I found


if(request_mask_display & DT_DEV_PIXELPIPE_DISPLAY_ANY)
  display_channel(, in, out, m, request_mask_display, work_profile);
else
  blend(, in, out, m, blendflag);


in blend.c.  I.e., nothing is blended when channels or masks are shown. 
Thus, I believe that the blendflag related code is actually no longer used.


I am going to remove it unless somebody can indicate an actual use.


Heiko

--
-- Number Crunch Blog @ https://www.numbercrunch.de
--  Cluster Computing @ https://www.clustercomputing.de
--  Social Networking @ https://www.researchgate.net/profile/Heiko_Bauke
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] unused feature "blend only lightness"

2020-02-01 Thread Ulrich Pegelow

Am 01.02.20 um 13:27 schrieb Heiko Bauke:

Hi,

all blend modes that operate in Lab space have some special treatment 
for the case that a module sets the flag IOP_FLAGS_BLEND_ONLY_LIGHTNESS. 
  However, I cannot find any module that actually sets this flag. 
Furthermore, it seams to me not reasonable why the behavior of a blend 
mode should depend on a module flag.


Can we get rid of this?  Is there any good reason why we have this in 
darktable?


I think yes. I remember faintly that in the very early days of blending 
(+8 year ago) there have been a use case but that has been overcome 
shortly after. So this in fact a stale left-over.


Ulrich

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] unused feature "blend only lightness"

2020-02-01 Thread rawfiner
Hi
Only a guess, but maybe it is used when we display some channels of the
parametric masks, or when we display the masks?
rawfiner


Le sam. 1 févr. 2020 à 13:28, Heiko Bauke  a écrit :

> Hi,
>
> all blend modes that operate in Lab space have some special treatment
> for the case that a module sets the flag IOP_FLAGS_BLEND_ONLY_LIGHTNESS.
>   However, I cannot find any module that actually sets this flag.
> Furthermore, it seams to me not reasonable why the behavior of a blend
> mode should depend on a module flag.
>
> Can we get rid of this?  Is there any good reason why we have this in
> darktable?
>
> To give an example,
>
> >   if(flag == 0)
> >   {
> > tb[1]
> =clamp_range_f(ta[1]*(1.0f-fabsf(tbo-tb[0]))+0.5f*(ta[1]+tb[1])*fabsf(tbo-tb[0]),
> >  min[1], max[1]);
> > tb[2]
> =clamp_range_f(ta[2]*(1.0f-fabsf(tbo-tb[0]))+0.5f*(ta[2]+tb[2])*fabsf(tbo-tb[0]),
> >  min[2], max[2]);
> >   }
> >   else
> >   {
> > tb[1] = ta[1];
> > tb[2] = ta[2];
> >   }
>
> in _blend_darken would simplify to
>
> > tb[1]
> =clamp_range_f(ta[1]*(1.0f-fabsf(tbo-tb[0]))+0.5f*(ta[1]+tb[1])*fabsf(tbo-tb[0]),
> >  min[1], max[1]);
> > tb[2]
> =clamp_range_f(ta[2]*(1.0f-fabsf(tbo-tb[0]))+0.5f*(ta[2]+tb[2])*fabsf(tbo-tb[0]),
> >  min[2], max[2]);
>
>
> Heiko
>
>
> --
> -- Number Crunch Blog @ https://www.numbercrunch.de
> --  Cluster Computing @ https://www.clustercomputing.de
> --  Social Networking @ https://www.researchgate.net/profile/Heiko_Bauke
> ___
> darktable developer mailing list
> to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org
>
>

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



[darktable-dev] unused feature "blend only lightness"

2020-02-01 Thread Heiko Bauke

Hi,

all blend modes that operate in Lab space have some special treatment 
for the case that a module sets the flag IOP_FLAGS_BLEND_ONLY_LIGHTNESS. 
 However, I cannot find any module that actually sets this flag. 
Furthermore, it seams to me not reasonable why the behavior of a blend 
mode should depend on a module flag.


Can we get rid of this?  Is there any good reason why we have this in 
darktable?


To give an example,


  if(flag == 0)
  {
tb[1] 
=clamp_range_f(ta[1]*(1.0f-fabsf(tbo-tb[0]))+0.5f*(ta[1]+tb[1])*fabsf(tbo-tb[0]),
 min[1], max[1]);
tb[2] 
=clamp_range_f(ta[2]*(1.0f-fabsf(tbo-tb[0]))+0.5f*(ta[2]+tb[2])*fabsf(tbo-tb[0]),
 min[2], max[2]);
  }
  else
  {
tb[1] = ta[1];
tb[2] = ta[2];
  }


in _blend_darken would simplify to


tb[1] 
=clamp_range_f(ta[1]*(1.0f-fabsf(tbo-tb[0]))+0.5f*(ta[1]+tb[1])*fabsf(tbo-tb[0]),
 min[1], max[1]);
tb[2] 
=clamp_range_f(ta[2]*(1.0f-fabsf(tbo-tb[0]))+0.5f*(ta[2]+tb[2])*fabsf(tbo-tb[0]),
 min[2], max[2]);



Heiko


--
-- Number Crunch Blog @ https://www.numbercrunch.de
--  Cluster Computing @ https://www.clustercomputing.de
--  Social Networking @ https://www.researchgate.net/profile/Heiko_Bauke
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org