Re: [darktable-dev] string should be in .po file, but it isn't...

2020-04-16 Thread Pascal Obry


Hi Jeronimo,

> Did I miss something?

You are not missing anything. src/common/metadata.c was not listed in
POFILES.in.

I've just fixed that. Thanks for reporting.

-- 
  Pascal Obry /  Magny Les Hameaux (78)

  The best way to travel is by means of imagination

  http://www.obry.net

  gpg --keyserver keys.gnupg.net --recv-key F949BD3B

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



[darktable-dev] string should be in .po file, but it isn't...

2020-04-16 Thread Jeronimo Pellegrini
Hello,

I have been working on the pt_BR translation and found something I didn't
understand:  in the right panel in lighttable view there is the metadata
editor. When it is exapnded, I see six fields:

title
description
creator
publisher
rights
notes

I have translated all these, except for the last "notes", because it does 
not show up in the .po file! It doesn't seem to show up in the fr.po and
it.po either. It seems to be in src/common/metadata.c on line 50,

static const struct
{
  char *key;
  char *name;
  int type;
  uint32_t display_order;
} dt_metadata_def[] = {
  // clang-format off
  {"Xmp.dc.creator", N_("creator"), DT_METADATA_TYPE_USER, 2},
  {"Xmp.dc.publisher", N_("publisher"), DT_METADATA_TYPE_USER, 3},
  {"Xmp.dc.title", N_("title"), DT_METADATA_TYPE_USER, 0},
  {"Xmp.dc.description", N_("description"), DT_METADATA_TYPE_USER, 1},
  {"Xmp.dc.rights", N_("rights"), DT_METADATA_TYPE_USER, 4},
  {"Xmp.acdsee.notes", N_("notes"), DT_METADATA_TYPE_USER, 5} <== here!
  // clang-format on
};

along with the other fields, which do show up in the .po files!

I have ran intltool-update pt_BR, and I see that other strings are updated
when there is an upstream update.

Did I miss something?

Thanks!
J.

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



[darktable-dev] your contributions

2020-04-16 Thread Pascal Obry


Dear developers,

Just a little message to thanks you all.

At the moment there is some many PR that I barely have time to do any
coding on darktable. This is nice, very nice and shows that darktable
is moving at a good pace ensuring that the project is alive and well.

If you see some PR or issues that are getting time to be reviewed, do
not worry, I'll come to it if needed, I just need to find some time.

Have all a good day and I hope your are all well and safe at home.

Cheers,

-- 
  Pascal Obry /  Magny Les Hameaux (78)

  The best way to travel is by means of imagination

  http://www.obry.net

  gpg --keyserver keys.gnupg.net --recv-key F949BD3B

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



[darktable-dev] feature request: add a shortcut to center and a shortcut to fit crop area in the crop and rotate module

2020-04-16 Thread Alexander Rabtchevich
Hello

Is it possible to add two actions with respective shortcuts to the crop and 
rotate module? During cropping it is often required to maximize the selection 
area before crop is applied or to center it within a view. It would be nice if 
it could be done via shortcuts or modifier + mouse button. Now several 
incremental Ctrl+arrow or mouse wheel actions are required.


Woth respect,
Alexander Rabtchevich
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] HSL and RGB scene-referred space

2020-04-16 Thread Aurélien Pierre
Hello,

 1. you go from RGB to XYZ using the ICC profile of the RGB space you
are using, which gives you the coeffs of the 3×3 matrix RGB -> XYZ.
Call that matrix M. Do a matrix dot product [XYZ] = [M] * [RGB]
 2. you go from XYZ to Yxy using x = X / (X + Y + Z) and y = Y / (X + Y + Z)
 3. you subtract the x and y values by those of the white point you are
using (usually, D50). That's x_D50 = 0.34567 and y_D50 = 0.35850,
using 2° CIE 1931 observer. So
x = X / (X + Y + Z) - x_D50 and y = Y / (X + Y + Z) - y_D50,
 4. then, hue = arctan2(y, x), saturation = sqrt(x^2 + y^2)
 5. since it's only to produce a boolean mask, you don't need to bother
about the back transform. But in case you need :
 1. x = saturation * cos(hue) + x_D50, y = saturation * sin(hue) + y_D50
 2. X = xY / y, Y = Y, Z = (1 - x - y) * Y / y
 3. and then, again, matrix dot product [RGB] = [M^-1] * [XYZ] where
[M^-1] is the inverse of the matrix M formed with the ICC
profile coefficients.

Cheers,

Aurélien.

Le 11/04/2020 à 18:23, Harold le Clément a écrit :
> Hello,
>
> Thanks a lot for the feedback.
>
> Agree, the problem would be only when trying to use the saturation for
> parametric masking (as the color picker HSL mode is only used for
> that).
>
> Perhaps a cylindrical HSY could be used, but it depends how the
> saturation is computed (most of the information I could find on the
> Internet suppose that the RGB values are bounded).
>
> Anyway, in the mean time I could just disregard the saturation selector.
>
> Thanks,
>
> Harold
> ___
> darktable developer mailing list
> to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
>

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org