Re: [darktable-dev] Large number of warnings when building dt master
Hi Nicolas, Do you update submodule (git submodule update ; a git submodule init is sometimes good to do again) ? Yes, I use both commands every time I build dt master. I observed the warnings for the first time some weeks ago. I copied the output of build.sh to a file using ./build.sh | tee > build.log. This log file does not contain the warnings. They are visible in terminal output if you are scrolling back to about 3% of the build process. I had to increase the number of buffered lines in my terminal to allow scrolling back thus far. Best regards Peter Harde ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] Large number of warnings when building dt master
Hi Peter,
I just compile last master (so 3.1.0+2031 now) and I don't have any
error about libxcf on my side (nor I have on previous compile). But I am
on Ubuntu 20.04 so that could make some differences.
Do you update submodule (git submodule update ; a git submodule init is
sometimes good to do again) ?
I couldn't help more here so just ideas to follow for that errors.
Best regards,
Nicolas Auffray
Le 09/06/2020 à 17:33, Peter Harde a écrit :
Dear developers,
3.1.0+2016~g40a922d0e, Ubuntu 18.04
Running the build script build.sh a large number of warnings is thrown
on terminal. All warnings relate to xcf.c. They seem to have no impact
on the correct result of the build process, the binaries are working
fine. A reduced list of the warnings is pasted below, if you are
interested in the whole list, please let me know.
Best regards
Peter Harde
...
[ 3%] Built target darktablerc_file
~/darktable/src/external/libxcf/xcf.c: In function
‘xcf_write_image_header’:
~/darktable/src/external/libxcf/xcf.c:329:67: warning: ISO C99
requires at least one argument for the "..." in a variadic macro
PRINT_ERROR("error: the image header has already been written");
^
~/darktable/src/external/libxcf/xcf.c:336:58: warning: ISO C99
requires at least one argument for the "..." in a variadic macro
PRINT_ERROR("error: rle compression is not supported");
^
~/darktable/src/external/libxcf/xcf.c:362:45: warning: ISO C99
requires at least one argument for the "..." in a variadic macro
PRINT_ERROR("error: can't write to file");
^
~/darktable/src/external/libxcf/xcf.c:367:59: warning: ISO C99
requires at least one argument for the "..." in a variadic macro
CHECK_IO(xcf, xcf_write_uint32(xcf, xcf->image.width), 1);
^
~/darktable/src/external/libxcf/xcf.c:368:60: warning: ISO C99
requires at least one argument for the "..." in a variadic macro
CHECK_IO(xcf, xcf_write_uint32(xcf, xcf->image.height), 1);
^
^
~/darktable/src/external/libxcf/xcf.c: In function ‘xcf_add_data’:
~/darktable/src/external/libxcf/xcf.c:1184:85: warning: ISO C99
requires at least one argument for the "..." in a variadic macro
PRINT_ERROR("error: the file is in error state. better add some
error handling.");
^
~/darktable/src/external/libxcf/xcf.c:1197:65: warning: ISO C99
requires at least one argument for the "..." in a variadic macro
PRINT_ERROR("error: no open layer or channel to add data to");
^
Merging translations into ~/darktable/build/data/darktable.desktop.
[ 3%] Checking validity of darktable.desktop
...
___
darktable developer mailing list
to unsubscribe send a mail to
darktable-dev+unsubscr...@lists.darktable.org
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.or
Re: [darktable-dev] filmic v.4 and exposure compensation bias in git master
Hm, as I understand, if I enable filmic plugin v 4.0 manually, I need to add +1.0EV manually too? That wasn't so with 3.0. With respect, Alexander Rabtchevich Aurélien Pierre wrote: Hi, there is a +1 EV added by default in exposure if you enable the scene-referred workflow. I don't understand what you mean. The exposure bias is read in image EXIF, if the bias is 0 EV, then the setting is 0 EV too. Cheers, Aurélien. Le 09/06/2020 à 19:46, Alexander Rabtchevich a écrit : Hello Exposure compensation bias for my Sony A99 is 0EV and images are too dark. They require to add +1EV to match filmic v.3 Current git master With respect, Alexander Rabtchevich ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] filmic v.4 and exposure compensation bias in git master
Hi, there is a +1 EV added by default in exposure if you enable the scene-referred workflow. I don't understand what you mean. The exposure bias is read in image EXIF, if the bias is 0 EV, then the setting is 0 EV too. Cheers, Aurélien. Le 09/06/2020 à 19:46, Alexander Rabtchevich a écrit : > Hello > Exposure compensation bias for my Sony A99 is 0EV and images are too > dark. They require to add +1EV to match filmic v.3 > > Current git master > > With respect, > Alexander Rabtchevich > ___ > > darktable developer mailing list > to unsubscribe send a mail to > darktable-dev+unsubscr...@lists.darktable.org > ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
[darktable-dev] filmic v.4 and exposure compensation bias in git master
Hello Exposure compensation bias for my Sony A99 is 0EV and images are too dark. They require to add +1EV to match filmic v.3 Current git master With respect, Alexander Rabtchevich ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
[darktable-dev] Large number of warnings when building dt master
Dear developers,
3.1.0+2016~g40a922d0e, Ubuntu 18.04
Running the build script build.sh a large number of warnings is thrown
on terminal. All warnings relate to xcf.c. They seem to have no impact
on the correct result of the build process, the binaries are working
fine. A reduced list of the warnings is pasted below, if you are
interested in the whole list, please let me know.
Best regards
Peter Harde
...
[ 3%] Built target darktablerc_file
~/darktable/src/external/libxcf/xcf.c: In function ‘xcf_write_image_header’:
~/darktable/src/external/libxcf/xcf.c:329:67: warning: ISO C99 requires
at least one argument for the "..." in a variadic macro
PRINT_ERROR("error: the image header has already been written");
^
~/darktable/src/external/libxcf/xcf.c:336:58: warning: ISO C99 requires
at least one argument for the "..." in a variadic macro
PRINT_ERROR("error: rle compression is not supported");
^
~/darktable/src/external/libxcf/xcf.c:362:45: warning: ISO C99 requires
at least one argument for the "..." in a variadic macro
PRINT_ERROR("error: can't write to file");
^
~/darktable/src/external/libxcf/xcf.c:367:59: warning: ISO C99 requires
at least one argument for the "..." in a variadic macro
CHECK_IO(xcf, xcf_write_uint32(xcf, xcf->image.width), 1);
^
~/darktable/src/external/libxcf/xcf.c:368:60: warning: ISO C99 requires
at least one argument for the "..." in a variadic macro
CHECK_IO(xcf, xcf_write_uint32(xcf, xcf->image.height), 1);
^
^
~/darktable/src/external/libxcf/xcf.c: In function ‘xcf_add_data’:
~/darktable/src/external/libxcf/xcf.c:1184:85: warning: ISO C99 requires
at least one argument for the "..." in a variadic macro
PRINT_ERROR("error: the file is in error state. better add some
error handling.");
^
~/darktable/src/external/libxcf/xcf.c:1197:65: warning: ISO C99 requires
at least one argument for the "..." in a variadic macro
PRINT_ERROR("error: no open layer or channel to add data to");
^
Merging translations into ~/darktable/build/data/darktable.desktop.
[ 3%] Checking validity of darktable.desktop
...
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
