Re: [darktable-dev] Darktable current master fails to build on Fedora 30
On Thu, 25 Jul 2019 21:07:12 +1000, Andy Dodd wrote: Terry, Please test https://github.com/darktable-org/darktable/pull/2816 to see if I missed anything else that isn't problematic on GCC 8.3 - I won't be at my development machine for the rest of the day unfortunately. I also won't be checking this email account until evening Eastern Standard but can likely at least stop by at github. I don't use github, but email will do, no hurry. darktable now builds without any complaints on Fedora 30, and a rudimentary check indicates that it is working OK. Thanks for your rapid response. Cheers, -- Regards, Terry Duell ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] Darktable current master fails to build on Fedora 30
Terry, Please test https://github.com/darktable-org/darktable/pull/2816 to see if I missed anything else that isn't problematic on GCC 8.3 - I won't be at my development machine for the rest of the day unfortunately. I also won't be checking this email account until evening Eastern Standard but can likely at least stop by at github. On Thu, Jul 25, 2019 at 5:58 AM Terry Duell wrote: > Hello, > Attempting to do an rpmbuild of current master (e31d89cbff35b) on Fedora > 30, fails with the following message... > > /home/terry/rpmbuild/BUILD/darktable-2.7.0/src/iop/basecurve.c:982:29: > error: 'preserve_colors' not specified in enclosing 'parallel' >982 | const float lum = mul * dt_rgb_norm(inp, preserve_colors, > work_profile); >| > ^~~ > /home/terry/rpmbuild/BUILD/darktable-2.7.0/src/iop/basecurve.c:971:9: > error: enclosing 'parallel' >971 | #pragma omp parallel for default(none) > \ >| ^~~ > make[2]: *** [src/iop/CMakeFiles/basecurve.dir/build.make:71: > src/iop/CMakeFiles/basecurve.dir/introspection_basecurve.c.o] Error 1 > make[2]: Leaving directory > '/home/terry/rpmbuild/BUILD/darktable-2.7.0/build' > make[1]: *** [CMakeFiles/Makefile2:5656: > src/iop/CMakeFiles/basecurve.dir/all] Error 2 > make[1]: Leaving directory > '/home/terry/rpmbuild/BUILD/darktable-2.7.0/build' > make: *** [Makefile:155: all] Error 2 > error: Bad exit status from /var/tmp/rpm-tmp.RDfswD (%build) > > Hope this helps, > > Cheers, > -- > Regards, > Terry Duell > ___ > darktable developer mailing list > to unsubscribe send a mail to > darktable-dev+unsubscr...@lists.darktable.org > > ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] Darktable current master fails to build on Fedora 30
I'll take care of this, apparently something my compiler didn't care about. On Thu, Jul 25, 2019 at 6:15 AM Aurélien Pierre wrote: > Hi, > > someone needs to add preserve_colors in the dt_omp_firstprivate(…) in the > next line, to please GCC 9. > > Cheers, > > Aurélien. > Le 25/07/2019 à 11:48, Terry Duell a écrit : > > Hello, > Attempting to do an rpmbuild of current master (e31d89cbff35b) on Fedora > 30, fails with the following message... > > /home/terry/rpmbuild/BUILD/darktable-2.7.0/src/iop/basecurve.c:982:29: > error: 'preserve_colors' not specified in enclosing 'parallel' > 982 | const float lum = mul * dt_rgb_norm(inp, preserve_colors, > work_profile); > | > ^~~ > /home/terry/rpmbuild/BUILD/darktable-2.7.0/src/iop/basecurve.c:971:9: > error: enclosing 'parallel' > 971 | #pragma omp parallel for default(none) > \ > | ^~~ > make[2]: *** [src/iop/CMakeFiles/basecurve.dir/build.make:71: > src/iop/CMakeFiles/basecurve.dir/introspection_basecurve.c.o] Error 1 > make[2]: Leaving directory > '/home/terry/rpmbuild/BUILD/darktable-2.7.0/build' > make[1]: *** [CMakeFiles/Makefile2:5656: > src/iop/CMakeFiles/basecurve.dir/all] Error 2 > make[1]: Leaving directory > '/home/terry/rpmbuild/BUILD/darktable-2.7.0/build' > make: *** [Makefile:155: all] Error 2 > error: Bad exit status from /var/tmp/rpm-tmp.RDfswD (%build) > > Hope this helps, > > Cheers, > > > ___ > darktable developer mailing list to unsubscribe send a mail to > darktable-dev+unsubscr...@lists.darktable.org > ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] Darktable current master fails to build on Fedora 30
Hi, someone needs to add preserve_colors in the dt_omp_firstprivate(…) in the next line, to please GCC 9. Cheers, Aurélien. Le 25/07/2019 à 11:48, Terry Duell a écrit : > Hello, > Attempting to do an rpmbuild of current master (e31d89cbff35b) on > Fedora 30, fails with the following message... > > /home/terry/rpmbuild/BUILD/darktable-2.7.0/src/iop/basecurve.c:982:29: > error: 'preserve_colors' not specified in enclosing 'parallel' > 982 | const float lum = mul * dt_rgb_norm(inp, preserve_colors, > work_profile); > | > ^~~ > /home/terry/rpmbuild/BUILD/darktable-2.7.0/src/iop/basecurve.c:971:9: > error: enclosing 'parallel' > 971 | #pragma omp parallel for > default(none) \ > | ^~~ > make[2]: *** [src/iop/CMakeFiles/basecurve.dir/build.make:71: > src/iop/CMakeFiles/basecurve.dir/introspection_basecurve.c.o] Error 1 > make[2]: Leaving directory > '/home/terry/rpmbuild/BUILD/darktable-2.7.0/build' > make[1]: *** [CMakeFiles/Makefile2:5656: > src/iop/CMakeFiles/basecurve.dir/all] Error 2 > make[1]: Leaving directory > '/home/terry/rpmbuild/BUILD/darktable-2.7.0/build' > make: *** [Makefile:155: all] Error 2 > error: Bad exit status from /var/tmp/rpm-tmp.RDfswD (%build) > > Hope this helps, > > Cheers, ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
[darktable-dev] Darktable current master fails to build on Fedora 30
Hello, Attempting to do an rpmbuild of current master (e31d89cbff35b) on Fedora 30, fails with the following message... /home/terry/rpmbuild/BUILD/darktable-2.7.0/src/iop/basecurve.c:982:29: error: 'preserve_colors' not specified in enclosing 'parallel' 982 | const float lum = mul * dt_rgb_norm(inp, preserve_colors, work_profile); | ^~~ /home/terry/rpmbuild/BUILD/darktable-2.7.0/src/iop/basecurve.c:971:9: error: enclosing 'parallel' 971 | #pragma omp parallel for default(none)\ | ^~~ make[2]: *** [src/iop/CMakeFiles/basecurve.dir/build.make:71: src/iop/CMakeFiles/basecurve.dir/introspection_basecurve.c.o] Error 1 make[2]: Leaving directory '/home/terry/rpmbuild/BUILD/darktable-2.7.0/build' make[1]: *** [CMakeFiles/Makefile2:5656: src/iop/CMakeFiles/basecurve.dir/all] Error 2 make[1]: Leaving directory '/home/terry/rpmbuild/BUILD/darktable-2.7.0/build' make: *** [Makefile:155: all] Error 2 error: Bad exit status from /var/tmp/rpm-tmp.RDfswD (%build) Hope this helps, Cheers, -- Regards, Terry Duell ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
