Re: [darktable-dev] Bug in shape selection at large pictures?
Hi Frank, I saw that in the "bad" image rotation module and crop and rotate was done after retouch. Moving retouch up did not change anything did you check if there are other modules modifying the geometry? Not only crop and rotate is a candidate... Could it help if I provide the picture and sidecar files? I can put it on a cloud drive and provide the link. I just don't want to provide the link to everybody. Of course, this is possible. If you don't want to provide the link to every member of this mailing list, you could send me a personal mail, or you could think about providing the files via https://discuss.pixls.us/c/processing/playraw/. Another consideration : no one seems to be able to reproduce the issue, including yourself, if you use a fresh copy of the image. I'm wondering if it is worth to spent plenty of time to solve a problem which is actually not reproducible. Peter ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] Bug in shape selection at large pictures?
Peter Harde writes: > The modules are grouped. Selecting the group symbolized by the "power switch" > icon (most left) , the modules applied are shown in the order of the > pixelpipe (bottom - first, top - last). The order can be modified by > CTRL-SHIFT-dragging a module to a new position. Changing the order did not change the behaviour. I saw that in the "bad" image rotation module and crop and rotate was done after retouch. Moving retouch up did not change anything In a "good" copy rotate and crop and rotate module are done before retouch. Moving retouch down did not change anything. Could it help if I provide the picture and sidecar files? I can put it on a cloud drive and provide the link. I just don't want to provide the link to everybody. Frank ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] Bug in shape selection at large pictures?
The modules are grouped. Selecting the group symbolized by the "power switch" icon (most left) , the modules applied are shown in the order of the pixelpipe (bottom - first, top - last). The order can be modified by CTRL-SHIFT-dragging a module to a new position. Frank Huebner schrieb am Di., 13. Okt. 2020, 20:50: > > > I did not compare the order of the modules. I might need some advice how > to do it. I never used to changing the order. > > ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] Bug in shape selection at large pictures?
Peter Harde writes: Hi Peter, > did you compare the order of the modules you applied in the pixelpipe when the > issue appeared and when it did not? I did not compare the order of the modules. I might need some advice how to do it. I never used to changing the order. Anyway, I tried the following actions: Starting with a blank copy of the picture 1st try: use crop and rotate afterwards retouch module 2nd try: use retouch module afterwards crop and rotate (original picture: I think I applied the crop and rotate module first, then the retouch module). The I noticed that the order of the modules (right sidebar) was set to legacy. I changed to be V3.0, but it did not change the behaviour of the original image. Frank ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] Bug in shape selection at large pictures?
Hi Frank, did you compare the order of the modules you applied in the pixelpipe when the issue appeared and when it did not? Peter Am 11.10.20 um 20:34 schrieb Frank Huebner: Hello! Let me start with my thanks to Peter, Juha and István! The crop and rotate module caused the problem. I deactivated all other modules than retouch except the crop and rotate module. The problem is still present then. Starting with a duplicate of the original picture without modules I was able to use the retouch module as it should be. But: adding the crop and rotate module to the duplicated picture (same size, slightly different position) works fine too. I tried to crop and rotate first and later retouch and vice versa. All versions are fine. Thus I am a bit surprised as I can't reproduce the problem. That might explain why Peter could not reproduce the problem. Looks like the issue is not reproducible. Maybe soneone has a good idea how analyze the problem? Bye, Frank ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] Bug in shape selection at large pictures?
Hello! Let me start with my thanks to Peter, Juha and István! The crop and rotate module caused the problem. I deactivated all other modules than retouch except the crop and rotate module. The problem is still present then. Starting with a duplicate of the original picture without modules I was able to use the retouch module as it should be. But: adding the crop and rotate module to the duplicated picture (same size, slightly different position) works fine too. I tried to crop and rotate first and later retouch and vice versa. All versions are fine. Thus I am a bit surprised as I can't reproduce the problem. That might explain why Peter could not reproduce the problem. Looks like the issue is not reproducible. Maybe soneone has a good idea how analyze the problem? Bye, Frank ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] Bug in shape selection at large pictures?
On Fri, 9 Oct 2020 at 20:22, Frank Huebner wrote: > I used the retouch module on a large picture (10165 x 4018). It did not > work as expected. At normal size pictures (16 Mpix) it worked as > expected. This sounds like an issue I have logged, though mine had nothing to do with size of the image. See https://github.com/darktable-org/darktable/issues/3904#issuecomment-609007856 I think the following should work: - turn off lens corrections (so you actually see the image you're working on while healing or when drawing masks, and not the corrected one) - move the problematic module before lens corrections (if it's not there yet) - do your work, including drawing any masks - turn on lens corrections This way, lens corrections should use the 'healed' image as input. Kofa ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] Bug in shape selection at large pictures?
Hi Have you used any modules that change the geometry? I have experienced similar thing earlier. You could also try to disable all the modules above retouch to see if that helps. Juha On Sat, 10 Oct 2020, 9.44 Peter Harde wrote: > Hi Frank, > > on dt 3.3.0+1006~ge31529f63, Ubuntu 20.04 I'm not able to reproduce. Tried > several times with different shapes on a really huge panorama (24792x5552 > pixel). > > Best regards > Am 09.10.20 um 20:11 schrieb Frank Huebner: > > Hello, > > I used the retouch module on a large picture (10165 x 4018). It did not > work as expected. At normal size pictures (16 Mpix) it worked as > expected. Using a shape at the large picture did not use the selected > area to be copied - it copied/healed from an area different than > the selection. > > Showing the mask helped me to make the issue visible: > > ___ > darktable developer mailing list > to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org > > > The picture is taken at 200% mangnification. The mask is left from the shape. > > My OS is Opensuse Leap 15.2 > > I use darktable 3.2.1 from repository > https://build.opensuse.org/package/show/graphics%3Adarktable/darktable > and > nvidias opencl driver > > > I hope someone can reproduce and fix the error! > > Bye, Frank > > > ___ > darktable developer mailing list to unsubscribe send a mail to > darktable-dev+unsubscr...@lists.darktable.org > ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] Bug in shape selection at large pictures?
Hi Frank, on dt 3.3.0+1006~ge31529f63, Ubuntu 20.04 I'm not able to reproduce. Tried several times with different shapes on a really huge panorama (24792x5552 pixel). Best regards Am 09.10.20 um 20:11 schrieb Frank Huebner: Hello, I used the retouch module on a large picture (10165 x 4018). It did not work as expected. At normal size pictures (16 Mpix) it worked as expected. Using a shape at the large picture did not use the selected area to be copied - it copied/healed from an area different than the selection. Showing the mask helped me to make the issue visible: ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org The picture is taken at 200% mangnification. The mask is left from the shape. My OS is Opensuse Leap 15.2 I use darktable 3.2.1 from repository https://build.opensuse.org/package/show/graphics%3Adarktable/darktable and nvidias opencl driver I hope someone can reproduce and fix the error! Bye, Frank ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org