Re: [darktable-dev] GCC version, optimisation options, split-loops

[Sturm Flut]

Hi,

GCC 6.3.0 is just three years old (December 21, 2016). Most codebases
don't profit as much from optimization as darktable does, so it's no
wonder most build with GCC 6.x and even much older releases. Red Hat 7.7
still ships GCC 4.8.5...

cheers,
Simon



Am 18.10.19 um 17:55 schrieb Marco Tedaldi:
> Hello
> 
> Thanks very much. I've now upgraded my GCC (which it was REALLY time
> for). Interestingly, it seemed to work quite ok until recently...
> 
> best regards
> 
> Marco
> 
> Am So., 6. Okt. 2019 um 15:58 Uhr schrieb Aurélien Pierre
> mailto:rese...@aurelienpierre.com>>:
> 
> Hi,
> 
> We support GCC 8 and 9. GCC 6 is quite old already.
> 
> The commit you refer to affects only CLang.
> 
> Cheers,
> 
> Aurélien.
> 
> Le 06/10/2019 à 15:26, Marco Tedaldi a écrit :
>> Hi Everyone
>> After a long time away from this list (but still regularly working
>> with git master) I'm back here...
>>
>>
>> I've just tried to compile dt master again and it failed on me...
>> The reason is that my GCC doesn't recognize the option split-loops
>>
>> Error:
>> /home/marco/build/darktable/src/iop/toneequal.c:1312:1: error:
>> unrecognized command line option ‘-fsplit-loops’
>>
>> My GCC-Version
>> marco@schwipschwap:~/build/darktable$ gcc --version
>> gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516
>>
>> Interestingly,the last time I compiled dt it worked. It was: dt
>> 2.7.0+1709~g580bf49da
>>
>>
>> As a workaround for me I've just removed the option "split-loops"
>> from the following files:
>> src/common/fast_guided_filter.h
>> src/common/luminance_mask.h
>> src/iop/choleski.h
>> src/iop/filmicrgb.c
>> src/iop/toneequal.c
>>
>>
>> So my question is: what version of gcc is required to compile it?
>>
>> could it be that commit 50742fa02bdf511e62f3bbe10b11c61c2036e4e5 
>> 
>> https://github.com/darktable-org/darktable/commit/50742fa02bdf511e62f3bbe10b11c61c2036e4e5#diff-b93b6846a64705e34a1eb02a9d620317
>>
>> made my version of gcc stumble?
>>
>> best regards
>>
>> Marco
>>
>> 
>> ___
>> darktable developer mailing list to unsubscribe send a mail to
>> darktable-dev+unsubscr...@lists.darktable.org
>> 
> 
> 
> ___
> darktable developer mailing list to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] GCC version, optimisation options, split-loops

[Marco Tedaldi]

Hello

Thanks very much. I've now upgraded my GCC (which it was REALLY time for).
Interestingly, it seemed to work quite ok until recently...

best regards

Marco

Am So., 6. Okt. 2019 um 15:58 Uhr schrieb Aurélien Pierre <
rese...@aurelienpierre.com>:

> Hi,
>
> We support GCC 8 and 9. GCC 6 is quite old already.
>
> The commit you refer to affects only CLang.
>
> Cheers,
>
> Aurélien.
> Le 06/10/2019 à 15:26, Marco Tedaldi a écrit :
>
> Hi Everyone
> After a long time away from this list (but still regularly working with
> git master) I'm back here...
>
>
> I've just tried to compile dt master again and it failed on me...
> The reason is that my GCC doesn't recognize the option split-loops
>
> Error:
> /home/marco/build/darktable/src/iop/toneequal.c:1312:1: error:
> unrecognized command line option ‘-fsplit-loops’
>
> My GCC-Version
> marco@schwipschwap:~/build/darktable$ gcc --version
> gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516
>
> Interestingly,the last time I compiled dt it worked. It was: dt
> 2.7.0+1709~g580bf49da
>
>
> As a workaround for me I've just removed the option "split-loops" from the
> following files:
> src/common/fast_guided_filter.h
> src/common/luminance_mask.h
> src/iop/choleski.h
> src/iop/filmicrgb.c
> src/iop/toneequal.c
>
>
> So my question is: what version of gcc is required to compile it?
>
> could it be that commit 50742fa02bdf511e62f3bbe10b11c61c2036e4e5
>
> https://github.com/darktable-org/darktable/commit/50742fa02bdf511e62f3bbe10b11c61c2036e4e5#diff-b93b6846a64705e34a1eb02a9d620317
>
> made my version of gcc stumble?
>
> best regards
>
> Marco
>
> ___
> darktable developer mailing list to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org
>
>

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] GCC version, optimisation options, split-loops

[Aurélien Pierre]

Hi,

We support GCC 8 and 9. GCC 6 is quite old already.

The commit you refer to affects only CLang.

Cheers,

Aurélien.

Le 06/10/2019 à 15:26, Marco Tedaldi a écrit :
> Hi Everyone
> After a long time away from this list (but still regularly working
> with git master) I'm back here...
>
>
> I've just tried to compile dt master again and it failed on me...
> The reason is that my GCC doesn't recognize the option split-loops
>
> Error:
> /home/marco/build/darktable/src/iop/toneequal.c:1312:1: error:
> unrecognized command line option ‘-fsplit-loops’
>
> My GCC-Version
> marco@schwipschwap:~/build/darktable$ gcc --version
> gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516
>
> Interestingly,the last time I compiled dt it worked. It was: dt
> 2.7.0+1709~g580bf49da
>
>
> As a workaround for me I've just removed the option "split-loops" from
> the following files:
> src/common/fast_guided_filter.h
> src/common/luminance_mask.h
> src/iop/choleski.h
> src/iop/filmicrgb.c
> src/iop/toneequal.c
>
>
> So my question is: what version of gcc is required to compile it?
>
> could it be that commit 50742fa02bdf511e62f3bbe10b11c61c2036e4e5 
> https://github.com/darktable-org/darktable/commit/50742fa02bdf511e62f3bbe10b11c61c2036e4e5#diff-b93b6846a64705e34a1eb02a9d620317
>
> made my version of gcc stumble?
>
> best regards
>
> Marco
>
> ___
> darktable developer mailing list to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org