[PATCH] MFD: DaVinci: Fix voice codec device name
Fix the device name in DaVinci Voice Codec MFD driver to load davinci-vcif and cq93vc codec client drivers. Signed-off-by: Manjunathappa, Prakash prakash...@ti.com --- This patch applies to Linus's tree at [1]. [1] http://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git --- drivers/mfd/davinci_voicecodec.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/davinci_voicecodec.c b/drivers/mfd/davinci_voicecodec.c index 33c923d..fdd8a1b 100644 --- a/drivers/mfd/davinci_voicecodec.c +++ b/drivers/mfd/davinci_voicecodec.c @@ -118,12 +118,12 @@ static int __init davinci_vc_probe(struct platform_device *pdev) /* Voice codec interface client */ cell = davinci_vc-cells[DAVINCI_VC_VCIF_CELL]; - cell-name = davinci_vcif; + cell-name = davinci-vcif; cell-driver_data = davinci_vc; /* Voice codec CQ93VC client */ cell = davinci_vc-cells[DAVINCI_VC_CQ93VC_CELL]; - cell-name = cq93vc; + cell-name = cq93vc-codec; cell-driver_data = davinci_vc; ret = mfd_add_devices(pdev-dev, pdev-id, davinci_vc-cells, -- 1.7.1 ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
[PATCH] ASoC: DaVinci: fix kernel panic due to uninitialized platform_data
This patch fixes the Kernel panic issue on accessing davinci_vc in
cq93vc_probe function. struct davinci_vc is part of platform device's
private driver data(codec-dev-p-driver_data) and this is populated
by DaVinci Voice Codec MFD driver.
Signed-off-by: Manjunathappa, Prakash prakash...@ti.com
---
This patch applies to Linus's tree at [1].
[1] http://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
---
sound/soc/codecs/cq93vc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/cq93vc.c b/sound/soc/codecs/cq93vc.c
index 46dbfd0..347a567 100644
--- a/sound/soc/codecs/cq93vc.c
+++ b/sound/soc/codecs/cq93vc.c
@@ -153,7 +153,7 @@ static int cq93vc_resume(struct snd_soc_codec *codec)
static int cq93vc_probe(struct snd_soc_codec *codec)
{
- struct davinci_vc *davinci_vc = codec-dev-platform_data;
+ struct davinci_vc *davinci_vc = snd_soc_codec_get_drvdata(codec);
davinci_vc-cq93vc.codec = codec;
codec-control_data = davinci_vc;
--
1.7.1
___
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
Re: [alsa-devel] [PATCH] ASoC: DaVinci: fix kernel panic due to uninitialized platform_data
On Thu, 2011-01-27 at 19:17 +0530, Manjunathappa, Prakash wrote:
This patch fixes the Kernel panic issue on accessing davinci_vc in
cq93vc_probe function. struct davinci_vc is part of platform device's
private driver data(codec-dev-p-driver_data) and this is populated
by DaVinci Voice Codec MFD driver.
Signed-off-by: Manjunathappa, Prakash prakash...@ti.com
---
This patch applies to Linus's tree at [1].
[1] http://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
---
sound/soc/codecs/cq93vc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/cq93vc.c b/sound/soc/codecs/cq93vc.c
index 46dbfd0..347a567 100644
--- a/sound/soc/codecs/cq93vc.c
+++ b/sound/soc/codecs/cq93vc.c
@@ -153,7 +153,7 @@ static int cq93vc_resume(struct snd_soc_codec *codec)
static int cq93vc_probe(struct snd_soc_codec *codec)
{
- struct davinci_vc *davinci_vc = codec-dev-platform_data;
+ struct davinci_vc *davinci_vc = snd_soc_codec_get_drvdata(codec);
davinci_vc-cq93vc.codec = codec;
codec-control_data = davinci_vc;
Acked-by: Liam Girdwood l...@slimlogic.co.uk
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
___
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
Re: [PATCH] MFD: DaVinci: Fix voice codec device name
On Thu, 2011-01-27 at 18:58 +0530, Manjunathappa, Prakash wrote: Fix the device name in DaVinci Voice Codec MFD driver to load davinci-vcif and cq93vc codec client drivers. Signed-off-by: Manjunathappa, Prakash prakash...@ti.com --- This patch applies to Linus's tree at [1]. [1] http://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git --- drivers/mfd/davinci_voicecodec.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/davinci_voicecodec.c b/drivers/mfd/davinci_voicecodec.c index 33c923d..fdd8a1b 100644 --- a/drivers/mfd/davinci_voicecodec.c +++ b/drivers/mfd/davinci_voicecodec.c @@ -118,12 +118,12 @@ static int __init davinci_vc_probe(struct platform_device *pdev) /* Voice codec interface client */ cell = davinci_vc-cells[DAVINCI_VC_VCIF_CELL]; - cell-name = davinci_vcif; + cell-name = davinci-vcif; cell-driver_data = davinci_vc; /* Voice codec CQ93VC client */ cell = davinci_vc-cells[DAVINCI_VC_CQ93VC_CELL]; - cell-name = cq93vc; + cell-name = cq93vc-codec; cell-driver_data = davinci_vc; ret = mfd_add_devices(pdev-dev, pdev-id, davinci_vc-cells, Acked-by: Liam Girdwood l...@slimlogic.co.uk -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
Intermittent SD write corruption on DM355, kernel 2.6.36
I am seeing rare SD card write corruption on DM355 running 2.6.36. The system will get itself into a state where it appears all SD writes are offset by two bytes. This is using a vfat filesystem on the SD, and affects the FAT and directories at least. When I look at the contents of the SD card, corrupt sectors start with two bytes of junk which looks like the end of the previous sector write, then valid data (but shifted up two byte places), with the last two bytes missing - they seem to get written at the start of whatever sector gets written next. When the system is in this state I can umount and change cards, mount, touch a file and unmount and it repeatably corrupts the sector containing the directory entry. Unfortunately after a reboot everything works fine again, I haven't found a repeatable way to get the system back into the corrupting state. I have seen this happen on at least two separate occasions now and was not doing anything particularly abusive or unusual this time, so I know now this is real and needs to be fixed. I am going to look at git history since 2.6.36 to see if anything looking like a fix has been committed, will also try banging on things to reproduce the problem. But if anyone has any similar experiences, comments, suggestions they would be most welcome. Thanks. -- Jon Povey jon.po...@racelogic.co.uk Racelogic is a limited company registered in England. Registered number 2743719 . Registered Office Unit 10, Swan Business Centre, Osier Way, Buckingham, Bucks, MK18 1TB . The information contained in this electronic mail transmission is intended by Racelogic Ltd for the use of the named individual or entity to which it is directed and may contain information that is confidential or privileged. If you have received this electronic mail transmission in error, please delete it from your system without copying or forwarding it, and notify the sender of the error by reply email so that the sender's address records can be corrected. The views expressed by the sender of this communication do not necessarily represent those of Racelogic Ltd. Please note that Racelogic reserves the right to monitor e-mail communications passing through its network ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
