RE: [PATCH V4 1/3] ARM: davinci: da850: add pinctrl driver DT entries
On Wed, Jan 16, 2013 at 09:18:20, Kumar, Anil wrote:
For DT, DaVinci platform can use pinctrl-single driver for handling
padconf registers.
Enable PINCTRL Kconfig for MACH_DA8XX_DT platform. Add required
pinctrl DT entries in da850 dts file.
Test procedure
1)Populate DT file with NAND node information.
2)Populate board DT file with pinmux information for NAND.
3)Boot and confirm NAND is detected by the kernel.
4)cat /proc/mtd to show partitions.
Signed-off-by: Kumar, Anil anilkuma...@ti.com
---
:100644 100644 37dc5a3... c7609d0... March/arm/boot/dts/da850-evm.dts
:100644 100644 fbada87... e9c6e82... March/arm/boot/dts/da850.dtsi
:100644 100644 0153950... a075b3e... March/arm/mach-davinci/Kconfig
arch/arm/boot/dts/da850-evm.dts |3 +++
arch/arm/boot/dts/da850.dtsi| 10 ++
arch/arm/mach-davinci/Kconfig |1 +
3 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
index 37dc5a3..c7609d0 100644
--- a/arch/arm/boot/dts/da850-evm.dts
+++ b/arch/arm/boot/dts/da850-evm.dts
@@ -15,6 +15,9 @@
model = DA850/AM1808/OMAP-L138 EVM;
soc {
+ pmx_core:pinmux@1c14120 {
I have found cosmetics issue here. I will correct it and send next version.
+ status = okay;
+ };
serial0: serial@1c42000 {
status = okay;
};
diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
index fbada87..e9c6e82 100644
--- a/arch/arm/boot/dts/da850.dtsi
+++ b/arch/arm/boot/dts/da850.dtsi
@@ -29,6 +29,16 @@
#size-cells = 1;
ranges = 0x0 0x01c0 0x40;
+ pmx_core:pinmux@1c14120 {
I have found cosmetics issue here. I will correct it and send next version.
+ compatible = pinctrl-single;
+ reg = 0x14120 0x50;
+ #address-cells = 1;
+ #size-cells = 0;
+ pinctrl-single,bit-per-mux;
+ pinctrl-single,register-width = 32;
+ pinctrl-single,function-mask = 0x;
+ status = disabled;
+ };
serial0: serial@1c42000 {
compatible = ns16550a;
reg = 0x42000 0x100;
diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig
index 0153950..a075b3e 100644
--- a/arch/arm/mach-davinci/Kconfig
+++ b/arch/arm/mach-davinci/Kconfig
@@ -62,6 +62,7 @@ config MACH_DA8XX_DT
bool Support DA8XX platforms using device tree
default y
depends on ARCH_DAVINCI_DA8XX
+ select PINCTRL
help
Say y here to include support for TI DaVinci DA850 based using
Flattened Device Tree. More information at Documentation/devicetree
--
1.7.4.1
___
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
[PATCH V5 0/3] ARM: davinci: da850: add pinctrl support
This set of patches adds: * Add pinctrl-single for handling Padconf registers. * Add NAND node to export NAND functionality on da850 EVM. * Add NAND pinctrl node to do pin mux according to pinctrl-single driver. This series applies on top of tag next-20130107 git tree https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git and the following patch -drivers/pinctrl: grab default handles from device core https://patchwork.kernel.org/patch/1862231/ This series is tested on da850 EVM. Changes since V4: -Cosmetic changes. Changes since V3: -Move NAND related pinctrl DT data into the da850.dtsi file so it can be reused. Changes since V2: -Move NAND pins configuration into the nand_cs3 DT node to avoid pins configuration if it is not probed. Changes since V1: -Remove the binding documentation as already documented as part of Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt -Enable PINCTRL Kconfig for MACH_DA8XX_DT platform only. -Fix the pinctrl driver node unit-address. -Make separate patch for da8xx_omapl_defconfig changes. Kumar, Anil (3): ARM: davinci: da850: add pinctrl driver DT entries ARM: davinci: da8xx defconfig: enable pinctrl config option ARM: davinci: da850: add NAND driver DT entries arch/arm/boot/dts/da850-evm.dts|8 ++ arch/arm/boot/dts/da850.dtsi | 40 arch/arm/configs/da8xx_omapl_defconfig |1 + arch/arm/mach-davinci/Kconfig |1 + 4 files changed, 50 insertions(+), 0 deletions(-) -- 1.7.4.1 ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
[PATCH V5 1/3] ARM: davinci: da850: add pinctrl driver DT entries
For DT, DaVinci platform can use pinctrl-single driver for handling
padconf registers.
Enable PINCTRL Kconfig for MACH_DA8XX_DT platform. Add required
pinctrl DT entries in da850 dts file.
Test procedure
1)Populate DT file with NAND node information.
2)Populate board DT file with pinmux information for NAND.
3)Boot and confirm NAND is detected by the kernel.
4)cat /proc/mtd to show partitions.
Signed-off-by: Kumar, Anil anilkuma...@ti.com
---
Cosmetic changes for pmx_core: pinmux@1c14120 DT node
:100644 100644 37dc5a3... 087ba28... M arch/arm/boot/dts/da850-evm.dts
:100644 100644 fbada87... 160ebac... M arch/arm/boot/dts/da850.dtsi
:100644 100644 0153950... a075b3e... M arch/arm/mach-davinci/Kconfig
arch/arm/boot/dts/da850-evm.dts |3 +++
arch/arm/boot/dts/da850.dtsi| 10 ++
arch/arm/mach-davinci/Kconfig |1 +
3 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
index 37dc5a3..087ba28 100644
--- a/arch/arm/boot/dts/da850-evm.dts
+++ b/arch/arm/boot/dts/da850-evm.dts
@@ -15,6 +15,9 @@
model = DA850/AM1808/OMAP-L138 EVM;
soc {
+ pmx_core: pinmux@1c14120 {
+ status = okay;
+ };
serial0: serial@1c42000 {
status = okay;
};
diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
index fbada87..160ebac 100644
--- a/arch/arm/boot/dts/da850.dtsi
+++ b/arch/arm/boot/dts/da850.dtsi
@@ -29,6 +29,16 @@
#size-cells = 1;
ranges = 0x0 0x01c0 0x40;
+ pmx_core: pinmux@1c14120 {
+ compatible = pinctrl-single;
+ reg = 0x14120 0x50;
+ #address-cells = 1;
+ #size-cells = 0;
+ pinctrl-single,bit-per-mux;
+ pinctrl-single,register-width = 32;
+ pinctrl-single,function-mask = 0x;
+ status = disabled;
+ };
serial0: serial@1c42000 {
compatible = ns16550a;
reg = 0x42000 0x100;
diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig
index 0153950..a075b3e 100644
--- a/arch/arm/mach-davinci/Kconfig
+++ b/arch/arm/mach-davinci/Kconfig
@@ -62,6 +62,7 @@ config MACH_DA8XX_DT
bool Support DA8XX platforms using device tree
default y
depends on ARCH_DAVINCI_DA8XX
+ select PINCTRL
help
Say y here to include support for TI DaVinci DA850 based using
Flattened Device Tree. More information at Documentation/devicetree
--
1.7.4.1
___
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
[PATCH V5 3/3] ARM: davinci: da850: add NAND driver DT entries
Add NAND driver DT node and related pinctrl DT data to export NAND
functionality on da850 evm.
Signed-off-by: Kumar, Anil anilkuma...@ti.com
---
:100644 100644 087ba28... 98c1a48... M arch/arm/boot/dts/da850-evm.dts
:100644 100644 160ebac... f014f7b... M arch/arm/boot/dts/da850.dtsi
arch/arm/boot/dts/da850-evm.dts |5 +
arch/arm/boot/dts/da850.dtsi| 30 ++
2 files changed, 35 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
index 087ba28..98c1a48 100644
--- a/arch/arm/boot/dts/da850-evm.dts
+++ b/arch/arm/boot/dts/da850-evm.dts
@@ -28,4 +28,9 @@
status = okay;
};
};
+ nand_cs3@6200 {
+ status = okay;
+ pinctrl-names = default;
+ pinctrl-0 = nand_cs3_pins;
+ };
};
diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
index 160ebac..f014f7b 100644
--- a/arch/arm/boot/dts/da850.dtsi
+++ b/arch/arm/boot/dts/da850.dtsi
@@ -38,6 +38,23 @@
pinctrl-single,register-width = 32;
pinctrl-single,function-mask = 0x;
status = disabled;
+
+ nand_cs3_pins: pinmux_nand_pins {
+ pinctrl-single,bits =
+ /* EMA_OE, EMA_WE */
+ 0x1c 0x0011 0x00ff
+ /* EMA_CS[4],EMA_CS[3]*/
+ 0x1c 0x0110 0x0ff0
+ /*
+* EMA_D[0], EMA_D[1], EMA_D[2],
+* EMA_D[3], EMA_D[4], EMA_D[5],
+* EMA_D[6], EMA_D[7]
+*/
+ 0x24 0x 0x
+ /* EMA_A[1], EMA_A[2] */
+ 0x30 0x0110 0x0ff0
+ ;
+ };
};
serial0: serial@1c42000 {
compatible = ns16550a;
@@ -67,4 +84,17 @@
status = disabled;
};
};
+ nand_cs3@6200 {
+ compatible = ti,davinci-nand;
+ reg = 0x6200 0x807ff
+ 0x6800 0x8000;
+ ti,davinci-chipselect = 1;
+ ti,davinci-mask-ale = 0;
+ ti,davinci-mask-cle = 0;
+ ti,davinci-mask-chipsel = 0;
+ ti,davinci-ecc-mode = hw;
+ ti,davinci-ecc-bits = 4;
+ ti,davinci-nand-use-bbt;
+ status = disabled;
+ };
};
--
1.7.4.1
___
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
[PATCH V5 2/3] ARM: davinci: da8xx defconfig: enable pinctrl config option
Enable pinctrl related config option in da8xx_omapl_defconfig Signed-off-by: Kumar, Anil anilkuma...@ti.com --- :100644 100644 f292239... 0892db4... M arch/arm/configs/da8xx_omapl_defconfig arch/arm/configs/da8xx_omapl_defconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/configs/da8xx_omapl_defconfig b/arch/arm/configs/da8xx_omapl_defconfig index f292239..0892db4 100644 --- a/arch/arm/configs/da8xx_omapl_defconfig +++ b/arch/arm/configs/da8xx_omapl_defconfig @@ -81,6 +81,7 @@ CONFIG_SERIAL_OF_PLATFORM=y CONFIG_I2C=y CONFIG_I2C_CHARDEV=y CONFIG_I2C_DAVINCI=y +CONFIG_PINCTRL_SINGLE=y # CONFIG_HWMON is not set CONFIG_WATCHDOG=y CONFIG_REGULATOR=y -- 1.7.4.1 ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
Re: [PATCH v5 1/9] ARM: davinci: da850 board: change pr_warning() to pr_warn()
On 1/11/2013 5:53 AM, Robert Tivy wrote: Changed all pr_warning() calls to pr_warn(), as advised by checkpatch.pl. Also, while modifying those pr_warning() calls I changed hardcoded function names to use '%s:, __func__' instead, and converted acronym usage to upper case Signed-off-by: Robert Tivy rt...@ti.com Applying this patch for v3.9. While committing I updated the commit message to change past tense to present and also removed the first person reference. Thanks, Sekhar ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
Re: [PATCH v4, 03/14] ARM: edma: add AM33XX support to the private EDMA API
Hi Matt, On Friday 11 January 2013 at 06:48:39, Matt Porter wrote: diff --git a/arch/arm/common/edma.c b/arch/arm/common/edma.c index a3d189d..1951d63 100644 --- a/arch/arm/common/edma.c +++ b/arch/arm/common/edma.c @@ -24,6 +24,13 @@ #include linux/platform_device.h #include linux/io.h #include linux/slab.h +#include linux/edma.h +#include linux/err.h +#include linux/of_address.h +#include linux/of_device.h +#include linux/of_dma.h +#include linux/of_irq.h +#include linux/pm_runtime.h You add the include linux/of_dma.h here, but maybe you missed to add the file itself. It is not in Linus v3.8-rc3 tree, not in the patches yours depend on listed and not in your patchset. Regards, Lars ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
Re: [PATCH v5 2/9] ARM: davinci: devices-da8xx.c: change pr_warning() to pr_warn()
On 1/11/2013 5:53 AM, Robert Tivy wrote: Changed all pr_warning() calls to pr_warn(), as advised by checkpatch.pl. Signed-off-by: Robert Tivy rt...@ti.com --- Clean up files that will be otherwise modified in subsequent patch. arch/arm/mach-davinci/devices-da8xx.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-davinci/devices-da8xx.c b/arch/arm/mach-davinci/devices-da8xx.c index 2d5502d..fb2f51b 100644 --- a/arch/arm/mach-davinci/devices-da8xx.c +++ b/arch/arm/mach-davinci/devices-da8xx.c @@ -751,7 +751,7 @@ void __iomem * __init da8xx_get_mem_ctlr(void) da8xx_ddr2_ctlr_base = ioremap(DA8XX_DDR2_CTL_BASE, SZ_32K); if (!da8xx_ddr2_ctlr_base) - pr_warning(%s: Unable to map DDR2 controller, __func__); + pr_warn(%s: Unable to map DDR2 controller, __func__); return da8xx_ddr2_ctlr_base; } @@ -876,8 +876,8 @@ int __init da8xx_register_spi(int instance, const struct spi_board_info *info, ret = spi_register_board_info(info, len); if (ret) - pr_warning(%s: failed to register board info for spi %d : - %d\n, __func__, instance, ret); + pr_warn(%s: failed to register board info for spi %d : %d\n, + __func__, instance, ret); This part is not required anymore since this is already fixed by Vivien Didelot as part of his SPI fixes. I applied rest of the patch for v3.9. As with previous patch, I fixed the past tense to present in commit text while applying. Thanks, Sekhar ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
Re: [PATCH v5 4/9] ARM: davinci: da850: added pll0_sysclk1 for DSP usage
On 1/11/2013 5:53 AM, Robert Tivy wrote: Added pll0_sysclk1 to allow clocking control for DSP Signed-off-by: Robert Tivy rt...@ti.com Applied patches 3 and 4 as well. Thanks, Sekhar ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
