subject:"\[PATCH\] v4l2\-subdev\: THS7303 video amplifier driver"

[PATCH] v4l2-subdev: THS7303 video amplifier driver

2009-03-23 Thread Chaithrika U S

TI THS7303 video amplifier driver code

This patch adds driver for TI THS7303 video amplifier. This driver is
implemented as a v4l2 sub device. Tested on TI DM646x EVM.

This patch applies on top of the ADV7343 driver patch submitted prior to
this. The dependency is due to the modification of the
'Kconfig', 'Makefile', 'v4l2-chip-ident.h' files by both the patches.

Signed-off-by: Chaithrika U S chaithr...@ti.com
---
 drivers/media/video/Kconfig |9 ++
 drivers/media/video/Makefile|1 +
 drivers/media/video/ths7303.c   |  158 +++
 include/media/v4l2-chip-ident.h |3 +
 4 files changed, 171 insertions(+), 0 deletions(-)
 create mode 100644 drivers/media/video/ths7303.c

diff --git a/drivers/media/video/Kconfig b/drivers/media/video/Kconfig
index 49ff639..9747e4d 100644
--- a/drivers/media/video/Kconfig
+++ b/drivers/media/video/Kconfig
@@ -435,6 +435,15 @@ config VIDEO_ADV7343
   To compile this driver as a module, choose M here: the
   module will be called adv7343.
 
+config VIDEO_THS7303
+   tristate THS7303 Video Amplifier
+   depends on I2C
+   help
+ Support for TI THS7303 video amplifier
+
+ To compile this driver as a module, choose M here: the
+  module will be called ths7303.
+
 comment Video improvement chips
 
 config VIDEO_UPD64031A
diff --git a/drivers/media/video/Makefile b/drivers/media/video/Makefile
index eaa5a49..4dc10de 100644
--- a/drivers/media/video/Makefile
+++ b/drivers/media/video/Makefile
@@ -55,6 +55,7 @@ obj-$(CONFIG_VIDEO_BT819) += bt819.o
 obj-$(CONFIG_VIDEO_BT856) += bt856.o
 obj-$(CONFIG_VIDEO_BT866) += bt866.o
 obj-$(CONFIG_VIDEO_KS0127) += ks0127.o
+obj-$(CONFIG_VIDEO_THS7303) += ths7303.o
 
 obj-$(CONFIG_VIDEO_ZORAN) += zoran/
 
diff --git a/drivers/media/video/ths7303.c b/drivers/media/video/ths7303.c
new file mode 100644
index 000..ae94910
--- /dev/null
+++ b/drivers/media/video/ths7303.c
@@ -0,0 +1,158 @@
+/*
+ * ths7303- THS7303 Video Amplifier driver
+ *
+ * Copyright (C) 2009 Texas Instruments Incorporated - http://www.ti.com/
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation version 2.
+ *
+ * This program is distributed .as is. WITHOUT ANY WARRANTY of any
+ * kind, whether express or implied; without even the implied warranty
+ * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include linux/kernel.h
+#include linux/init.h
+#include linux/ctype.h
+#include linux/i2c.h
+#include linux/device.h
+#include linux/delay.h
+#include linux/module.h
+#include linux/uaccess.h
+#include linux/videodev2.h
+
+#include media/v4l2-device.h
+#include media/v4l2-subdev.h
+#include media/v4l2-chip-ident.h
+
+MODULE_DESCRIPTION(TI THS7303 video amplifier driver);
+MODULE_AUTHOR(Chaithrika U S);
+MODULE_LICENSE(GPL);
+
+#define THS7303_NAME   ths7303
+
+static int debug = 1;
+module_param(debug, int, 0644);
+MODULE_PARM_DESC(debug, Debug level 0-1);
+
+struct ths7303_state {
+   struct v4l2_subdev sd;
+};
+
+/* following function is used to set ths7303 */
+static int ths7303_setvalue(struct v4l2_subdev *sd, v4l2_std_id std)
+{
+   int err = 0;
+   u8 val;
+   struct i2c_client *client;
+
+   client = v4l2_get_subdevdata(sd);
+
+   if (std  V4L2_STD_ALL) {
+   val = 0x02;
+   v4l2_dbg(1, debug, sd, setting value for SDTV format\n);
+   } else {
+   val = 0x00;
+   v4l2_dbg(1, debug, sd, disabling all channels\n);
+   }
+
+   err |= i2c_smbus_write_byte_data(client, 0x01, val);
+   err |= i2c_smbus_write_byte_data(client, 0x02, val);
+   err |= i2c_smbus_write_byte_data(client, 0x03, val);
+
+   if (err)
+   v4l2_err(sd, write failed\n);
+
+   return err;
+}
+
+static int ths7303_s_std(struct v4l2_subdev *sd, v4l2_std_id norm)
+{
+   return ths7303_setvalue(sd, norm);
+}
+
+static int ths7303_g_chip_ident(struct v4l2_subdev *sd,
+   struct v4l2_dbg_chip_ident *chip)
+{
+   struct i2c_client *client = v4l2_get_subdevdata(sd);
+
+   return v4l2_chip_ident_i2c_client(client, chip, V4L2_IDENT_THS7303, 0);
+}
+
+static const struct v4l2_subdev_tuner_ops ths7303_tuner_ops = {
+   .s_std  = ths7303_s_std,
+};
+
+static const struct v4l2_subdev_core_ops ths7303_core_ops = {
+   .g_chip_ident = ths7303_g_chip_ident,
+};
+
+static const struct v4l2_subdev_ops ths7303_ops = {
+   .core   = ths7303_core_ops,
+   .tuner  = ths7303_tuner_ops,
+};
+
+static int ths7303_probe(struct i2c_client *client,
+   const struct i2c_device_id *id)
+{
+   struct ths7303_state *state;
+   v4l2_std_id std_id = V4L2_STD_NTSC;
+
+   if (!i2c_check_functionality(client-adapter, I2C_FUNC_SMBUS_BYTE_DATA))
+

Re: [PATCH] v4l2-subdev: THS7303 video amplifier driver

2009-03-23 Thread Hans Verkuil

On Monday 23 March 2009 13:38:15 Chaithrika U S wrote:
 TI THS7303 video amplifier driver code

 This patch adds driver for TI THS7303 video amplifier. This driver is
 implemented as a v4l2 sub device. Tested on TI DM646x EVM.

 This patch applies on top of the ADV7343 driver patch submitted prior to
 this. The dependency is due to the modification of the
 'Kconfig', 'Makefile', 'v4l2-chip-ident.h' files by both the patches.

 Signed-off-by: Chaithrika U S chaithr...@ti.com

Just a few small points left:

 ---
  drivers/media/video/Kconfig |9 ++
  drivers/media/video/Makefile|1 +
  drivers/media/video/ths7303.c   |  158
 +++ include/media/v4l2-chip-ident.h |
3 +
  4 files changed, 171 insertions(+), 0 deletions(-)
  create mode 100644 drivers/media/video/ths7303.c

 diff --git a/drivers/media/video/Kconfig b/drivers/media/video/Kconfig
 index 49ff639..9747e4d 100644
 --- a/drivers/media/video/Kconfig
 +++ b/drivers/media/video/Kconfig
 @@ -435,6 +435,15 @@ config VIDEO_ADV7343
To compile this driver as a module, choose M here: the
module will be called adv7343.

 +config VIDEO_THS7303
 + tristate THS7303 Video Amplifier
 + depends on I2C
 + help
 +   Support for TI THS7303 video amplifier
 +
 +   To compile this driver as a module, choose M here: the
 +  module will be called ths7303.
 +
  comment Video improvement chips

  config VIDEO_UPD64031A
 diff --git a/drivers/media/video/Makefile b/drivers/media/video/Makefile
 index eaa5a49..4dc10de 100644
 --- a/drivers/media/video/Makefile
 +++ b/drivers/media/video/Makefile
 @@ -55,6 +55,7 @@ obj-$(CONFIG_VIDEO_BT819) += bt819.o
  obj-$(CONFIG_VIDEO_BT856) += bt856.o
  obj-$(CONFIG_VIDEO_BT866) += bt866.o
  obj-$(CONFIG_VIDEO_KS0127) += ks0127.o
 +obj-$(CONFIG_VIDEO_THS7303) += ths7303.o

  obj-$(CONFIG_VIDEO_ZORAN) += zoran/

 diff --git a/drivers/media/video/ths7303.c
 b/drivers/media/video/ths7303.c new file mode 100644
 index 000..ae94910
 --- /dev/null
 +++ b/drivers/media/video/ths7303.c
 @@ -0,0 +1,158 @@
 +/*
 + * ths7303- THS7303 Video Amplifier driver
 + *
 + * Copyright (C) 2009 Texas Instruments Incorporated -
 http://www.ti.com/ + *
 + * This program is free software; you can redistribute it and/or
 + * modify it under the terms of the GNU General Public License as
 + * published by the Free Software Foundation version 2.
 + *
 + * This program is distributed .as is. WITHOUT ANY WARRANTY of any
 + * kind, whether express or implied; without even the implied warranty
 + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 + * GNU General Public License for more details.
 + */
 +
 +#include linux/kernel.h
 +#include linux/init.h
 +#include linux/ctype.h
 +#include linux/i2c.h
 +#include linux/device.h
 +#include linux/delay.h
 +#include linux/module.h
 +#include linux/uaccess.h
 +#include linux/videodev2.h
 +
 +#include media/v4l2-device.h
 +#include media/v4l2-subdev.h
 +#include media/v4l2-chip-ident.h
 +
 +MODULE_DESCRIPTION(TI THS7303 video amplifier driver);
 +MODULE_AUTHOR(Chaithrika U S);
 +MODULE_LICENSE(GPL);
 +
 +#define THS7303_NAME ths7303
 +
 +static int debug = 1;

By default the debug level should be 0.

 +module_param(debug, int, 0644);
 +MODULE_PARM_DESC(debug, Debug level 0-1);
 +
 +struct ths7303_state {
 + struct v4l2_subdev sd;
 +};

No need for this struct. Just allocate a v4l2_subdev struct directly.

 +
 +/* following function is used to set ths7303 */
 +static int ths7303_setvalue(struct v4l2_subdev *sd, v4l2_std_id std)
 +{
 + int err = 0;
 + u8 val;
 + struct i2c_client *client;
 +
 + client = v4l2_get_subdevdata(sd);
 +
 + if (std  V4L2_STD_ALL) {
 + val = 0x02;
 + v4l2_dbg(1, debug, sd, setting value for SDTV format\n);
 + } else {
 + val = 0x00;
 + v4l2_dbg(1, debug, sd, disabling all channels\n);
 + }
 +
 + err |= i2c_smbus_write_byte_data(client, 0x01, val);
 + err |= i2c_smbus_write_byte_data(client, 0x02, val);
 + err |= i2c_smbus_write_byte_data(client, 0x03, val);
 +
 + if (err)
 + v4l2_err(sd, write failed\n);
 +
 + return err;
 +}
 +
 +static int ths7303_s_std(struct v4l2_subdev *sd, v4l2_std_id norm)
 +{
 + return ths7303_setvalue(sd, norm);
 +}

It is my understanding that the ths7303 is only used in combination with 
video encoders (i.e. video output). In that case this should be 
ths7303_s_std_output.

 +
 +static int ths7303_g_chip_ident(struct v4l2_subdev *sd,
 + struct v4l2_dbg_chip_ident *chip)
 +{
 + struct i2c_client *client = v4l2_get_subdevdata(sd);
 +
 + return v4l2_chip_ident_i2c_client(client, chip, V4L2_IDENT_THS7303, 0);
 +}
 +
 +static const struct v4l2_subdev_tuner_ops ths7303_tuner_ops = {
 + .s_std  = ths7303_s_std,
 +};
 +
 +static const struct v4l2_subdev_core_ops ths7303_core_ops = {
 + .g_chip_ident =

[PATCH] v4l2-subdev: THS7303 video amplifier driver

Re: [PATCH] v4l2-subdev: THS7303 video amplifier driver

2 matches

Site Navigation

Mail list logo

Footer information