Re: [PATCH 3/4] OMAP3 : clock data: Update name string for EMAC clocks.

2010-03-12 Thread Kevin Hilman 
Sriramakrishnan s...@ti.com writes:

 The emac driver uses generic name for the module and phy
 clocks. Updated the omap3xxx_clks table to match the names
 used by the Davinci emac driver.

 Signed-off-by: Sriramakrishnan s...@ti.com
 ---
  arch/arm/mach-omap2/clock3xxx_data.c |4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

 diff --git a/arch/arm/mach-omap2/clock3xxx_data.c 
 b/arch/arm/mach-omap2/clock3xxx_data.c
 index d5153b6..989da2e 100644
 --- a/arch/arm/mach-omap2/clock3xxx_data.c
 +++ b/arch/arm/mach-omap2/clock3xxx_data.c
 @@ -3472,8 +3472,8 @@ static struct omap_clk omap3xxx_clks[] = {
   CLK(NULL,   ipss_ick, ipss_ick,  CK_AM35XX),
   CLK(NULL,   rmii_ck,  rmii_ck,   CK_AM35XX),
   CLK(NULL,   pclk_ck,  pclk_ck,   CK_AM35XX),
 - CLK(davinci_emac, ick,  emac_ick,  CK_AM35XX),
 - CLK(davinci_emac, fck,  emac_fck,  CK_AM35XX),
 + CLK(davinci_emac, emac_clk, emac_ick,  CK_AM35XX),
 + CLK(davinci_emac, phy_clk,  emac_fck,  CK_AM35XX),

As I mentioned in the review of the equivalent davinci changes,
I'm not crazy abou the _clk suffixes on the con_id.  I think
these should be called main (or emac) and phy.

Kevin
___
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

[PATCH 3/4] OMAP3 : clock data: Update name string for EMAC clocks.

2010-03-11 Thread Sriramakrishnan 
The emac driver uses generic name for the module and phy
clocks. Updated the omap3xxx_clks table to match the names
used by the Davinci emac driver.

Signed-off-by: Sriramakrishnan s...@ti.com
---
 arch/arm/mach-omap2/clock3xxx_data.c |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-omap2/clock3xxx_data.c 
b/arch/arm/mach-omap2/clock3xxx_data.c
index d5153b6..989da2e 100644
--- a/arch/arm/mach-omap2/clock3xxx_data.c
+++ b/arch/arm/mach-omap2/clock3xxx_data.c
@@ -3472,8 +3472,8 @@ static struct omap_clk omap3xxx_clks[] = {
CLK(NULL,   ipss_ick, ipss_ick,  CK_AM35XX),
CLK(NULL,   rmii_ck,  rmii_ck,   CK_AM35XX),
CLK(NULL,   pclk_ck,  pclk_ck,   CK_AM35XX),
-   CLK(davinci_emac, ick,  emac_ick,  CK_AM35XX),
-   CLK(davinci_emac, fck,  emac_fck,  CK_AM35XX),
+   CLK(davinci_emac, emac_clk, emac_ick,  CK_AM35XX),
+   CLK(davinci_emac, phy_clk,  emac_fck,  CK_AM35XX),
CLK(vpfe-capture, master,   vpfe_ick,  CK_AM35XX),
CLK(vpfe-capture, slave,vpfe_fck,  CK_AM35XX),
CLK(musb_hdrc,ick,  hsotgusb_ick_am35xx,   
CK_AM35XX),
-- 
1.6.2.4

___
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Re: [PATCH 3/4] OMAP3 : clock data: Update name string for EMAC clocks.

2010-03-11 Thread Paul Walmsley 
On Thu, 11 Mar 2010, Sriramakrishnan wrote:

 The emac driver uses generic name for the module and phy
 clocks. Updated the omap3xxx_clks table to match the names
 used by the Davinci emac driver.
 
 Signed-off-by: Sriramakrishnan s...@ti.com

Acked-by: Paul Walmsley p...@pwsan.com

At some point, someone should go through that davinci_emac.c driver and 
change the DaVinci references to TI or something generic, now that this 
core exists on DaVinci, OMAP, etc.

 ---
  arch/arm/mach-omap2/clock3xxx_data.c |4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
 
 diff --git a/arch/arm/mach-omap2/clock3xxx_data.c 
 b/arch/arm/mach-omap2/clock3xxx_data.c
 index d5153b6..989da2e 100644
 --- a/arch/arm/mach-omap2/clock3xxx_data.c
 +++ b/arch/arm/mach-omap2/clock3xxx_data.c
 @@ -3472,8 +3472,8 @@ static struct omap_clk omap3xxx_clks[] = {
   CLK(NULL,   ipss_ick, ipss_ick,  CK_AM35XX),
   CLK(NULL,   rmii_ck,  rmii_ck,   CK_AM35XX),
   CLK(NULL,   pclk_ck,  pclk_ck,   CK_AM35XX),
 - CLK(davinci_emac, ick,  emac_ick,  CK_AM35XX),
 - CLK(davinci_emac, fck,  emac_fck,  CK_AM35XX),
 + CLK(davinci_emac, emac_clk, emac_ick,  CK_AM35XX),
 + CLK(davinci_emac, phy_clk,  emac_fck,  CK_AM35XX),
   CLK(vpfe-capture, master,   vpfe_ick,  CK_AM35XX),
   CLK(vpfe-capture, slave,vpfe_fck,  CK_AM35XX),
   CLK(musb_hdrc,ick,  hsotgusb_ick_am35xx,   
 CK_AM35XX),
 -- 
 1.6.2.4
 
 --
 To unsubscribe from this list: send the line unsubscribe linux-omap in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
 


- Paul
___
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source