[Dbmail] Missing free statements in cvs as of this morning... db.c

2004-03-01 Thread Leif Jackson
Roel,

 I noticed that some of the original patch I sent you a while ago for
memory leaks missed these few db_free_result's I have attached the patch
for current cvs. Thanks. I am still trying to track down the issue with
the list.c node_add it still seems that there is an instance in the
codebase where the list is not fully freed, I am seeing a significant
leak in pop3d still. Will let you know when I find it. Any pointers would
be great.

Also I am really exited about Arron's sieve stuff, will this implement the
SORT command for imap and not just filtering? I believe a major
performance enhancement for web based clients like squirrellmail which I
use full time with dbmail would be the addition of the server side sorting
code.

Thanks,
Leif

dbmail-2.0cvs030104-db.c.diff
Description: Binary data


Re: [Dbmail] Missing free statements in cvs as of this morning... db.c

2004-03-02 Thread Ilja Booij

Hi

Leif Jackson wrote:


Roel,

 I noticed that some of the original patch I sent you a while ago for
memory leaks missed these few db_free_result's I have attached the patch
for current cvs. Thanks. I am still trying to track down the issue with
the list.c node_add it still seems that there is an instance in the
codebase where the list is not fully freed, I am seeing a significant
leak in pop3d still. Will let you know when I find it. Any pointers would
be great.
I haven't looked into this myself (yet). I'll let you know if I can find 
any place where a list (or list item) is not freed. Meanwhile, I'll 
apply your patch.


Also I am really exited about Arron's sieve stuff, will this implement the
SORT command for imap and not just filtering? I believe a major
performance enhancement for web based clients like squirrellmail which I
use full time with dbmail would be the addition of the server side sorting
code.
The sorting in Aaron's stuff is on the delivery side. The SORT and 
THREAD commands are on the IMAP side. So, to answer your question: This 
will not implement the server side sorting for IMAP clients. That will 
take some more work. I agree that we should do this to benefit webbased 
clients.


Ilja