Re: acidrip: doesnt work with latest versions of mencoder

2005-10-21 Thread Jean-Luc Coulon (f5ibh)

Le 19.10.2005 22:40:27, Corey Hickey a écrit :

Jean-Luc Coulon (f5ibh) wrote:

me) dont dont accept the -xvidencopts suboption which is used by
acidrip, typically with something like:
   -xvidencopts :bitrate=759:pass=2 ...


Yes, the ':' before bitrate is a syntax error. I don't know if
earlier
versions of mencoder were tolerant of that.

I don't know perl, but I can see what's going on.

Line 221 of AcidRip/acidrip.pm:

$menc{'video'} = -ovc xvid -xvidencopts
$::settings-{'xvid_options'}:bitrate=$::settings-{'video
_bitrate'};

xvid_options is empty, leaving only the ':'. Mencoder accepts a
trailing
':', so you ought to be able to just reorder that line, putting
xvid_options at the end. Try the attached patch. If that fixes the
xvidencopts part, you might have to follow my example for some of the
other nearby lines in AcidRip/acidrip.pm.


Yes, it works, thanks.
But I think even this way it is not clean: next time, mencoder will  
refuse also the trailing :. So I think the best is to test if  
xvid_options is empty (it is initialised to '' at the beginning) and  
create 2 different lines depending of the result of the test.


Something like:

  if ( $::settings-{'video_codec'} eq 'xvid' ) {
 if ($xvid_options) ne '' {
$menc{'video'} = -ovc xvid -xvidencopts  
$::settings-{'xvid_options'}:bitrate=$::settings-{'video_bitrate'};

} else {
$menc{'video'} = -ovc xvid -xvidencopts  
bitrate=$::settings-{'video_bitrate'};

}


or:

  if ( $::settings-{'video_codec'} eq 'xvid' ) {
$memc{'video'} = -ovc xvid -xvidencopts ;
$menc{'video'} .= $::settings-{'xvid_options'}: if  
$xvid_options ne '';

$menc{'video'} .= bitrate=$::settings-{'video_bitrate'};
$menc{'video'} .= :pass=$::settings-{'video_pass'} if  
$::settings-{'video_passes'}  1;

  }



-Corey



Jean-Luc


pgpNlsQ6meBej.pgp
Description: PGP signature


acidrip: doesnt work with latest versions of mencoder

2005-10-19 Thread Jean-Luc Coulon (f5ibh)

Hi,

The latest versions of mencoder (cvs) that are newer than 20051011 (for  
me) dont dont accept the -xvidencopts suboption which is used by  
acidrip, typically with something like:

  -xvidencopts :bitrate=759:pass=2 ...

Is there any way to use latest version of mencoder with acidrip?

Regards

Jean-Luc


pgpEABGCXbBlF.pgp
Description: PGP signature


Re: acidrip: doesnt work with latest versions of mencoder

2005-10-19 Thread Jean-Luc Coulon (f5ibh)

Le 19.10.2005 20:58:13, Jean-Luc Coulon (f5ibh) a écrit :

Hi,

The latest versions of mencoder (cvs) that are newer than 20051011  
(for me) dont dont accept the -xvidencopts suboption which is used by  
acidrip, typically with something like:

  -xvidencopts :bitrate=759:pass=2 ...

 ***
In fact the proble seems to be here: there is nothing before bitrate  
but the leading ':' is still here. Older versionq of mencoder accept  
this syntax.




Is there any way to use latest version of mencoder with acidrip?

Regards



J-L



pgpG1wFSXn7WE.pgp
Description: PGP signature


Re: acidrip: doesnt work with latest versions of mencoder

2005-10-19 Thread Corey Hickey
Jean-Luc Coulon (f5ibh) wrote:
 Hi,
 
 The latest versions of mencoder (cvs) that are newer than 20051011 (for  
 me) dont dont accept the -xvidencopts suboption which is used by  
 acidrip, typically with something like:
    -xvidencopts :bitrate=759:pass=2 ...
 

Yes, the ':' before bitrate is a syntax error. I don't know if earlier
versions of mencoder were tolerant of that.

In any case, you'd be best off contacting Chris Phillips, the author of
acidrip. His address is listed at the bottom of the acidrip file (the
perl script itself). Just use a text editor and scroll to the end. Or,
if you want to be fancy, use 'perldoc acidrip'.

-Corey


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Re: acidrip: doesnt work with latest versions of mencoder

2005-10-19 Thread Jean-Luc Coulon (f5ibh)

Le 19.10.2005 21:15:33, Corey Hickey a écrit :

Jean-Luc Coulon (f5ibh) wrote:
 Hi,

 The latest versions of mencoder (cvs) that are newer than 20051011
(for
 me) dont dont accept the -xvidencopts suboption which is used by
 acidrip, typically with something like:
    -xvidencopts :bitrate=759:pass=2 ...


Yes, the ':' before bitrate is a syntax error. I don't know if earlier
versions of mencoder were tolerant of that.


yes, I managed to write an avi file with cvs20051011



In any case, you'd be best off contacting Chris Phillips, the author
of
acidrip. His address is listed at the bottom of the acidrip file (the
perl script itself). Just use a text editor and scroll to the end. Or,
if you want to be fancy, use 'perldoc acidrip'.


Well, I've opended a bug on sourceforge.
I think this works also ?



-Corey


Jean-Luc


pgpnOGzvdJzzL.pgp
Description: PGP signature


Re: acidrip: doesnt work with latest versions of mencoder

2005-10-19 Thread Corey Hickey
Jean-Luc Coulon (f5ibh) wrote:

me) dont dont accept the -xvidencopts suboption which is used by
acidrip, typically with something like:
   -xvidencopts :bitrate=759:pass=2 ...


Yes, the ':' before bitrate is a syntax error. I don't know if earlier
versions of mencoder were tolerant of that.

I don't know perl, but I can see what's going on.

Line 221 of AcidRip/acidrip.pm:

$menc{'video'} = -ovc xvid -xvidencopts
$::settings-{'xvid_options'}:bitrate=$::settings-{'video
_bitrate'};

xvid_options is empty, leaving only the ':'. Mencoder accepts a trailing
':', so you ought to be able to just reorder that line, putting
xvid_options at the end. Try the attached patch. If that fixes the
xvidencopts part, you might have to follow my example for some of the
other nearby lines in AcidRip/acidrip.pm.

-Corey
diff -aur acidrip-0.14.orig/AcidRip/acidrip.pm acidrip-0.14/AcidRip/acidrip.pm
--- acidrip-0.14.orig/AcidRip/acidrip.pm2004-07-25 07:03:09.0 
-0700
+++ acidrip-0.14/AcidRip/acidrip.pm 2005-10-19 13:37:57.0 -0700
@@ -218,7 +218,7 @@
 $menc{'video'} .= :pass=$::settings-{'video_pass'} if 
$::settings-{'video_passes'}  1;
   }
   if ( $::settings-{'video_codec'} eq 'xvid' ) {
-$menc{'video'} = -ovc xvid -xvidencopts 
$::settings-{'xvid_options'}:bitrate=$::settings-{'video_bitrate'};
+$menc{'video'} = -ovc xvid -xvidencopts 
bitrate=$::settings-{'video_bitrate'}:$::settings-{'xvid_options'};
 $menc{'video'} .= :pass=$::settings-{'video_pass'} if 
$::settings-{'video_passes'}  1;
   }
   if ( $::settings-{'video_codec'} eq 'nuv' ) {