Bug#339352: marked as done ([g-i] CapsShift in kernel keymaps not handled properl)

2021-05-21 Thread Debian Bug Tracking System
Your message dated Sat, 22 May 2021 07:11:10 +0200
with message-id 
and subject line Re: Bug#339352: Reopen and block 339352
has caused the Debian Bug report #339352,
regarding [g-i] CapsShift in kernel keymaps not handled properl
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
339352: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=339352
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: cdebconf-gtk
Tags: upstream
Severity: normal

Step to repeat:
Set language to "French"/France, keyboard "Francais (fr-latin9)
Shift+key is not working when trying to use uppercase chars for
setting the system name after network hw has been detected.

The problem shows up _on i386_ both when using an iso image based on
gtk+directfb 2.0.9 libs [1], and based on 2.8.3 ones [2].
If  you try to switch to a text console (i.e. VT2 via ctrl-alt-f2)
the problem does _not_ show up and it's possible to type uppercase
chars [A-Z].

I tried to reproduce the problem on AMD64 [3] and it does _not_
reproduce.

Regards,
Davide

[1] http://people.debian.org/~fjp/d-i/gtk-miniiso/daily/i386/mini.iso
[2] https://debian.polito.it/downloads/mini_gtkdfb_2_8_3.iso
[3] http://people.debian.org/~fjp/d-i/gtk-miniiso/daily/amd64/mini.iso


signature.asc
Description: Digital signature
--- End Message ---
--- Begin Message ---
Jérémy Bobbio  (2008-07-13):
> CapsShift is not currently handled in DirectFB (#383220) but is not
> handled in kbd-chooser's loadkeys either… :)

DirectFB was a long while ago, and everything looks good under X.Org
(and should have been for ~ 10 years), closing.


Cheers,
-- 
Cyril Brulebois (k...@debian.org)
D-I release manager -- Release team member -- Freelance Consultant


signature.asc
Description: PGP signature
--- End Message ---


Bug#401693: marked as done (Patch to make the g-i fulscreen)

2021-05-21 Thread Debian Bug Tracking System
Your message dated Sat, 22 May 2021 07:07:20 +0200
with message-id 
and subject line Re: Bug#401693: Patch to make the g-i fulscreen
has caused the Debian Bug report #401693,
regarding Patch to make the g-i fulscreen
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
401693: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=401693
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---

package: cdebconf-gtk-udeb
severity: wishlist
tags: patch

GTK frontend has currently a fixed size 800x600, but on some machines 
(especially PPCs) the framebuffer device has a fixed size which is 
greater than 800x600, resulting in a ugly frame around the installer.

This patch takes care of making the frontend going "fullscreen".

Attilio
--- gtk.c	2006-12-05 12:56:44.0 +0100
+++ gtk.c.fullscreen	2006-12-05 13:02:00.0 +0100
@@ -57,9 +57,6 @@
 #include 
 #endif
 
-#define WINDOW_WIDTH 800
-#define WINDOW_HEIGHT 600
-
 /* maximum length for string questions */
 #define STRING_MAX_LENGTH 128
 
@@ -67,6 +64,7 @@
 #define PROGRESSBAR_HPADDING 60
 #define PROGRESSBAR_VPADDING 60
 
+int screen_width, screen_height;
 typedef int (gtk_handler)(struct frontend *obj, struct question *q, GtkWidget *questionbox);
 
 static GCond *button_cond = NULL;
@@ -245,7 +243,7 @@
 pango_layout_set_font_description(layout, pango_font_description_from_string("Sans 12"));
 pango_layout_get_pixel_size(layout, , );
 /* obj->info is drawn over the debian banner, top-right corner of the screen */
-gdk_draw_layout(wid->window, gdk_gc_new(wid->window),  WINDOW_WIDTH - w - 4, 4, layout);
+gdk_draw_layout(wid->window, gdk_gc_new(wid->window),  screen_width - w - 4, 4, layout);
 free(message);
 }
 free(text);
@@ -1445,8 +1443,10 @@
 
 gtk_init (, );
 
+screen_width = gdk_screen_get_width (gdk_screen_get_default ());
+screen_height = gdk_screen_get_height (gdk_screen_get_default ());
 window = gtk_window_new (GTK_WINDOW_TOPLEVEL);
-gtk_widget_set_size_request (window, WINDOW_WIDTH, WINDOW_HEIGHT);
+gtk_widget_set_size_request (window, screen_width, screen_height);
 gtk_window_set_resizable (GTK_WINDOW (window), TRUE);
 gtk_window_set_position (GTK_WINDOW (window), GTK_WIN_POS_CENTER);
 gtk_window_set_decorated (GTK_WINDOW (window), TRUE);
--- End Message ---
--- Begin Message ---
Version: 0.123

Attilio Fiandrotti  (2006-12-06):
> Given it's more a feature implementation than a bugfix, i'll postpose to
> Etch release, pherhaps adding capability to load a user-specified image for
> custom debian builders benefit.

This happened in r49705:

commit 345db88a74b3ac47c9e581f994d5ee98e6bc333a
Author: Jérémy Bobbio 
Date:   Thu Oct 4 15:58:35 2007 +

Merge changes to the GTK+ frontend from the "fe_gtk" branch.

Featuring:
 - Rewritten codebase, more readable and documented.
 - Switch "Screenshot" button as secondary.
 - Define a clear API for plugins.

r49705

Closing, finally. :)


Cheers,
-- 
Cyril Brulebois (k...@debian.org)
D-I release manager -- Release team member -- Freelance Consultant


signature.asc
Description: PGP signature
--- End Message ---


Bug#474286: marked as done (cdebconf-gtk-udeb: segfaults after SIGTERM during reboot)

2021-05-21 Thread Debian Bug Tracking System
Your message dated Sat, 22 May 2021 06:59:24 +0200
with message-id 
and subject line Re: Bug#474286: cdebconf-gtk-udeb: segfaults after SIGTERM 
during reboot
has caused the Debian Bug report #474286,
regarding cdebconf-gtk-udeb: segfaults after SIGTERM during reboot
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
474286: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=474286
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: installation-reports
Version: 2.33
Severity: normal

Boot method: debian.exe
Image version: debian.exe daily (forgot to record URL)
Date: 2008-03-30

Machine: old whitebox machine (amd)
Partitions: 

fdisk -l:

Disk /dev/hda: 60.0 GB, 60022480896 bytes
255 heads, 63 sectors/track, 7297 cylinders
Units = cylinders of 16065 * 512 = 8225280 bytes
Disk identifier: 0x16c116c1

   Device Boot  Start End  Blocks   Id  System
/dev/hda1   *   11913153661417  HPFS/NTFS
/dev/hda21914510125607610f  W95 Ext'd (LBA)
/dev/hda351027169166112107  HPFS/NTFS
/dev/hda471707297 1028160   82  Linux swap / Solaris
/dev/hda51914497324579418+  83  Linux
/dev/hda649745101 1028128+   7  HPFS/NTFS

df -Tl:

FilesystemType   1K-blocks  Used Available Use% Mounted on
/dev/hda5 ext324193508   2408128  20556412  11% /
tmpfstmpfs  371756 0371756   0% /lib/init/rw
udev tmpfs   1024092 10148   1% /dev
tmpfstmpfs  371756 0371756   0% /dev/shm


Base System Installation Checklist:
[O] = OK, [E] = Error (please elaborate below), [ ] = didn't try it

Initial boot:   [O]
Detect network card:[O]
Configure network:  [O]
Detect CD:  [ ]
Load installer modules: [O]
Detect hard drives: [O]
Partition hard drives:  [O]
Install base system:[O]
Clock/timezone setup:   [O]
User/password setup:[O]
Install tasks:  [E]
Install boot loader:[E]
Overall install:[O]

Comments/Problems:

I booted the graphical installer from debian.exe in expert mode so I
could install sid and use one of the daily images.

The /etc/grub.d/30_otheros that was generated did not allow me to boot
Windows. Simply changing (hd0,0) to (hd0,1) fixed this. Looks like grub2
uses 1-based partition indexes instead of 0-based ones like grub1 did.

Despite choosing the desktop task in the tasksel section and a gnome
desktop in debian.exe, I didn't get a desktop login manager installed
and a graphical login started up. Looking at the tasks in aptitude seems
to show that gdm is only present in the Xfce desktop environment task.

Thirdly my mouse is a serial mouse and there didn't seem to be any
obvious way to use it. The computer has a PS2 mouse port, but I don't
have a PS2 mouse for this computer. It is on /dev/ttyS1 rather than S0
due to the positions of cables, usb sockets and stuff.

I can retry the install as often as needed, since I'm just using a spare
partition for it and am not using that partition for anything else.

-- 

==
Installer lsb-release:
==
DISTRIB_ID=Debian
DISTRIB_DESCRIPTION="Debian GNU/Linux installer"
DISTRIB_RELEASE="lenny (installer build 20080329-19:05)"
X_INSTALLATION_MEDIUM=netboot-gtk

==
Installer hardware-summary:
==
umame -a: Linux morrison 2.6.24-1-486 #1 Mon Feb 11 13:52:45 UTC 2008 i686 
unknown
lspci -nn: 00:00.0 Host bridge [0600]: nVidia Corporation nForce CPU bridge 
[10de:01a4] (rev b2)
lspci -nn: 00:00.1 RAM memory [0500]: nVidia Corporation nForce 220/420 Memory 
Controller [10de:01ac] (rev b2)
lspci -nn: 00:00.2 RAM memory [0500]: nVidia Corporation nForce 220/420 Memory 
Controller [10de:01ad] (rev b2)
lspci -nn: 00:00.3 RAM memory [0500]: nVidia Corporation Unknown device 
[10de:01aa] (rev b2)
lspci -nn: 00:01.0 ISA bridge [0601]: nVidia Corporation nForce ISA Bridge 
[10de:01b2] (rev c3)
lspci -nn: 00:01.1 SMBus [0c05]: nVidia Corporation nForce PCI System 
Management [10de:01b4] (rev c1)
lspci -nn: 00:02.0 USB Controller [0c03]: nVidia Corporation nForce USB 
Controller [10de:01c2] (rev c3)
lspci -nn: 00:03.0 USB Controller [0c03]: nVidia Corporation nForce USB 
Controller [10de:01c2] (rev c3)
lspci -nn: 00:04.0 Ethernet controller [0200]: nVidia Corporation nForce 
Ethernet Controller [10de:01c3] (rev c2)
lspci 

Processed: found 927037 in 0.249, found 927037 in 0.258

2021-05-21 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org:

> found 927037 0.249
Bug #927037 [cdebconf-gtk-udeb] Message didn't fully fit inside its window
Marked as found in versions cdebconf/0.249.
> found 927037 0.258
Bug #927037 [cdebconf-gtk-udeb] Message didn't fully fit inside its window
Marked as found in versions cdebconf/0.258.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
927037: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=927037
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems



Bug#405737: marked as done ("i810 based gfx cards need adhoc framebuffer driver to support g-i")

2021-05-21 Thread Debian Bug Tracking System
Your message dated Sat, 22 May 2021 06:55:31 +0200
with message-id 
and subject line Re: Bug#405737: Reassigning 405737 to debian-installer
has caused the Debian Bug report #405737,
regarding "i810 based gfx cards need adhoc framebuffer driver to support g-i"
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
405737: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=405737
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---

Package: installation-reports (bug report  : installgui fails)

Boot method: CD

Image version: Debian GNU/Linux testing "Etch" - Official Snapshot
i386 NETINST Binary-1 20070103-21:52 (/.disk/info)

Date: Jan 5 22:59:22 (IST)
Machine: Assembled PC x86.
Processor: Intel Pentium III (Katmai) 550MHz
Memory: 128 MB

Partitions: (output of fdisk -l)

Disk /dev/hda: 80.0 GB, 80060424192 bytes
255 heads, 63 sectors/track, 9733 cylinders
Units = cylinders of 16065 * 512 = 8225280 bytes

  Device  Boot  Start EndBlocks  IdSystem
/dev/hda1   *1   2  16033+   11  Hidden FAT12
/dev/hda2 3975 7815622+   83  Linux
/dev/hda3 976 1583  4883760 c W95 FAT32 (LBA)
/dev/hda41584973365464875 5 Extended
/dev/hda515842556  7815591 83   Linux
/dev/hda625572618497983+  82   Linux swap / Solaris
/dev/hda72619626529294496 83   Linux
/dev/hda862666873  4883728+   83  Linux
/dev/hda968747481  4883728+   83  Linux
/dev/hda10  91269733  4883728+   83  Linux



Output of lspci -nn :

:00:00.0 0600: 8086:7120 (rev 03)
:00:01.0 0300: 8086:7121 (rev 03)
:00:1e.0 0604: 8086:2418 (rev 02)
:00:1f.0 0601: 8086:2410 (rev 02)
:00:1f.1 0101: 8086:2411 (rev 02)
:00:1f.2 0c03: 8086:2412 (rev 02)
:00:1f.5 0401: 8086:2415 (rev 02)
:01:0a.0 0200: 10ec:8139 (rev 10)

Output of lspci -vnn:

:00:00.0 0600: 8086:7120 (rev 03)
   Subsystem: 8086:7120
   Flags: bus master, fast devsel, latency 0

:00:01.0 0300: 8086:7121 (rev 03)
   Subsystem: 8086:7121
   Flags: bus master, 66MHz, medium devsel, latency 0, IRQ 10
   Memory at d800 (32-bit, prefetchable) [size=64M]
   Memory at de00 (32-bit, non-prefetchable) [size=512K]
   Capabilities: [dc] Power Management version 1

:00:1e.0 0604: 8086:2418 (rev 02)
   Flags: bus master, fast devsel, latency 0
   Bus: primary=00, secondary=01, subordinate=01, sec-latency=32
   I/O behind bridge: c000-cfff
   Memory behind bridge: dc00-ddff
   Prefetchable memory behind bridge: 1000-100f

:00:1f.0 0601: 8086:2410 (rev 02)
   Flags: bus master, medium devsel, latency 0

:00:1f.1 0101: 8086:2411 (rev 02) (prog-if 80 [Master])
   Subsystem: 8086:2411
   Flags: bus master, medium devsel, latency 0
   I/O ports at f000 [size=16]

:00:1f.2 0c03: 8086:2412 (rev 02)
   Subsystem: 8086:2412
   Flags: bus master, medium devsel, latency 0, IRQ 11
   I/O ports at d000 [size=32]

:00:1f.5 0401: 8086:2415 (rev 02)
   Subsystem: 11d4:0048
   Flags: bus master, medium devsel, latency 0, IRQ 5
   I/O ports at d800 [size=256]
   I/O ports at dc00 [size=64]

:01:0a.0 0200: 10ec:8139 (rev 10)
   Subsystem: 10ec:8139
   Flags: bus master, medium devsel, latency 32, IRQ 11
   I/O ports at c000 [size=256]
   Memory at dd00 (32-bit, non-prefetchable) [size=256]
   Expansion ROM at 1000 [disabled] [size=64K]
   Capabilities: [50] Power Management version 2



bootparameters : installgui

Base System Installation Checklist:
[O] = OK, [E] = Error (please elaborate below), [ ] = didn't try it

Initial boot:[O]
Detect network card:[ ]
This was O.K when a normal textmode install is used.

Configure network:  [ ]
Detect CD:  [O]
Load installer modules: [E]

DirectFB initialisation fails.
then init keeps restarting debian-installer for ever.


Detect hard drives: [O]
Partition hard drives:  [ ]
Install base system:[ ]
Clock/timezone setup:   [ ]
User/password setup:[ ]
Install tasks:  [ ]
Install boot loader:[ ]
Overall install:[ ]

Comments/Problems:
I am using the daily-build netinst image burnt onto a CDRW using cdrecord. Once
the bootsplash is shown, I used installgui at boot-prompt. Booting is perfect in
all respects until 

Bug#745361: marked as done (cdebconf-gtk-udeb: fails to advertise "rescue mode" on start-up)

2021-05-21 Thread Debian Bug Tracking System
Your message dated Sat, 22 May 2021 06:53:17 +0200
with message-id 
and subject line Re: Bug#745361: cdebconf-gtk-udeb: fails to advertise "rescue 
mode" on start-up
has caused the Debian Bug report #745361,
regarding cdebconf-gtk-udeb: fails to advertise "rescue mode" on start-up
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
745361: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=745361
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: cdebconf-gtk-udeb
Version: 0.189
Severity: normal

When enabling rescue mode, the banner isn't including the usual “Rescue
mode” label at start-up. Switching to any language enables it, though.
Going back to English afterwards gives the proper message. So I suspect
that's really a one-time issue while loading the first time. The text
installer doesn't seem to suffer from this, so I'm filing this bug
report against cdebconf-gtk-udeb without further investigation for the
time being.

I've also reproduced this with a 7.4 netinst image, using graphical
rescue mode:
  
http://cdimage.debian.org/cdimage/release/current/amd64/iso-cd/debian-7.4.0-amd64-netinst.iso

Mraw,
KiBi.
--- End Message ---
--- Begin Message ---
Cyril Brulebois  (2014-04-21):
> Cyril Brulebois  (2014-04-20):
> > When enabling rescue mode, the banner isn't including the usual “Rescue
> > mode” label at start-up. Switching to any language enables it, though.
> > Going back to English afterwards gives the proper message. So I suspect
> > that's really a one-time issue while loading the first time. The text
> > installer doesn't seem to suffer from this, so I'm filing this bug
> > report against cdebconf-gtk-udeb without further investigation for the
> > time being.
> 
> It looks like a start-up issue indeed. Looking at handle_exposed_banner(),
> we're getting fe->info == NULL at the beginning. What is funny is that
> switching to a VT, then going back to X triggers the appropriate
> behaviour: the message is then written on the banner as expected.
> 
> Not quite sure how to fix this issue at the moment.

This bug report received a duplicate later on, which has been addressed
(#882804), closing.


Cheers,
-- 
Cyril Brulebois (k...@debian.org)
D-I release manager -- Release team member -- Freelance Consultant


signature.asc
Description: PGP signature
--- End Message ---


Bug#696970: marked as done (cdebconf-gtk-udeb: Add support for an alternate logo in the banner)

2021-05-21 Thread Debian Bug Tracking System
Your message dated Sat, 22 May 2021 06:50:48 +0200
with message-id 
and subject line Re: Bug#696970: cdebconf-gtk-udeb: Add support for an 
alternate logo in the banner
has caused the Debian Bug report #696970,
regarding cdebconf-gtk-udeb: Add support for an alternate logo in the banner
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
696970: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=696970
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: cdebconf-gtk-udeb
Version: 0.181
Severity: normal
Tags: d-i

Hi,

currently we have a logo defined by:
| #define LOGO_IMAGE_PATH \
| BASE_IMAGE_PATH "/logo_installer.png"

In a bug report against rootskel-gtk (bug number is pending), I suggested
we improve support for theme=dark, especially on the banner side. That'll
likely include shipping an extra logo, so a little less of hardcoding will
probably be needed at that point.

Opening this bug report as a placeholder for now.

Mraw,
KiBi.
--- End Message ---
--- Begin Message ---
Version: 0.187

Cyril Brulebois  (2012-12-30):
> currently we have a logo defined by:
> | #define LOGO_IMAGE_PATH \
> | BASE_IMAGE_PATH "/logo_installer.png"
> 
> In a bug report against rootskel-gtk (bug number is pending), I suggested
> we improve support for theme=dark, especially on the banner side. That'll
> likely include shipping an extra logo, so a little less of hardcoding will
> probably be needed at that point.
> 
> Opening this bug report as a placeholder for now.

I think I forgot about that bug report (having a See reference for
#696969 only in the changelog), but that was addressed long ago in:

commit a209703c314604238f0c03c528b8dc4d0bfb9eb5
Author: Cyril Brulebois 
Date:   Fri Feb 28 20:38:38 2014 +0300

Add support for loading an alternate banner when the GTK theme name is 
"dark" (Closes: #740358).

Fall back to the regular one if it's not available (See: #696969).


Cheers,
-- 
Cyril Brulebois (k...@debian.org)
D-I release manager -- Release team member -- Freelance Consultant


signature.asc
Description: PGP signature
--- End Message ---


Re: Bug#988832: unblock: libx11/2:1.7.1-1

2021-05-21 Thread Cyril Brulebois
Hi,

Paul Gevers  (2021-05-21):
> On 20-05-2021 10:26, Emilio Pozuelo Monfort wrote:
> > Please unblock package libx11
> 
> This needs also an ack from d-i, boot CC-ed.

Tests are looking good, feel free to go ahead.

> > The debdiff is a little large due to the autotools version the
> > tarball was generated with. I'm attaching a debdiff filtered with
> > 
> >   filterdiff -x '*/Makefile.in' -x '*.man' -x '*/aclocal.m4' -x 
> > '*/configure'
> > 
> > (the *.man changes are actual manpage syntax fixes, but make it
> > harder to review the actually important code fixes in this update,
> > so I filtered them).

Thanks for that.

> Funny how some copyrights go backward in time in this release.

Exactly my first reaction when I d'd your package. :)


Cheers,
-- 
Cyril Brulebois (k...@debian.org)
D-I release manager -- Release team member -- Freelance Consultant


signature.asc
Description: PGP signature


Processed: /boot/vmlinuz-5.10.0-6-armmp-lpae: lamobo-r1 ethernet/bridge failure

2021-05-21 Thread Debian Bug Tracking System
Processing control commands:

> block 986767 by -1
Bug #986767 [installation-reports] installation-reports: Bullseye installation 
on Lamobo-R1
986767 was not blocked by any bugs.
986767 was not blocking any bugs.
Added blocking bug(s) of 986767: 988966

-- 
986767: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=986767
988966: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=988966
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems



Bug#988951: regression: focus_path on last items no longer works properly

2021-05-21 Thread Cyril Brulebois
Package: cdebconf-gtk-udeb
Version: 0.258
Severity: important
X-Debbugs-Cc: Simon McVittie 

Hi,

The 0.258 update is *very* important for us since it makes extra sure
(together with libgtk2.0-0-udeb 2.24.33-2) we don't run into relayout
loops meaning hangs from a user point of view.

Yes, it comes at a price: focussing on the last items of a GtkTreeView
no longer works correctly.

There might be simpler (shorter) ways to trigger this but the following
is robust:

 - Initially detected while testing an encrypted LVM install in Swedish
   (confirming all hangs go away), when reaching the partition layout
   confirmation dialog, the selected entry is the last one in the list,
   but the selection isn't seen. One might wonder where the focus is,
   why no entry was selected, etc. Since that can happen in various
   places, I think users might get confused. That should not be specific
   to Swedish, it just happens to be the first occurrence I noticed.

 - Slightly shorter (`kvm -m 1G -cdrom mini.iso`, no disk layout or even
   disk required), pick a language like French and all default choices,
   until the mirror country selection, pick the very last one
   (États-Unis), and on the mirror host selection, pick the very last
   one again (the actual hostname doesn't matter). Now, on the next
   dialog, hit “Revenir en arrière” (Back), and see the selected
   hostname isn't focussed. Another step back shows the selected country
   isn't focussed either. That should happen with other languages as
   well, using French has the main advantage for me to get the
   appropriate keyboard layout automatically plus get two “back” steps
   that exhibit the problem (other countries might not have a mirror
   list as big as the US one).

With both gtk+2.0 and cdebconf being uploaded recently, I've made sure
to determine what triggers this:
 - bulleye: OK
 - unstable: KO
 - bullseye + gtk2.0: OK
 - bullseye + cdebconf: KO

My first hunch was that the focus_path callback (one-shot call, it
disables itself once it has triggered gtk_tree_view_scroll_to_cell on
the first expose event) happens before the set_text_in_idle one, and
that's indeed correct. I suppose we have a slightly taller widget at
first, we scroll down to the bottom; then when set_text_in_idle happens,
the widget is resized slightly smaller, the position is not correct
anymore (it's no longer “full-bottom” but a little higher as seen in the
scrollbar), and the selected line gets out of sight.

I've tried various things like having the focus_path happens in a
“_later” indirection using the same kind of logic as Simon introduced
for setting the text (with a different priority), but that would happen
waaay before set_text_in_idle anyway.

I've also tried to implement a “double-tap” approach, letting the
callback be called twice, so that we would focus first, let the text be
set and get a new expose event, and re-focus. But it seems the amount of
events we need to reach this point is not constant (I didn't conduct a
real study but it seems one might need up to 4-5 such events).

Next on my list of things to try was adding a pointer to the frontend
object (and its `data` member) so that we could keep the callback alive
until set_text_in_idle has done its job. I thought it might need some
mutex or locking around a counter of pending set_text calls and I
haven't touched that yet. And today, the following rang a bell… :)
  https://salsa.debian.org/installer-team/cdebconf/-/merge_requests/7


I'm happy to be told whether the vague idea above looks like a
workaround that could or even should work before diving a little more
into it, and/or to be suggested better ideas!


Cheers,
-- 
Cyril Brulebois (k...@debian.org)
D-I release manager -- Release team member -- Freelance Consultant


Re: Bug#988832: unblock: libx11/2:1.7.1-1

2021-05-21 Thread Paul Gevers
Control: tags -1 d-i confirmed

Hi,

On 20-05-2021 10:26, Emilio Pozuelo Monfort wrote:
> Please unblock package libx11

This needs also an ack from d-i, boot CC-ed.

> This fixes CVE-2021-31535, a bug in libX11 which could lead to the
> execution of additional X requests due to insufficient buffer checks.
> 
> I have done some manual tests (run an X server with various applications)
> 
> The risks are minor as the changes are pretty much limited to the security
> fix, with minor changes aside of that.
> 
> [ Checklist ]
>   [x] all changes are documented in the d/changelog
>   [x] I reviewed all changes and I approve them
>   [x] attach debdiff against the package in testing
> 
> The debdiff is a little large due to the autotools version the tarball
> was generated with. I'm attaching a debdiff filtered with
> 
>   filterdiff -x '*/Makefile.in' -x '*.man' -x '*/aclocal.m4' -x '*/configure'
> 
> (the *.man changes are actual manpage syntax fixes, but make it harder to 
> review
> the actually important code fixes in this update, so I filtered them).

Funny how some copyrights go backward in time in this release.

Paul



OpenPGP_signature
Description: OpenPGP digital signature