Bug#913431: Debian Installer Bullseye RC 2 release

[Philip Hands]

Hi Vincent,

I've applied your patch and pushed it to to salsa (my fork) to get it
built by CI ... which failed, because of the use of ${X/...} and
${X:...}, which it seems busybox doesn't like.

So I've changed that code, and added a couple of other tweaks, as you
can see here:

  https://salsa.debian.org/philh/partman-base/-/commits/bug/913431

Perhaps you can look at the result, and check that it still does what
you intended, and pick anything you like out of the rest.

BTW the working pipeline build includes the creation of a mini-ISO image
(once one kicks branch2repo into action), that should allow this code to
be tested in D-I:

  
https://salsa.debian.org/installer-team/debian-installer/-/jobs/4087808/artifacts/file/public/gtk-mini.iso

HTH

Cheers, Phil.
-- 
|)|  Philip Hands  [+44 (0)20 8530 9560]  HANDS.COM Ltd.
|-|  http://www.hands.com/http://ftp.uk.debian.org/
|(|  Hugo-Klemm-Strasse 34,   21075 Hamburg,GERMANY


signature.asc
Description: PGP signature

Bug#1033535: installation-guide: Remove dmraid information

[Chris Hofstaedtler]

Source: installation-guide
Version: dmraid support was removed
Severity: normal
Tags: patch

Please remove information related to dmraid from the installation-guide.
Installer support for dmraid was removed in #864423.

MR: https://salsa.debian.org/zeha/installation-guide/-/merge_requests/2

Chris

Bug#1033524: Simplify the instructions for making bootable media

[Chris Hofstaedtler]

* Steve McIntyre  [230326 23:23]:
> On Mon, Mar 27, 2023 at 12:52:41AM +0200, Chris Hofstaedtler wrote:
> >* Steve McIntyre :
> >> We should definitely also kill section 4.4.2: Loadlin is *dead* -
> >> *nobody* has DOS any more.
> >
> >Section 5.1.4. "Booting from DOS using loadlin" should also go, I
> >guess.
> 
> Yup, good call.

Trivial MR for removing loadlin sections is here:
https://salsa.debian.org/installer-team/installation-guide/-/merge_requests/27

Bug#913431: Debian Installer Bullseye RC 2 release

[Vincent Danjean]

Le 26/03/2023 à 18:38, Emanuele Rocca a écrit :

Hi Vincent,

On 2023-03-24 11:03, Vincent Danjean wrote:

However, I did not rebuild all the installer packages to generate a
new installer and test it in real conditions.


I haven't had the time to test your patch yet, but there's a hack I'd
like to share to test things in d-i without rebuilding anything.


Thank you very much for the tip. I see later that you can also
just go to the second console and type the "wget ..." instruction
here (before (re)starting the partitioning).
  This allows me to fix my patch: ${str:start:end} is not available
in the installer context, nor is ${str// /} to remove space.
I used 'cut' and 'tr' to do the job.

  With this updated patch, I successfully created plain (GPT)
partition in MiB and GiB (plain and fractional) and also
LVM LV in GiB (plain and fractional) with the Debian Installer
Bookworm Alpha 2 release (amd64 and i386 netinst CD images)
  The only 'bug' (but it should be present before) is that
the first partition for whose I asked a size of 128MiB gets
a size of 127MiB, probably due to the fact that the start
of the partition has been aligned to the first MiB (ie 1024kiB)

  Moreover, the tests I provide now also pass within the
installer (run the 'tests' script with the "di" argument to
avoid the script to try to run 'bc'). Both outputs (in d-i and
in a 'normal' machine) have the same md5sum (on amd64 and i386)

  So, I think I've done all what I can.

  Regards,
Vincent


diff --git a/lib/base.sh b/lib/base.sh
index d38e101e..08cfec55 100644
--- a/lib/base.sh
+++ b/lib/base.sh
@@ -313,9 +313,125 @@ longint2human () {
 	printf "%i%s%i %s\n" $int $deci $frac $suffix
 }
 
+substr() {
+	local s="$1"
+	local start="$2" # first is 0
+	local size="$3"
+
+	if [ -n "$3" ]; then
+		echo "$s" | cut -c $(($start + 1))-$(($start + $size))
+	else
+		echo "$s" | cut -c $(($start + 1))-
+	fi
+}
+
+longmult() {
+	local a="$1" # no size limit
+	local b="$2" # <= 2^30
+
+	local carry=0
+	local endres=""
+	local partres
+	local enda
+
+	while [ "${#a}" -gt 6 ]; do
+		enda="$(substr "$a" $((${#a} - 6)))"
+		a="${a%$enda}"
+		partres="$(expr "$enda" '*' "$b" + "$carry")"
+		if [ "${#partres}" -gt 6 ]; then
+			carry="$(substr "$partres" 0 $((${#partres} - 6)))"
+			endres="${partres#$carry}$endres"
+		else
+			partres="00$partres"
+			carry=0
+			endres="$(substr "$partres" $((${#partres} - 6)))$endres"
+		fi
+	done
+	partres="$(expr "$a" '*' "$b" + "$carry")"
+	echo "$partres$endres"
+}
+
+longadd() {
+	local a="$1" # no size limit
+	local b="$2" # <= 2^60
+
+	local carry="$b"
+	local endres=""
+	local partres
+	local enda
+
+	while [ "${#a}" -gt 15 ]; do
+		enda="$(substr "$a" $((${#a} - 15)))"
+		a="${a%$enda}"
+		partres="$(expr "$enda" + "$carry")"
+		if [ "${#partres}" -gt 15 ]; then
+			carry="$(substr "$partres" 0 $((${#partres} - 15)))"
+			endres="${partres#$carry}$endres"
+		else
+			partres="000$partres"
+			echo "${a}$(substr "$partres" $((${#partres} - 15)))$endres"
+			return
+		fi
+	done
+	partres="$(expr "$a" + "$carry")"
+	echo "$partres$endres"
+}
+
+human2longint_binary_unit() {
+	local int="$1"
+	local frac="$2"
+	local powbase="$3" # 1 <= powbase <= 6
+	# must return "$int.$frac * 1024^$powbase"
+	# contraints :
+	# - no floating point operation
+	# - no computed values above 2^63-1
+	# - expr has no exponentiation
+	# - bash arithmetics consider that 0-leading numbers are octal
+
+	# max of useful decimals when converting: powbase*10
+	# next ones, when multipled by 1024^powbase, would be <1
+	# so no need to take into account to many decimals
+	frac="$(substr "$frac" 0 $((powbase * 10 )))"
+	local longint="${int}${frac}"
+	longint="$(substr "$longint" $(expr "$longint" : '0*' || true))" # remove leading 0
+	[ "$longint" ] || {
+		echo 0
+		return
+	}
+	while [ "$powbase" -gt 3 ]; do
+		longint="$(longmult "$longint" "$((1024**3))")"
+		powbase=$(( $powbase - 3 ))
+	done
+	longint="$(longmult "$longint" "$((1024**$powbase))")"
+
+	if [ -z "$frac" ]; then
+		# no fractional part, just return the result
+		echo "$longint"
+		return
+	fi
+	# non-null fractional part.
+	# longint must be divided by 10^length(frac)
+	local posfrac="$(( ${#longint} - ${#frac} ))"
+	if [ $posfrac -le 0 ]; then
+		echo 0
+		return
+	fi
+	local res="$(substr "$longint" 0 $posfrac)"
+	# roundup if the next decimal is >= 5
+	case "$(substr "$longint" $posfrac 1)" in
+	[5-9]*) # roundup
+		longadd "$res" 1
+		;;
+	*)
+		echo "$res"
+		;;
+	esac
+}
+
 human2longint () {
-	local human orighuman gotb suffix int frac longint
-	set -- $*; human="$1$2$3$4$5" # without the spaces
+	local human orighuman gotb suffix int frac
+	local binary powbase dfrac
+	human="$(echo "$*" | tr -d ' ')" # without the spaces
 	orighuman="$human"
 	human=${human%b} #remove last b
 	human=${human%B} #remove last B
@@ -323,9 +439,18 @@ human2longint () {
 	if [ "$human" != "$orighuman" ]; then
 		gotb=1
 	fi
+	binary=${human#${human%?}} # the 

Bug#1033524: Simplify the instructions for making bootable media

[Steve McIntyre]

On Mon, Mar 27, 2023 at 12:52:41AM +0200, Chris Hofstaedtler wrote:
>* Steve McIntyre :
>> We should definitely also kill section 4.4.2: Loadlin is *dead* -
>> *nobody* has DOS any more.
>
>Section 5.1.4. "Booting from DOS using loadlin" should also go, I
>guess.

Yup, good call.

-- 
Steve McIntyre, Cambridge, UK.st...@einval.com
"I suspect most samba developers are already technically insane... Of
 course, since many of them are Australians, you can't tell." -- Linus Torvalds

Bug#1033524: Simplify the instructions for making bootable media

[Chris Hofstaedtler]

* Steve McIntyre :
> We should definitely also kill section 4.4.2: Loadlin is *dead* -
> *nobody* has DOS any more.

Section 5.1.4. "Booting from DOS using loadlin" should also go, I
guess.

Bug#1033524: Simplify the instructions for making bootable media

[Steve McIntyre]

On Sun, Mar 26, 2023 at 11:06:56PM +0200, Holger Wansing wrote:
>
>
>Am 26. März 2023 19:48:09 MESZ schrieb Steve McIntyre :
>>If anybody *does* want to keep the rest of the text, please put it in
>>an appendix called "extra USB options that nobody needs" or similar.
>
>We could add such info to the wiki, and point there from this guide, if it's 
>wanted to keep it (somewhere).

Yes, that sounds like a good idea. :-)

>>We should definitely also kill section 4.4.2: Loadlin is *dead* -
>>*nobody* has DOS any more.
>
>Also remove it from the images as well then?

Doing it right now, in fact!

-- 
Steve McIntyre, Cambridge, UK.st...@einval.com
"Every time you use Tcl, God kills a kitten." -- Malcolm Ray

Bug#1033524: Simplify the instructions for making bootable media

[Holger Wansing]

Am 26. März 2023 19:48:09 MESZ schrieb Steve McIntyre :
>If anybody *does* want to keep the rest of the text, please put it in
>an appendix called "extra USB options that nobody needs" or similar.

We could add such info to the wiki, and point there from this guide, if it's 
wanted to keep it (somewhere).

>We should definitely also kill section 4.4.2: Loadlin is *dead* -
>*nobody* has DOS any more.

Also remove it from the images as well then?


Holger

-- 
Sent from /e/ OS on Fairphone3

Re: Bug#1033498: installation-reports: Missing FW files not detected on USB stick

[Rainer Dorsch]

Am Sonntag, 26. März 2023, 12:23:48 CEST schrieben Sie:
> [Resent to OP, please send any reply to debian-boot@lists.debian.org]
> 
> Hello,
> 
> On 26/03/2023 at 10:52, Rainer Dorsch wrote:
> >  │ The missing firmware files are:
> >   │
> >  │ brcm/brcmfmac4330-sdio.solidrun,cubox-i-q.bin  
> >   │
> >  │ brcm/brcmfmac4330-sdio.solidrun,cubox-i-q.bin  
> >   │
> >  │ brcm/brcmfmac4330-sdio.bin brcm/brcmfmac4330-sdio.bin  
> >   │
> 
> (...)
> 
> > I copied all files from
> > 
> > https://github.com/LibreELEC/brcmfmac_sdio-firmware
> > 
> > on a USB-stick (ext3 formated, with vfat I got an error, probably the
> > filenames were not compatible). I selected  but the same box showed
> > up again and I assume no FW files were found (but it did not say so).
> 
> At that stage the installer may not support any filesystem other than
> FAT and ISO 9660. Also the current search algorithm for loose firmware
> files is very poor.
> 
> What error did you have with vfat ? I can successfully create files with
> these names on a vfat filesystem so I doubt filenames are the culprit.

Many thanks for your quick response. I looked in it in more detail:

There are many symlinks in the repo and I used Dolphin (KDE filemanager) to 
copy the data. It complained and pointed to a potential permission issue, but 
reading the error message more carefully reveals that it is not a permission 
issue, but it could not copy symlinks.

If I do a cp on bash, the files are copied as (many identical) copies, i.e. 
symlinks are not preserved.

I have not yet tested if that resolves the FW not found issue though. It would 
have helped me, if the installed would be a little bit more verbose and 
reported something like

No non-free FW files found in these directories:



Then it would have become more obvious that the installer cannot see the ext3 
formatted USB stick.

Thanks
Rainer

-- 
Rainer Dorsch
http://bokomoko.de/

Re: 11.7 planning + bookworm planning

[Steve McIntyre]

Hey Paul,

Nobody else seems to have replied yet, so... :-)

On Thu, Mar 23, 2023 at 01:31:22PM +0100, Paul Gevers wrote:
>Hi,
>
>With the point release scheduled for April 29th, it's probably good to have
>at least one weekend in between, or do people not mind doing two weekends in
>a row?

Definitely *not* two weekends on the run, please!

>On 17-03-2023 15:59, Steve McIntyre wrote:
>> On Thu, Mar 16, 2023 at 11:26:00AM +0100, Paul Gevers wrote:
>> > So, shall we add availability for May too? 6th, 13th, 20th (Ascension
>> > weekend), and 27th (coincides with DebianReunionHamburg)?
>> 
>> I could do the 6th and 13th, but I'm away on vacation 20th and 27th
>> (and 3rd June).
>
>If I did the bookkeeping correctly, the missing necessary teams are press and
>release team, as I now have:
>kibi  - 6, 13, 20, 27   d-i
>mhy   - 6, 13, 20, 27   ftp
>Sledge- 6, 13   CD
>Luna  - 6, 20   CD testing
>
>I can help 6 (probably), 13 and 27, but I don't have the signing key and I
>haven't witnessed all details from our side so I'm not comfortable doing it
>alone even if I could get my hands on the key.
>
>elbrus-13, 27  release team

13th could work. I'll admit I'm a little anxious about the amount of
work needed before release, but tbh that's not a new thing here... :-)

-- 
Steve McIntyre, Cambridge, UK.st...@einval.com
"This dress doesn't reverse." -- Alden Spiess

Bug#1033523: installation-reports: First installation

[Innocenzo Ventre]

Package: installation-reports
Severity: normal
X-Debbugs-Cc: el.diab...@gmail.com

(Please provide enough information to help the Debian
maintainers evaluate the report efficiently - e.g., by filling
in the sections below.)

Boot method: USB
Image version: 
https://cdimage.debian.org/cdimage/bookworm_di_alpha2/amd64/iso-cd/debian-bookworm-DI-alpha2-amd64-netinst.iso
Date: 

Machine: Intel NUC 11gen Barebone i3-1115G4, Kingston 8GB DDR4 3200Mhz, Adata 
1TB XPG SX6000 M.2 NVME
Partitions: 


Base System Installation Checklist:
[O] = OK, [E] = Error (please elaborate below), [ ] = didn't try it

Initial boot:   [O]
Detect network card:[O]
Configure network:  [O]
Detect media:   [O]
Load installer modules: [O]
Clock/timezone setup:   [O]
User/password setup:[O]
Detect hard drives: [O]
Partition hard drives:  [O]
Install base system:[O]
Install tasks:  [O]
Install boot loader:[O]
Overall install:[O]

Comments/Problems:




Please make sure that any installation logs that you think would
be useful are attached to this report. (You can find them in the
installer system in /var/log/ and later on the installed system
under /var/log/installer.) Please compress large files using gzip.


-- Package-specific info:

==
Installer lsb-release:
==
DISTRIB_ID=Debian
DISTRIB_DESCRIPTION="Debian GNU/Linux installer"
DISTRIB_RELEASE="12 (bookworm) - installer build 20230217"
X_INSTALLATION_MEDIUM=cdrom

==
Installer hardware-summary:
==
uname -a: Linux debianbox 6.1.0-3-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.8-1 
(2023-01-29) x86_64 GNU/Linux
lspci -knn: 00:00.0 Host bridge [0600]: Intel Corporation Device [8086:9a04] 
(rev 01)
lspci -knn: DeviceName: Onboard - Other
lspci -knn: Subsystem: Intel Corporation Device [8086:3002]
lspci -knn: 00:02.0 VGA compatible controller [0300]: Intel Corporation Tiger 
Lake-LP GT2 [UHD Graphics G4] [8086:9a78] (rev 01)
lspci -knn: DeviceName: Onboard - Video
lspci -knn: Subsystem: Intel Corporation Device [8086:3002]
lspci -knn: 00:06.0 PCI bridge [0604]: Intel Corporation 11th Gen Core 
Processor PCIe Controller [8086:9a09] (rev 01)
lspci -knn: Kernel driver in use: pcieport
lspci -knn: 00:07.0 PCI bridge [0604]: Intel Corporation Tiger Lake-LP 
Thunderbolt 4 PCI Express Root Port #1 [8086:9a25] (rev 01)
lspci -knn: Subsystem: Intel Corporation Device [8086:3002]
lspci -knn: Kernel driver in use: pcieport
lspci -knn: 00:07.2 PCI bridge [0604]: Intel Corporation Tiger Lake-LP 
Thunderbolt 4 PCI Express Root Port #2 [8086:9a27] (rev 01)
lspci -knn: Kernel driver in use: pcieport
lspci -knn: 00:08.0 System peripheral [0880]: Intel Corporation GNA Scoring 
Accelerator module [8086:9a11] (rev 01)
lspci -knn: DeviceName: Onboard - Other
lspci -knn: Subsystem: Intel Corporation Device [8086:3002]
lspci -knn: 00:0d.0 USB controller [0c03]: Intel Corporation Tiger Lake-LP 
Thunderbolt 4 USB Controller [8086:9a13] (rev 01)
lspci -knn: DeviceName: Onboard - Other
lspci -knn: Kernel driver in use: xhci_hcd
lspci -knn: Kernel modules: xhci_pci
lspci -knn: 00:0d.2 USB controller [0c03]: Intel Corporation Tiger Lake-LP 
Thunderbolt 4 NHI #0 [8086:9a1b] (rev 01)
lspci -knn: DeviceName: Onboard - Other
lspci -knn: Subsystem: Device [:]
lspci -knn: 00:0d.3 USB controller [0c03]: Intel Corporation Tiger Lake-LP 
Thunderbolt 4 NHI #1 [8086:9a1d] (rev 01)
lspci -knn: DeviceName: Onboard - Other
lspci -knn: Subsystem: Device [:]
lspci -knn: 00:14.0 USB controller [0c03]: Intel Corporation Tiger Lake-LP USB 
3.2 Gen 2x1 xHCI Host Controller [8086:a0ed] (rev 20)
lspci -knn: DeviceName: Onboard - Other
lspci -knn: Subsystem: Intel Corporation Device [8086:3002]
lspci -knn: Kernel driver in use: xhci_hcd
lspci -knn: Kernel modules: xhci_pci
lspci -knn: 00:14.2 RAM memory [0500]: Intel Corporation Tiger Lake-LP Shared 
SRAM [8086:a0ef] (rev 20)
lspci -knn: DeviceName: Onboard - Other
lspci -knn: 00:14.3 Network controller [0280]: Intel Corporation Wi-Fi 6 AX201 
[8086:a0f0] (rev 20)
lspci -knn: DeviceName: Onboard - Ethernet
lspci -knn: Subsystem: Intel Corporation Device [8086:0074]
lspci -knn: Kernel driver in use: iwlwifi
lspci -knn: Kernel modules: iwlwifi
lspci -knn: 00:15.0 Serial bus controller [0c80]: Intel Corporation Tiger 
Lake-LP Serial IO I2C Controller #0 [8086:a0e8] (rev 20)
lspci -knn: DeviceName: Onboard - Other
lspci -knn: Subsystem: Intel Corporation Device [8086:3002]
lspci -knn: 00:15.1 Serial bus controller [0c80]: Intel Corporation Tiger 
Lake-LP Serial IO I2C Controller #1 [8086:a0e9] (rev 20)
lspci -knn: DeviceName: Onboard - Other
lspci -knn: Subsystem: Intel Corporation Device [8086:3002]
lspci -knn: 00:16.0 Communication 

Bug#1033524: Simplify the instructions for making bootable media

[Steve McIntyre]

Source: installation-guide
Severity: important

Almost all of section 4.3 (Preparing Files for USB Memory Stick
Booting) needs to go away. We should *not* be telling most users about
manually formatting media, copying installer files, etc.

My strong preference would be to simply remove *everything* after the
text "Simply writing the installation image to USB like this should
work fine for most users." The rest of the text here is massively
overblown for anybody except developers, and is causing confusion.

If anybody *does* want to keep the rest of the text, please put it in
an appendix called "extra USB options that nobody needs" or similar.

We should also remove mentions of the mini.iso in the "normal users"
section - it's totally not a sensible option for most people to ever
be trying to use it here.

We should definitely also kill section 4.4.2: Loadlin is *dead* -
*nobody* has DOS any more.

-- System Information:
Debian Release: 11.6
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500, 
'stable'), (500, 'oldstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.10.0-21-amd64 (SMP w/8 CPU threads)
Kernel taint flags: TAINT_WARN, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Bug#913431: Debian Installer Bullseye RC 2 release

[Emanuele Rocca]

Hi Vincent,

On 2023-03-24 11:03, Vincent Danjean wrote:
> However, I did not rebuild all the installer packages to generate a
> new installer and test it in real conditions.

I haven't had the time to test your patch yet, but there's a hack I'd
like to share to test things in d-i without rebuilding anything.

Create a preseed file (say preseed.cfg) with the following line:

d-i partman/early_command string wget 
https://example.org/partman-base-vincent.sh -O /lib/partman/lib/base.sh

Upload the preseed file to a webserver, say https://example.org/preseed.cfg,
and your patched base.sh to https://example.org/partman-base-vincent.sh.

When booting the installer, pass the following to the kernel command
line:

 preseed/url=https://example.org/preseed.cfg

Just in case you want to give it a try.

Bug#1033519: debootstrap: Fails to bootstrap wheezy (please symlink script as 'archived', like squeeze)

[Stephan Sürken]

Package: debootstrap
Version: 1.0.128+nmu2
Severity: wishlist

Dear Maintainer,

wheezy is archived, but script (unlike, f.e. squeeze) still links to sid:

---
ls -l /usr/share/debootstrap/scripts/wheezy 
/usr/share/debootstrap/scripts/squeeze
lrwxrwxrwx 1 root root 4 Oct 19 00:49 /usr/share/debootstrap/scripts/squeeze -> 
etch
lrwxrwxrwx 1 root root 3 Oct 19 00:49 /usr/share/debootstrap/scripts/wheezy -> 
sid
---

[i.e., bootstrap w/o special parameters for mirror (archived) and key file 
(removed) will fail.]

Please symlink wheezy like squeeze.

Thx!

Stephan

-- System Information:
Debian Release: 12.0
  APT prefers testing-security
  APT policy: (500, 'testing-security'), (500, 'unstable'), (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 6.0.0-0.deb11.6-amd64 (SMP w/16 CPU threads; PREEMPT)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8) (ignored: LC_ALL 
set to C.UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: unable to detect

Versions of packages debootstrap depends on:
ii  wget  1.21.3-1+b2

Versions of packages debootstrap recommends:
ii  arch-test   0.20-1
ii  debian-archive-keyring  2023.2
ii  gnupg   2.2.40-1

Versions of packages debootstrap suggests:
ii  binutils 2.40-2
pn  squid-deb-proxy-client   
ii  ubuntu-keyring [ubuntu-archive-keyring]  2020.06.17.1-1
ii  xz-utils 5.4.1-0.2
ii  zstd 1.5.4+dfsg2-5

-- no debconf information

Bug#1028250: debian-installer: broken cryptsetup support

[Cyril Brulebois]

Hi Guilhem,

Guilhem Moulin  (2023-03-26):
> In https://bugs.debian.org/1032235#107 elbrus (CC'ed) asked for a t-p-u
> upload of cryptsetup to fix a potential major regression should
> bookworm's src:argon2 ever be rebuilt with the bookworm toolchain.  The
> version currently in sid, 2:2.6.1-3, also includes 2 upstream patches to
> mitigate #1028250.  (“Mitigate”, because it only reduces the memory cost
> of the PBKDF on memory-constrained systems without swap.  This only buys
> time, and Milan argued that such systems are better off using a
> non-memory hard PBKDF.  I might propose a partman-crypto patch to that
> effect, but I guess it's too late for bookworm at this point.)
> 
> 2:2.6.1-3 (sid) and 2:2.6.1-1 (testing) differs as such:
> https://salsa.debian.org/cryptsetup-team/cryptsetup/-/compare/debian%2F2%252.6.1-1...debian%2F2%252.6.1-3
> 
> Would you rather have us exclude these backported upstream patches from
> the t-p-u upload or should we leave them in?  Concretely these patches
> set the maximum memory cost at ~256M on a system with 1G RAM, so in
> practice the memory pressure never exceeds 75% during installation
> (tested with d-i bookworm alpha 2 with updated src:cryptsetup udebs,
> graphical install).

Sorry, I haven't been able to follow upstream/downstream discussions too
closely, but I do appreciate everything that's been happening on that
front.

I'm happy to have the patches included, and I can definitely live with
possible temporary regressions (should that happen) that might arise
from having them.

Thanks for your help, as always.


Cheers,
-- 
Cyril Brulebois (k...@debian.org)
D-I release manager -- Release team member -- Freelance Consultant


signature.asc
Description: PGP signature

Bug#1028250: debian-installer: broken cryptsetup support

[Guilhem Moulin]

Hi kibi,

In https://bugs.debian.org/1032235#107 elbrus (CC'ed) asked for a t-p-u
upload of cryptsetup to fix a potential major regression should
bookworm's src:argon2 ever be rebuilt with the bookworm toolchain.  The
version currently in sid, 2:2.6.1-3, also includes 2 upstream patches to
mitigate #1028250.  (“Mitigate”, because it only reduces the memory cost
of the PBKDF on memory-constrained systems without swap.  This only buys
time, and Milan argued that such systems are better off using a
non-memory hard PBKDF.  I might propose a partman-crypto patch to that
effect, but I guess it's too late for bookworm at this point.)

2:2.6.1-3 (sid) and 2:2.6.1-1 (testing) differs as such:
https://salsa.debian.org/cryptsetup-team/cryptsetup/-/compare/debian%2F2%252.6.1-1...debian%2F2%252.6.1-3

Would you rather have us exclude these backported upstream patches from
the t-p-u upload or should we leave them in?  Concretely these patches
set the maximum memory cost at ~256M on a system with 1G RAM, so in
practice the memory pressure never exceeds 75% during installation
(tested with d-i bookworm alpha 2 with updated src:cryptsetup udebs,
graphical install).

Cheers
-- 
Guilhem.


signature.asc
Description: PGP signature

Re: Bug#1033498: installation-reports: Missing FW files not detected on USB stick

[Pascal Hambourg]

Hello,

On 26/03/2023 at 10:52, Rainer Dorsch wrote:


 │ The missing firmware files are:  │
 │ brcm/brcmfmac4330-sdio.solidrun,cubox-i-q.bin│
 │ brcm/brcmfmac4330-sdio.solidrun,cubox-i-q.bin│
 │ brcm/brcmfmac4330-sdio.bin brcm/brcmfmac4330-sdio.bin│

(...)

I copied all files from

https://github.com/LibreELEC/brcmfmac_sdio-firmware

on a USB-stick (ext3 formated, with vfat I got an error, probably the filenames
were not compatible). I selected  but the same box showed up again and I
assume no FW files were found (but it did not say so).


At that stage the installer may not support any filesystem other than 
FAT and ISO 9660. Also the current search algorithm for loose firmware 
files is very poor.


What error did you have with vfat ? I can successfully create files with 
these names on a vfat filesystem so I doubt filenames are the culprit.

Bug#1033488: Idea: use CROSS_GRADE_TO_ARCH, if set.

[Geert Stappers]

> cross-grading an ARM system from armhf to arm64

Idea for supporting such corner cases


if environmentvariable CROSS_GRADE_TO_ARCH is set
use it
else
dpkg --print-architecture



Groeten
Geert Stappers
-- 
Silence is hard to parse

Bug#1033498: installation-reports: Missing FW files not detected on USB stick

[Holger Wansing]

Hi,

Am 26. März 2023 10:52:38 MESZ schrieb Rainer Dorsch :
>
>I copied all files from 
>
>https://github.com/LibreELEC/brcmfmac_sdio-firmware
>
>on a USB-stick (ext3 formated, with vfat I got an error, probably the 
>filenames 
>were not compatible). I selected  but the same box showed up again and I 
>assume no FW files were found (but it did not say so).

As always: we need the syslog from /var/log/installer, to debug.


Holger

-- 
Sent from /e/ OS on Fairphone3

Bug#1033498: installation-reports: Missing FW files not detected on USB stick

[Rainer Dorsch]

Package: installation-reports
Severity: minor

(Please provide enough information to help the Debian
maintainers evaluate the report efficiently - e.g., by filling
in the sections below.)

Boot method: netboot
Image version: https://d-i.debian.org/daily-images/armhf/ (March 19th, 2023)
Date: 

Machine: Solid-run Cubox-i (the machine I send the bug report from)
Partitions: 


Base System Installation Checklist:
[O] = OK, [E] = Error (please elaborate below), [ ] = didn't try it

Initial boot:   [ OK ]
Detect network card:[ OK ]
Configure network:  [ OK ]
Detect media:   [ OK ]
Load installer modules: [ OK ]
Clock/timezone setup:   [ OK ]
User/password setup:[ OK ]
Detect hard drives: [ E ]
Partition hard drives:  [ OK ]
Install base system:[ OK ]
Install tasks:  [ OK ]
Install boot loader:[ OK ]
Overall install:[ OK ]

Comments/Problems:

During installation on a cubox-i, I run into two issues:

-> Machine did not reboot automatically at the end of the installation, but 
hang during the reboot process (see separate bug report on u-boot-imx 
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1033497 )
-> The installer did not manage to detect non-free firmare:

I got a non-free FW message:

┌─┤ [!] Detect disks ├─┐
│  │
│ Some of your hardware needs non-free firmware files to operate. The  │
│ firmware can be loaded from removable media, such as a USB stick or  │
│ floppy.  │
│  │
│ The missing firmware files are:  │
│ brcm/brcmfmac4330-sdio.solidrun,cubox-i-q.bin│
│ brcm/brcmfmac4330-sdio.solidrun,cubox-i-q.bin│
│ brcm/brcmfmac4330-sdio.bin brcm/brcmfmac4330-sdio.bin│
│  │
│ If you have such media available now, insert it, and continue.   │
│  │
│ Load missing firmware from removable media?  │
│  │
││

I copied all files from 

https://github.com/LibreELEC/brcmfmac_sdio-firmware

on a USB-stick (ext3 formated, with vfat I got an error, probably the filenames 
were not compatible). I selected  but the same box showed up again and I 
assume no FW files were found (but it did not say so).

-- Package-specific info:

==
Installer lsb-release:
==
DISTRIB_ID=Debian
DISTRIB_DESCRIPTION="Debian GNU/Linux installer"
DISTRIB_RELEASE="12 (bookworm) - installer build 20230319-00:06:13"
X_INSTALLATION_MEDIUM=netboot

==
Installer hardware-summary:
==
uname -a: Linux evcc 6.1.0-6-armmp #1 SMP Debian 6.1.15-1 (2023-03-05) armv7l 
GNU/Linux
usb-list: 
usb-list: Bus 01 Device 01: EHCI Host Controller [1d6b:0002]
usb-list:Level 00 Parent 00 Port 00  Class 09(hub  ) Subclass 00 Protocol 01
usb-list:Manufacturer: Linux 6.1.0-6-armmp ehci_hcd
usb-list:Interface 00: Class 09(hub  ) Subclass 00 Protocol 00 Driver hub
usb-list: 
usb-list: Bus 02 Device 01: EHCI Host Controller [1d6b:0002]
usb-list:Level 00 Parent 00 Port 00  Class 09(hub  ) Subclass 00 Protocol 01
usb-list:Manufacturer: Linux 6.1.0-6-armmp ehci_hcd
usb-list:Interface 00: Class 09(hub  ) Subclass 00 Protocol 00 Driver hub
lsmod: Module  Size  Used by
lsmod: dm_mod131072  0
lsmod: md_mod143360  0
lsmod: jfs   176128  0
lsmod: btrfs1425408  0
lsmod: libcrc32c  16384  1 btrfs
lsmod: xor16384  1 btrfs
lsmod: xor_neon   16384  1 xor
lsmod: raid6_pq  106496  1 btrfs
lsmod: zstd_compress 262144  1 btrfs
lsmod: vfat   24576  0
lsmod: fat73728  1 vfat
lsmod: ext4  733184  2
lsmod: crc16  16384  1 ext4
lsmod: mbcache16384  1 ext4
lsmod: jbd2  118784  1 ext4
lsmod: crc32c_generic 16384  4
lsmod: brcmfmac  278528  0
lsmod: brcmutil   16384  1 brcmfmac
lsmod: cfg80211  700416  1 brcmfmac
lsmod: sd_mod 53248  0
lsmod: t10_pi 16384  1 sd_mod
lsmod: crc64_rocksoft 20480  1 t10_pi
lsmod: crc64  20480  1 crc64_rocksoft
lsmod: crc_t10dif 20480  1 

Bug#1032377: firmware loading tests with bookworm-DI-alpha2

[Pascal Hambourg]

Hello,

On 05/03/2023 at 15:59, Cyril Brulebois wrote:

Pascal Hambourg  (2023-03-05):

I am afraid that when the firmware is missing the driver is not
attached to the device so there is no direct way to retrieve it
through /sys.


Alright, nice to know which part of the lookup was failing anyway
(single 2-4:1.0 below 2-4, but missing driver symlink).


What is wrong if there are multiple /sys/bus/devices/$address/$address:* 
subdirectories ?



An indirect way may be to list loaded USB driver modules in
/sys/bus/usb/drivers or /proc/modules and search in their firmware
fields with modinfo ? Heavy and not 100% reliable though...


Since the existing code seems to work in at least some cases, it
wouldn't seem crazy to me to implement a fallback plan in case it
doesn't (as opposed to replacing the existing lookup entirely). After
all, we're quite certain that reloading usb* isn't going to work anyway,
so anything else we can try can't really be worse.


OK, I am working on fallback module detection based on matching modalias 
and firmware fields when they exist. Also check module holders when needed.



And I suppose iterating over a (uniquified) list of basename for
/sys/bus//drivers/*/module might work on more buses than just usb
(see mhi for the qrtr-mhi thing in #1032140), so it should even be
possible to reuse this outside this specific usb usecase.


Yes, although #1032140 seems to be a very special case because 
ath11k_pci fields do not advertise the requested firmware file 
ath11k/WCN6855/hw2.1/amss.bin, and only advertise pci aliases, not mhi.